From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] Revert "drm/i915/chv: Use timeout mode for RC6 on chv"
Date: Wed, 21 Jan 2015 19:14:01 +0200 [thread overview]
Message-ID: <87a91c5a5i.fsf@intel.com> (raw)
In-Reply-To: <1421072071-10985-1-git-send-email-rodrigo.vivi@intel.com>
On Mon, 12 Jan 2015, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> This reverts commit 5a0afd4b78ec23f27f5d486ac3d102c2e8d66bd7.
>
> Although timeout mode allows higher residency it impact badly on performance.
> I believe while we don't have a way to balance between performance and
> power savings at runtime I believe we have to revert and prioritize
> performance that was impacted a lot.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88103
The bug points at [1] as a potential fix.
BR,
Jani.
[1] http://mid.gmane.org/1421668253-18641-4-git-send-email-ville.syrjala@linux.intel.com
>
> Cc: Deepak S <deepak.s@linux.intel.com>
> Cc: Wendy Wang <wendy.wang@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 20a6dfa..03fc7f2 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4681,8 +4681,7 @@ static void cherryview_enable_rps(struct drm_device *dev)
> I915_WRITE(RING_MAX_IDLE(ring->mmio_base), 10);
> I915_WRITE(GEN6_RC_SLEEP, 0);
>
> - /* TO threshold set to 1750 us ( 0x557 * 1.28 us) */
> - I915_WRITE(GEN6_RC6_THRESHOLD, 0x557);
> + I915_WRITE(GEN6_RC6_THRESHOLD, 50000); /* 50/125ms per EI */
>
> /* allows RC6 residency counter to work */
> I915_WRITE(VLV_COUNTER_CONTROL,
> @@ -4696,7 +4695,7 @@ static void cherryview_enable_rps(struct drm_device *dev)
> /* 3: Enable RC6 */
> if ((intel_enable_rc6(dev) & INTEL_RC6_ENABLE) &&
> (pcbr >> VLV_PCBR_ADDR_SHIFT))
> - rc6_mode = GEN7_RC_CTL_TO_MODE;
> + rc6_mode = GEN6_RC_CTL_EI_MODE(1);
>
> I915_WRITE(GEN6_RC_CONTROL, rc6_mode);
>
> --
> 1.9.3
>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-01-21 17:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 14:14 [PATCH] Revert "drm/i915/chv: Use timeout mode for RC6 on chv" Rodrigo Vivi
2015-01-13 11:30 ` Chris Wilson
2015-01-21 17:14 ` Jani Nikula [this message]
2015-01-21 17:40 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a91c5a5i.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox