* [PATCH] drm/i915: Ban Haswell from using RCS flips
@ 2014-12-27 9:48 Chris Wilson
2014-12-27 13:57 ` shuang.he
2014-12-30 7:29 ` Jani Nikula
0 siblings, 2 replies; 4+ messages in thread
From: Chris Wilson @ 2014-12-27 9:48 UTC (permalink / raw)
To: intel-gfx
Like Ivybridge, we have reports that we get random hangs when flipping
with multiple pipes. Extend
commit 2a92d5bca1999b69c78f3c3e97b5484985b094b9
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Tue Jul 8 10:40:29 2014 +0100
drm/i915: Disable RCS flips on Ivybridge
to also apply to Haswell.
Reported-by: Scott Tsai <scottt.tw@gmail.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87759
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/intel_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index d01db1b82869..ed2102e62271 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -9703,7 +9703,7 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc,
if (obj->tiling_mode != work->old_fb_obj->tiling_mode)
/* vlv: DISPLAY_FLIP fails to change tiling */
ring = NULL;
- } else if (IS_IVYBRIDGE(dev)) {
+ } else if (IS_IVYBRIDGE(dev) || IS_HASWELL(dev)) {
ring = &dev_priv->ring[BCS];
} else if (INTEL_INFO(dev)->gen >= 7) {
ring = i915_gem_request_get_ring(obj->last_read_req);
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915: Ban Haswell from using RCS flips
2014-12-27 9:48 [PATCH] drm/i915: Ban Haswell from using RCS flips Chris Wilson
@ 2014-12-27 13:57 ` shuang.he
2014-12-30 7:29 ` Jani Nikula
1 sibling, 0 replies; 4+ messages in thread
From: shuang.he @ 2014-12-27 13:57 UTC (permalink / raw)
To: shuang.he, intel-gfx, chris
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 363/364 363/364
ILK 364/366 364/366
SNB -1 447/450 446/450
IVB 496/498 496/498
BYT 288/289 288/289
HSW 562/564 562/564
BDW 415/417 415/417
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
*SNB igt_gem_concurrent_blit_gtt-rcs-early-read-forked PASS(2, M35) DMESG_FAIL(1, M35)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: Ban Haswell from using RCS flips
2014-12-27 9:48 [PATCH] drm/i915: Ban Haswell from using RCS flips Chris Wilson
2014-12-27 13:57 ` shuang.he
@ 2014-12-30 7:29 ` Jani Nikula
2015-01-05 13:32 ` Jani Nikula
1 sibling, 1 reply; 4+ messages in thread
From: Jani Nikula @ 2014-12-30 7:29 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On Sat, 27 Dec 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Like Ivybridge, we have reports that we get random hangs when flipping
> with multiple pipes. Extend
>
> commit 2a92d5bca1999b69c78f3c3e97b5484985b094b9
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date: Tue Jul 8 10:40:29 2014 +0100
>
> drm/i915: Disable RCS flips on Ivybridge
>
> to also apply to Haswell.
>
> Reported-by: Scott Tsai <scottt.tw@gmail.com>
From the bug,
Tested-by: Scott Tsai <scottt.tw@gmail.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87759
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index d01db1b82869..ed2102e62271 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -9703,7 +9703,7 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc,
> if (obj->tiling_mode != work->old_fb_obj->tiling_mode)
> /* vlv: DISPLAY_FLIP fails to change tiling */
> ring = NULL;
> - } else if (IS_IVYBRIDGE(dev)) {
> + } else if (IS_IVYBRIDGE(dev) || IS_HASWELL(dev)) {
> ring = &dev_priv->ring[BCS];
> } else if (INTEL_INFO(dev)->gen >= 7) {
> ring = i915_gem_request_get_ring(obj->last_read_req);
> --
> 2.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915: Ban Haswell from using RCS flips
2014-12-30 7:29 ` Jani Nikula
@ 2015-01-05 13:32 ` Jani Nikula
0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2015-01-05 13:32 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On Tue, 30 Dec 2014, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Sat, 27 Dec 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> Like Ivybridge, we have reports that we get random hangs when flipping
>> with multiple pipes. Extend
>>
>> commit 2a92d5bca1999b69c78f3c3e97b5484985b094b9
>> Author: Chris Wilson <chris@chris-wilson.co.uk>
>> Date: Tue Jul 8 10:40:29 2014 +0100
>>
>> drm/i915: Disable RCS flips on Ivybridge
>>
>> to also apply to Haswell.
>>
>> Reported-by: Scott Tsai <scottt.tw@gmail.com>
>
> From the bug,
>
> Tested-by: Scott Tsai <scottt.tw@gmail.com>
>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87759
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Pushed to drm-intel-fixes with Daniel's IRC r-b and cc: stable (also on
the ivb commit). Thanks for the patch and review.
BR,
Jani.
>> ---
>> drivers/gpu/drm/i915/intel_display.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>> index d01db1b82869..ed2102e62271 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -9703,7 +9703,7 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc,
>> if (obj->tiling_mode != work->old_fb_obj->tiling_mode)
>> /* vlv: DISPLAY_FLIP fails to change tiling */
>> ring = NULL;
>> - } else if (IS_IVYBRIDGE(dev)) {
>> + } else if (IS_IVYBRIDGE(dev) || IS_HASWELL(dev)) {
>> ring = &dev_priv->ring[BCS];
>> } else if (INTEL_INFO(dev)->gen >= 7) {
>> ring = i915_gem_request_get_ring(obj->last_read_req);
>> --
>> 2.1.4
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Jani Nikula, Intel Open Source Technology Center
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-05 13:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-27 9:48 [PATCH] drm/i915: Ban Haswell from using RCS flips Chris Wilson
2014-12-27 13:57 ` shuang.he
2014-12-30 7:29 ` Jani Nikula
2015-01-05 13:32 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox