* [PATCH 0/3] fbdev-less i915, take 2
@ 2013-10-08 15:44 Daniel Vetter
2013-10-08 15:44 ` [PATCH 1/3] drm: Add separate Kconfig option for fbdev helpers Daniel Vetter
` (3 more replies)
0 siblings, 4 replies; 14+ messages in thread
From: Daniel Vetter @ 2013-10-08 15:44 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Intel Graphics Development
Hi all,
By popular demand (our embedded guys kept asking for this) I've resurrected my
fbdev less patches. Now Rob's msm driver can be completely completely without
CONFIG_FB stuff at all when disabling the fbdev helper support.
Review highly welcome.
Cheers, Daniel
Daniel Vetter (3):
drm: Add separate Kconfig option for fbdev helpers
drm/i915: Kconfig option to disable the legacy fbdev support
drm/i915: rename intel_fb.c to intel_fbdev.c
drivers/gpu/drm/Kconfig | 69 ++------
drivers/gpu/drm/Makefile | 3 +-
drivers/gpu/drm/ast/Kconfig | 1 +
drivers/gpu/drm/cirrus/Kconfig | 1 +
drivers/gpu/drm/drm_crtc_helper.c | 4 +
drivers/gpu/drm/drm_fb_helper.c | 4 -
drivers/gpu/drm/exynos/Kconfig | 1 +
drivers/gpu/drm/gma500/Kconfig | 1 +
drivers/gpu/drm/i915/Kconfig | 67 ++++++++
drivers/gpu/drm/i915/Makefile | 3 +-
drivers/gpu/drm/i915/i915_debugfs.c | 9 +-
drivers/gpu/drm/i915/i915_dma.c | 8 +-
drivers/gpu/drm/i915/i915_drv.h | 2 +
drivers/gpu/drm/i915/intel_display.c | 12 +-
drivers/gpu/drm/i915/intel_drv.h | 36 +++-
drivers/gpu/drm/i915/intel_fb.c | 323 -----------------------------------
drivers/gpu/drm/i915/intel_fbdev.c | 323 +++++++++++++++++++++++++++++++++++
drivers/gpu/drm/mgag200/Kconfig | 1 +
drivers/gpu/drm/msm/Kconfig | 1 +
drivers/gpu/drm/nouveau/Kconfig | 1 +
drivers/gpu/drm/omapdrm/Kconfig | 1 +
drivers/gpu/drm/qxl/Kconfig | 1 +
drivers/gpu/drm/rcar-du/Kconfig | 1 +
drivers/gpu/drm/shmobile/Kconfig | 1 +
drivers/gpu/drm/tilcdc/Kconfig | 1 +
drivers/gpu/drm/udl/Kconfig | 1 +
drivers/gpu/host1x/drm/Kconfig | 1 +
drivers/staging/imx-drm/Kconfig | 1 +
28 files changed, 477 insertions(+), 401 deletions(-)
create mode 100644 drivers/gpu/drm/i915/Kconfig
delete mode 100644 drivers/gpu/drm/i915/intel_fb.c
create mode 100644 drivers/gpu/drm/i915/intel_fbdev.c
--
1.8.1.4
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 1/3] drm: Add separate Kconfig option for fbdev helpers 2013-10-08 15:44 [PATCH 0/3] fbdev-less i915, take 2 Daniel Vetter @ 2013-10-08 15:44 ` Daniel Vetter 2013-10-08 16:52 ` Rob Clark 2013-10-08 15:44 ` [PATCH 2/3] drm/i915: Kconfig option to disable the legacy fbdev support Daniel Vetter ` (2 subsequent siblings) 3 siblings, 1 reply; 14+ messages in thread From: Daniel Vetter @ 2013-10-08 15:44 UTC (permalink / raw) To: DRI Development; +Cc: Daniel Vetter, Intel Graphics Development, David Herrmann For drivers which might want to disable fbdev legacy support. Select the new option in all drivers for now, so this shouldn't result in any change. Drivers need some work anyway to make fbdev support optional (if they have it implemented, that is), so the recommended way to expose this is by adding per-driver options. At least as long as most drivers don't support disabling the fbdev support. v2: Update for new drm drivers msm and rcar-du. Note that Rob's msm driver can already take advantage of this, which allows us to build msm without any fbdev depencies in the kernel! v3: Move the MODULE_* stuff from the fbdev helper file to drm_crtc_helper.c. Cc: David Herrmann <dh.herrmann@gmail.com> Cc: Rob Clark <robdclark@gmail.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/gpu/drm/Kconfig | 11 ++++++++++- drivers/gpu/drm/Makefile | 3 ++- drivers/gpu/drm/ast/Kconfig | 1 + drivers/gpu/drm/cirrus/Kconfig | 1 + drivers/gpu/drm/drm_crtc_helper.c | 4 ++++ drivers/gpu/drm/drm_fb_helper.c | 4 ---- drivers/gpu/drm/exynos/Kconfig | 1 + drivers/gpu/drm/gma500/Kconfig | 1 + drivers/gpu/drm/mgag200/Kconfig | 1 + drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/nouveau/Kconfig | 1 + drivers/gpu/drm/omapdrm/Kconfig | 1 + drivers/gpu/drm/qxl/Kconfig | 1 + drivers/gpu/drm/rcar-du/Kconfig | 1 + drivers/gpu/drm/shmobile/Kconfig | 1 + drivers/gpu/drm/tilcdc/Kconfig | 1 + drivers/gpu/drm/udl/Kconfig | 1 + drivers/gpu/host1x/drm/Kconfig | 1 + drivers/staging/imx-drm/Kconfig | 1 + 19 files changed, 31 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 955555d..3104b6d 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -29,11 +29,17 @@ config DRM_USB config DRM_KMS_HELPER tristate depends on DRM + help + CRTC helpers for KMS drivers. + +config DRM_KMS_FB_HELPER + bool + depends on DRM_KMS_HELPER select FB select FRAMEBUFFER_CONSOLE if !EXPERT select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE help - FB and CRTC helpers for KMS drivers. + FBDEV helpers for KMS drivers. config DRM_LOAD_EDID_FIRMWARE bool "Allow to specify an EDID data set instead of probing for it" @@ -64,6 +70,7 @@ config DRM_GEM_CMA_HELPER config DRM_KMS_CMA_HELPER bool select DRM_GEM_CMA_HELPER + select DRM_KMS_FB_HELPER select FB_SYS_FILLRECT select FB_SYS_COPYAREA select FB_SYS_IMAGEBLIT @@ -96,6 +103,7 @@ config DRM_RADEON select FB_CFB_IMAGEBLIT select FW_LOADER select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER select DRM_TTM select POWER_SUPPLY select HWMON @@ -130,6 +138,7 @@ config DRM_I915 select SHMEM select TMPFS select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index f089adf..5af240b 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -21,8 +21,9 @@ drm-$(CONFIG_PCI) += ati_pcigart.o drm-usb-y := drm_usb.o -drm_kms_helper-y := drm_fb_helper.o drm_crtc_helper.o drm_dp_helper.o +drm_kms_helper-y := drm_crtc_helper.o drm_dp_helper.o drm_kms_helper-$(CONFIG_DRM_LOAD_EDID_FIRMWARE) += drm_edid_load.o +drm_kms_helper-$(CONFIG_DRM_KMS_FB_HELPER) += drm_fb_helper.o drm_kms_helper-$(CONFIG_DRM_KMS_CMA_HELPER) += drm_fb_cma_helper.o obj-$(CONFIG_DRM_KMS_HELPER) += drm_kms_helper.o diff --git a/drivers/gpu/drm/ast/Kconfig b/drivers/gpu/drm/ast/Kconfig index da4a51e..8a784c4 100644 --- a/drivers/gpu/drm/ast/Kconfig +++ b/drivers/gpu/drm/ast/Kconfig @@ -6,6 +6,7 @@ config DRM_AST select FB_SYS_FILLRECT select FB_SYS_IMAGEBLIT select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER select DRM_TTM help Say yes for experimental AST GPU driver. Do not enable diff --git a/drivers/gpu/drm/cirrus/Kconfig b/drivers/gpu/drm/cirrus/Kconfig index bf67b22..9864559 100644 --- a/drivers/gpu/drm/cirrus/Kconfig +++ b/drivers/gpu/drm/cirrus/Kconfig @@ -5,6 +5,7 @@ config DRM_CIRRUS_QEMU select FB_SYS_COPYAREA select FB_SYS_IMAGEBLIT select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER select DRM_TTM help This is a KMS driver for emulated cirrus device in qemu. diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index 4280e37..c4bfd69 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -39,6 +39,10 @@ #include <drm/drm_fb_helper.h> #include <drm/drm_edid.h> +MODULE_AUTHOR("David Airlie, Jesse Barnes"); +MODULE_DESCRIPTION("DRM KMS helper"); +MODULE_LICENSE("GPL and additional rights"); + /** * drm_helper_move_panel_connectors_to_head() - move panels to the front in the * connector list diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index f6f6cc7..b1ad5fa 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -39,10 +39,6 @@ #include <drm/drm_fb_helper.h> #include <drm/drm_crtc_helper.h> -MODULE_AUTHOR("David Airlie, Jesse Barnes"); -MODULE_DESCRIPTION("DRM KMS helper"); -MODULE_LICENSE("GPL and additional rights"); - static LIST_HEAD(kernel_fb_helper_list); /** diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index 45b6ef5..f227f54 100644 --- a/drivers/gpu/drm/exynos/Kconfig +++ b/drivers/gpu/drm/exynos/Kconfig @@ -2,6 +2,7 @@ config DRM_EXYNOS tristate "DRM Support for Samsung SoC EXYNOS Series" depends on OF && DRM && (PLAT_SAMSUNG || ARCH_MULTIPLATFORM) select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig index 1f6e2df..508cf99 100644 --- a/drivers/gpu/drm/gma500/Kconfig +++ b/drivers/gpu/drm/gma500/Kconfig @@ -5,6 +5,7 @@ config DRM_GMA500 select FB_CFB_FILLRECT select FB_CFB_IMAGEBLIT select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER select DRM_TTM # GMA500 depends on ACPI_VIDEO when ACPI is enabled, just like i915 select ACPI_VIDEO if ACPI diff --git a/drivers/gpu/drm/mgag200/Kconfig b/drivers/gpu/drm/mgag200/Kconfig index b487cde..3a1c5fb 100644 --- a/drivers/gpu/drm/mgag200/Kconfig +++ b/drivers/gpu/drm/mgag200/Kconfig @@ -5,6 +5,7 @@ config DRM_MGAG200 select FB_SYS_COPYAREA select FB_SYS_IMAGEBLIT select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER select DRM_TTM help This is a KMS driver for the MGA G200 server chips, it diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index a06c19c..f39ab75 100644 --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -14,6 +14,7 @@ config DRM_MSM config DRM_MSM_FBDEV bool "Enable legacy fbdev support for MSM modesetting driver" depends on DRM_MSM + select DRM_KMS_FB_HELPER select FB_SYS_FILLRECT select FB_SYS_COPYAREA select FB_SYS_IMAGEBLIT diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig index ff80f12..7cf787d 100644 --- a/drivers/gpu/drm/nouveau/Kconfig +++ b/drivers/gpu/drm/nouveau/Kconfig @@ -3,6 +3,7 @@ config DRM_NOUVEAU depends on DRM && PCI select FW_LOADER select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER select DRM_TTM select FB_CFB_FILLRECT select FB_CFB_COPYAREA diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig index 20c41e7..6c220cd 100644 --- a/drivers/gpu/drm/omapdrm/Kconfig +++ b/drivers/gpu/drm/omapdrm/Kconfig @@ -5,6 +5,7 @@ config DRM_OMAP depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM depends on OMAP2_DSS select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER select FB_SYS_FILLRECT select FB_SYS_COPYAREA select FB_SYS_IMAGEBLIT diff --git a/drivers/gpu/drm/qxl/Kconfig b/drivers/gpu/drm/qxl/Kconfig index d6c1279..037d324 100644 --- a/drivers/gpu/drm/qxl/Kconfig +++ b/drivers/gpu/drm/qxl/Kconfig @@ -6,6 +6,7 @@ config DRM_QXL select FB_SYS_IMAGEBLIT select FB_DEFERRED_IO select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER select DRM_TTM help QXL virtual GPU for Spice virtualization desktop integration. Do not enable this driver unless your distro ships a corresponding X.org QXL driver that can handle kernel modesetting. diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig index c590cd9..d8e835a 100644 --- a/drivers/gpu/drm/rcar-du/Kconfig +++ b/drivers/gpu/drm/rcar-du/Kconfig @@ -4,6 +4,7 @@ config DRM_RCAR_DU select DRM_KMS_HELPER select DRM_KMS_CMA_HELPER select DRM_GEM_CMA_HELPER + select DRM_KMS_FB_HELPER help Choose this option if you have an R-Car chipset. If M is selected the module will be called rcar-du-drm. diff --git a/drivers/gpu/drm/shmobile/Kconfig b/drivers/gpu/drm/shmobile/Kconfig index ca498d1..d137286 100644 --- a/drivers/gpu/drm/shmobile/Kconfig +++ b/drivers/gpu/drm/shmobile/Kconfig @@ -2,6 +2,7 @@ config DRM_SHMOBILE tristate "DRM Support for SH Mobile" depends on DRM && (ARM || SUPERH) select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER select DRM_KMS_CMA_HELPER select DRM_GEM_CMA_HELPER help diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig index 7a4d101..7c3ef79 100644 --- a/drivers/gpu/drm/tilcdc/Kconfig +++ b/drivers/gpu/drm/tilcdc/Kconfig @@ -2,6 +2,7 @@ config DRM_TILCDC tristate "DRM Support for TI LCDC Display Controller" depends on DRM && OF && ARM select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER select DRM_KMS_CMA_HELPER select DRM_GEM_CMA_HELPER select VIDEOMODE_HELPERS diff --git a/drivers/gpu/drm/udl/Kconfig b/drivers/gpu/drm/udl/Kconfig index 6222af1..f025286 100644 --- a/drivers/gpu/drm/udl/Kconfig +++ b/drivers/gpu/drm/udl/Kconfig @@ -8,6 +8,7 @@ config DRM_UDL select FB_SYS_IMAGEBLIT select FB_DEFERRED_IO select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER help This is a KMS driver for the USB displaylink video adapters. Say M/Y to add support for these devices via drm/kms interfaces. diff --git a/drivers/gpu/host1x/drm/Kconfig b/drivers/gpu/host1x/drm/Kconfig index 69853a4..0f36ddd 100644 --- a/drivers/gpu/host1x/drm/Kconfig +++ b/drivers/gpu/host1x/drm/Kconfig @@ -2,6 +2,7 @@ config DRM_TEGRA bool "NVIDIA Tegra DRM" depends on DRM select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER select FB_SYS_FILLRECT select FB_SYS_COPYAREA select FB_SYS_IMAGEBLIT diff --git a/drivers/staging/imx-drm/Kconfig b/drivers/staging/imx-drm/Kconfig index 394254f7d..5032ff7 100644 --- a/drivers/staging/imx-drm/Kconfig +++ b/drivers/staging/imx-drm/Kconfig @@ -1,6 +1,7 @@ config DRM_IMX tristate "DRM Support for Freescale i.MX" select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER select VIDEOMODE_HELPERS select DRM_GEM_CMA_HELPER select DRM_KMS_CMA_HELPER -- 1.8.1.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] drm: Add separate Kconfig option for fbdev helpers 2013-10-08 15:44 ` [PATCH 1/3] drm: Add separate Kconfig option for fbdev helpers Daniel Vetter @ 2013-10-08 16:52 ` Rob Clark 2013-10-11 21:36 ` Daniel Vetter 0 siblings, 1 reply; 14+ messages in thread From: Rob Clark @ 2013-10-08 16:52 UTC (permalink / raw) To: Daniel Vetter; +Cc: Intel Graphics Development, DRI Development On Tue, Oct 8, 2013 at 11:44 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > For drivers which might want to disable fbdev legacy support. > > Select the new option in all drivers for now, so this shouldn't result > in any change. Drivers need some work anyway to make fbdev support > optional (if they have it implemented, that is), so the recommended > way to expose this is by adding per-driver options. At least as long > as most drivers don't support disabling the fbdev support. > > v2: Update for new drm drivers msm and rcar-du. Note that Rob's msm > driver can already take advantage of this, which allows us to build > msm without any fbdev depencies in the kernel! > > v3: Move the MODULE_* stuff from the fbdev helper file to > drm_crtc_helper.c. > > Cc: David Herrmann <dh.herrmann@gmail.com> > Cc: Rob Clark <robdclark@gmail.com> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> \o/-by: Rob Clark <robdclark@gmail.com> (and also: Reviewed-by: Rob Clark <robdclark@gmail.com> ) > --- > drivers/gpu/drm/Kconfig | 11 ++++++++++- > drivers/gpu/drm/Makefile | 3 ++- > drivers/gpu/drm/ast/Kconfig | 1 + > drivers/gpu/drm/cirrus/Kconfig | 1 + > drivers/gpu/drm/drm_crtc_helper.c | 4 ++++ > drivers/gpu/drm/drm_fb_helper.c | 4 ---- > drivers/gpu/drm/exynos/Kconfig | 1 + > drivers/gpu/drm/gma500/Kconfig | 1 + > drivers/gpu/drm/mgag200/Kconfig | 1 + > drivers/gpu/drm/msm/Kconfig | 1 + > drivers/gpu/drm/nouveau/Kconfig | 1 + > drivers/gpu/drm/omapdrm/Kconfig | 1 + > drivers/gpu/drm/qxl/Kconfig | 1 + > drivers/gpu/drm/rcar-du/Kconfig | 1 + > drivers/gpu/drm/shmobile/Kconfig | 1 + > drivers/gpu/drm/tilcdc/Kconfig | 1 + > drivers/gpu/drm/udl/Kconfig | 1 + > drivers/gpu/host1x/drm/Kconfig | 1 + > drivers/staging/imx-drm/Kconfig | 1 + > 19 files changed, 31 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 955555d..3104b6d 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -29,11 +29,17 @@ config DRM_USB > config DRM_KMS_HELPER > tristate > depends on DRM > + help > + CRTC helpers for KMS drivers. > + > +config DRM_KMS_FB_HELPER > + bool > + depends on DRM_KMS_HELPER > select FB > select FRAMEBUFFER_CONSOLE if !EXPERT > select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE > help > - FB and CRTC helpers for KMS drivers. > + FBDEV helpers for KMS drivers. > > config DRM_LOAD_EDID_FIRMWARE > bool "Allow to specify an EDID data set instead of probing for it" > @@ -64,6 +70,7 @@ config DRM_GEM_CMA_HELPER > config DRM_KMS_CMA_HELPER > bool > select DRM_GEM_CMA_HELPER > + select DRM_KMS_FB_HELPER > select FB_SYS_FILLRECT > select FB_SYS_COPYAREA > select FB_SYS_IMAGEBLIT > @@ -96,6 +103,7 @@ config DRM_RADEON > select FB_CFB_IMAGEBLIT > select FW_LOADER > select DRM_KMS_HELPER > + select DRM_KMS_FB_HELPER > select DRM_TTM > select POWER_SUPPLY > select HWMON > @@ -130,6 +138,7 @@ config DRM_I915 > select SHMEM > select TMPFS > select DRM_KMS_HELPER > + select DRM_KMS_FB_HELPER > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile > index f089adf..5af240b 100644 > --- a/drivers/gpu/drm/Makefile > +++ b/drivers/gpu/drm/Makefile > @@ -21,8 +21,9 @@ drm-$(CONFIG_PCI) += ati_pcigart.o > > drm-usb-y := drm_usb.o > > -drm_kms_helper-y := drm_fb_helper.o drm_crtc_helper.o drm_dp_helper.o > +drm_kms_helper-y := drm_crtc_helper.o drm_dp_helper.o > drm_kms_helper-$(CONFIG_DRM_LOAD_EDID_FIRMWARE) += drm_edid_load.o > +drm_kms_helper-$(CONFIG_DRM_KMS_FB_HELPER) += drm_fb_helper.o > drm_kms_helper-$(CONFIG_DRM_KMS_CMA_HELPER) += drm_fb_cma_helper.o > > obj-$(CONFIG_DRM_KMS_HELPER) += drm_kms_helper.o > diff --git a/drivers/gpu/drm/ast/Kconfig b/drivers/gpu/drm/ast/Kconfig > index da4a51e..8a784c4 100644 > --- a/drivers/gpu/drm/ast/Kconfig > +++ b/drivers/gpu/drm/ast/Kconfig > @@ -6,6 +6,7 @@ config DRM_AST > select FB_SYS_FILLRECT > select FB_SYS_IMAGEBLIT > select DRM_KMS_HELPER > + select DRM_KMS_FB_HELPER > select DRM_TTM > help > Say yes for experimental AST GPU driver. Do not enable > diff --git a/drivers/gpu/drm/cirrus/Kconfig b/drivers/gpu/drm/cirrus/Kconfig > index bf67b22..9864559 100644 > --- a/drivers/gpu/drm/cirrus/Kconfig > +++ b/drivers/gpu/drm/cirrus/Kconfig > @@ -5,6 +5,7 @@ config DRM_CIRRUS_QEMU > select FB_SYS_COPYAREA > select FB_SYS_IMAGEBLIT > select DRM_KMS_HELPER > + select DRM_KMS_FB_HELPER > select DRM_TTM > help > This is a KMS driver for emulated cirrus device in qemu. > diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c > index 4280e37..c4bfd69 100644 > --- a/drivers/gpu/drm/drm_crtc_helper.c > +++ b/drivers/gpu/drm/drm_crtc_helper.c > @@ -39,6 +39,10 @@ > #include <drm/drm_fb_helper.h> > #include <drm/drm_edid.h> > > +MODULE_AUTHOR("David Airlie, Jesse Barnes"); > +MODULE_DESCRIPTION("DRM KMS helper"); > +MODULE_LICENSE("GPL and additional rights"); > + > /** > * drm_helper_move_panel_connectors_to_head() - move panels to the front in the > * connector list > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index f6f6cc7..b1ad5fa 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -39,10 +39,6 @@ > #include <drm/drm_fb_helper.h> > #include <drm/drm_crtc_helper.h> > > -MODULE_AUTHOR("David Airlie, Jesse Barnes"); > -MODULE_DESCRIPTION("DRM KMS helper"); > -MODULE_LICENSE("GPL and additional rights"); > - > static LIST_HEAD(kernel_fb_helper_list); > > /** > diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig > index 45b6ef5..f227f54 100644 > --- a/drivers/gpu/drm/exynos/Kconfig > +++ b/drivers/gpu/drm/exynos/Kconfig > @@ -2,6 +2,7 @@ config DRM_EXYNOS > tristate "DRM Support for Samsung SoC EXYNOS Series" > depends on OF && DRM && (PLAT_SAMSUNG || ARCH_MULTIPLATFORM) > select DRM_KMS_HELPER > + select DRM_KMS_FB_HELPER > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig > index 1f6e2df..508cf99 100644 > --- a/drivers/gpu/drm/gma500/Kconfig > +++ b/drivers/gpu/drm/gma500/Kconfig > @@ -5,6 +5,7 @@ config DRM_GMA500 > select FB_CFB_FILLRECT > select FB_CFB_IMAGEBLIT > select DRM_KMS_HELPER > + select DRM_KMS_FB_HELPER > select DRM_TTM > # GMA500 depends on ACPI_VIDEO when ACPI is enabled, just like i915 > select ACPI_VIDEO if ACPI > diff --git a/drivers/gpu/drm/mgag200/Kconfig b/drivers/gpu/drm/mgag200/Kconfig > index b487cde..3a1c5fb 100644 > --- a/drivers/gpu/drm/mgag200/Kconfig > +++ b/drivers/gpu/drm/mgag200/Kconfig > @@ -5,6 +5,7 @@ config DRM_MGAG200 > select FB_SYS_COPYAREA > select FB_SYS_IMAGEBLIT > select DRM_KMS_HELPER > + select DRM_KMS_FB_HELPER > select DRM_TTM > help > This is a KMS driver for the MGA G200 server chips, it > diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig > index a06c19c..f39ab75 100644 > --- a/drivers/gpu/drm/msm/Kconfig > +++ b/drivers/gpu/drm/msm/Kconfig > @@ -14,6 +14,7 @@ config DRM_MSM > config DRM_MSM_FBDEV > bool "Enable legacy fbdev support for MSM modesetting driver" > depends on DRM_MSM > + select DRM_KMS_FB_HELPER > select FB_SYS_FILLRECT > select FB_SYS_COPYAREA > select FB_SYS_IMAGEBLIT > diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig > index ff80f12..7cf787d 100644 > --- a/drivers/gpu/drm/nouveau/Kconfig > +++ b/drivers/gpu/drm/nouveau/Kconfig > @@ -3,6 +3,7 @@ config DRM_NOUVEAU > depends on DRM && PCI > select FW_LOADER > select DRM_KMS_HELPER > + select DRM_KMS_FB_HELPER > select DRM_TTM > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig > index 20c41e7..6c220cd 100644 > --- a/drivers/gpu/drm/omapdrm/Kconfig > +++ b/drivers/gpu/drm/omapdrm/Kconfig > @@ -5,6 +5,7 @@ config DRM_OMAP > depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM > depends on OMAP2_DSS > select DRM_KMS_HELPER > + select DRM_KMS_FB_HELPER > select FB_SYS_FILLRECT > select FB_SYS_COPYAREA > select FB_SYS_IMAGEBLIT > diff --git a/drivers/gpu/drm/qxl/Kconfig b/drivers/gpu/drm/qxl/Kconfig > index d6c1279..037d324 100644 > --- a/drivers/gpu/drm/qxl/Kconfig > +++ b/drivers/gpu/drm/qxl/Kconfig > @@ -6,6 +6,7 @@ config DRM_QXL > select FB_SYS_IMAGEBLIT > select FB_DEFERRED_IO > select DRM_KMS_HELPER > + select DRM_KMS_FB_HELPER > select DRM_TTM > help > QXL virtual GPU for Spice virtualization desktop integration. Do not enable this driver unless your distro ships a corresponding X.org QXL driver that can handle kernel modesetting. > diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig > index c590cd9..d8e835a 100644 > --- a/drivers/gpu/drm/rcar-du/Kconfig > +++ b/drivers/gpu/drm/rcar-du/Kconfig > @@ -4,6 +4,7 @@ config DRM_RCAR_DU > select DRM_KMS_HELPER > select DRM_KMS_CMA_HELPER > select DRM_GEM_CMA_HELPER > + select DRM_KMS_FB_HELPER > help > Choose this option if you have an R-Car chipset. > If M is selected the module will be called rcar-du-drm. > diff --git a/drivers/gpu/drm/shmobile/Kconfig b/drivers/gpu/drm/shmobile/Kconfig > index ca498d1..d137286 100644 > --- a/drivers/gpu/drm/shmobile/Kconfig > +++ b/drivers/gpu/drm/shmobile/Kconfig > @@ -2,6 +2,7 @@ config DRM_SHMOBILE > tristate "DRM Support for SH Mobile" > depends on DRM && (ARM || SUPERH) > select DRM_KMS_HELPER > + select DRM_KMS_FB_HELPER > select DRM_KMS_CMA_HELPER > select DRM_GEM_CMA_HELPER > help > diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig > index 7a4d101..7c3ef79 100644 > --- a/drivers/gpu/drm/tilcdc/Kconfig > +++ b/drivers/gpu/drm/tilcdc/Kconfig > @@ -2,6 +2,7 @@ config DRM_TILCDC > tristate "DRM Support for TI LCDC Display Controller" > depends on DRM && OF && ARM > select DRM_KMS_HELPER > + select DRM_KMS_FB_HELPER > select DRM_KMS_CMA_HELPER > select DRM_GEM_CMA_HELPER > select VIDEOMODE_HELPERS > diff --git a/drivers/gpu/drm/udl/Kconfig b/drivers/gpu/drm/udl/Kconfig > index 6222af1..f025286 100644 > --- a/drivers/gpu/drm/udl/Kconfig > +++ b/drivers/gpu/drm/udl/Kconfig > @@ -8,6 +8,7 @@ config DRM_UDL > select FB_SYS_IMAGEBLIT > select FB_DEFERRED_IO > select DRM_KMS_HELPER > + select DRM_KMS_FB_HELPER > help > This is a KMS driver for the USB displaylink video adapters. > Say M/Y to add support for these devices via drm/kms interfaces. > diff --git a/drivers/gpu/host1x/drm/Kconfig b/drivers/gpu/host1x/drm/Kconfig > index 69853a4..0f36ddd 100644 > --- a/drivers/gpu/host1x/drm/Kconfig > +++ b/drivers/gpu/host1x/drm/Kconfig > @@ -2,6 +2,7 @@ config DRM_TEGRA > bool "NVIDIA Tegra DRM" > depends on DRM > select DRM_KMS_HELPER > + select DRM_KMS_FB_HELPER > select FB_SYS_FILLRECT > select FB_SYS_COPYAREA > select FB_SYS_IMAGEBLIT > diff --git a/drivers/staging/imx-drm/Kconfig b/drivers/staging/imx-drm/Kconfig > index 394254f7d..5032ff7 100644 > --- a/drivers/staging/imx-drm/Kconfig > +++ b/drivers/staging/imx-drm/Kconfig > @@ -1,6 +1,7 @@ > config DRM_IMX > tristate "DRM Support for Freescale i.MX" > select DRM_KMS_HELPER > + select DRM_KMS_FB_HELPER > select VIDEOMODE_HELPERS > select DRM_GEM_CMA_HELPER > select DRM_KMS_CMA_HELPER > -- > 1.8.1.4 > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] drm: Add separate Kconfig option for fbdev helpers 2013-10-08 16:52 ` Rob Clark @ 2013-10-11 21:36 ` Daniel Vetter 0 siblings, 0 replies; 14+ messages in thread From: Daniel Vetter @ 2013-10-11 21:36 UTC (permalink / raw) To: Rob Clark Cc: Daniel Vetter, Intel Graphics Development, DRI Development, David Herrmann On Tue, Oct 08, 2013 at 12:52:53PM -0400, Rob Clark wrote: > On Tue, Oct 8, 2013 at 11:44 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > For drivers which might want to disable fbdev legacy support. > > > > Select the new option in all drivers for now, so this shouldn't result > > in any change. Drivers need some work anyway to make fbdev support > > optional (if they have it implemented, that is), so the recommended > > way to expose this is by adding per-driver options. At least as long > > as most drivers don't support disabling the fbdev support. > > > > v2: Update for new drm drivers msm and rcar-du. Note that Rob's msm > > driver can already take advantage of this, which allows us to build > > msm without any fbdev depencies in the kernel! > > > > v3: Move the MODULE_* stuff from the fbdev helper file to > > drm_crtc_helper.c. > > > > Cc: David Herrmann <dh.herrmann@gmail.com> > > Cc: Rob Clark <robdclark@gmail.com> > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > \o/-by: Rob Clark <robdclark@gmail.com> > > (and also: > Reviewed-by: Rob Clark <robdclark@gmail.com> > ) Thanks for the review, patch merged to drm-intel-next with Dave's ack on irc. -Daniel > > > --- > > drivers/gpu/drm/Kconfig | 11 ++++++++++- > > drivers/gpu/drm/Makefile | 3 ++- > > drivers/gpu/drm/ast/Kconfig | 1 + > > drivers/gpu/drm/cirrus/Kconfig | 1 + > > drivers/gpu/drm/drm_crtc_helper.c | 4 ++++ > > drivers/gpu/drm/drm_fb_helper.c | 4 ---- > > drivers/gpu/drm/exynos/Kconfig | 1 + > > drivers/gpu/drm/gma500/Kconfig | 1 + > > drivers/gpu/drm/mgag200/Kconfig | 1 + > > drivers/gpu/drm/msm/Kconfig | 1 + > > drivers/gpu/drm/nouveau/Kconfig | 1 + > > drivers/gpu/drm/omapdrm/Kconfig | 1 + > > drivers/gpu/drm/qxl/Kconfig | 1 + > > drivers/gpu/drm/rcar-du/Kconfig | 1 + > > drivers/gpu/drm/shmobile/Kconfig | 1 + > > drivers/gpu/drm/tilcdc/Kconfig | 1 + > > drivers/gpu/drm/udl/Kconfig | 1 + > > drivers/gpu/host1x/drm/Kconfig | 1 + > > drivers/staging/imx-drm/Kconfig | 1 + > > 19 files changed, 31 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > > index 955555d..3104b6d 100644 > > --- a/drivers/gpu/drm/Kconfig > > +++ b/drivers/gpu/drm/Kconfig > > @@ -29,11 +29,17 @@ config DRM_USB > > config DRM_KMS_HELPER > > tristate > > depends on DRM > > + help > > + CRTC helpers for KMS drivers. > > + > > +config DRM_KMS_FB_HELPER > > + bool > > + depends on DRM_KMS_HELPER > > select FB > > select FRAMEBUFFER_CONSOLE if !EXPERT > > select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE > > help > > - FB and CRTC helpers for KMS drivers. > > + FBDEV helpers for KMS drivers. > > > > config DRM_LOAD_EDID_FIRMWARE > > bool "Allow to specify an EDID data set instead of probing for it" > > @@ -64,6 +70,7 @@ config DRM_GEM_CMA_HELPER > > config DRM_KMS_CMA_HELPER > > bool > > select DRM_GEM_CMA_HELPER > > + select DRM_KMS_FB_HELPER > > select FB_SYS_FILLRECT > > select FB_SYS_COPYAREA > > select FB_SYS_IMAGEBLIT > > @@ -96,6 +103,7 @@ config DRM_RADEON > > select FB_CFB_IMAGEBLIT > > select FW_LOADER > > select DRM_KMS_HELPER > > + select DRM_KMS_FB_HELPER > > select DRM_TTM > > select POWER_SUPPLY > > select HWMON > > @@ -130,6 +138,7 @@ config DRM_I915 > > select SHMEM > > select TMPFS > > select DRM_KMS_HELPER > > + select DRM_KMS_FB_HELPER > > select FB_CFB_FILLRECT > > select FB_CFB_COPYAREA > > select FB_CFB_IMAGEBLIT > > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile > > index f089adf..5af240b 100644 > > --- a/drivers/gpu/drm/Makefile > > +++ b/drivers/gpu/drm/Makefile > > @@ -21,8 +21,9 @@ drm-$(CONFIG_PCI) += ati_pcigart.o > > > > drm-usb-y := drm_usb.o > > > > -drm_kms_helper-y := drm_fb_helper.o drm_crtc_helper.o drm_dp_helper.o > > +drm_kms_helper-y := drm_crtc_helper.o drm_dp_helper.o > > drm_kms_helper-$(CONFIG_DRM_LOAD_EDID_FIRMWARE) += drm_edid_load.o > > +drm_kms_helper-$(CONFIG_DRM_KMS_FB_HELPER) += drm_fb_helper.o > > drm_kms_helper-$(CONFIG_DRM_KMS_CMA_HELPER) += drm_fb_cma_helper.o > > > > obj-$(CONFIG_DRM_KMS_HELPER) += drm_kms_helper.o > > diff --git a/drivers/gpu/drm/ast/Kconfig b/drivers/gpu/drm/ast/Kconfig > > index da4a51e..8a784c4 100644 > > --- a/drivers/gpu/drm/ast/Kconfig > > +++ b/drivers/gpu/drm/ast/Kconfig > > @@ -6,6 +6,7 @@ config DRM_AST > > select FB_SYS_FILLRECT > > select FB_SYS_IMAGEBLIT > > select DRM_KMS_HELPER > > + select DRM_KMS_FB_HELPER > > select DRM_TTM > > help > > Say yes for experimental AST GPU driver. Do not enable > > diff --git a/drivers/gpu/drm/cirrus/Kconfig b/drivers/gpu/drm/cirrus/Kconfig > > index bf67b22..9864559 100644 > > --- a/drivers/gpu/drm/cirrus/Kconfig > > +++ b/drivers/gpu/drm/cirrus/Kconfig > > @@ -5,6 +5,7 @@ config DRM_CIRRUS_QEMU > > select FB_SYS_COPYAREA > > select FB_SYS_IMAGEBLIT > > select DRM_KMS_HELPER > > + select DRM_KMS_FB_HELPER > > select DRM_TTM > > help > > This is a KMS driver for emulated cirrus device in qemu. > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c > > index 4280e37..c4bfd69 100644 > > --- a/drivers/gpu/drm/drm_crtc_helper.c > > +++ b/drivers/gpu/drm/drm_crtc_helper.c > > @@ -39,6 +39,10 @@ > > #include <drm/drm_fb_helper.h> > > #include <drm/drm_edid.h> > > > > +MODULE_AUTHOR("David Airlie, Jesse Barnes"); > > +MODULE_DESCRIPTION("DRM KMS helper"); > > +MODULE_LICENSE("GPL and additional rights"); > > + > > /** > > * drm_helper_move_panel_connectors_to_head() - move panels to the front in the > > * connector list > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > > index f6f6cc7..b1ad5fa 100644 > > --- a/drivers/gpu/drm/drm_fb_helper.c > > +++ b/drivers/gpu/drm/drm_fb_helper.c > > @@ -39,10 +39,6 @@ > > #include <drm/drm_fb_helper.h> > > #include <drm/drm_crtc_helper.h> > > > > -MODULE_AUTHOR("David Airlie, Jesse Barnes"); > > -MODULE_DESCRIPTION("DRM KMS helper"); > > -MODULE_LICENSE("GPL and additional rights"); > > - > > static LIST_HEAD(kernel_fb_helper_list); > > > > /** > > diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig > > index 45b6ef5..f227f54 100644 > > --- a/drivers/gpu/drm/exynos/Kconfig > > +++ b/drivers/gpu/drm/exynos/Kconfig > > @@ -2,6 +2,7 @@ config DRM_EXYNOS > > tristate "DRM Support for Samsung SoC EXYNOS Series" > > depends on OF && DRM && (PLAT_SAMSUNG || ARCH_MULTIPLATFORM) > > select DRM_KMS_HELPER > > + select DRM_KMS_FB_HELPER > > select FB_CFB_FILLRECT > > select FB_CFB_COPYAREA > > select FB_CFB_IMAGEBLIT > > diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig > > index 1f6e2df..508cf99 100644 > > --- a/drivers/gpu/drm/gma500/Kconfig > > +++ b/drivers/gpu/drm/gma500/Kconfig > > @@ -5,6 +5,7 @@ config DRM_GMA500 > > select FB_CFB_FILLRECT > > select FB_CFB_IMAGEBLIT > > select DRM_KMS_HELPER > > + select DRM_KMS_FB_HELPER > > select DRM_TTM > > # GMA500 depends on ACPI_VIDEO when ACPI is enabled, just like i915 > > select ACPI_VIDEO if ACPI > > diff --git a/drivers/gpu/drm/mgag200/Kconfig b/drivers/gpu/drm/mgag200/Kconfig > > index b487cde..3a1c5fb 100644 > > --- a/drivers/gpu/drm/mgag200/Kconfig > > +++ b/drivers/gpu/drm/mgag200/Kconfig > > @@ -5,6 +5,7 @@ config DRM_MGAG200 > > select FB_SYS_COPYAREA > > select FB_SYS_IMAGEBLIT > > select DRM_KMS_HELPER > > + select DRM_KMS_FB_HELPER > > select DRM_TTM > > help > > This is a KMS driver for the MGA G200 server chips, it > > diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig > > index a06c19c..f39ab75 100644 > > --- a/drivers/gpu/drm/msm/Kconfig > > +++ b/drivers/gpu/drm/msm/Kconfig > > @@ -14,6 +14,7 @@ config DRM_MSM > > config DRM_MSM_FBDEV > > bool "Enable legacy fbdev support for MSM modesetting driver" > > depends on DRM_MSM > > + select DRM_KMS_FB_HELPER > > select FB_SYS_FILLRECT > > select FB_SYS_COPYAREA > > select FB_SYS_IMAGEBLIT > > diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig > > index ff80f12..7cf787d 100644 > > --- a/drivers/gpu/drm/nouveau/Kconfig > > +++ b/drivers/gpu/drm/nouveau/Kconfig > > @@ -3,6 +3,7 @@ config DRM_NOUVEAU > > depends on DRM && PCI > > select FW_LOADER > > select DRM_KMS_HELPER > > + select DRM_KMS_FB_HELPER > > select DRM_TTM > > select FB_CFB_FILLRECT > > select FB_CFB_COPYAREA > > diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig > > index 20c41e7..6c220cd 100644 > > --- a/drivers/gpu/drm/omapdrm/Kconfig > > +++ b/drivers/gpu/drm/omapdrm/Kconfig > > @@ -5,6 +5,7 @@ config DRM_OMAP > > depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM > > depends on OMAP2_DSS > > select DRM_KMS_HELPER > > + select DRM_KMS_FB_HELPER > > select FB_SYS_FILLRECT > > select FB_SYS_COPYAREA > > select FB_SYS_IMAGEBLIT > > diff --git a/drivers/gpu/drm/qxl/Kconfig b/drivers/gpu/drm/qxl/Kconfig > > index d6c1279..037d324 100644 > > --- a/drivers/gpu/drm/qxl/Kconfig > > +++ b/drivers/gpu/drm/qxl/Kconfig > > @@ -6,6 +6,7 @@ config DRM_QXL > > select FB_SYS_IMAGEBLIT > > select FB_DEFERRED_IO > > select DRM_KMS_HELPER > > + select DRM_KMS_FB_HELPER > > select DRM_TTM > > help > > QXL virtual GPU for Spice virtualization desktop integration. Do not enable this driver unless your distro ships a corresponding X.org QXL driver that can handle kernel modesetting. > > diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig > > index c590cd9..d8e835a 100644 > > --- a/drivers/gpu/drm/rcar-du/Kconfig > > +++ b/drivers/gpu/drm/rcar-du/Kconfig > > @@ -4,6 +4,7 @@ config DRM_RCAR_DU > > select DRM_KMS_HELPER > > select DRM_KMS_CMA_HELPER > > select DRM_GEM_CMA_HELPER > > + select DRM_KMS_FB_HELPER > > help > > Choose this option if you have an R-Car chipset. > > If M is selected the module will be called rcar-du-drm. > > diff --git a/drivers/gpu/drm/shmobile/Kconfig b/drivers/gpu/drm/shmobile/Kconfig > > index ca498d1..d137286 100644 > > --- a/drivers/gpu/drm/shmobile/Kconfig > > +++ b/drivers/gpu/drm/shmobile/Kconfig > > @@ -2,6 +2,7 @@ config DRM_SHMOBILE > > tristate "DRM Support for SH Mobile" > > depends on DRM && (ARM || SUPERH) > > select DRM_KMS_HELPER > > + select DRM_KMS_FB_HELPER > > select DRM_KMS_CMA_HELPER > > select DRM_GEM_CMA_HELPER > > help > > diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig > > index 7a4d101..7c3ef79 100644 > > --- a/drivers/gpu/drm/tilcdc/Kconfig > > +++ b/drivers/gpu/drm/tilcdc/Kconfig > > @@ -2,6 +2,7 @@ config DRM_TILCDC > > tristate "DRM Support for TI LCDC Display Controller" > > depends on DRM && OF && ARM > > select DRM_KMS_HELPER > > + select DRM_KMS_FB_HELPER > > select DRM_KMS_CMA_HELPER > > select DRM_GEM_CMA_HELPER > > select VIDEOMODE_HELPERS > > diff --git a/drivers/gpu/drm/udl/Kconfig b/drivers/gpu/drm/udl/Kconfig > > index 6222af1..f025286 100644 > > --- a/drivers/gpu/drm/udl/Kconfig > > +++ b/drivers/gpu/drm/udl/Kconfig > > @@ -8,6 +8,7 @@ config DRM_UDL > > select FB_SYS_IMAGEBLIT > > select FB_DEFERRED_IO > > select DRM_KMS_HELPER > > + select DRM_KMS_FB_HELPER > > help > > This is a KMS driver for the USB displaylink video adapters. > > Say M/Y to add support for these devices via drm/kms interfaces. > > diff --git a/drivers/gpu/host1x/drm/Kconfig b/drivers/gpu/host1x/drm/Kconfig > > index 69853a4..0f36ddd 100644 > > --- a/drivers/gpu/host1x/drm/Kconfig > > +++ b/drivers/gpu/host1x/drm/Kconfig > > @@ -2,6 +2,7 @@ config DRM_TEGRA > > bool "NVIDIA Tegra DRM" > > depends on DRM > > select DRM_KMS_HELPER > > + select DRM_KMS_FB_HELPER > > select FB_SYS_FILLRECT > > select FB_SYS_COPYAREA > > select FB_SYS_IMAGEBLIT > > diff --git a/drivers/staging/imx-drm/Kconfig b/drivers/staging/imx-drm/Kconfig > > index 394254f7d..5032ff7 100644 > > --- a/drivers/staging/imx-drm/Kconfig > > +++ b/drivers/staging/imx-drm/Kconfig > > @@ -1,6 +1,7 @@ > > config DRM_IMX > > tristate "DRM Support for Freescale i.MX" > > select DRM_KMS_HELPER > > + select DRM_KMS_FB_HELPER > > select VIDEOMODE_HELPERS > > select DRM_GEM_CMA_HELPER > > select DRM_KMS_CMA_HELPER > > -- > > 1.8.1.4 > > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] drm/i915: Kconfig option to disable the legacy fbdev support 2013-10-08 15:44 [PATCH 0/3] fbdev-less i915, take 2 Daniel Vetter 2013-10-08 15:44 ` [PATCH 1/3] drm: Add separate Kconfig option for fbdev helpers Daniel Vetter @ 2013-10-08 15:44 ` Daniel Vetter 2013-10-09 6:35 ` Lee, Chon Ming 2013-10-08 15:44 ` [PATCH 3/3] drm/i915: rename intel_fb.c to intel_fbdev.c Daniel Vetter 2013-10-08 15:59 ` [PATCH 0/3] fbdev-less i915, take 2 Chris Wilson 3 siblings, 1 reply; 14+ messages in thread From: Daniel Vetter @ 2013-10-08 15:44 UTC (permalink / raw) To: DRI Development; +Cc: Daniel Vetter, Intel Graphics Development Boots Just Fine (tm)! The only glitch seems to be that at least on Fedora the boot splash gets confused and doesn't display much at all. And since there's no ugly console flickering anymore in between, the flicker while switching between X servers (VT support is still enabled) is even more jarring. Also, I'm unsure whether we don't need to somehow kick out vgacon, now that nothing else gets in the way. But stuff seems to work, so I don't care. Also everything still works as well with VGA_CONSOLE=n Also the #ifdef mess needs a bit of a cleanup, follow-up patches will do just that. To keep the Kconfig tidy, extract all the i915 options into its own file. v2: - Rebase on top of the preliminary hw support option and the intel_drv.h cleanup. - Shut up warnings in i915_debugfs.c Cc: David Herrmann <dh.herrmann@gmail.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/gpu/drm/Kconfig | 60 +------------------------------- drivers/gpu/drm/i915/Kconfig | 67 ++++++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/i915_debugfs.c | 9 ++--- drivers/gpu/drm/i915/i915_dma.c | 6 ++++ drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/intel_display.c | 10 ++++++ drivers/gpu/drm/i915/intel_drv.h | 36 +++++++++++++++---- 8 files changed, 122 insertions(+), 71 deletions(-) create mode 100644 drivers/gpu/drm/i915/Kconfig diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 3104b6d..b4e4fc0 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -128,65 +128,7 @@ config DRM_I810 selected, the module will be called i810. AGP support is required for this driver to work. -config DRM_I915 - tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics" - depends on DRM - depends on AGP - depends on AGP_INTEL - # we need shmfs for the swappable backing store, and in particular - # the shmem_readpage() which depends upon tmpfs - select SHMEM - select TMPFS - select DRM_KMS_HELPER - select DRM_KMS_FB_HELPER - select FB_CFB_FILLRECT - select FB_CFB_COPYAREA - select FB_CFB_IMAGEBLIT - # i915 depends on ACPI_VIDEO when ACPI is enabled - # but for select to work, need to select ACPI_VIDEO's dependencies, ick - select BACKLIGHT_LCD_SUPPORT if ACPI - select BACKLIGHT_CLASS_DEVICE if ACPI - select VIDEO_OUTPUT_CONTROL if ACPI - select INPUT if ACPI - select THERMAL if ACPI - select ACPI_VIDEO if ACPI - select ACPI_BUTTON if ACPI - help - Choose this option if you have a system that has "Intel Graphics - Media Accelerator" or "HD Graphics" integrated graphics, - including 830M, 845G, 852GM, 855GM, 865G, 915G, 945G, 965G, - G35, G41, G43, G45 chipsets and Celeron, Pentium, Core i3, - Core i5, Core i7 as well as Atom CPUs with integrated graphics. - If M is selected, the module will be called i915. AGP support - is required for this driver to work. This driver is used by - the Intel driver in X.org 6.8 and XFree86 4.4 and above. It - replaces the older i830 module that supported a subset of the - hardware in older X.org releases. - - Note that the older i810/i815 chipsets require the use of the - i810 driver instead, and the Atom z5xx series has an entirely - different implementation. - -config DRM_I915_KMS - bool "Enable modesetting on intel by default" - depends on DRM_I915 - help - Choose this option if you want kernel modesetting enabled by default, - and you have a new enough userspace to support this. Running old - userspaces with this enabled will cause pain. Note that this causes - the driver to bind to PCI devices, which precludes loading things - like intelfb. - -config DRM_I915_PRELIMINARY_HW_SUPPORT - bool "Enable preliminary support for prerelease Intel hardware by default" - depends on DRM_I915 - help - Choose this option if you have prerelease Intel hardware and want the - i915 driver to support it by default. You can enable such support at - runtime with the module option i915.preliminary_hw_support=1; this - option changes the default for that module option. - - If in doubt, say "N". +source "drivers/gpu/drm/i915/Kconfig" config DRM_MGA tristate "Matrox g200/g400" diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig new file mode 100644 index 0000000..6199d0b --- /dev/null +++ b/drivers/gpu/drm/i915/Kconfig @@ -0,0 +1,67 @@ +config DRM_I915 + tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics" + depends on DRM + depends on AGP + depends on AGP_INTEL + # we need shmfs for the swappable backing store, and in particular + # the shmem_readpage() which depends upon tmpfs + select SHMEM + select TMPFS + select DRM_KMS_HELPER + # i915 depends on ACPI_VIDEO when ACPI is enabled + # but for select to work, need to select ACPI_VIDEO's dependencies, ick + select BACKLIGHT_LCD_SUPPORT if ACPI + select BACKLIGHT_CLASS_DEVICE if ACPI + select VIDEO_OUTPUT_CONTROL if ACPI + select INPUT if ACPI + select ACPI_VIDEO if ACPI + select ACPI_BUTTON if ACPI + help + Choose this option if you have a system that has "Intel Graphics + Media Accelerator" or "HD Graphics" integrated graphics, + including 830M, 845G, 852GM, 855GM, 865G, 915G, 945G, 965G, + G35, G41, G43, G45 chipsets and Celeron, Pentium, Core i3, + Core i5, Core i7 as well as Atom CPUs with integrated graphics. + If M is selected, the module will be called i915. AGP support + is required for this driver to work. This driver is used by + the Intel driver in X.org 6.8 and XFree86 4.4 and above. It + replaces the older i830 module that supported a subset of the + hardware in older X.org releases. + + Note that the older i810/i815 chipsets require the use of the + i810 driver instead, and the Atom z5xx series has an entirely + different implementation. + +config DRM_I915_KMS + bool "Enable modesetting on intel by default" + depends on DRM_I915 + help + Choose this option if you want kernel modesetting enabled by default, + and you have a new enough userspace to support this. Running old + userspaces with this enabled will cause pain. Note that this causes + the driver to bind to PCI devices, which precludes loading things + like intelfb. + +config DRM_I915_FBDEV + bool "Enable legacy fbdev support for the modesettting intel driver" + depends on DRM_I915 + select DRM_KMS_FB_HELPER + select FB_CFB_FILLRECT + select FB_CFB_COPYAREA + select FB_CFB_IMAGEBLIT + default y + help + Choose this option if you have a need for the legacy fbdev + support. Note that this support also provide the linux console + support on top of the intel modesetting driver. + +config DRM_I915_PRELIMINARY_HW_SUPPORT + bool "Enable preliminary support for prerelease Intel hardware by default" + depends on DRM_I915 + help + Choose this option if you have prerelease Intel hardware and want the + i915 driver to support it by default. You can enable such support at + runtime with the module option i915.preliminary_hw_support=1; this + option changes the default for that module option. + + If in doubt, say "N". diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index 65e60d2..45e14a8 100644 --- a/drivers/gpu/drm/i915/Makefile +++ b/drivers/gpu/drm/i915/Makefile @@ -33,7 +33,6 @@ i915-y := i915_drv.o i915_dma.o i915_irq.o \ intel_panel.o \ intel_pm.o \ intel_i2c.o \ - intel_fb.o \ intel_tv.o \ intel_dvo.o \ intel_ringbuffer.o \ @@ -54,6 +53,8 @@ i915-$(CONFIG_COMPAT) += i915_ioc32.o i915-$(CONFIG_ACPI) += intel_acpi.o +i915-$(CONFIG_DRM_I915_FBDEV) += intel_fb.o + obj-$(CONFIG_DRM_I915) += i915.o CFLAGS_i915_trace_points.o := -I$(src) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 5fd6a5d..79bfbd5 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -1399,12 +1399,12 @@ static int i915_gem_framebuffer_info(struct seq_file *m, void *data) { struct drm_info_node *node = (struct drm_info_node *) m->private; struct drm_device *dev = node->minor->dev; - drm_i915_private_t *dev_priv = dev->dev_private; - struct intel_fbdev *ifbdev; + struct intel_fbdev *ifbdev = NULL; struct intel_framebuffer *fb; - int ret; - ret = mutex_lock_interruptible(&dev->mode_config.mutex); +#ifdef CONFIG_DRM_I915_FBDEV + struct drm_i915_private *dev_priv = dev->dev_private; + int ret = mutex_lock_interruptible(&dev->mode_config.mutex); if (ret) return ret; @@ -1420,6 +1420,7 @@ static int i915_gem_framebuffer_info(struct seq_file *m, void *data) describe_obj(m, fb->obj); seq_putc(m, '\n'); mutex_unlock(&dev->mode_config.mutex); +#endif mutex_lock(&dev->mode_config.fb_lock); list_for_each_entry(fb, &dev->mode_config.fb_list, base.head) { diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index f221631..057ddeb 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c @@ -1416,6 +1416,7 @@ void i915_master_destroy(struct drm_device *dev, struct drm_master *master) master->driver_priv = NULL; } +#ifdef CONFIG_FB static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) { struct apertures_struct *ap; @@ -1436,6 +1437,11 @@ static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) kfree(ap); } +#else +static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) +{ +} +#endif static void i915_dump_device_info(struct drm_i915_private *dev_priv) { diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index ed8653f..99f621d 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -1354,8 +1354,10 @@ typedef struct drm_i915_private { struct drm_i915_gem_object *vlv_pctx; +#ifdef CONFIG_DRM_I915_FBDEV /* list of fbdev register on this device */ struct intel_fbdev *fbdev; +#endif /* * The console may be contended at resume, but we don't diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index ded0d45..43e4e75 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -7318,6 +7318,7 @@ static struct drm_framebuffer * mode_fits_in_fbdev(struct drm_device *dev, struct drm_display_mode *mode) { +#ifdef CONFIG_DRM_I915_FBDEV struct drm_i915_private *dev_priv = dev->dev_private; struct drm_i915_gem_object *obj; struct drm_framebuffer *fb; @@ -7338,6 +7339,9 @@ mode_fits_in_fbdev(struct drm_device *dev, return NULL; return fb; +#else + return NULL; +#endif } bool intel_get_load_detect_pipe(struct drm_connector *connector, @@ -10084,6 +10088,12 @@ intel_user_framebuffer_create(struct drm_device *dev, return intel_framebuffer_create(dev, mode_cmd, obj); } +#ifndef CONFIG_DRM_I915_FBDEV +static inline void intel_fb_output_poll_changed(struct drm_device *dev) +{ +} +#endif + static const struct drm_mode_config_funcs intel_mode_funcs = { .fb_create = intel_user_framebuffer_create, .output_poll_changed = intel_fb_output_poll_changed, diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index adfb57c..181d10b 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h @@ -716,14 +716,36 @@ bool intel_dsi_init(struct drm_device *dev); void intel_dvo_init(struct drm_device *dev); -/* intel_fb.c */ -int intel_fbdev_init(struct drm_device *dev); -void intel_fbdev_initial_config(struct drm_device *dev); -void intel_fbdev_fini(struct drm_device *dev); -void intel_fbdev_set_suspend(struct drm_device *dev, int state); -void intel_fb_output_poll_changed(struct drm_device *dev); -void intel_fb_restore_mode(struct drm_device *dev); +/* legacy fbdev emulation in intel_fb.c */ +#ifdef CONFIG_DRM_I915_FBDEV +extern int intel_fbdev_init(struct drm_device *dev); +extern void intel_fbdev_initial_config(struct drm_device *dev); +extern void intel_fbdev_fini(struct drm_device *dev); +extern void intel_fbdev_set_suspend(struct drm_device *dev, int state); +extern void intel_fb_output_poll_changed(struct drm_device *dev); +extern void intel_fb_restore_mode(struct drm_device *dev); +#else +static inline int intel_fbdev_init(struct drm_device *dev) +{ + return 0; +} +static inline void intel_fbdev_initial_config(struct drm_device *dev) +{ +} + +static inline void intel_fbdev_fini(struct drm_device *dev) +{ +} + +static inline void intel_fbdev_set_suspend(struct drm_device *dev, int state) +{ +} + +static inline void intel_fb_restore_mode(struct drm_device *dev) +{ +} +#endif /* intel_hdmi.c */ void intel_hdmi_init(struct drm_device *dev, int hdmi_reg, enum port port); -- 1.8.1.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] drm/i915: Kconfig option to disable the legacy fbdev support 2013-10-08 15:44 ` [PATCH 2/3] drm/i915: Kconfig option to disable the legacy fbdev support Daniel Vetter @ 2013-10-09 6:35 ` Lee, Chon Ming 2013-10-09 7:18 ` [PATCH] " Daniel Vetter 0 siblings, 1 reply; 14+ messages in thread From: Lee, Chon Ming @ 2013-10-09 6:35 UTC (permalink / raw) To: Daniel Vetter; +Cc: Intel Graphics Development, DRI Development, David Herrmann On 10/08 17:44, Daniel Vetter wrote: > > mutex_lock(&dev->mode_config.fb_lock); > list_for_each_entry(fb, &dev->mode_config.fb_list, base.head) { > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c > index f221631..057ddeb 100644 > --- a/drivers/gpu/drm/i915/i915_dma.c > +++ b/drivers/gpu/drm/i915/i915_dma.c > @@ -1416,6 +1416,7 @@ void i915_master_destroy(struct drm_device *dev, struct drm_master *master) > master->driver_priv = NULL; > } > > +#ifdef CONFIG_FB Why use CONFIG_FB here, as this is i915, should use CONFIG_DRM_I915_FBDEV right? > static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) > { > struct apertures_struct *ap; > @@ -1436,6 +1437,11 @@ static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) > > kfree(ap); > } > +#else > +static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) > +{ > +} > +#endif > Regards, Chon Ming ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] drm/i915: Kconfig option to disable the legacy fbdev support 2013-10-09 6:35 ` Lee, Chon Ming @ 2013-10-09 7:18 ` Daniel Vetter 2013-10-09 8:09 ` [Intel-gfx] " Chris Wilson ` (2 more replies) 0 siblings, 3 replies; 14+ messages in thread From: Daniel Vetter @ 2013-10-09 7:18 UTC (permalink / raw) To: DRI Development; +Cc: Daniel Vetter, Intel Graphics Development, David Herrmann Boots Just Fine (tm)! The only glitch seems to be that at least on Fedora the boot splash gets confused and doesn't display much at all. And since there's no ugly console flickering anymore in between, the flicker while switching between X servers (VT support is still enabled) is even more jarring. Also, I'm unsure whether we don't need to somehow kick out vgacon, now that nothing else gets in the way. But stuff seems to work, so I don't care. Also everything still works as well with VGA_CONSOLE=n Also the #ifdef mess needs a bit of a cleanup, follow-up patches will do just that. To keep the Kconfig tidy, extract all the i915 options into its own file. v2: - Rebase on top of the preliminary hw support option and the intel_drv.h cleanup. - Shut up warnings in i915_debugfs.c v3: Use the right CONFIG variable, spotted by Chon Ming. Cc: Lee, Chon Ming <chon.ming.lee@intel.com> Cc: David Herrmann <dh.herrmann@gmail.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/gpu/drm/Kconfig | 60 +------------------------------- drivers/gpu/drm/i915/Kconfig | 67 ++++++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/i915_debugfs.c | 9 ++--- drivers/gpu/drm/i915/i915_dma.c | 6 ++++ drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/intel_display.c | 10 ++++++ drivers/gpu/drm/i915/intel_drv.h | 36 +++++++++++++++---- 8 files changed, 122 insertions(+), 71 deletions(-) create mode 100644 drivers/gpu/drm/i915/Kconfig diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 3104b6d..b4e4fc0 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -128,65 +128,7 @@ config DRM_I810 selected, the module will be called i810. AGP support is required for this driver to work. -config DRM_I915 - tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics" - depends on DRM - depends on AGP - depends on AGP_INTEL - # we need shmfs for the swappable backing store, and in particular - # the shmem_readpage() which depends upon tmpfs - select SHMEM - select TMPFS - select DRM_KMS_HELPER - select DRM_KMS_FB_HELPER - select FB_CFB_FILLRECT - select FB_CFB_COPYAREA - select FB_CFB_IMAGEBLIT - # i915 depends on ACPI_VIDEO when ACPI is enabled - # but for select to work, need to select ACPI_VIDEO's dependencies, ick - select BACKLIGHT_LCD_SUPPORT if ACPI - select BACKLIGHT_CLASS_DEVICE if ACPI - select VIDEO_OUTPUT_CONTROL if ACPI - select INPUT if ACPI - select THERMAL if ACPI - select ACPI_VIDEO if ACPI - select ACPI_BUTTON if ACPI - help - Choose this option if you have a system that has "Intel Graphics - Media Accelerator" or "HD Graphics" integrated graphics, - including 830M, 845G, 852GM, 855GM, 865G, 915G, 945G, 965G, - G35, G41, G43, G45 chipsets and Celeron, Pentium, Core i3, - Core i5, Core i7 as well as Atom CPUs with integrated graphics. - If M is selected, the module will be called i915. AGP support - is required for this driver to work. This driver is used by - the Intel driver in X.org 6.8 and XFree86 4.4 and above. It - replaces the older i830 module that supported a subset of the - hardware in older X.org releases. - - Note that the older i810/i815 chipsets require the use of the - i810 driver instead, and the Atom z5xx series has an entirely - different implementation. - -config DRM_I915_KMS - bool "Enable modesetting on intel by default" - depends on DRM_I915 - help - Choose this option if you want kernel modesetting enabled by default, - and you have a new enough userspace to support this. Running old - userspaces with this enabled will cause pain. Note that this causes - the driver to bind to PCI devices, which precludes loading things - like intelfb. - -config DRM_I915_PRELIMINARY_HW_SUPPORT - bool "Enable preliminary support for prerelease Intel hardware by default" - depends on DRM_I915 - help - Choose this option if you have prerelease Intel hardware and want the - i915 driver to support it by default. You can enable such support at - runtime with the module option i915.preliminary_hw_support=1; this - option changes the default for that module option. - - If in doubt, say "N". +source "drivers/gpu/drm/i915/Kconfig" config DRM_MGA tristate "Matrox g200/g400" diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig new file mode 100644 index 0000000..6199d0b --- /dev/null +++ b/drivers/gpu/drm/i915/Kconfig @@ -0,0 +1,67 @@ +config DRM_I915 + tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics" + depends on DRM + depends on AGP + depends on AGP_INTEL + # we need shmfs for the swappable backing store, and in particular + # the shmem_readpage() which depends upon tmpfs + select SHMEM + select TMPFS + select DRM_KMS_HELPER + # i915 depends on ACPI_VIDEO when ACPI is enabled + # but for select to work, need to select ACPI_VIDEO's dependencies, ick + select BACKLIGHT_LCD_SUPPORT if ACPI + select BACKLIGHT_CLASS_DEVICE if ACPI + select VIDEO_OUTPUT_CONTROL if ACPI + select INPUT if ACPI + select ACPI_VIDEO if ACPI + select ACPI_BUTTON if ACPI + help + Choose this option if you have a system that has "Intel Graphics + Media Accelerator" or "HD Graphics" integrated graphics, + including 830M, 845G, 852GM, 855GM, 865G, 915G, 945G, 965G, + G35, G41, G43, G45 chipsets and Celeron, Pentium, Core i3, + Core i5, Core i7 as well as Atom CPUs with integrated graphics. + If M is selected, the module will be called i915. AGP support + is required for this driver to work. This driver is used by + the Intel driver in X.org 6.8 and XFree86 4.4 and above. It + replaces the older i830 module that supported a subset of the + hardware in older X.org releases. + + Note that the older i810/i815 chipsets require the use of the + i810 driver instead, and the Atom z5xx series has an entirely + different implementation. + +config DRM_I915_KMS + bool "Enable modesetting on intel by default" + depends on DRM_I915 + help + Choose this option if you want kernel modesetting enabled by default, + and you have a new enough userspace to support this. Running old + userspaces with this enabled will cause pain. Note that this causes + the driver to bind to PCI devices, which precludes loading things + like intelfb. + +config DRM_I915_FBDEV + bool "Enable legacy fbdev support for the modesettting intel driver" + depends on DRM_I915 + select DRM_KMS_FB_HELPER + select FB_CFB_FILLRECT + select FB_CFB_COPYAREA + select FB_CFB_IMAGEBLIT + default y + help + Choose this option if you have a need for the legacy fbdev + support. Note that this support also provide the linux console + support on top of the intel modesetting driver. + +config DRM_I915_PRELIMINARY_HW_SUPPORT + bool "Enable preliminary support for prerelease Intel hardware by default" + depends on DRM_I915 + help + Choose this option if you have prerelease Intel hardware and want the + i915 driver to support it by default. You can enable such support at + runtime with the module option i915.preliminary_hw_support=1; this + option changes the default for that module option. + + If in doubt, say "N". diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index 65e60d2..45e14a8 100644 --- a/drivers/gpu/drm/i915/Makefile +++ b/drivers/gpu/drm/i915/Makefile @@ -33,7 +33,6 @@ i915-y := i915_drv.o i915_dma.o i915_irq.o \ intel_panel.o \ intel_pm.o \ intel_i2c.o \ - intel_fb.o \ intel_tv.o \ intel_dvo.o \ intel_ringbuffer.o \ @@ -54,6 +53,8 @@ i915-$(CONFIG_COMPAT) += i915_ioc32.o i915-$(CONFIG_ACPI) += intel_acpi.o +i915-$(CONFIG_DRM_I915_FBDEV) += intel_fb.o + obj-$(CONFIG_DRM_I915) += i915.o CFLAGS_i915_trace_points.o := -I$(src) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 5fd6a5d..79bfbd5 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -1399,12 +1399,12 @@ static int i915_gem_framebuffer_info(struct seq_file *m, void *data) { struct drm_info_node *node = (struct drm_info_node *) m->private; struct drm_device *dev = node->minor->dev; - drm_i915_private_t *dev_priv = dev->dev_private; - struct intel_fbdev *ifbdev; + struct intel_fbdev *ifbdev = NULL; struct intel_framebuffer *fb; - int ret; - ret = mutex_lock_interruptible(&dev->mode_config.mutex); +#ifdef CONFIG_DRM_I915_FBDEV + struct drm_i915_private *dev_priv = dev->dev_private; + int ret = mutex_lock_interruptible(&dev->mode_config.mutex); if (ret) return ret; @@ -1420,6 +1420,7 @@ static int i915_gem_framebuffer_info(struct seq_file *m, void *data) describe_obj(m, fb->obj); seq_putc(m, '\n'); mutex_unlock(&dev->mode_config.mutex); +#endif mutex_lock(&dev->mode_config.fb_lock); list_for_each_entry(fb, &dev->mode_config.fb_list, base.head) { diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index f221631..90f1fb6 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c @@ -1416,6 +1416,7 @@ void i915_master_destroy(struct drm_device *dev, struct drm_master *master) master->driver_priv = NULL; } +#ifdef CONFIG_DRM_I915_FBDEV static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) { struct apertures_struct *ap; @@ -1436,6 +1437,11 @@ static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) kfree(ap); } +#else +static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) +{ +} +#endif static void i915_dump_device_info(struct drm_i915_private *dev_priv) { diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index ed8653f..99f621d 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -1354,8 +1354,10 @@ typedef struct drm_i915_private { struct drm_i915_gem_object *vlv_pctx; +#ifdef CONFIG_DRM_I915_FBDEV /* list of fbdev register on this device */ struct intel_fbdev *fbdev; +#endif /* * The console may be contended at resume, but we don't diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index ded0d45..43e4e75 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -7318,6 +7318,7 @@ static struct drm_framebuffer * mode_fits_in_fbdev(struct drm_device *dev, struct drm_display_mode *mode) { +#ifdef CONFIG_DRM_I915_FBDEV struct drm_i915_private *dev_priv = dev->dev_private; struct drm_i915_gem_object *obj; struct drm_framebuffer *fb; @@ -7338,6 +7339,9 @@ mode_fits_in_fbdev(struct drm_device *dev, return NULL; return fb; +#else + return NULL; +#endif } bool intel_get_load_detect_pipe(struct drm_connector *connector, @@ -10084,6 +10088,12 @@ intel_user_framebuffer_create(struct drm_device *dev, return intel_framebuffer_create(dev, mode_cmd, obj); } +#ifndef CONFIG_DRM_I915_FBDEV +static inline void intel_fb_output_poll_changed(struct drm_device *dev) +{ +} +#endif + static const struct drm_mode_config_funcs intel_mode_funcs = { .fb_create = intel_user_framebuffer_create, .output_poll_changed = intel_fb_output_poll_changed, diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index adfb57c..181d10b 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h @@ -716,14 +716,36 @@ bool intel_dsi_init(struct drm_device *dev); void intel_dvo_init(struct drm_device *dev); -/* intel_fb.c */ -int intel_fbdev_init(struct drm_device *dev); -void intel_fbdev_initial_config(struct drm_device *dev); -void intel_fbdev_fini(struct drm_device *dev); -void intel_fbdev_set_suspend(struct drm_device *dev, int state); -void intel_fb_output_poll_changed(struct drm_device *dev); -void intel_fb_restore_mode(struct drm_device *dev); +/* legacy fbdev emulation in intel_fb.c */ +#ifdef CONFIG_DRM_I915_FBDEV +extern int intel_fbdev_init(struct drm_device *dev); +extern void intel_fbdev_initial_config(struct drm_device *dev); +extern void intel_fbdev_fini(struct drm_device *dev); +extern void intel_fbdev_set_suspend(struct drm_device *dev, int state); +extern void intel_fb_output_poll_changed(struct drm_device *dev); +extern void intel_fb_restore_mode(struct drm_device *dev); +#else +static inline int intel_fbdev_init(struct drm_device *dev) +{ + return 0; +} +static inline void intel_fbdev_initial_config(struct drm_device *dev) +{ +} + +static inline void intel_fbdev_fini(struct drm_device *dev) +{ +} + +static inline void intel_fbdev_set_suspend(struct drm_device *dev, int state) +{ +} + +static inline void intel_fb_restore_mode(struct drm_device *dev) +{ +} +#endif /* intel_hdmi.c */ void intel_hdmi_init(struct drm_device *dev, int hdmi_reg, enum port port); -- 1.8.1.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Kconfig option to disable the legacy fbdev support 2013-10-09 7:18 ` [PATCH] " Daniel Vetter @ 2013-10-09 8:09 ` Chris Wilson 2013-10-09 8:33 ` Daniel Vetter 2013-10-09 9:33 ` [Intel-gfx] " Jani Nikula 2013-10-11 5:53 ` Lee, Chon Ming 2 siblings, 1 reply; 14+ messages in thread From: Chris Wilson @ 2013-10-09 8:09 UTC (permalink / raw) To: Daniel Vetter; +Cc: Intel Graphics Development, DRI Development On Wed, Oct 09, 2013 at 09:18:51AM +0200, Daniel Vetter wrote: > mode_fits_in_fbdev(struct drm_device *dev, > struct drm_display_mode *mode) > { > +#ifdef CONFIG_DRM_I915_FBDEV > struct drm_i915_private *dev_priv = dev->dev_private; > struct drm_i915_gem_object *obj; > struct drm_framebuffer *fb; > @@ -7338,6 +7339,9 @@ mode_fits_in_fbdev(struct drm_device *dev, > return NULL; > > return fb; > +#else > + return NULL; > +#endif This for example is not fbdev specific. There used to be code, extracted from this function, to sanity check that the mode fitted in the fb provided by the user and by the bios. Which caught a few problems in the past. -Chris -- Chris Wilson, Intel Open Source Technology Centre ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/i915: Kconfig option to disable the legacy fbdev support 2013-10-09 8:09 ` [Intel-gfx] " Chris Wilson @ 2013-10-09 8:33 ` Daniel Vetter 0 siblings, 0 replies; 14+ messages in thread From: Daniel Vetter @ 2013-10-09 8:33 UTC (permalink / raw) To: Chris Wilson, Daniel Vetter, DRI Development, Intel Graphics Development, David Herrmann On Wed, Oct 09, 2013 at 09:09:36AM +0100, Chris Wilson wrote: > On Wed, Oct 09, 2013 at 09:18:51AM +0200, Daniel Vetter wrote: > > mode_fits_in_fbdev(struct drm_device *dev, > > struct drm_display_mode *mode) > > { > > +#ifdef CONFIG_DRM_I915_FBDEV > > struct drm_i915_private *dev_priv = dev->dev_private; > > struct drm_i915_gem_object *obj; > > struct drm_framebuffer *fb; > > @@ -7338,6 +7339,9 @@ mode_fits_in_fbdev(struct drm_device *dev, > > return NULL; > > > > return fb; > > +#else > > + return NULL; > > +#endif > > This for example is not fbdev specific. There used to be code, extracted > from this function, to sanity check that the mode fitted in the fb > provided by the user and by the bios. Which caught a few problems in the > past. Hm, I think we should check the size of the underlying gem bo against the fb we create. Then core drm should take care of all constraint checking. But the size check in intel_framebuffer_init seems to indeed be missing. I'll add something and submit a patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Kconfig option to disable the legacy fbdev support 2013-10-09 7:18 ` [PATCH] " Daniel Vetter 2013-10-09 8:09 ` [Intel-gfx] " Chris Wilson @ 2013-10-09 9:33 ` Jani Nikula 2013-10-11 5:53 ` Lee, Chon Ming 2 siblings, 0 replies; 14+ messages in thread From: Jani Nikula @ 2013-10-09 9:33 UTC (permalink / raw) To: DRI Development; +Cc: Daniel Vetter, Intel Graphics Development On Wed, 09 Oct 2013, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > Boots Just Fine (tm)! > > The only glitch seems to be that at least on Fedora the boot splash > gets confused and doesn't display much at all. > > And since there's no ugly console flickering anymore in between, the > flicker while switching between X servers (VT support is still enabled) > is even more jarring. > > Also, I'm unsure whether we don't need to somehow kick out vgacon, now > that nothing else gets in the way. But stuff seems to work, so I > don't care. Also everything still works as well with VGA_CONSOLE=n > > Also the #ifdef mess needs a bit of a cleanup, follow-up patches will > do just that. > > To keep the Kconfig tidy, extract all the i915 options into its own > file. Obligatory bikeshed: I'd really like the Kconfig move to be a separate prep patch. BR, Jani. > > v2: > - Rebase on top of the preliminary hw support option and the > intel_drv.h cleanup. > - Shut up warnings in i915_debugfs.c > > v3: Use the right CONFIG variable, spotted by Chon Ming. > > Cc: Lee, Chon Ming <chon.ming.lee@intel.com> > Cc: David Herrmann <dh.herrmann@gmail.com> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/Kconfig | 60 +------------------------------- > drivers/gpu/drm/i915/Kconfig | 67 ++++++++++++++++++++++++++++++++++++ > drivers/gpu/drm/i915/Makefile | 3 +- > drivers/gpu/drm/i915/i915_debugfs.c | 9 ++--- > drivers/gpu/drm/i915/i915_dma.c | 6 ++++ > drivers/gpu/drm/i915/i915_drv.h | 2 ++ > drivers/gpu/drm/i915/intel_display.c | 10 ++++++ > drivers/gpu/drm/i915/intel_drv.h | 36 +++++++++++++++---- > 8 files changed, 122 insertions(+), 71 deletions(-) > create mode 100644 drivers/gpu/drm/i915/Kconfig > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 3104b6d..b4e4fc0 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -128,65 +128,7 @@ config DRM_I810 > selected, the module will be called i810. AGP support is required > for this driver to work. > > -config DRM_I915 > - tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics" > - depends on DRM > - depends on AGP > - depends on AGP_INTEL > - # we need shmfs for the swappable backing store, and in particular > - # the shmem_readpage() which depends upon tmpfs > - select SHMEM > - select TMPFS > - select DRM_KMS_HELPER > - select DRM_KMS_FB_HELPER > - select FB_CFB_FILLRECT > - select FB_CFB_COPYAREA > - select FB_CFB_IMAGEBLIT > - # i915 depends on ACPI_VIDEO when ACPI is enabled > - # but for select to work, need to select ACPI_VIDEO's dependencies, ick > - select BACKLIGHT_LCD_SUPPORT if ACPI > - select BACKLIGHT_CLASS_DEVICE if ACPI > - select VIDEO_OUTPUT_CONTROL if ACPI > - select INPUT if ACPI > - select THERMAL if ACPI > - select ACPI_VIDEO if ACPI > - select ACPI_BUTTON if ACPI > - help > - Choose this option if you have a system that has "Intel Graphics > - Media Accelerator" or "HD Graphics" integrated graphics, > - including 830M, 845G, 852GM, 855GM, 865G, 915G, 945G, 965G, > - G35, G41, G43, G45 chipsets and Celeron, Pentium, Core i3, > - Core i5, Core i7 as well as Atom CPUs with integrated graphics. > - If M is selected, the module will be called i915. AGP support > - is required for this driver to work. This driver is used by > - the Intel driver in X.org 6.8 and XFree86 4.4 and above. It > - replaces the older i830 module that supported a subset of the > - hardware in older X.org releases. > - > - Note that the older i810/i815 chipsets require the use of the > - i810 driver instead, and the Atom z5xx series has an entirely > - different implementation. > - > -config DRM_I915_KMS > - bool "Enable modesetting on intel by default" > - depends on DRM_I915 > - help > - Choose this option if you want kernel modesetting enabled by default, > - and you have a new enough userspace to support this. Running old > - userspaces with this enabled will cause pain. Note that this causes > - the driver to bind to PCI devices, which precludes loading things > - like intelfb. > - > -config DRM_I915_PRELIMINARY_HW_SUPPORT > - bool "Enable preliminary support for prerelease Intel hardware by default" > - depends on DRM_I915 > - help > - Choose this option if you have prerelease Intel hardware and want the > - i915 driver to support it by default. You can enable such support at > - runtime with the module option i915.preliminary_hw_support=1; this > - option changes the default for that module option. > - > - If in doubt, say "N". > +source "drivers/gpu/drm/i915/Kconfig" > > config DRM_MGA > tristate "Matrox g200/g400" > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig > new file mode 100644 > index 0000000..6199d0b > --- /dev/null > +++ b/drivers/gpu/drm/i915/Kconfig > @@ -0,0 +1,67 @@ > +config DRM_I915 > + tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics" > + depends on DRM > + depends on AGP > + depends on AGP_INTEL > + # we need shmfs for the swappable backing store, and in particular > + # the shmem_readpage() which depends upon tmpfs > + select SHMEM > + select TMPFS > + select DRM_KMS_HELPER > + # i915 depends on ACPI_VIDEO when ACPI is enabled > + # but for select to work, need to select ACPI_VIDEO's dependencies, ick > + select BACKLIGHT_LCD_SUPPORT if ACPI > + select BACKLIGHT_CLASS_DEVICE if ACPI > + select VIDEO_OUTPUT_CONTROL if ACPI > + select INPUT if ACPI > + select ACPI_VIDEO if ACPI > + select ACPI_BUTTON if ACPI > + help > + Choose this option if you have a system that has "Intel Graphics > + Media Accelerator" or "HD Graphics" integrated graphics, > + including 830M, 845G, 852GM, 855GM, 865G, 915G, 945G, 965G, > + G35, G41, G43, G45 chipsets and Celeron, Pentium, Core i3, > + Core i5, Core i7 as well as Atom CPUs with integrated graphics. > + If M is selected, the module will be called i915. AGP support > + is required for this driver to work. This driver is used by > + the Intel driver in X.org 6.8 and XFree86 4.4 and above. It > + replaces the older i830 module that supported a subset of the > + hardware in older X.org releases. > + > + Note that the older i810/i815 chipsets require the use of the > + i810 driver instead, and the Atom z5xx series has an entirely > + different implementation. > + > +config DRM_I915_KMS > + bool "Enable modesetting on intel by default" > + depends on DRM_I915 > + help > + Choose this option if you want kernel modesetting enabled by default, > + and you have a new enough userspace to support this. Running old > + userspaces with this enabled will cause pain. Note that this causes > + the driver to bind to PCI devices, which precludes loading things > + like intelfb. > + > +config DRM_I915_FBDEV > + bool "Enable legacy fbdev support for the modesettting intel driver" > + depends on DRM_I915 > + select DRM_KMS_FB_HELPER > + select FB_CFB_FILLRECT > + select FB_CFB_COPYAREA > + select FB_CFB_IMAGEBLIT > + default y > + help > + Choose this option if you have a need for the legacy fbdev > + support. Note that this support also provide the linux console > + support on top of the intel modesetting driver. > + > +config DRM_I915_PRELIMINARY_HW_SUPPORT > + bool "Enable preliminary support for prerelease Intel hardware by default" > + depends on DRM_I915 > + help > + Choose this option if you have prerelease Intel hardware and want the > + i915 driver to support it by default. You can enable such support at > + runtime with the module option i915.preliminary_hw_support=1; this > + option changes the default for that module option. > + > + If in doubt, say "N". > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > index 65e60d2..45e14a8 100644 > --- a/drivers/gpu/drm/i915/Makefile > +++ b/drivers/gpu/drm/i915/Makefile > @@ -33,7 +33,6 @@ i915-y := i915_drv.o i915_dma.o i915_irq.o \ > intel_panel.o \ > intel_pm.o \ > intel_i2c.o \ > - intel_fb.o \ > intel_tv.o \ > intel_dvo.o \ > intel_ringbuffer.o \ > @@ -54,6 +53,8 @@ i915-$(CONFIG_COMPAT) += i915_ioc32.o > > i915-$(CONFIG_ACPI) += intel_acpi.o > > +i915-$(CONFIG_DRM_I915_FBDEV) += intel_fb.o > + > obj-$(CONFIG_DRM_I915) += i915.o > > CFLAGS_i915_trace_points.o := -I$(src) > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index 5fd6a5d..79bfbd5 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -1399,12 +1399,12 @@ static int i915_gem_framebuffer_info(struct seq_file *m, void *data) > { > struct drm_info_node *node = (struct drm_info_node *) m->private; > struct drm_device *dev = node->minor->dev; > - drm_i915_private_t *dev_priv = dev->dev_private; > - struct intel_fbdev *ifbdev; > + struct intel_fbdev *ifbdev = NULL; > struct intel_framebuffer *fb; > - int ret; > > - ret = mutex_lock_interruptible(&dev->mode_config.mutex); > +#ifdef CONFIG_DRM_I915_FBDEV > + struct drm_i915_private *dev_priv = dev->dev_private; > + int ret = mutex_lock_interruptible(&dev->mode_config.mutex); > if (ret) > return ret; > > @@ -1420,6 +1420,7 @@ static int i915_gem_framebuffer_info(struct seq_file *m, void *data) > describe_obj(m, fb->obj); > seq_putc(m, '\n'); > mutex_unlock(&dev->mode_config.mutex); > +#endif > > mutex_lock(&dev->mode_config.fb_lock); > list_for_each_entry(fb, &dev->mode_config.fb_list, base.head) { > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c > index f221631..90f1fb6 100644 > --- a/drivers/gpu/drm/i915/i915_dma.c > +++ b/drivers/gpu/drm/i915/i915_dma.c > @@ -1416,6 +1416,7 @@ void i915_master_destroy(struct drm_device *dev, struct drm_master *master) > master->driver_priv = NULL; > } > > +#ifdef CONFIG_DRM_I915_FBDEV > static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) > { > struct apertures_struct *ap; > @@ -1436,6 +1437,11 @@ static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) > > kfree(ap); > } > +#else > +static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) > +{ > +} > +#endif > > static void i915_dump_device_info(struct drm_i915_private *dev_priv) > { > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index ed8653f..99f621d 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -1354,8 +1354,10 @@ typedef struct drm_i915_private { > > struct drm_i915_gem_object *vlv_pctx; > > +#ifdef CONFIG_DRM_I915_FBDEV > /* list of fbdev register on this device */ > struct intel_fbdev *fbdev; > +#endif > > /* > * The console may be contended at resume, but we don't > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index ded0d45..43e4e75 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -7318,6 +7318,7 @@ static struct drm_framebuffer * > mode_fits_in_fbdev(struct drm_device *dev, > struct drm_display_mode *mode) > { > +#ifdef CONFIG_DRM_I915_FBDEV > struct drm_i915_private *dev_priv = dev->dev_private; > struct drm_i915_gem_object *obj; > struct drm_framebuffer *fb; > @@ -7338,6 +7339,9 @@ mode_fits_in_fbdev(struct drm_device *dev, > return NULL; > > return fb; > +#else > + return NULL; > +#endif > } > > bool intel_get_load_detect_pipe(struct drm_connector *connector, > @@ -10084,6 +10088,12 @@ intel_user_framebuffer_create(struct drm_device *dev, > return intel_framebuffer_create(dev, mode_cmd, obj); > } > > +#ifndef CONFIG_DRM_I915_FBDEV > +static inline void intel_fb_output_poll_changed(struct drm_device *dev) > +{ > +} > +#endif > + > static const struct drm_mode_config_funcs intel_mode_funcs = { > .fb_create = intel_user_framebuffer_create, > .output_poll_changed = intel_fb_output_poll_changed, > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h > index adfb57c..181d10b 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -716,14 +716,36 @@ bool intel_dsi_init(struct drm_device *dev); > void intel_dvo_init(struct drm_device *dev); > > > -/* intel_fb.c */ > -int intel_fbdev_init(struct drm_device *dev); > -void intel_fbdev_initial_config(struct drm_device *dev); > -void intel_fbdev_fini(struct drm_device *dev); > -void intel_fbdev_set_suspend(struct drm_device *dev, int state); > -void intel_fb_output_poll_changed(struct drm_device *dev); > -void intel_fb_restore_mode(struct drm_device *dev); > +/* legacy fbdev emulation in intel_fb.c */ > +#ifdef CONFIG_DRM_I915_FBDEV > +extern int intel_fbdev_init(struct drm_device *dev); > +extern void intel_fbdev_initial_config(struct drm_device *dev); > +extern void intel_fbdev_fini(struct drm_device *dev); > +extern void intel_fbdev_set_suspend(struct drm_device *dev, int state); > +extern void intel_fb_output_poll_changed(struct drm_device *dev); > +extern void intel_fb_restore_mode(struct drm_device *dev); > +#else > +static inline int intel_fbdev_init(struct drm_device *dev) > +{ > + return 0; > +} > > +static inline void intel_fbdev_initial_config(struct drm_device *dev) > +{ > +} > + > +static inline void intel_fbdev_fini(struct drm_device *dev) > +{ > +} > + > +static inline void intel_fbdev_set_suspend(struct drm_device *dev, int state) > +{ > +} > + > +static inline void intel_fb_restore_mode(struct drm_device *dev) > +{ > +} > +#endif > > /* intel_hdmi.c */ > void intel_hdmi_init(struct drm_device *dev, int hdmi_reg, enum port port); > -- > 1.8.1.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/i915: Kconfig option to disable the legacy fbdev support 2013-10-09 7:18 ` [PATCH] " Daniel Vetter 2013-10-09 8:09 ` [Intel-gfx] " Chris Wilson 2013-10-09 9:33 ` [Intel-gfx] " Jani Nikula @ 2013-10-11 5:53 ` Lee, Chon Ming 2013-10-11 21:37 ` Daniel Vetter 2 siblings, 1 reply; 14+ messages in thread From: Lee, Chon Ming @ 2013-10-11 5:53 UTC (permalink / raw) To: Daniel Vetter; +Cc: Intel Graphics Development, DRI Development, David Herrmann On 10/09 09:18, Daniel Vetter wrote: > Boots Just Fine (tm)! > > The only glitch seems to be that at least on Fedora the boot splash > gets confused and doesn't display much at all. > > And since there's no ugly console flickering anymore in between, the > flicker while switching between X servers (VT support is still enabled) > is even more jarring. > > Also, I'm unsure whether we don't need to somehow kick out vgacon, now > that nothing else gets in the way. But stuff seems to work, so I > don't care. Also everything still works as well with VGA_CONSOLE=n > > Also the #ifdef mess needs a bit of a cleanup, follow-up patches will > do just that. > > To keep the Kconfig tidy, extract all the i915 options into its own > file. > > v2: > - Rebase on top of the preliminary hw support option and the > intel_drv.h cleanup. > - Shut up warnings in i915_debugfs.c > > v3: Use the right CONFIG variable, spotted by Chon Ming. > > Cc: Lee, Chon Ming <chon.ming.lee@intel.com> > Cc: David Herrmann <dh.herrmann@gmail.com> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- Look good to me this series. Reviewed-by: Chon Ming Lee <chon.ming.lee@intel.com> > drivers/gpu/drm/Kconfig | 60 +------------------------------- > drivers/gpu/drm/i915/Kconfig | 67 ++++++++++++++++++++++++++++++++++++ > drivers/gpu/drm/i915/Makefile | 3 +- > drivers/gpu/drm/i915/i915_debugfs.c | 9 ++--- > drivers/gpu/drm/i915/i915_dma.c | 6 ++++ > drivers/gpu/drm/i915/i915_drv.h | 2 ++ > drivers/gpu/drm/i915/intel_display.c | 10 ++++++ > drivers/gpu/drm/i915/intel_drv.h | 36 +++++++++++++++---- > 8 files changed, 122 insertions(+), 71 deletions(-) > create mode 100644 drivers/gpu/drm/i915/Kconfig > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 3104b6d..b4e4fc0 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -128,65 +128,7 @@ config DRM_I810 > selected, the module will be called i810. AGP support is required > for this driver to work. > > -config DRM_I915 > - tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics" > - depends on DRM > - depends on AGP > - depends on AGP_INTEL > - # we need shmfs for the swappable backing store, and in particular > - # the shmem_readpage() which depends upon tmpfs > - select SHMEM > - select TMPFS > - select DRM_KMS_HELPER > - select DRM_KMS_FB_HELPER > - select FB_CFB_FILLRECT > - select FB_CFB_COPYAREA > - select FB_CFB_IMAGEBLIT > - # i915 depends on ACPI_VIDEO when ACPI is enabled > - # but for select to work, need to select ACPI_VIDEO's dependencies, ick > - select BACKLIGHT_LCD_SUPPORT if ACPI > - select BACKLIGHT_CLASS_DEVICE if ACPI > - select VIDEO_OUTPUT_CONTROL if ACPI > - select INPUT if ACPI > - select THERMAL if ACPI > - select ACPI_VIDEO if ACPI > - select ACPI_BUTTON if ACPI > - help > - Choose this option if you have a system that has "Intel Graphics > - Media Accelerator" or "HD Graphics" integrated graphics, > - including 830M, 845G, 852GM, 855GM, 865G, 915G, 945G, 965G, > - G35, G41, G43, G45 chipsets and Celeron, Pentium, Core i3, > - Core i5, Core i7 as well as Atom CPUs with integrated graphics. > - If M is selected, the module will be called i915. AGP support > - is required for this driver to work. This driver is used by > - the Intel driver in X.org 6.8 and XFree86 4.4 and above. It > - replaces the older i830 module that supported a subset of the > - hardware in older X.org releases. > - > - Note that the older i810/i815 chipsets require the use of the > - i810 driver instead, and the Atom z5xx series has an entirely > - different implementation. > - > -config DRM_I915_KMS > - bool "Enable modesetting on intel by default" > - depends on DRM_I915 > - help > - Choose this option if you want kernel modesetting enabled by default, > - and you have a new enough userspace to support this. Running old > - userspaces with this enabled will cause pain. Note that this causes > - the driver to bind to PCI devices, which precludes loading things > - like intelfb. > - > -config DRM_I915_PRELIMINARY_HW_SUPPORT > - bool "Enable preliminary support for prerelease Intel hardware by default" > - depends on DRM_I915 > - help > - Choose this option if you have prerelease Intel hardware and want the > - i915 driver to support it by default. You can enable such support at > - runtime with the module option i915.preliminary_hw_support=1; this > - option changes the default for that module option. > - > - If in doubt, say "N". > +source "drivers/gpu/drm/i915/Kconfig" > > config DRM_MGA > tristate "Matrox g200/g400" > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig > new file mode 100644 > index 0000000..6199d0b > --- /dev/null > +++ b/drivers/gpu/drm/i915/Kconfig > @@ -0,0 +1,67 @@ > +config DRM_I915 > + tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics" > + depends on DRM > + depends on AGP > + depends on AGP_INTEL > + # we need shmfs for the swappable backing store, and in particular > + # the shmem_readpage() which depends upon tmpfs > + select SHMEM > + select TMPFS > + select DRM_KMS_HELPER > + # i915 depends on ACPI_VIDEO when ACPI is enabled > + # but for select to work, need to select ACPI_VIDEO's dependencies, ick > + select BACKLIGHT_LCD_SUPPORT if ACPI > + select BACKLIGHT_CLASS_DEVICE if ACPI > + select VIDEO_OUTPUT_CONTROL if ACPI > + select INPUT if ACPI > + select ACPI_VIDEO if ACPI > + select ACPI_BUTTON if ACPI > + help > + Choose this option if you have a system that has "Intel Graphics > + Media Accelerator" or "HD Graphics" integrated graphics, > + including 830M, 845G, 852GM, 855GM, 865G, 915G, 945G, 965G, > + G35, G41, G43, G45 chipsets and Celeron, Pentium, Core i3, > + Core i5, Core i7 as well as Atom CPUs with integrated graphics. > + If M is selected, the module will be called i915. AGP support > + is required for this driver to work. This driver is used by > + the Intel driver in X.org 6.8 and XFree86 4.4 and above. It > + replaces the older i830 module that supported a subset of the > + hardware in older X.org releases. > + > + Note that the older i810/i815 chipsets require the use of the > + i810 driver instead, and the Atom z5xx series has an entirely > + different implementation. > + > +config DRM_I915_KMS > + bool "Enable modesetting on intel by default" > + depends on DRM_I915 > + help > + Choose this option if you want kernel modesetting enabled by default, > + and you have a new enough userspace to support this. Running old > + userspaces with this enabled will cause pain. Note that this causes > + the driver to bind to PCI devices, which precludes loading things > + like intelfb. > + > +config DRM_I915_FBDEV > + bool "Enable legacy fbdev support for the modesettting intel driver" > + depends on DRM_I915 > + select DRM_KMS_FB_HELPER > + select FB_CFB_FILLRECT > + select FB_CFB_COPYAREA > + select FB_CFB_IMAGEBLIT > + default y > + help > + Choose this option if you have a need for the legacy fbdev > + support. Note that this support also provide the linux console > + support on top of the intel modesetting driver. > + > +config DRM_I915_PRELIMINARY_HW_SUPPORT > + bool "Enable preliminary support for prerelease Intel hardware by default" > + depends on DRM_I915 > + help > + Choose this option if you have prerelease Intel hardware and want the > + i915 driver to support it by default. You can enable such support at > + runtime with the module option i915.preliminary_hw_support=1; this > + option changes the default for that module option. > + > + If in doubt, say "N". > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > index 65e60d2..45e14a8 100644 > --- a/drivers/gpu/drm/i915/Makefile > +++ b/drivers/gpu/drm/i915/Makefile > @@ -33,7 +33,6 @@ i915-y := i915_drv.o i915_dma.o i915_irq.o \ > intel_panel.o \ > intel_pm.o \ > intel_i2c.o \ > - intel_fb.o \ > intel_tv.o \ > intel_dvo.o \ > intel_ringbuffer.o \ > @@ -54,6 +53,8 @@ i915-$(CONFIG_COMPAT) += i915_ioc32.o > > i915-$(CONFIG_ACPI) += intel_acpi.o > > +i915-$(CONFIG_DRM_I915_FBDEV) += intel_fb.o > + > obj-$(CONFIG_DRM_I915) += i915.o > > CFLAGS_i915_trace_points.o := -I$(src) > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index 5fd6a5d..79bfbd5 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -1399,12 +1399,12 @@ static int i915_gem_framebuffer_info(struct seq_file *m, void *data) > { > struct drm_info_node *node = (struct drm_info_node *) m->private; > struct drm_device *dev = node->minor->dev; > - drm_i915_private_t *dev_priv = dev->dev_private; > - struct intel_fbdev *ifbdev; > + struct intel_fbdev *ifbdev = NULL; > struct intel_framebuffer *fb; > - int ret; > > - ret = mutex_lock_interruptible(&dev->mode_config.mutex); > +#ifdef CONFIG_DRM_I915_FBDEV > + struct drm_i915_private *dev_priv = dev->dev_private; > + int ret = mutex_lock_interruptible(&dev->mode_config.mutex); > if (ret) > return ret; > > @@ -1420,6 +1420,7 @@ static int i915_gem_framebuffer_info(struct seq_file *m, void *data) > describe_obj(m, fb->obj); > seq_putc(m, '\n'); > mutex_unlock(&dev->mode_config.mutex); > +#endif > > mutex_lock(&dev->mode_config.fb_lock); > list_for_each_entry(fb, &dev->mode_config.fb_list, base.head) { > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c > index f221631..90f1fb6 100644 > --- a/drivers/gpu/drm/i915/i915_dma.c > +++ b/drivers/gpu/drm/i915/i915_dma.c > @@ -1416,6 +1416,7 @@ void i915_master_destroy(struct drm_device *dev, struct drm_master *master) > master->driver_priv = NULL; > } > > +#ifdef CONFIG_DRM_I915_FBDEV > static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) > { > struct apertures_struct *ap; > @@ -1436,6 +1437,11 @@ static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) > > kfree(ap); > } > +#else > +static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) > +{ > +} > +#endif > > static void i915_dump_device_info(struct drm_i915_private *dev_priv) > { > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index ed8653f..99f621d 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -1354,8 +1354,10 @@ typedef struct drm_i915_private { > > struct drm_i915_gem_object *vlv_pctx; > > +#ifdef CONFIG_DRM_I915_FBDEV > /* list of fbdev register on this device */ > struct intel_fbdev *fbdev; > +#endif > > /* > * The console may be contended at resume, but we don't > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index ded0d45..43e4e75 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -7318,6 +7318,7 @@ static struct drm_framebuffer * > mode_fits_in_fbdev(struct drm_device *dev, > struct drm_display_mode *mode) > { > +#ifdef CONFIG_DRM_I915_FBDEV > struct drm_i915_private *dev_priv = dev->dev_private; > struct drm_i915_gem_object *obj; > struct drm_framebuffer *fb; > @@ -7338,6 +7339,9 @@ mode_fits_in_fbdev(struct drm_device *dev, > return NULL; > > return fb; > +#else > + return NULL; > +#endif > } > > bool intel_get_load_detect_pipe(struct drm_connector *connector, > @@ -10084,6 +10088,12 @@ intel_user_framebuffer_create(struct drm_device *dev, > return intel_framebuffer_create(dev, mode_cmd, obj); > } > > +#ifndef CONFIG_DRM_I915_FBDEV > +static inline void intel_fb_output_poll_changed(struct drm_device *dev) > +{ > +} > +#endif > + > static const struct drm_mode_config_funcs intel_mode_funcs = { > .fb_create = intel_user_framebuffer_create, > .output_poll_changed = intel_fb_output_poll_changed, > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h > index adfb57c..181d10b 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -716,14 +716,36 @@ bool intel_dsi_init(struct drm_device *dev); > void intel_dvo_init(struct drm_device *dev); > > > -/* intel_fb.c */ > -int intel_fbdev_init(struct drm_device *dev); > -void intel_fbdev_initial_config(struct drm_device *dev); > -void intel_fbdev_fini(struct drm_device *dev); > -void intel_fbdev_set_suspend(struct drm_device *dev, int state); > -void intel_fb_output_poll_changed(struct drm_device *dev); > -void intel_fb_restore_mode(struct drm_device *dev); > +/* legacy fbdev emulation in intel_fb.c */ > +#ifdef CONFIG_DRM_I915_FBDEV > +extern int intel_fbdev_init(struct drm_device *dev); > +extern void intel_fbdev_initial_config(struct drm_device *dev); > +extern void intel_fbdev_fini(struct drm_device *dev); > +extern void intel_fbdev_set_suspend(struct drm_device *dev, int state); > +extern void intel_fb_output_poll_changed(struct drm_device *dev); > +extern void intel_fb_restore_mode(struct drm_device *dev); > +#else > +static inline int intel_fbdev_init(struct drm_device *dev) > +{ > + return 0; > +} > > +static inline void intel_fbdev_initial_config(struct drm_device *dev) > +{ > +} > + > +static inline void intel_fbdev_fini(struct drm_device *dev) > +{ > +} > + > +static inline void intel_fbdev_set_suspend(struct drm_device *dev, int state) > +{ > +} > + > +static inline void intel_fb_restore_mode(struct drm_device *dev) > +{ > +} > +#endif > > /* intel_hdmi.c */ > void intel_hdmi_init(struct drm_device *dev, int hdmi_reg, enum port port); > -- > 1.8.1.4 > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/i915: Kconfig option to disable the legacy fbdev support 2013-10-11 5:53 ` Lee, Chon Ming @ 2013-10-11 21:37 ` Daniel Vetter 0 siblings, 0 replies; 14+ messages in thread From: Daniel Vetter @ 2013-10-11 21:37 UTC (permalink / raw) To: Lee, Chon Ming; +Cc: Daniel Vetter, Intel Graphics Development, DRI Development On Fri, Oct 11, 2013 at 01:53:36PM +0800, Lee, Chon Ming wrote: > On 10/09 09:18, Daniel Vetter wrote: > > Boots Just Fine (tm)! > > > > The only glitch seems to be that at least on Fedora the boot splash > > gets confused and doesn't display much at all. > > > > And since there's no ugly console flickering anymore in between, the > > flicker while switching between X servers (VT support is still enabled) > > is even more jarring. > > > > Also, I'm unsure whether we don't need to somehow kick out vgacon, now > > that nothing else gets in the way. But stuff seems to work, so I > > don't care. Also everything still works as well with VGA_CONSOLE=n > > > > Also the #ifdef mess needs a bit of a cleanup, follow-up patches will > > do just that. > > > > To keep the Kconfig tidy, extract all the i915 options into its own > > file. > > > > v2: > > - Rebase on top of the preliminary hw support option and the > > intel_drv.h cleanup. > > - Shut up warnings in i915_debugfs.c > > > > v3: Use the right CONFIG variable, spotted by Chon Ming. > > > > Cc: Lee, Chon Ming <chon.ming.lee@intel.com> > > Cc: David Herrmann <dh.herrmann@gmail.com> > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > --- > > Look good to me this series. > > Reviewed-by: Chon Ming Lee <chon.ming.lee@intel.com> Thanks for the review, all patches merged to dinq. -Daniel > > > drivers/gpu/drm/Kconfig | 60 +------------------------------- > > drivers/gpu/drm/i915/Kconfig | 67 ++++++++++++++++++++++++++++++++++++ > > drivers/gpu/drm/i915/Makefile | 3 +- > > drivers/gpu/drm/i915/i915_debugfs.c | 9 ++--- > > drivers/gpu/drm/i915/i915_dma.c | 6 ++++ > > drivers/gpu/drm/i915/i915_drv.h | 2 ++ > > drivers/gpu/drm/i915/intel_display.c | 10 ++++++ > > drivers/gpu/drm/i915/intel_drv.h | 36 +++++++++++++++---- > > 8 files changed, 122 insertions(+), 71 deletions(-) > > create mode 100644 drivers/gpu/drm/i915/Kconfig > > > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > > index 3104b6d..b4e4fc0 100644 > > --- a/drivers/gpu/drm/Kconfig > > +++ b/drivers/gpu/drm/Kconfig > > @@ -128,65 +128,7 @@ config DRM_I810 > > selected, the module will be called i810. AGP support is required > > for this driver to work. > > > > -config DRM_I915 > > - tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics" > > - depends on DRM > > - depends on AGP > > - depends on AGP_INTEL > > - # we need shmfs for the swappable backing store, and in particular > > - # the shmem_readpage() which depends upon tmpfs > > - select SHMEM > > - select TMPFS > > - select DRM_KMS_HELPER > > - select DRM_KMS_FB_HELPER > > - select FB_CFB_FILLRECT > > - select FB_CFB_COPYAREA > > - select FB_CFB_IMAGEBLIT > > - # i915 depends on ACPI_VIDEO when ACPI is enabled > > - # but for select to work, need to select ACPI_VIDEO's dependencies, ick > > - select BACKLIGHT_LCD_SUPPORT if ACPI > > - select BACKLIGHT_CLASS_DEVICE if ACPI > > - select VIDEO_OUTPUT_CONTROL if ACPI > > - select INPUT if ACPI > > - select THERMAL if ACPI > > - select ACPI_VIDEO if ACPI > > - select ACPI_BUTTON if ACPI > > - help > > - Choose this option if you have a system that has "Intel Graphics > > - Media Accelerator" or "HD Graphics" integrated graphics, > > - including 830M, 845G, 852GM, 855GM, 865G, 915G, 945G, 965G, > > - G35, G41, G43, G45 chipsets and Celeron, Pentium, Core i3, > > - Core i5, Core i7 as well as Atom CPUs with integrated graphics. > > - If M is selected, the module will be called i915. AGP support > > - is required for this driver to work. This driver is used by > > - the Intel driver in X.org 6.8 and XFree86 4.4 and above. It > > - replaces the older i830 module that supported a subset of the > > - hardware in older X.org releases. > > - > > - Note that the older i810/i815 chipsets require the use of the > > - i810 driver instead, and the Atom z5xx series has an entirely > > - different implementation. > > - > > -config DRM_I915_KMS > > - bool "Enable modesetting on intel by default" > > - depends on DRM_I915 > > - help > > - Choose this option if you want kernel modesetting enabled by default, > > - and you have a new enough userspace to support this. Running old > > - userspaces with this enabled will cause pain. Note that this causes > > - the driver to bind to PCI devices, which precludes loading things > > - like intelfb. > > - > > -config DRM_I915_PRELIMINARY_HW_SUPPORT > > - bool "Enable preliminary support for prerelease Intel hardware by default" > > - depends on DRM_I915 > > - help > > - Choose this option if you have prerelease Intel hardware and want the > > - i915 driver to support it by default. You can enable such support at > > - runtime with the module option i915.preliminary_hw_support=1; this > > - option changes the default for that module option. > > - > > - If in doubt, say "N". > > +source "drivers/gpu/drm/i915/Kconfig" > > > > config DRM_MGA > > tristate "Matrox g200/g400" > > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig > > new file mode 100644 > > index 0000000..6199d0b > > --- /dev/null > > +++ b/drivers/gpu/drm/i915/Kconfig > > @@ -0,0 +1,67 @@ > > +config DRM_I915 > > + tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics" > > + depends on DRM > > + depends on AGP > > + depends on AGP_INTEL > > + # we need shmfs for the swappable backing store, and in particular > > + # the shmem_readpage() which depends upon tmpfs > > + select SHMEM > > + select TMPFS > > + select DRM_KMS_HELPER > > + # i915 depends on ACPI_VIDEO when ACPI is enabled > > + # but for select to work, need to select ACPI_VIDEO's dependencies, ick > > + select BACKLIGHT_LCD_SUPPORT if ACPI > > + select BACKLIGHT_CLASS_DEVICE if ACPI > > + select VIDEO_OUTPUT_CONTROL if ACPI > > + select INPUT if ACPI > > + select ACPI_VIDEO if ACPI > > + select ACPI_BUTTON if ACPI > > + help > > + Choose this option if you have a system that has "Intel Graphics > > + Media Accelerator" or "HD Graphics" integrated graphics, > > + including 830M, 845G, 852GM, 855GM, 865G, 915G, 945G, 965G, > > + G35, G41, G43, G45 chipsets and Celeron, Pentium, Core i3, > > + Core i5, Core i7 as well as Atom CPUs with integrated graphics. > > + If M is selected, the module will be called i915. AGP support > > + is required for this driver to work. This driver is used by > > + the Intel driver in X.org 6.8 and XFree86 4.4 and above. It > > + replaces the older i830 module that supported a subset of the > > + hardware in older X.org releases. > > + > > + Note that the older i810/i815 chipsets require the use of the > > + i810 driver instead, and the Atom z5xx series has an entirely > > + different implementation. > > + > > +config DRM_I915_KMS > > + bool "Enable modesetting on intel by default" > > + depends on DRM_I915 > > + help > > + Choose this option if you want kernel modesetting enabled by default, > > + and you have a new enough userspace to support this. Running old > > + userspaces with this enabled will cause pain. Note that this causes > > + the driver to bind to PCI devices, which precludes loading things > > + like intelfb. > > + > > +config DRM_I915_FBDEV > > + bool "Enable legacy fbdev support for the modesettting intel driver" > > + depends on DRM_I915 > > + select DRM_KMS_FB_HELPER > > + select FB_CFB_FILLRECT > > + select FB_CFB_COPYAREA > > + select FB_CFB_IMAGEBLIT > > + default y > > + help > > + Choose this option if you have a need for the legacy fbdev > > + support. Note that this support also provide the linux console > > + support on top of the intel modesetting driver. > > + > > +config DRM_I915_PRELIMINARY_HW_SUPPORT > > + bool "Enable preliminary support for prerelease Intel hardware by default" > > + depends on DRM_I915 > > + help > > + Choose this option if you have prerelease Intel hardware and want the > > + i915 driver to support it by default. You can enable such support at > > + runtime with the module option i915.preliminary_hw_support=1; this > > + option changes the default for that module option. > > + > > + If in doubt, say "N". > > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > > index 65e60d2..45e14a8 100644 > > --- a/drivers/gpu/drm/i915/Makefile > > +++ b/drivers/gpu/drm/i915/Makefile > > @@ -33,7 +33,6 @@ i915-y := i915_drv.o i915_dma.o i915_irq.o \ > > intel_panel.o \ > > intel_pm.o \ > > intel_i2c.o \ > > - intel_fb.o \ > > intel_tv.o \ > > intel_dvo.o \ > > intel_ringbuffer.o \ > > @@ -54,6 +53,8 @@ i915-$(CONFIG_COMPAT) += i915_ioc32.o > > > > i915-$(CONFIG_ACPI) += intel_acpi.o > > > > +i915-$(CONFIG_DRM_I915_FBDEV) += intel_fb.o > > + > > obj-$(CONFIG_DRM_I915) += i915.o > > > > CFLAGS_i915_trace_points.o := -I$(src) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > > index 5fd6a5d..79bfbd5 100644 > > --- a/drivers/gpu/drm/i915/i915_debugfs.c > > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > > @@ -1399,12 +1399,12 @@ static int i915_gem_framebuffer_info(struct seq_file *m, void *data) > > { > > struct drm_info_node *node = (struct drm_info_node *) m->private; > > struct drm_device *dev = node->minor->dev; > > - drm_i915_private_t *dev_priv = dev->dev_private; > > - struct intel_fbdev *ifbdev; > > + struct intel_fbdev *ifbdev = NULL; > > struct intel_framebuffer *fb; > > - int ret; > > > > - ret = mutex_lock_interruptible(&dev->mode_config.mutex); > > +#ifdef CONFIG_DRM_I915_FBDEV > > + struct drm_i915_private *dev_priv = dev->dev_private; > > + int ret = mutex_lock_interruptible(&dev->mode_config.mutex); > > if (ret) > > return ret; > > > > @@ -1420,6 +1420,7 @@ static int i915_gem_framebuffer_info(struct seq_file *m, void *data) > > describe_obj(m, fb->obj); > > seq_putc(m, '\n'); > > mutex_unlock(&dev->mode_config.mutex); > > +#endif > > > > mutex_lock(&dev->mode_config.fb_lock); > > list_for_each_entry(fb, &dev->mode_config.fb_list, base.head) { > > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c > > index f221631..90f1fb6 100644 > > --- a/drivers/gpu/drm/i915/i915_dma.c > > +++ b/drivers/gpu/drm/i915/i915_dma.c > > @@ -1416,6 +1416,7 @@ void i915_master_destroy(struct drm_device *dev, struct drm_master *master) > > master->driver_priv = NULL; > > } > > > > +#ifdef CONFIG_DRM_I915_FBDEV > > static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) > > { > > struct apertures_struct *ap; > > @@ -1436,6 +1437,11 @@ static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) > > > > kfree(ap); > > } > > +#else > > +static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) > > +{ > > +} > > +#endif > > > > static void i915_dump_device_info(struct drm_i915_private *dev_priv) > > { > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > > index ed8653f..99f621d 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.h > > +++ b/drivers/gpu/drm/i915/i915_drv.h > > @@ -1354,8 +1354,10 @@ typedef struct drm_i915_private { > > > > struct drm_i915_gem_object *vlv_pctx; > > > > +#ifdef CONFIG_DRM_I915_FBDEV > > /* list of fbdev register on this device */ > > struct intel_fbdev *fbdev; > > +#endif > > > > /* > > * The console may be contended at resume, but we don't > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > > index ded0d45..43e4e75 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -7318,6 +7318,7 @@ static struct drm_framebuffer * > > mode_fits_in_fbdev(struct drm_device *dev, > > struct drm_display_mode *mode) > > { > > +#ifdef CONFIG_DRM_I915_FBDEV > > struct drm_i915_private *dev_priv = dev->dev_private; > > struct drm_i915_gem_object *obj; > > struct drm_framebuffer *fb; > > @@ -7338,6 +7339,9 @@ mode_fits_in_fbdev(struct drm_device *dev, > > return NULL; > > > > return fb; > > +#else > > + return NULL; > > +#endif > > } > > > > bool intel_get_load_detect_pipe(struct drm_connector *connector, > > @@ -10084,6 +10088,12 @@ intel_user_framebuffer_create(struct drm_device *dev, > > return intel_framebuffer_create(dev, mode_cmd, obj); > > } > > > > +#ifndef CONFIG_DRM_I915_FBDEV > > +static inline void intel_fb_output_poll_changed(struct drm_device *dev) > > +{ > > +} > > +#endif > > + > > static const struct drm_mode_config_funcs intel_mode_funcs = { > > .fb_create = intel_user_framebuffer_create, > > .output_poll_changed = intel_fb_output_poll_changed, > > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h > > index adfb57c..181d10b 100644 > > --- a/drivers/gpu/drm/i915/intel_drv.h > > +++ b/drivers/gpu/drm/i915/intel_drv.h > > @@ -716,14 +716,36 @@ bool intel_dsi_init(struct drm_device *dev); > > void intel_dvo_init(struct drm_device *dev); > > > > > > -/* intel_fb.c */ > > -int intel_fbdev_init(struct drm_device *dev); > > -void intel_fbdev_initial_config(struct drm_device *dev); > > -void intel_fbdev_fini(struct drm_device *dev); > > -void intel_fbdev_set_suspend(struct drm_device *dev, int state); > > -void intel_fb_output_poll_changed(struct drm_device *dev); > > -void intel_fb_restore_mode(struct drm_device *dev); > > +/* legacy fbdev emulation in intel_fb.c */ > > +#ifdef CONFIG_DRM_I915_FBDEV > > +extern int intel_fbdev_init(struct drm_device *dev); > > +extern void intel_fbdev_initial_config(struct drm_device *dev); > > +extern void intel_fbdev_fini(struct drm_device *dev); > > +extern void intel_fbdev_set_suspend(struct drm_device *dev, int state); > > +extern void intel_fb_output_poll_changed(struct drm_device *dev); > > +extern void intel_fb_restore_mode(struct drm_device *dev); > > +#else > > +static inline int intel_fbdev_init(struct drm_device *dev) > > +{ > > + return 0; > > +} > > > > +static inline void intel_fbdev_initial_config(struct drm_device *dev) > > +{ > > +} > > + > > +static inline void intel_fbdev_fini(struct drm_device *dev) > > +{ > > +} > > + > > +static inline void intel_fbdev_set_suspend(struct drm_device *dev, int state) > > +{ > > +} > > + > > +static inline void intel_fb_restore_mode(struct drm_device *dev) > > +{ > > +} > > +#endif > > > > /* intel_hdmi.c */ > > void intel_hdmi_init(struct drm_device *dev, int hdmi_reg, enum port port); > > -- > > 1.8.1.4 > > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 3/3] drm/i915: rename intel_fb.c to intel_fbdev.c 2013-10-08 15:44 [PATCH 0/3] fbdev-less i915, take 2 Daniel Vetter 2013-10-08 15:44 ` [PATCH 1/3] drm: Add separate Kconfig option for fbdev helpers Daniel Vetter 2013-10-08 15:44 ` [PATCH 2/3] drm/i915: Kconfig option to disable the legacy fbdev support Daniel Vetter @ 2013-10-08 15:44 ` Daniel Vetter 2013-10-08 15:59 ` [PATCH 0/3] fbdev-less i915, take 2 Chris Wilson 3 siblings, 0 replies; 14+ messages in thread From: Daniel Vetter @ 2013-10-08 15:44 UTC (permalink / raw) To: DRI Development; +Cc: Daniel Vetter, Intel Graphics Development This file is all about the legacy fbdev support. If we want to extract framebuffer functions, we better put those into a separate file. Also rename functions accordingly, only two have used the intel_fb_ prefix anyway. Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_dma.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 4 +- drivers/gpu/drm/i915/intel_drv.h | 8 +- drivers/gpu/drm/i915/intel_fb.c | 323 ----------------------------------- drivers/gpu/drm/i915/intel_fbdev.c | 323 +++++++++++++++++++++++++++++++++++ 6 files changed, 331 insertions(+), 331 deletions(-) delete mode 100644 drivers/gpu/drm/i915/intel_fb.c create mode 100644 drivers/gpu/drm/i915/intel_fbdev.c diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index 45e14a8..41838ea 100644 --- a/drivers/gpu/drm/i915/Makefile +++ b/drivers/gpu/drm/i915/Makefile @@ -53,7 +53,7 @@ i915-$(CONFIG_COMPAT) += i915_ioc32.o i915-$(CONFIG_ACPI) += intel_acpi.o -i915-$(CONFIG_DRM_I915_FBDEV) += intel_fb.o +i915-$(CONFIG_DRM_I915_FBDEV) += intel_fbdev.o obj-$(CONFIG_DRM_I915) += i915.o diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index 057ddeb..6744490 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c @@ -1865,7 +1865,7 @@ void i915_driver_lastclose(struct drm_device * dev) return; if (drm_core_check_feature(dev, DRIVER_MODESET)) { - intel_fb_restore_mode(dev); + intel_fbdev_restore_mode(dev); vga_switcheroo_process_delayed_switch(); return; } diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 43e4e75..ac50539 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -10089,14 +10089,14 @@ intel_user_framebuffer_create(struct drm_device *dev, } #ifndef CONFIG_DRM_I915_FBDEV -static inline void intel_fb_output_poll_changed(struct drm_device *dev) +static inline void intel_fbdev_output_poll_changed(struct drm_device *dev) { } #endif static const struct drm_mode_config_funcs intel_mode_funcs = { .fb_create = intel_user_framebuffer_create, - .output_poll_changed = intel_fb_output_poll_changed, + .output_poll_changed = intel_fbdev_output_poll_changed, }; /* Set up chip specific display functions */ diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index 181d10b..6a8b027 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h @@ -716,14 +716,14 @@ bool intel_dsi_init(struct drm_device *dev); void intel_dvo_init(struct drm_device *dev); -/* legacy fbdev emulation in intel_fb.c */ +/* legacy fbdev emulation in intel_fbdev.c */ #ifdef CONFIG_DRM_I915_FBDEV extern int intel_fbdev_init(struct drm_device *dev); extern void intel_fbdev_initial_config(struct drm_device *dev); extern void intel_fbdev_fini(struct drm_device *dev); extern void intel_fbdev_set_suspend(struct drm_device *dev, int state); -extern void intel_fb_output_poll_changed(struct drm_device *dev); -extern void intel_fb_restore_mode(struct drm_device *dev); +extern void intel_fbdev_output_poll_changed(struct drm_device *dev); +extern void intel_fbdev_restore_mode(struct drm_device *dev); #else static inline int intel_fbdev_init(struct drm_device *dev) { @@ -742,7 +742,7 @@ static inline void intel_fbdev_set_suspend(struct drm_device *dev, int state) { } -static inline void intel_fb_restore_mode(struct drm_device *dev) +static inline void intel_fbdev_restore_mode(struct drm_device *dev) { } #endif diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c deleted file mode 100644 index d883b77..0000000 --- a/drivers/gpu/drm/i915/intel_fb.c +++ /dev/null @@ -1,323 +0,0 @@ -/* - * Copyright © 2007 David Airlie - * - * Permission is hereby granted, free of charge, to any person obtaining a - * copy of this software and associated documentation files (the "Software"), - * to deal in the Software without restriction, including without limitation - * the rights to use, copy, modify, merge, publish, distribute, sublicense, - * and/or sell copies of the Software, and to permit persons to whom the - * Software is furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice (including the next - * paragraph) shall be included in all copies or substantial portions of the - * Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL - * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * - * Authors: - * David Airlie - */ - -#include <linux/module.h> -#include <linux/kernel.h> -#include <linux/errno.h> -#include <linux/string.h> -#include <linux/mm.h> -#include <linux/tty.h> -#include <linux/sysrq.h> -#include <linux/delay.h> -#include <linux/fb.h> -#include <linux/init.h> -#include <linux/vga_switcheroo.h> - -#include <drm/drmP.h> -#include <drm/drm_crtc.h> -#include <drm/drm_fb_helper.h> -#include "intel_drv.h" -#include <drm/i915_drm.h> -#include "i915_drv.h" - -static struct fb_ops intelfb_ops = { - .owner = THIS_MODULE, - .fb_check_var = drm_fb_helper_check_var, - .fb_set_par = drm_fb_helper_set_par, - .fb_fillrect = cfb_fillrect, - .fb_copyarea = cfb_copyarea, - .fb_imageblit = cfb_imageblit, - .fb_pan_display = drm_fb_helper_pan_display, - .fb_blank = drm_fb_helper_blank, - .fb_setcmap = drm_fb_helper_setcmap, - .fb_debug_enter = drm_fb_helper_debug_enter, - .fb_debug_leave = drm_fb_helper_debug_leave, -}; - -static int intelfb_create(struct drm_fb_helper *helper, - struct drm_fb_helper_surface_size *sizes) -{ - struct intel_fbdev *ifbdev = - container_of(helper, struct intel_fbdev, helper); - struct drm_device *dev = helper->dev; - struct drm_i915_private *dev_priv = dev->dev_private; - struct fb_info *info; - struct drm_framebuffer *fb; - struct drm_mode_fb_cmd2 mode_cmd = {}; - struct drm_i915_gem_object *obj; - struct device *device = &dev->pdev->dev; - int size, ret; - - /* we don't do packed 24bpp */ - if (sizes->surface_bpp == 24) - sizes->surface_bpp = 32; - - mode_cmd.width = sizes->surface_width; - mode_cmd.height = sizes->surface_height; - - mode_cmd.pitches[0] = ALIGN(mode_cmd.width * ((sizes->surface_bpp + 7) / - 8), 64); - mode_cmd.pixel_format = drm_mode_legacy_fb_format(sizes->surface_bpp, - sizes->surface_depth); - - size = mode_cmd.pitches[0] * mode_cmd.height; - size = ALIGN(size, PAGE_SIZE); - obj = i915_gem_object_create_stolen(dev, size); - if (obj == NULL) - obj = i915_gem_alloc_object(dev, size); - if (!obj) { - DRM_ERROR("failed to allocate framebuffer\n"); - ret = -ENOMEM; - goto out; - } - - mutex_lock(&dev->struct_mutex); - - /* Flush everything out, we'll be doing GTT only from now on */ - ret = intel_pin_and_fence_fb_obj(dev, obj, NULL); - if (ret) { - DRM_ERROR("failed to pin fb: %d\n", ret); - goto out_unref; - } - - info = framebuffer_alloc(0, device); - if (!info) { - ret = -ENOMEM; - goto out_unpin; - } - - info->par = helper; - - ret = intel_framebuffer_init(dev, &ifbdev->ifb, &mode_cmd, obj); - if (ret) - goto out_unpin; - - fb = &ifbdev->ifb.base; - - ifbdev->helper.fb = fb; - ifbdev->helper.fbdev = info; - - strcpy(info->fix.id, "inteldrmfb"); - - info->flags = FBINFO_DEFAULT | FBINFO_CAN_FORCE_OUTPUT; - info->fbops = &intelfb_ops; - - ret = fb_alloc_cmap(&info->cmap, 256, 0); - if (ret) { - ret = -ENOMEM; - goto out_unpin; - } - /* setup aperture base/size for vesafb takeover */ - info->apertures = alloc_apertures(1); - if (!info->apertures) { - ret = -ENOMEM; - goto out_unpin; - } - info->apertures->ranges[0].base = dev->mode_config.fb_base; - info->apertures->ranges[0].size = dev_priv->gtt.mappable_end; - - info->fix.smem_start = dev->mode_config.fb_base + i915_gem_obj_ggtt_offset(obj); - info->fix.smem_len = size; - - info->screen_base = - ioremap_wc(dev_priv->gtt.mappable_base + i915_gem_obj_ggtt_offset(obj), - size); - if (!info->screen_base) { - ret = -ENOSPC; - goto out_unpin; - } - info->screen_size = size; - - /* This driver doesn't need a VT switch to restore the mode on resume */ - info->skip_vt_switch = true; - - drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth); - drm_fb_helper_fill_var(info, &ifbdev->helper, sizes->fb_width, sizes->fb_height); - - /* If the object is shmemfs backed, it will have given us zeroed pages. - * If the object is stolen however, it will be full of whatever - * garbage was left in there. - */ - if (ifbdev->ifb.obj->stolen) - memset_io(info->screen_base, 0, info->screen_size); - - /* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */ - - DRM_DEBUG_KMS("allocated %dx%d fb: 0x%08lx, bo %p\n", - fb->width, fb->height, - i915_gem_obj_ggtt_offset(obj), obj); - - - mutex_unlock(&dev->struct_mutex); - vga_switcheroo_client_fb_set(dev->pdev, info); - return 0; - -out_unpin: - i915_gem_object_unpin(obj); -out_unref: - drm_gem_object_unreference(&obj->base); - mutex_unlock(&dev->struct_mutex); -out: - return ret; -} - -/** Sets the color ramps on behalf of RandR */ -static void intel_crtc_fb_gamma_set(struct drm_crtc *crtc, u16 red, u16 green, - u16 blue, int regno) -{ - struct intel_crtc *intel_crtc = to_intel_crtc(crtc); - - intel_crtc->lut_r[regno] = red >> 8; - intel_crtc->lut_g[regno] = green >> 8; - intel_crtc->lut_b[regno] = blue >> 8; -} - -static void intel_crtc_fb_gamma_get(struct drm_crtc *crtc, u16 *red, u16 *green, - u16 *blue, int regno) -{ - struct intel_crtc *intel_crtc = to_intel_crtc(crtc); - - *red = intel_crtc->lut_r[regno] << 8; - *green = intel_crtc->lut_g[regno] << 8; - *blue = intel_crtc->lut_b[regno] << 8; -} - -static struct drm_fb_helper_funcs intel_fb_helper_funcs = { - .gamma_set = intel_crtc_fb_gamma_set, - .gamma_get = intel_crtc_fb_gamma_get, - .fb_probe = intelfb_create, -}; - -static void intel_fbdev_destroy(struct drm_device *dev, - struct intel_fbdev *ifbdev) -{ - if (ifbdev->helper.fbdev) { - struct fb_info *info = ifbdev->helper.fbdev; - - unregister_framebuffer(info); - iounmap(info->screen_base); - if (info->cmap.len) - fb_dealloc_cmap(&info->cmap); - - framebuffer_release(info); - } - - drm_fb_helper_fini(&ifbdev->helper); - - drm_framebuffer_unregister_private(&ifbdev->ifb.base); - intel_framebuffer_fini(&ifbdev->ifb); -} - -int intel_fbdev_init(struct drm_device *dev) -{ - struct intel_fbdev *ifbdev; - struct drm_i915_private *dev_priv = dev->dev_private; - int ret; - - ifbdev = kzalloc(sizeof(*ifbdev), GFP_KERNEL); - if (!ifbdev) - return -ENOMEM; - - dev_priv->fbdev = ifbdev; - ifbdev->helper.funcs = &intel_fb_helper_funcs; - - ret = drm_fb_helper_init(dev, &ifbdev->helper, - INTEL_INFO(dev)->num_pipes, - 4); - if (ret) { - kfree(ifbdev); - return ret; - } - - drm_fb_helper_single_add_all_connectors(&ifbdev->helper); - - return 0; -} - -void intel_fbdev_initial_config(struct drm_device *dev) -{ - struct drm_i915_private *dev_priv = dev->dev_private; - - /* Due to peculiar init order wrt to hpd handling this is separate. */ - drm_fb_helper_initial_config(&dev_priv->fbdev->helper, 32); -} - -void intel_fbdev_fini(struct drm_device *dev) -{ - struct drm_i915_private *dev_priv = dev->dev_private; - if (!dev_priv->fbdev) - return; - - intel_fbdev_destroy(dev, dev_priv->fbdev); - kfree(dev_priv->fbdev); - dev_priv->fbdev = NULL; -} - -void intel_fbdev_set_suspend(struct drm_device *dev, int state) -{ - struct drm_i915_private *dev_priv = dev->dev_private; - struct intel_fbdev *ifbdev = dev_priv->fbdev; - struct fb_info *info; - - if (!ifbdev) - return; - - info = ifbdev->helper.fbdev; - - /* On resume from hibernation: If the object is shmemfs backed, it has - * been restored from swap. If the object is stolen however, it will be - * full of whatever garbage was left in there. - */ - if (state == FBINFO_STATE_RUNNING && ifbdev->ifb.obj->stolen) - memset_io(info->screen_base, 0, info->screen_size); - - fb_set_suspend(info, state); -} - -MODULE_LICENSE("GPL and additional rights"); - -void intel_fb_output_poll_changed(struct drm_device *dev) -{ - struct drm_i915_private *dev_priv = dev->dev_private; - drm_fb_helper_hotplug_event(&dev_priv->fbdev->helper); -} - -void intel_fb_restore_mode(struct drm_device *dev) -{ - int ret; - struct drm_i915_private *dev_priv = dev->dev_private; - - if (INTEL_INFO(dev)->num_pipes == 0) - return; - - drm_modeset_lock_all(dev); - - ret = drm_fb_helper_restore_fbdev_mode(&dev_priv->fbdev->helper); - if (ret) - DRM_DEBUG("failed to restore crtc mode\n"); - - drm_modeset_unlock_all(dev); -} diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c new file mode 100644 index 0000000..acc8395 --- /dev/null +++ b/drivers/gpu/drm/i915/intel_fbdev.c @@ -0,0 +1,323 @@ +/* + * Copyright © 2007 David Airlie + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice (including the next + * paragraph) shall be included in all copies or substantial portions of the + * Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + * + * Authors: + * David Airlie + */ + +#include <linux/module.h> +#include <linux/kernel.h> +#include <linux/errno.h> +#include <linux/string.h> +#include <linux/mm.h> +#include <linux/tty.h> +#include <linux/sysrq.h> +#include <linux/delay.h> +#include <linux/fb.h> +#include <linux/init.h> +#include <linux/vga_switcheroo.h> + +#include <drm/drmP.h> +#include <drm/drm_crtc.h> +#include <drm/drm_fb_helper.h> +#include "intel_drv.h" +#include <drm/i915_drm.h> +#include "i915_drv.h" + +static struct fb_ops intelfb_ops = { + .owner = THIS_MODULE, + .fb_check_var = drm_fb_helper_check_var, + .fb_set_par = drm_fb_helper_set_par, + .fb_fillrect = cfb_fillrect, + .fb_copyarea = cfb_copyarea, + .fb_imageblit = cfb_imageblit, + .fb_pan_display = drm_fb_helper_pan_display, + .fb_blank = drm_fb_helper_blank, + .fb_setcmap = drm_fb_helper_setcmap, + .fb_debug_enter = drm_fb_helper_debug_enter, + .fb_debug_leave = drm_fb_helper_debug_leave, +}; + +static int intelfb_create(struct drm_fb_helper *helper, + struct drm_fb_helper_surface_size *sizes) +{ + struct intel_fbdev *ifbdev = + container_of(helper, struct intel_fbdev, helper); + struct drm_device *dev = helper->dev; + struct drm_i915_private *dev_priv = dev->dev_private; + struct fb_info *info; + struct drm_framebuffer *fb; + struct drm_mode_fb_cmd2 mode_cmd = {}; + struct drm_i915_gem_object *obj; + struct device *device = &dev->pdev->dev; + int size, ret; + + /* we don't do packed 24bpp */ + if (sizes->surface_bpp == 24) + sizes->surface_bpp = 32; + + mode_cmd.width = sizes->surface_width; + mode_cmd.height = sizes->surface_height; + + mode_cmd.pitches[0] = ALIGN(mode_cmd.width * ((sizes->surface_bpp + 7) / + 8), 64); + mode_cmd.pixel_format = drm_mode_legacy_fb_format(sizes->surface_bpp, + sizes->surface_depth); + + size = mode_cmd.pitches[0] * mode_cmd.height; + size = ALIGN(size, PAGE_SIZE); + obj = i915_gem_object_create_stolen(dev, size); + if (obj == NULL) + obj = i915_gem_alloc_object(dev, size); + if (!obj) { + DRM_ERROR("failed to allocate framebuffer\n"); + ret = -ENOMEM; + goto out; + } + + mutex_lock(&dev->struct_mutex); + + /* Flush everything out, we'll be doing GTT only from now on */ + ret = intel_pin_and_fence_fb_obj(dev, obj, NULL); + if (ret) { + DRM_ERROR("failed to pin fb: %d\n", ret); + goto out_unref; + } + + info = framebuffer_alloc(0, device); + if (!info) { + ret = -ENOMEM; + goto out_unpin; + } + + info->par = helper; + + ret = intel_framebuffer_init(dev, &ifbdev->ifb, &mode_cmd, obj); + if (ret) + goto out_unpin; + + fb = &ifbdev->ifb.base; + + ifbdev->helper.fb = fb; + ifbdev->helper.fbdev = info; + + strcpy(info->fix.id, "inteldrmfb"); + + info->flags = FBINFO_DEFAULT | FBINFO_CAN_FORCE_OUTPUT; + info->fbops = &intelfb_ops; + + ret = fb_alloc_cmap(&info->cmap, 256, 0); + if (ret) { + ret = -ENOMEM; + goto out_unpin; + } + /* setup aperture base/size for vesafb takeover */ + info->apertures = alloc_apertures(1); + if (!info->apertures) { + ret = -ENOMEM; + goto out_unpin; + } + info->apertures->ranges[0].base = dev->mode_config.fb_base; + info->apertures->ranges[0].size = dev_priv->gtt.mappable_end; + + info->fix.smem_start = dev->mode_config.fb_base + i915_gem_obj_ggtt_offset(obj); + info->fix.smem_len = size; + + info->screen_base = + ioremap_wc(dev_priv->gtt.mappable_base + i915_gem_obj_ggtt_offset(obj), + size); + if (!info->screen_base) { + ret = -ENOSPC; + goto out_unpin; + } + info->screen_size = size; + + /* This driver doesn't need a VT switch to restore the mode on resume */ + info->skip_vt_switch = true; + + drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth); + drm_fb_helper_fill_var(info, &ifbdev->helper, sizes->fb_width, sizes->fb_height); + + /* If the object is shmemfs backed, it will have given us zeroed pages. + * If the object is stolen however, it will be full of whatever + * garbage was left in there. + */ + if (ifbdev->ifb.obj->stolen) + memset_io(info->screen_base, 0, info->screen_size); + + /* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */ + + DRM_DEBUG_KMS("allocated %dx%d fb: 0x%08lx, bo %p\n", + fb->width, fb->height, + i915_gem_obj_ggtt_offset(obj), obj); + + + mutex_unlock(&dev->struct_mutex); + vga_switcheroo_client_fb_set(dev->pdev, info); + return 0; + +out_unpin: + i915_gem_object_unpin(obj); +out_unref: + drm_gem_object_unreference(&obj->base); + mutex_unlock(&dev->struct_mutex); +out: + return ret; +} + +/** Sets the color ramps on behalf of RandR */ +static void intel_crtc_fb_gamma_set(struct drm_crtc *crtc, u16 red, u16 green, + u16 blue, int regno) +{ + struct intel_crtc *intel_crtc = to_intel_crtc(crtc); + + intel_crtc->lut_r[regno] = red >> 8; + intel_crtc->lut_g[regno] = green >> 8; + intel_crtc->lut_b[regno] = blue >> 8; +} + +static void intel_crtc_fb_gamma_get(struct drm_crtc *crtc, u16 *red, u16 *green, + u16 *blue, int regno) +{ + struct intel_crtc *intel_crtc = to_intel_crtc(crtc); + + *red = intel_crtc->lut_r[regno] << 8; + *green = intel_crtc->lut_g[regno] << 8; + *blue = intel_crtc->lut_b[regno] << 8; +} + +static struct drm_fb_helper_funcs intel_fb_helper_funcs = { + .gamma_set = intel_crtc_fb_gamma_set, + .gamma_get = intel_crtc_fb_gamma_get, + .fb_probe = intelfb_create, +}; + +static void intel_fbdev_destroy(struct drm_device *dev, + struct intel_fbdev *ifbdev) +{ + if (ifbdev->helper.fbdev) { + struct fb_info *info = ifbdev->helper.fbdev; + + unregister_framebuffer(info); + iounmap(info->screen_base); + if (info->cmap.len) + fb_dealloc_cmap(&info->cmap); + + framebuffer_release(info); + } + + drm_fb_helper_fini(&ifbdev->helper); + + drm_framebuffer_unregister_private(&ifbdev->ifb.base); + intel_framebuffer_fini(&ifbdev->ifb); +} + +int intel_fbdev_init(struct drm_device *dev) +{ + struct intel_fbdev *ifbdev; + struct drm_i915_private *dev_priv = dev->dev_private; + int ret; + + ifbdev = kzalloc(sizeof(*ifbdev), GFP_KERNEL); + if (!ifbdev) + return -ENOMEM; + + dev_priv->fbdev = ifbdev; + ifbdev->helper.funcs = &intel_fb_helper_funcs; + + ret = drm_fb_helper_init(dev, &ifbdev->helper, + INTEL_INFO(dev)->num_pipes, + 4); + if (ret) { + kfree(ifbdev); + return ret; + } + + drm_fb_helper_single_add_all_connectors(&ifbdev->helper); + + return 0; +} + +void intel_fbdev_initial_config(struct drm_device *dev) +{ + struct drm_i915_private *dev_priv = dev->dev_private; + + /* Due to peculiar init order wrt to hpd handling this is separate. */ + drm_fb_helper_initial_config(&dev_priv->fbdev->helper, 32); +} + +void intel_fbdev_fini(struct drm_device *dev) +{ + struct drm_i915_private *dev_priv = dev->dev_private; + if (!dev_priv->fbdev) + return; + + intel_fbdev_destroy(dev, dev_priv->fbdev); + kfree(dev_priv->fbdev); + dev_priv->fbdev = NULL; +} + +void intel_fbdev_set_suspend(struct drm_device *dev, int state) +{ + struct drm_i915_private *dev_priv = dev->dev_private; + struct intel_fbdev *ifbdev = dev_priv->fbdev; + struct fb_info *info; + + if (!ifbdev) + return; + + info = ifbdev->helper.fbdev; + + /* On resume from hibernation: If the object is shmemfs backed, it has + * been restored from swap. If the object is stolen however, it will be + * full of whatever garbage was left in there. + */ + if (state == FBINFO_STATE_RUNNING && ifbdev->ifb.obj->stolen) + memset_io(info->screen_base, 0, info->screen_size); + + fb_set_suspend(info, state); +} + +MODULE_LICENSE("GPL and additional rights"); + +void intel_fbdev_output_poll_changed(struct drm_device *dev) +{ + struct drm_i915_private *dev_priv = dev->dev_private; + drm_fb_helper_hotplug_event(&dev_priv->fbdev->helper); +} + +void intel_fbdev_restore_mode(struct drm_device *dev) +{ + int ret; + struct drm_i915_private *dev_priv = dev->dev_private; + + if (INTEL_INFO(dev)->num_pipes == 0) + return; + + drm_modeset_lock_all(dev); + + ret = drm_fb_helper_restore_fbdev_mode(&dev_priv->fbdev->helper); + if (ret) + DRM_DEBUG("failed to restore crtc mode\n"); + + drm_modeset_unlock_all(dev); +} -- 1.8.1.4 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 0/3] fbdev-less i915, take 2 2013-10-08 15:44 [PATCH 0/3] fbdev-less i915, take 2 Daniel Vetter ` (2 preceding siblings ...) 2013-10-08 15:44 ` [PATCH 3/3] drm/i915: rename intel_fb.c to intel_fbdev.c Daniel Vetter @ 2013-10-08 15:59 ` Chris Wilson 3 siblings, 0 replies; 14+ messages in thread From: Chris Wilson @ 2013-10-08 15:59 UTC (permalink / raw) To: Daniel Vetter; +Cc: Intel Graphics Development, DRI Development On Tue, Oct 08, 2013 at 05:44:46PM +0200, Daniel Vetter wrote: > Hi all, > > By popular demand (our embedded guys kept asking for this) I've resurrected my > fbdev less patches. Now Rob's msm driver can be completely completely without > CONFIG_FB stuff at all when disabling the fbdev helper support. > > Review highly welcome. I still think this is misleading. fbdev to me is /dev/fb not fbcon. They are related only by implementation. -Chris -- Chris Wilson, Intel Open Source Technology Centre ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2013-10-11 21:37 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-10-08 15:44 [PATCH 0/3] fbdev-less i915, take 2 Daniel Vetter 2013-10-08 15:44 ` [PATCH 1/3] drm: Add separate Kconfig option for fbdev helpers Daniel Vetter 2013-10-08 16:52 ` Rob Clark 2013-10-11 21:36 ` Daniel Vetter 2013-10-08 15:44 ` [PATCH 2/3] drm/i915: Kconfig option to disable the legacy fbdev support Daniel Vetter 2013-10-09 6:35 ` Lee, Chon Ming 2013-10-09 7:18 ` [PATCH] " Daniel Vetter 2013-10-09 8:09 ` [Intel-gfx] " Chris Wilson 2013-10-09 8:33 ` Daniel Vetter 2013-10-09 9:33 ` [Intel-gfx] " Jani Nikula 2013-10-11 5:53 ` Lee, Chon Ming 2013-10-11 21:37 ` Daniel Vetter 2013-10-08 15:44 ` [PATCH 3/3] drm/i915: rename intel_fb.c to intel_fbdev.c Daniel Vetter 2013-10-08 15:59 ` [PATCH 0/3] fbdev-less i915, take 2 Chris Wilson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
