From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH] drm/i915/hsw: Disable L3 caching of atomic memory operations. Date: Wed, 02 Oct 2013 18:36:11 -0700 Message-ID: <87a9ircf04.fsf@eliezer.anholt.net> References: <1380751423-6255-1-git-send-email-currojerez@riseup.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1588899606==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter , Francisco Jerez Cc: intel-gfx , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org --===============1588899606== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Daniel Vetter writes: > On Thu, Oct 3, 2013 at 12:03 AM, Francisco Jerez wrote: >> + case I915_PARAM_HAS_ATOMICS: >> + value = 1; >> + break; > > Generally when we do kernel fixes for gpu hangs like that we don't add > parameters (would drown in them otherwise) but simply queue it up to > -fixes and slap a cc: stable on it. Gpu hang fixes are critical enough > imo for that treatment, even when it's for brand new userspace code. > > Any specific reason why we shouldn't follow this approach here? I'd > make the patch simpler and we could dump a bit of userspace code, too. Well, what it means is that people who pull new mesa on their old kernel will reliably get GPU hangs when running piglit, which is something we've avoided in the past when enabling new features (I915_PARAM_HAS_GEN7_SOL_RESET for example). --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQIcBAEBCAAGBQJSTMoLAAoJELXWKTbR/J7ouVsP/Rcv2JYrBI3H6TZOUcx74E6v AlrYpafklhZt/wwQzfiCRzSjNioXK2lyCEVf7YeobvuDaxVJvmqXE9iR3Kzpmyjy yKEJ/6A4hsVLm4ZflTNAJEGKlpVge+OL8Ekhoy/tXvzG3LpYxRSAu2QkW6ftyCLW GjPLXmFnLIjhaxXv8hOYv/gLZxbTSl1HIq3BkpffHfIcvsJcKhs1WLCf7+RYpqxI Ux090UBN8TQiRZxqmIUpOd/jSNgb99ECcvr6R8jF/0+27UbDbFDeLwH0QPoFQjhm OPCInIZhdxwuW/ZFXvU3uixWL+uyG/3WLLt19MTw3qU7fvhp5HFtjhePJZr3h6mn UX6fPYbaoss75s2jiaXRE+8htwsL99QlRdTfdfqSTzk/kfZVXsXX2MQTSU391w1e 5WRQFcjtOTiaXpKcFXzT83zhgUXOV1OSz8KYzhRTq+F5Xowgr2xvNu/IphVsqc7t 83Xx3DnpxDR+NYjx4og/QGikQ0wk0ldGV9s1xD4M70ljD5Da32cYJxb19GrfHf+5 7PCzrL8osqbTM4+BiAbFg2Vb4oFo2O5d2gArZlSaFNyLmDW6Qd5Z+/V+zHC7MREo 8sThhZUIuhpg64jHgw1ycwYJDs3gU46Uy0U+rJYjXF64pVxfQeZKfn7UCuwipMnU x34uWOOYbuLTxLEl81Mm =JRsg -----END PGP SIGNATURE----- --=-=-=-- --===============1588899606== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1588899606==--