From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH] drm/i915: Handle sync_seqno correctly when seqno has wrapped. Date: Thu, 29 Nov 2012 10:43:46 +0200 Message-ID: <87a9u04x4t.fsf@gaia.fi.intel.com> References: <1352814696-2154-1-git-send-email-mika.kuoppala@intel.com> <20121113083926.340d40d5@bwidawsk.net> <87obitc15x.fsf@gaia.fi.intel.com> <20121119092148.710df2a0@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 592E2E5DC2 for ; Thu, 29 Nov 2012 00:43:51 -0800 (PST) In-Reply-To: <20121119092148.710df2a0@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 19 Nov 2012 09:21:48 -0800, Ben Widawsky wrote: > On Mon, 19 Nov 2012 12:55:22 +0200 > Mika Kuoppala wrote: > > > > > On Tue, 13 Nov 2012 08:39:26 -0800, Ben Widawsky wrote: > > > Can you add another patch on top of this to have the starting seqno be a > > > near pre-wrap value so we can catch bugs even without igt. > > > > I tried that but failed. I suspect that there is something in hw/sw > > that doesn't like if first seqno is >0x80000000. Something in hw needs > > to initialized explicitly if seqno is not starting from 1? > > > > Nothing that I am aware of. If you have the first be 0, and then add a > huge jump right after that, does it work? We can't jump more than 0x80000000-1 as i915_seqno_passed() breaks. But with the patches for preallocate seqnos now in, I was able to get things working when first seqno was 0xFFFF0000. -Mika