From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79032D1CDAC for ; Tue, 22 Oct 2024 07:44:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1941910E1A3; Tue, 22 Oct 2024 07:44:07 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="j80Iniya"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id DAE2110E1A3; Tue, 22 Oct 2024 07:44:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729583045; x=1761119045; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=a6GkCFfwObql02caQi5RIcOyP3C8iy7YyFLxvDUFmog=; b=j80IniyaW2yMEi4xo4IHx42BcSQNPgEABvbO3pMOgtV4khoCk6NZYCXj dB8g2mQiqDSoctVek6x++uu/naOOvIEaRaTbR0KPWdriG7bqQkF2+ugps DfDYUtnhuyZbAmS5dtrPGR2636Y3wMCvlWjHirw03m++NZN6S38kM03fW FjwR0V2PjHh/RM7XAekufheXq6i5L7mNWxuey1Fm3xKvEPQGcHI1atrsx 1QULVOqqzXsJ9ETskkBHTSiolG4g1IGbZGatEW8YEiE2oh7czIgMl28Ax 21Gu+QYRwVu4GJ5hkvP1Tedd9fKzfXdl3wNFeAhWW+yavumLIKd7m8juY A==; X-CSE-ConnectionGUID: J+7nJ9MXR1yS5b6/uU4Bcg== X-CSE-MsgGUID: ibTgNaUxSeGetwg5gJx9yw== X-IronPort-AV: E=McAfee;i="6700,10204,11232"; a="39684446" X-IronPort-AV: E=Sophos;i="6.11,222,1725346800"; d="scan'208";a="39684446" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2024 00:44:05 -0700 X-CSE-ConnectionGUID: +fuySo1HQfGfxwLbf8IGeQ== X-CSE-MsgGUID: vyyzi2G0ReONscGJNAwXHQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,222,1725346800"; d="scan'208";a="84855591" Received: from lfiedoro-mobl.ger.corp.intel.com (HELO localhost) ([10.245.246.4]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2024 00:44:02 -0700 From: Jani Nikula To: "Nilawar, Badal" , "Kandpal, Suraj" , "intel-xe@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" Cc: "Kandpal, Suraj" Subject: RE: [PATCH] drm/xe/hdcp: Add check to remove hdcp2 compatibilty In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20241022055655.1902-1-suraj.kandpal@intel.com> Date: Tue, 22 Oct 2024 10:44:00 +0300 Message-ID: <87bjzcy43j.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 22 Oct 2024, "Nilawar, Badal" wrote: > -----Original Message----- > From: Intel-gfx On Behalf Of Suraj Kandpal > Sent: 22 October 2024 11:27 > To: intel-xe@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Cc: Kandpal, Suraj > Subject: [PATCH] drm/xe/hdcp: Add check to remove hdcp2 compatibilty > > Add check to remove HDCP2 compatibility from BMG as it does not have GSC which ends up causing warning when we try to get reference of GSC FW. > > Signed-off-by: Suraj Kandpal > > Could you please add fixes tag in commit message. > > Fixes: 89d030804831 ("drm/xe/hdcp: Fix condition for hdcp gsc cs requirement") > Fixes: 883631771038 ("drm/i915/mtl: Add HDCP GSC interface") > > Regards, > Badal Please quote your replies properly [1]. Your mail is really quite hard to read [2]. BR, Jani. [1] https://subspace.kernel.org/etiquette.html#do-not-top-post-when-replying [2] https://lore.kernel.org/all/BN9PR11MB5530247EFE733E0B4E16870AE54C2@BN9PR11MB5530.namprd11.prod.outlook.com/ > --- > drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 3 ++- > drivers/gpu/drm/xe/display/xe_hdcp_gsc.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c > index 55965844d829..2c1d0ee8cec2 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c > +++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c > @@ -21,7 +21,8 @@ struct intel_hdcp_gsc_message { > > bool intel_hdcp_gsc_cs_required(struct intel_display *display) { > - return DISPLAY_VER(display) >= 14; > + return DISPLAY_VER(display) >= 14 && > + DISPLAY_VER_FULL(display) != IP_VER(14, 1); > } > > bool intel_hdcp_gsc_check_status(struct intel_display *display) diff --git a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c > index 231677129a35..e3c57f0b79c4 100644 > --- a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c > +++ b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c > @@ -32,7 +32,8 @@ struct intel_hdcp_gsc_message { > > bool intel_hdcp_gsc_cs_required(struct intel_display *display) { > - return DISPLAY_VER(display) >= 14; > + return DISPLAY_VER(display) >= 14 && > + DISPLAY_VER_FULL(display) != IP_VER(14, 1); > } > > bool intel_hdcp_gsc_check_status(struct intel_display *display) > -- > 2.34.1 > -- Jani Nikula, Intel