* [PATCH] drm/i915/bios: remove some unused leftover declarations
@ 2023-12-21 10:54 Jani Nikula
2023-12-21 10:54 ` Jani Nikula
2023-12-26 15:09 ` Rodrigo Vivi
0 siblings, 2 replies; 4+ messages in thread
From: Jani Nikula @ 2023-12-21 10:54 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Remove some unused declarations probably left behind after some
refactoring.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/i915/display/intel_bios.h
index 49e24b7cf675..96673dc707e7 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.h
+++ b/drivers/gpu/drm/i915/display/intel_bios.h
@@ -246,13 +246,10 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size);
bool intel_bios_is_tv_present(struct drm_i915_private *dev_priv);
bool intel_bios_is_lvds_present(struct drm_i915_private *dev_priv, u8 *i2c_pin);
bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port port);
-bool intel_bios_is_port_edp(struct drm_i915_private *dev_priv, enum port port);
bool intel_bios_is_dsi_present(struct drm_i915_private *dev_priv, enum port *port);
bool intel_bios_get_dsc_params(struct intel_encoder *encoder,
struct intel_crtc_state *crtc_state,
int dsc_max_bpc);
-bool intel_bios_port_supports_typec_usb(struct drm_i915_private *i915, enum port port);
-bool intel_bios_port_supports_tbt(struct drm_i915_private *i915, enum port port);
const struct intel_bios_encoder_data *
intel_bios_encoder_data_lookup(struct drm_i915_private *i915, enum port port);
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/i915/bios: remove some unused leftover declarations
2023-12-21 10:54 [PATCH] drm/i915/bios: remove some unused leftover declarations Jani Nikula
@ 2023-12-21 10:54 ` Jani Nikula
2023-12-26 15:09 ` Rodrigo Vivi
1 sibling, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2023-12-21 10:54 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Remove some unused declarations probably left behind after some
refactoring.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/i915/display/intel_bios.h
index 49e24b7cf675..96673dc707e7 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.h
+++ b/drivers/gpu/drm/i915/display/intel_bios.h
@@ -246,13 +246,10 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size);
bool intel_bios_is_tv_present(struct drm_i915_private *dev_priv);
bool intel_bios_is_lvds_present(struct drm_i915_private *dev_priv, u8 *i2c_pin);
bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port port);
-bool intel_bios_is_port_edp(struct drm_i915_private *dev_priv, enum port port);
bool intel_bios_is_dsi_present(struct drm_i915_private *dev_priv, enum port *port);
bool intel_bios_get_dsc_params(struct intel_encoder *encoder,
struct intel_crtc_state *crtc_state,
int dsc_max_bpc);
-bool intel_bios_port_supports_typec_usb(struct drm_i915_private *i915, enum port port);
-bool intel_bios_port_supports_tbt(struct drm_i915_private *i915, enum port port);
const struct intel_bios_encoder_data *
intel_bios_encoder_data_lookup(struct drm_i915_private *i915, enum port port);
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915/bios: remove some unused leftover declarations
2023-12-21 10:54 [PATCH] drm/i915/bios: remove some unused leftover declarations Jani Nikula
2023-12-21 10:54 ` Jani Nikula
@ 2023-12-26 15:09 ` Rodrigo Vivi
2023-12-29 10:55 ` Jani Nikula
1 sibling, 1 reply; 4+ messages in thread
From: Rodrigo Vivi @ 2023-12-26 15:09 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Thu, Dec 21, 2023 at 12:54:14PM +0200, Jani Nikula wrote:
> Remove some unused declarations probably left behind after some
> refactoring.
when you mention 'unused' I was wondering if we should move the
local functions to 'static', but then I notice they are 'inexistent'.
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_bios.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/i915/display/intel_bios.h
> index 49e24b7cf675..96673dc707e7 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.h
> +++ b/drivers/gpu/drm/i915/display/intel_bios.h
> @@ -246,13 +246,10 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size);
> bool intel_bios_is_tv_present(struct drm_i915_private *dev_priv);
> bool intel_bios_is_lvds_present(struct drm_i915_private *dev_priv, u8 *i2c_pin);
> bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port port);
> -bool intel_bios_is_port_edp(struct drm_i915_private *dev_priv, enum port port);
> bool intel_bios_is_dsi_present(struct drm_i915_private *dev_priv, enum port *port);
> bool intel_bios_get_dsc_params(struct intel_encoder *encoder,
> struct intel_crtc_state *crtc_state,
> int dsc_max_bpc);
> -bool intel_bios_port_supports_typec_usb(struct drm_i915_private *i915, enum port port);
> -bool intel_bios_port_supports_tbt(struct drm_i915_private *i915, enum port port);
>
> const struct intel_bios_encoder_data *
> intel_bios_encoder_data_lookup(struct drm_i915_private *i915, enum port port);
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915/bios: remove some unused leftover declarations
2023-12-26 15:09 ` Rodrigo Vivi
@ 2023-12-29 10:55 ` Jani Nikula
0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2023-12-29 10:55 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
On Tue, 26 Dec 2023, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Thu, Dec 21, 2023 at 12:54:14PM +0200, Jani Nikula wrote:
>> Remove some unused declarations probably left behind after some
>> refactoring.
>
> when you mention 'unused' I was wondering if we should move the
> local functions to 'static', but then I notice they are 'inexistent'.
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Thanks, pushed to din.
BR,
Jani.
>
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_bios.h | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/i915/display/intel_bios.h
>> index 49e24b7cf675..96673dc707e7 100644
>> --- a/drivers/gpu/drm/i915/display/intel_bios.h
>> +++ b/drivers/gpu/drm/i915/display/intel_bios.h
>> @@ -246,13 +246,10 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size);
>> bool intel_bios_is_tv_present(struct drm_i915_private *dev_priv);
>> bool intel_bios_is_lvds_present(struct drm_i915_private *dev_priv, u8 *i2c_pin);
>> bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port port);
>> -bool intel_bios_is_port_edp(struct drm_i915_private *dev_priv, enum port port);
>> bool intel_bios_is_dsi_present(struct drm_i915_private *dev_priv, enum port *port);
>> bool intel_bios_get_dsc_params(struct intel_encoder *encoder,
>> struct intel_crtc_state *crtc_state,
>> int dsc_max_bpc);
>> -bool intel_bios_port_supports_typec_usb(struct drm_i915_private *i915, enum port port);
>> -bool intel_bios_port_supports_tbt(struct drm_i915_private *i915, enum port port);
>>
>> const struct intel_bios_encoder_data *
>> intel_bios_encoder_data_lookup(struct drm_i915_private *i915, enum port port);
>> --
>> 2.39.2
>>
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-29 10:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-21 10:54 [PATCH] drm/i915/bios: remove some unused leftover declarations Jani Nikula
2023-12-21 10:54 ` Jani Nikula
2023-12-26 15:09 ` Rodrigo Vivi
2023-12-29 10:55 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).