From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E7CCC77B7F for ; Thu, 18 May 2023 01:50:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA38A10E4C8; Thu, 18 May 2023 01:50:23 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id C237810E4C8 for ; Thu, 18 May 2023 01:50:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684374621; x=1715910621; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=37GKhw2TEFjatfb/NHMvlkm89kkMsJ3WkkT6kzpLOsc=; b=P1BJsuEAuPoOkZgoprumY1ZdFXTQZnzzDLurA1eSiTC6ZZlYruxk+BDc wyeNp0v3tgXb1cbs3NhXUY8gXMfJ2c3EtN/D+ineE69twbZXWA0jEjlla uUTLOgmUMh79oz9RHMNWI5ZYtLnzEdTe+VG0gij+ZTWtbk7ZWGGt1UK3P WgpsbH7P4tb9+RhK4BRL99avkf4KmskOJS6eJGHON7o5DPqvyWYqQvd2E QwYkAJGXSIC8Ey4hlIkoGf/qECLsaFdXTpYNgkewMo0MtwTFIBATH06nI XYrhEuJxhiP3SpDecaaCzw+TnR7lyPZbo+cEx07sKi2ztZDeHhiT7Redz g==; X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="380136916" X-IronPort-AV: E=Sophos;i="5.99,283,1677571200"; d="scan'208";a="380136916" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2023 18:50:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="652455500" X-IronPort-AV: E=Sophos;i="5.99,283,1677571200"; d="scan'208";a="652455500" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.251.19.98]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2023 18:50:19 -0700 Date: Wed, 17 May 2023 18:49:51 -0700 Message-ID: <87bkii4dds.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa In-Reply-To: <20230517205542.3680895-7-umesh.nerlige.ramappa@intel.com> References: <20230517205542.3680895-1-umesh.nerlige.ramappa@intel.com> <20230517205542.3680895-7-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH v6 6/7] drm/i915/pmu: Prepare for multi-tile non-engine counters X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 17 May 2023 13:55:41 -0700, Umesh Nerlige Ramappa wrote: > > From: Tvrtko Ursulin > > Reserve some bits in the counter config namespace which will carry the > tile id and prepare the code to handle this. > > No per tile counters have been added yet. > > v2: > - Fix checkpatch issues > - Use 4 bits for gt id in non-engine counters. Drop FIXME. > - Set MAX GTs to 4. Drop FIXME. > > v3: (Ashutosh, Tvrtko) > - Drop BUG_ON that would never fire > - Make enable u64 > - Pull in some code from next patch > > v4: Set I915_PMU_MAX_GTS to 2 (Tvrtko) > > v5: s/u64/u32 where needed (Ashutosh) Reviewed-by: Ashutosh Dixit