From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27BB1C3DA7D for ; Thu, 5 Jan 2023 16:29:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 72B9410E752; Thu, 5 Jan 2023 16:29:31 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B43310E752 for ; Thu, 5 Jan 2023 16:29:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672936170; x=1704472170; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=SpTq4L+DjXU8TrjDKbCAPU4F7bSMrZjeRj2ruU/ZBoM=; b=nHhZTLP6RZ6LXudJ8XcSwpj4KIfFQmp9eXk9v75u+yMfA47zbLS8edDn U4vRufPW6xkNGs0/mtC9ox8IM6m1npN9eA5EnjSUp1UFCaVpCw9SHCdo4 I0rTrbPnE904SMxKpjw/W1tUbzNVLbe/cWhNmeHrUkSVZI1R3MdpqcL6v Exbr1oe+Jc6AVRadc+TphIYLTHU7u5snnwZ657yT9tp4bohEx2zHQ3FJP AWGYG0r/Cich5Lt8OJC7Hha/smyRSv1kvFh+xMI/DUxkpk/Ge76MxZglk LMHTSTmKQnLhHu1yY8ogSNKSm+AvimV1hduuhOmLNFRDk+XHwz9gumMbr w==; X-IronPort-AV: E=McAfee;i="6500,9779,10581"; a="408501597" X-IronPort-AV: E=Sophos;i="5.96,303,1665471600"; d="scan'208";a="408501597" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2023 08:29:29 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10581"; a="724122401" X-IronPort-AV: E=Sophos;i="5.96,303,1665471600"; d="scan'208";a="724122401" Received: from bramakri-mobl2.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.250.244]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2023 08:29:29 -0800 Date: Thu, 05 Jan 2023 08:29:26 -0800 Message-ID: <87bkndeyhl.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Nirmoy Das In-Reply-To: <20230105153831.28256-1-nirmoy.das@intel.com> References: <20230105153831.28256-1-nirmoy.das@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH] drm/i915: Update doc for __intel_wakeref_put() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, chris.p.wilson@intel.com, andrzej.hajda@intel.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 05 Jan 2023 07:38:31 -0800, Nirmoy Das wrote: > Hi Nirmoy, > Fix the __intel_wakeref_put() doc to reflect current behaviour. > > Fixes: c7302f204490 ("drm/i915: Defer final intel_wakeref_put to process context") Seems to be d91e657876a9? > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/i915/intel_wakeref.h | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_wakeref.h b/drivers/gpu/drm/i915/intel_wakeref.h > index 4f4c2e15e736..b5e1c61b5003 100644 > --- a/drivers/gpu/drm/i915/intel_wakeref.h > +++ b/drivers/gpu/drm/i915/intel_wakeref.h > @@ -135,14 +135,12 @@ intel_wakeref_might_get(struct intel_wakeref *wf) > * @flags: control flags > * > * Release our hold on the wakeref. When there are no more users, > - * the runtime pm wakeref will be released after the @fn callback is called > - * underneath the wakeref mutex. > + * the runtime pm wakeref will be released after the intel_wakeref_ops->put() > + * callback is called underneath the wakeref mutex. > * > - * Note that @fn is allowed to fail, in which case the runtime-pm wakeref > - * is retained and an error reported. > + * Note that intel_wakeref_ops->put() is allowed to fail, in which case the > + * runtime-pm wakeref is retained. @fn is used in multiple places in this file (including some 'get' usages) so maybe needs to be fixed there too. Maybe better to just say somewhere @fn refers to ops->get()/put() where applicable? > * > - * Returns: 0 if the wakeref was released successfully, or a negative error > - * code otherwise. So this seems to be the reason for the patch... > */ > static inline void > __intel_wakeref_put(struct intel_wakeref *wf, unsigned long flags) > -- > 2.38.0 > Thanks. -- Ashutosh