From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAEBBC32771 for ; Fri, 16 Sep 2022 01:08:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8562510E33F; Fri, 16 Sep 2022 01:08:07 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E66110E33F for ; Fri, 16 Sep 2022 01:08:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663290482; x=1694826482; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=S7QU0fcaLVTk5OXMK3JqfGmNinUhrjNEcHcP4p70Mks=; b=f7SH0jtwnv+ofV01zWNYRzbQKDFeU+hfy5IShoTv5jiQh0B46TaEtbZ4 rvezNwgrA34z/MrApfUWAimxALpy3RxtMW6fL/as+WJw/OIG5JithiQt8 D5+UzwNGfT8TLkHc8aGjyaXUakewywdIdgk++LRXjX18o4cIUGdRYowNv 3Nq+Zzn3TAM+rpPlq6SEbbKocd1dCDaOKZy6xMyPdHm7hHMMnUf1ysPV9 dX7x/S5giFiQllFKUuic3/z1V3v7Qcs0npaod3foViK1rxFuzFhpjMIkS q45QAAXcdo4Gg5O+EqluhPb8WlhUMaNd+d51a3jsNroqMN2/MYLsKSk+C Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10471"; a="296470527" X-IronPort-AV: E=Sophos;i="5.93,319,1654585200"; d="scan'208";a="296470527" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2022 18:08:02 -0700 X-IronPort-AV: E=Sophos;i="5.93,319,1654585200"; d="scan'208";a="619913634" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.41.22]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2022 18:08:01 -0700 Date: Thu, 15 Sep 2022 18:08:01 -0700 Message-ID: <87bkrg3z4e.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa In-Reply-To: <20220823204155.8178-14-umesh.nerlige.ramappa@intel.com> References: <20220823204155.8178-1-umesh.nerlige.ramappa@intel.com> <20220823204155.8178-14-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 13/19] drm/i915/perf: Add Wa_16010703925:dg2 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 23 Aug 2022 13:41:49 -0700, Umesh Nerlige Ramappa wrote: > > On DG2 A0, the OAR report format is buggy. Workaround is to not use it > for A0. For A0, remove the OAR format from the bitmask of supported > formats. Are we going to support A0 upstream? If we are this is: Reviewed-by: Ashutosh Dixit > > Signed-off-by: Umesh Nerlige Ramappa > --- > drivers/gpu/drm/i915/i915_perf.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c > index 167e7355980a..a28f07923d8f 100644 > --- a/drivers/gpu/drm/i915/i915_perf.c > +++ b/drivers/gpu/drm/i915/i915_perf.c > @@ -4741,6 +4741,11 @@ static void oa_init_supported_formats(struct i915_perf *perf) > default: > MISSING_CASE(platform); > } > + > + if (IS_DG2_GRAPHICS_STEP(i915, G10, STEP_A0, STEP_B0)) { > + /* Wa_16010703925:dg2 */ > + clear_bit(I915_OAR_FORMAT_A36u64_B8_C8, perf->format_mask); > + } > } > > static void i915_perf_init_info(struct drm_i915_private *i915) > -- > 2.25.1 >