From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD29AC433EF for ; Tue, 24 May 2022 01:36:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EAA2910E343; Tue, 24 May 2022 01:36:18 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 606CC10E343 for ; Tue, 24 May 2022 01:36:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653356177; x=1684892177; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=l4Z1+0UcYFEMAGWcSuo1aF2Bg/V1o2/EU3X8OOG2yvY=; b=R8ikWhyI56OT3HIxUVI+qRYPZEL8r9V8Hcb32ujXYeBgw95L2Fos8uNR nwo5HURMZhOPt1DXRhb/qq36vJRBx2UCmyF5l9nq2dd6HiDzVxEOMIS9x kPfEOvB7TdW9PGSj0iJzDKZnbfOeoAaE7WFNaA2B1twHzLqQ6kE9PeNsX ySpVRb08IzcCfW5J1hZXvVglx2C+xtGv4zObd7toqFLEzlUdswgd5D5T+ 4X8kH8ijobtzzRRSkuTT/PY1xkRbGV08Asw8l0bobx4+c2w/2cxJyNdcw pC7Vv9GReTuYwAF5BqFuRW/f72TeXR9pj8kTPQZ4GjWuoFs56gVubmlhz g==; X-IronPort-AV: E=McAfee;i="6400,9594,10356"; a="270977476" X-IronPort-AV: E=Sophos;i="5.91,247,1647327600"; d="scan'208";a="270977476" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2022 18:36:16 -0700 X-IronPort-AV: E=Sophos;i="5.91,247,1647327600"; d="scan'208";a="577681433" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.8.157]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2022 18:36:16 -0700 Date: Mon, 23 May 2022 18:36:16 -0700 Message-ID: <87bkvnvhin.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Badal Nilawar In-Reply-To: <20220523110841.1151431-1-badal.nilawar@intel.com> References: <20220523110841.1151431-1-badal.nilawar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 0/3] drm/i915: Add HWMON support X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 23 May 2022 04:08:38 -0700, Badal Nilawar wrote: > > This series adds the HWMON support for DG1, DG2 > > Dale B Stimson (2): > drm/i915/hwmon: Add HWMON power sensor support > drm/i915/hwmon: Add HWMON energy support I would suggest a slight reorganization of the series. I think the first patch should just add the HWMON infrastrusture into i915. Subsequent patches should add the various hwmon features exposed in sysfs, mostly one patch per feature. So at least for now I'd add a first patch adding the HWMON infra to i915. And follow on with the feature patches. Thanks. > Riana Tauro (1): > drm/i915/hwmon: Add HWMON current voltage support > > .../ABI/testing/sysfs-driver-intel-i915-hwmon | 43 ++ > drivers/gpu/drm/i915/Kconfig | 1 + > drivers/gpu/drm/i915/Makefile | 1 + > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 4 + > drivers/gpu/drm/i915/i915_driver.c | 5 + > drivers/gpu/drm/i915/i915_drv.h | 2 + > drivers/gpu/drm/i915/i915_hwmon.c | 620 ++++++++++++++++++ > drivers/gpu/drm/i915/i915_hwmon.h | 56 ++ > drivers/gpu/drm/i915/i915_reg.h | 15 + > drivers/gpu/drm/i915/intel_mchbar_regs.h | 11 + > 10 files changed, 758 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > create mode 100644 drivers/gpu/drm/i915/i915_hwmon.c > create mode 100644 drivers/gpu/drm/i915/i915_hwmon.h > > -- > 2.25.1 >