From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02952C433DB for ; Wed, 17 Feb 2021 10:56:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A6E764DEC for ; Wed, 17 Feb 2021 10:56:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A6E764DEC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC52D6E09C; Wed, 17 Feb 2021 10:56:41 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6159689C54 for ; Wed, 17 Feb 2021 10:56:40 +0000 (UTC) IronPort-SDR: PF/O44CZvc0ZKv9QHY/nZD1KJqRzM3H4SgXD22SxwjEH6jGV5xAlgoswCmAyELCaQ3kFaCBphc fLqXbw0xW1hA== X-IronPort-AV: E=McAfee;i="6000,8403,9897"; a="179654989" X-IronPort-AV: E=Sophos;i="5.81,184,1610438400"; d="scan'208";a="179654989" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2021 02:56:39 -0800 IronPort-SDR: /aOYE4UlPmGiqjJMGLJeLQhvaVEVzN0J0prPAZJzLlr1siHc+k6/trrmj6QlVYtWjWvTLLhFJv 48V19lECbFEg== X-IronPort-AV: E=Sophos;i="5.81,184,1610438400"; d="scan'208";a="399910882" Received: from mvalka-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.39.140]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2021 02:56:35 -0800 From: Jani Nikula To: Tomas Winkler , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Joonas Lahtinen , Rodrigo Vivi In-Reply-To: <20210216181925.650082-4-tomas.winkler@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210216181925.650082-1-tomas.winkler@intel.com> <20210216181925.650082-4-tomas.winkler@intel.com> Date: Wed, 17 Feb 2021 12:56:32 +0200 Message-ID: <87blcjarof.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [RFC PATCH 3/9] drm/i915/spi: add driver for on-die spi device X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexander Usyskin , intel-gfx@lists.freedesktop.org, Lucas De Marchi , linux-mtd@lists.infradead.org, Tomas Winkler , Vitaly Lubart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 16 Feb 2021, Tomas Winkler wrote: > Add the platform driver for i915 on-die spi device, exposed via mfd > framework. > > Cc: Rodrigo Vivi > Cc: Lucas De Marchi > Signed-off-by: Tomas Winkler > --- > drivers/gpu/drm/i915/Kconfig | 2 + > drivers/gpu/drm/i915/Makefile | 3 + > drivers/gpu/drm/i915/spi/intel_spi_drv.c | 116 +++++++++++++++++++++++ > 3 files changed, 121 insertions(+) > create mode 100644 drivers/gpu/drm/i915/spi/intel_spi_drv.c > > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig > index abcaa8da45ac..13c870e5878e 100644 > --- a/drivers/gpu/drm/i915/Kconfig > +++ b/drivers/gpu/drm/i915/Kconfig > @@ -27,6 +27,8 @@ config DRM_I915 > select CEC_CORE if CEC_NOTIFIER > select VMAP_PFN > select MFD_CORE > + select MTD Selecting MTD does not seem to be a popular thing to do, which is usually a clue it's probably the wrong thing to do. > + select MTD_PARTITIONED_MASTER > help > Choose this option if you have a system that has "Intel Graphics > Media Accelerator" or "HD Graphics" integrated graphics, > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > index 7fa9120feb8d..f209cd541eec 100644 > --- a/drivers/gpu/drm/i915/Makefile > +++ b/drivers/gpu/drm/i915/Makefile > @@ -299,6 +299,9 @@ endif > obj-$(CONFIG_DRM_I915) += i915.o > obj-$(CONFIG_DRM_I915_GVT_KVMGT) += gvt/kvmgt.o > > +obj-m += i915_spi.o And literally nobody does this. > +i915_spi-y := spi/intel_spi_drv.o Time to add a separate Kconfig and Makefile in spi/? BR, Jani. > + > # header test > > # exclude some broken headers from the test coverage > diff --git a/drivers/gpu/drm/i915/spi/intel_spi_drv.c b/drivers/gpu/drm/i915/spi/intel_spi_drv.c > new file mode 100644 > index 000000000000..23261f35b71f > --- /dev/null > +++ b/drivers/gpu/drm/i915/spi/intel_spi_drv.c > @@ -0,0 +1,116 @@ > +// SPDX-License-Identifier: MIT > +/* > + * Copyright(c) 2019-2021, Intel Corporation. All rights reserved. > + */ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Should this have "" instead of <>? > + > +struct i915_spi { > + void __iomem *base; > + size_t size; > + unsigned int nregions; > + struct { > + const char *name; > + u8 id; > + u64 offset; > + u64 size; > + } regions[]; > +}; > + > +static int i915_spi_probe(struct platform_device *platdev) > +{ > + struct resource *bar; > + struct device *device; > + struct i915_spi *spi; > + struct i915_spi_region *regions; > + unsigned int nregions; > + unsigned int i, n; > + size_t size; > + char *name; > + size_t name_size; > + > + device = &platdev->dev; > + > + regions = dev_get_platdata(&platdev->dev); > + if (!regions) { > + dev_err(device, "no regions defined\n"); > + return -ENODEV; > + } > + > + /* count available regions */ > + for (nregions = 0, i = 0; i < I915_SPI_REGIONS; i++) { > + if (regions[i].name) > + nregions++; > + } > + > + if (!nregions) { > + dev_err(device, "no regions defined\n"); > + return -ENODEV; > + } > + > + size = sizeof(*spi) + sizeof(spi->regions[0]) * nregions; > + spi = devm_kzalloc(device, size, GFP_KERNEL); > + if (!spi) > + return -ENOMEM; > + > + spi->nregions = nregions; > + for (n = 0, i = 0; i < I915_SPI_REGIONS; i++) { > + if (regions[i].name) { > + name_size = strlen(dev_name(&platdev->dev)) + > + strlen(regions[i].name) + 2; /* for point */ > + name = devm_kzalloc(device, name_size, GFP_KERNEL); > + if (!name) > + continue; > + snprintf(name, name_size, "%s.%s", > + dev_name(&platdev->dev), regions[i].name); > + spi->regions[n].name = name; > + spi->regions[n].id = i; > + n++; > + } > + } > + > + bar = platform_get_resource(platdev, IORESOURCE_MEM, 0); > + if (!bar) > + return -ENODEV; > + > + spi->base = devm_ioremap_resource(device, bar); > + if (IS_ERR(spi->base)) { > + dev_err(device, "mmio not mapped\n"); > + return PTR_ERR(spi->base); > + } > + > + platform_set_drvdata(platdev, spi); > + > + dev_dbg(device, "i915-spi is bound\n"); > + > + return 0; > +} > + > +static int i915_spi_remove(struct platform_device *platdev) > +{ > + platform_set_drvdata(platdev, NULL); > + > + return 0; > +} > + > +MODULE_ALIAS("platform:i915-spi"); > +static struct platform_driver i915_spi_driver = { > + .probe = i915_spi_probe, > + .remove = i915_spi_remove, > + .driver = { > + .name = "i915-spi", > + }, > +}; > + > +module_platform_driver(i915_spi_driver); > + > +MODULE_LICENSE("GPL and additional rights"); > +MODULE_AUTHOR("Intel Corporation"); > +MODULE_DESCRIPTION("Intel DGFX SPI driver"); -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx