From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F4D1C433E0 for ; Wed, 10 Feb 2021 10:50:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9124064E37 for ; Wed, 10 Feb 2021 10:50:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9124064E37 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 02E286EC4C; Wed, 10 Feb 2021 10:50:34 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 45A9A6EC4C for ; Wed, 10 Feb 2021 10:50:32 +0000 (UTC) IronPort-SDR: 23lyLuklRwM8i02gb5jtWZVp8NMkw9kXyO6eBGsl9HA4SETi22ugBz/0I7Bd3akmFe/iCPX5V4 +D1V+rXklEXw== X-IronPort-AV: E=McAfee;i="6000,8403,9890"; a="201153969" X-IronPort-AV: E=Sophos;i="5.81,168,1610438400"; d="scan'208";a="201153969" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2021 02:50:31 -0800 IronPort-SDR: y+vAiOEAkiy/4OX/PdN7hdZSOC7QZ9Jyvub8G37sjwAqsdtXdMGk0N8N2kawAf6e1Y0gqrPGeM CgEDD4ASxKPQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,168,1610438400"; d="scan'208";a="396661100" Received: from gaia.fi.intel.com ([10.237.72.192]) by orsmga008.jf.intel.com with ESMTP; 10 Feb 2021 02:50:29 -0800 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id A22905C1F81; Wed, 10 Feb 2021 12:50:18 +0200 (EET) From: Mika Kuoppala To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20210210102238.28779-2-chris@chris-wilson.co.uk> References: <20210210102238.28779-1-chris@chris-wilson.co.uk> <20210210102238.28779-2-chris@chris-wilson.co.uk> Date: Wed, 10 Feb 2021 12:50:18 +0200 Message-ID: <87blcsryc5.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Correct surface base address X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wilson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Chris Wilson writes: > The surface_state_base is an offset into the batch, so we need to pass > the correct batch address for STATE_BASE_ADDRESS. > > Fixes: 47f8253d2b89 ("drm/i915/gen7: Clear all EU/L3 residual contexts") > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Cc: Prathap Kumar Valsan > Cc: Akeem G Abodunrin Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/gen7_renderclear.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/gen7_renderclear.c b/drivers/gpu/drm/i915/gt/gen7_renderclear.c > index e403eb046a43..de575fdb033f 100644 > --- a/drivers/gpu/drm/i915/gt/gen7_renderclear.c > +++ b/drivers/gpu/drm/i915/gt/gen7_renderclear.c > @@ -240,7 +240,7 @@ gen7_emit_state_base_address(struct batch_chunk *batch, > /* general */ > *cs++ = batch_addr(batch) | BASE_ADDRESS_MODIFY; > /* surface */ > - *cs++ = batch_addr(batch) | surface_state_base | BASE_ADDRESS_MODIFY; > + *cs++ = (batch_addr(batch) + surface_state_base) | BASE_ADDRESS_MODIFY; > /* dynamic */ > *cs++ = batch_addr(batch) | BASE_ADDRESS_MODIFY; > /* indirect */ > -- > 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx