From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 2/2] drm: add fallback override/firmware EDID modes workaround Date: Mon, 10 Jun 2019 12:32:30 +0300 Message-ID: <87blz5zsy9.fsf@intel.com> References: <20190607110513.12072-1-jani.nikula@intel.com> <20190607110513.12072-2-jani.nikula@intel.com> <20190607151021.GJ21222@phenom.ffwll.local> <24d1a13799ae7e0331ff668d9b170c4920d7d762.camel@bonedaddy.net> <0667fc81810f2da5110c7da00963c93da90a6cd7.camel@bonedaddy.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <0667fc81810f2da5110c7da00963c93da90a6cd7.camel@bonedaddy.net> Sender: stable-owner@vger.kernel.org To: Paul Wise , Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Ilpo =?utf-8?Q?J=C3=A4rvinen?= , stable@vger.kernel.org, Daniel Vetter , Ville =?utf-8?B?U3lyasOkbMOk?= , Harish Chegondi List-Id: intel-gfx@lists.freedesktop.org On Sat, 08 Jun 2019, Paul Wise wrote: > On Sat, 2019-06-08 at 13:10 +0800, Paul Wise wrote: > >> I've tested these two patches on top of Linux v5.2-rc3 and the EDID >> override works correctly on an Intel Ironlake GPU with a monitor that >> lost its EDID a while ago. > > While testing I noticed a couple of things: > > While everything the GUI is the correct resolution, GNOME is unable to > identify the monitor vendor or model. This is a regression from the > previous edid override functionality. It looks like this is because the > edid file in /sys is not populated with the EDID override data. Right, I've added a call to drm_connector_update_edid_property() in v2 to address this issue. > I got a crash due to null pointer dereference at one point, I'll try to > track down when this happens. Can't think of why this would happen; the backtrace might offer clues. Thanks for testing! BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center