From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915/backlight: Fix backlight takeover on LPT Date: Fri, 23 Nov 2018 14:33:12 +0200 Message-ID: <87bm6gc6t3.fsf@intel.com> References: <20181120103926.10117-1-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC18D6E68A for ; Fri, 23 Nov 2018 12:32:45 +0000 (UTC) In-Reply-To: <20181120103926.10117-1-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst , intel-gfx@lists.freedesktop.org Cc: Hans de Goede , Basil Eric Rabi , Tolga Cakir List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyMCBOb3YgMjAxOCwgTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0 QGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gbHlueHBvaW50IHRoZSBiaW9zIHNvbWV0aW1l cyBzZXRzIHVwIHRoZSBiYWNrbGlnaHQgdXNpbmcgdGhlIENQVQo+IGRpc3BsYXksIGJ1dCB0aGUg ZHJpdmVyIGV4cGVjdHMgdXNpbmcgdGhlIFBXTSBQQ0ggb3ZlcnJpZGUgcmVnaXN0ZXIuCj4KPiBS ZWFkIHRoZSB2YWx1ZSBmcm9tIHRoZSBDUFUgcmVnaXN0ZXIsIHRoZW4gY29udmVydCBpdCB0byB0 aGUgb3RoZXIKPiB1bml0cyBieSBjb252ZXJ0aW5nIGZyb20gdGhlIG9sZCBkdXR5IGN5Y2xlLCB0 byBmcmVxLCB0byB0aGUgbmV3IHVuaXRzLgo+Cj4gVGhpcyB2YWx1ZSBpcyB0aGVuIHByb2dyYW1t ZWQgaW4gdGhlIG92ZXJyaWRlIHJlZ2lzdGVyLCBhZnRlciB3aGljaAo+IHdlIHNldCB0aGUgb3Zl cnJpZGUgYW5kIGRpc2FibGUgdGhlIENQVSBkaXNwbGF5IGNvbnRyb2wuIFRoaXMgYWxsb3dzCj4g dXMgdG8gc3dpdGNoIHRoZSBzb3VyY2Ugd2l0aG91dCBmbGlja2VyaW5nLCBhbmQgbWFrZSB0aGUg YmFja2xpZ2h0Cj4gY29udHJvbHMgd29yayBpbiB0aGUgZHJpdmVyLgo+Cj4gU2lnbmVkLW9mZi1i eTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4K PiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA4MjI1Cj4gQ2M6IEJhc2lsIEVyaWMgUmFiaSA8ZXJpY2Jhc2lsLnJhYmlAZ21haWwuY29tPgo+ IENjOiBIYW5zIGRlIEdvZWRlIDxqd3JkZWdvZWRlQGZlZG9yYXByb2plY3Qub3JnPgo+IENjOiBU b2xnYSBDYWtpciA8Y2V2ZWxuZXRAZ21haWwuY29tPgo+IFRlc3RlZC1ieTogVG9sZ2EgQ2FraXIg PGNldmVsbmV0QGdtYWlsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cGFuZWwuYyB8IDM0ICsrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLQo+ICAxIGZpbGUgY2hh bmdlZCwgMzEgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfcGFuZWwuYwo+IGluZGV4IGU2Y2Q3YjU1YzAxOC4uMzM1NzIzMmYxYjBlIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jCj4gQEAgLTE0ODUsNyArMTQ4NSw3IEBAIHN0YXRp YyBpbnQgbHB0X3NldHVwX2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0 b3IsIGVudW0gcGlwZSB1bnVzCj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYg PSB0b19pOTE1KGNvbm5lY3Rvci0+YmFzZS5kZXYpOwo+ICAJc3RydWN0IGludGVsX3BhbmVsICpw YW5lbCA9ICZjb25uZWN0b3ItPnBhbmVsOwo+ICAJdTMyIHBjaF9jdGwxLCBwY2hfY3RsMiwgdmFs Owo+IC0JYm9vbCBhbHQ7Cj4gKwlib29sIGFsdCwgY3B1X21vZGUgPSBmYWxzZTsKPiAgCj4gIAlp ZiAoSEFTX1BDSF9MUFQoZGV2X3ByaXYpKQo+ICAJCWFsdCA9IEk5MTVfUkVBRChTT1VUSF9DSElD S0VOMikgJiBMUFRfUFdNX0dSQU5VTEFSSVRZOwo+IEBAIC0xNTA3LDEyICsxNTA3LDQwIEBAIHN0 YXRpYyBpbnQgbHB0X3NldHVwX2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25u ZWN0b3IsIGVudW0gcGlwZSB1bnVzCj4gIAo+ICAJcGFuZWwtPmJhY2tsaWdodC5taW4gPSBnZXRf YmFja2xpZ2h0X21pbl92YnQoY29ubmVjdG9yKTsKPiAgCj4gLQl2YWwgPSBscHRfZ2V0X2JhY2ts aWdodChjb25uZWN0b3IpOwo+ICsJcGFuZWwtPmJhY2tsaWdodC5lbmFibGVkID0gcGNoX2N0bDEg JiBCTE1fUENIX1BXTV9FTkFCTEU7Cj4gKwlpZiAocGFuZWwtPmJhY2tsaWdodC5lbmFibGVkICYm IEhBU19QQ0hfTFBUKGRldl9wcml2KSAmJgo+ICsJICAgIChJOTE1X1JFQUQoQkxDX1BXTV9DUFVf Q1RMMikgJiBCTE1fUFdNX0VOQUJMRSkgJiYKPiArCSAgICAhV0FSTl9PTihwY2hfY3RsMSAmIEJM TV9QQ0hfT1ZFUlJJREVfRU5BQkxFKSkgewoKSSB0aGluayB0aGVyZSdzIHNvbWV0aGluZyB3cm9u ZyB3aXRoIHRoZSBjb25kaXRpb25zIGhlcmUsIGJ1dCBjYW4ndApxdWl0ZSB3cmFwIG15IGhlYWQg YXJvdW5kIGl0LgoKQXQgbGVhc3QgaXQgc2VlbXMgd3JvbmcgdG8gd2FybiBhYm91dCBvdmVycmlk ZSBlbmFibGUgaW4gdGhpcyBjYXNlLiBJZgpvdmVycmlkZSBpcyBzZXQsIGl0J2xsIGJlIHVzZWQu IFNvIHRoZSB3YXJuaW5nIHNob3VsZCByZWFsbHkgYmUgYWJvdXQKY3B1X2N0bDIgYmVpbmcgZW5h YmxlZCB3aGVuIGl0J3Mgbm90IHVzZWQuCgpQZXJoYXBzIHJlYWQgY3B1X2N0bDIgaW50byBhIHZh cmlhYmxlLCBhbmQgcmV1c2UgdGhhdCBhbHNvIGxhdGVyIGZvcgpkaXNhYmxlLgoKQlIsCkphbmku Cgo+ICsJCXUzMiBmcmVxOwo+ICsKPiArCQljcHVfbW9kZSA9IHRydWU7Cj4gKwkJLyoKPiArCQkg KiBXZSdyZSBpbiBjcHUgbW9kZSwgY29udmVydCB0byBQQ0ggdW5pdHMuCj4gKwkJICoKPiArCQkg KiBDb252ZXJ0IENQVSBwd20gdGljayBiYWNrIHRvIGh6LCBiYWNrIHRvIG5ldyBQQ0ggdW5pdHMg YWdhaW4uCj4gKwkJICogdGhpcyBpcyB0aGUgc2FtZSBmb3JtdWxhIGFzIHBjaF9oel90b19wd20s IGJ1dCB0aGUgb3RoZXIgd2F5Cj4gKwkJICogYXJvdW5kLi4KPiArCQkgKi8KPiArCQl2YWwgPSBw Y2hfZ2V0X2JhY2tsaWdodChjb25uZWN0b3IpOwo+ICsJCWZyZXEgPSBESVZfUk9VTkRfQ0xPU0VT VChLSHooZGV2X3ByaXYtPnJhd2Nsa19mcmVxKSwgdmFsICogMTI4KTsKPiArCj4gKwkJdmFsID0g bHB0X2h6X3RvX3B3bShjb25uZWN0b3IsIGZyZXEpOwo+ICsJfSBlbHNlCj4gKwkJdmFsID0gbHB0 X2dldF9iYWNrbGlnaHQoY29ubmVjdG9yKTsKPiAgCXZhbCA9IGludGVsX3BhbmVsX2NvbXB1dGVf YnJpZ2h0bmVzcyhjb25uZWN0b3IsIHZhbCk7Cj4gIAlwYW5lbC0+YmFja2xpZ2h0LmxldmVsID0g Y2xhbXAodmFsLCBwYW5lbC0+YmFja2xpZ2h0Lm1pbiwKPiAgCQkJCSAgICAgICBwYW5lbC0+YmFj a2xpZ2h0Lm1heCk7Cj4gIAo+IC0JcGFuZWwtPmJhY2tsaWdodC5lbmFibGVkID0gcGNoX2N0bDEg JiBCTE1fUENIX1BXTV9FTkFCTEU7Cj4gKwlpZiAoY3B1X21vZGUpIHsKPiArCQl1MzIgdG1wOwo+ ICsKPiArCQkvKiBVc2UgUFdNIG1vZGUsIGluc3RlYWQgb2YgY3B1IGNsb2NrICovCj4gKwkJbHB0 X3NldF9iYWNrbGlnaHQoY29ubmVjdG9yLT5iYXNlLnN0YXRlLCBwYW5lbC0+YmFja2xpZ2h0Lmxl dmVsKTsKPiArCQlJOTE1X1dSSVRFKEJMQ19QV01fUENIX0NUTDEsIHBjaF9jdGwxIHwgQkxNX1BD SF9PVkVSUklERV9FTkFCTEUpOwo+ICsKPiArCQl0bXAgPSBJOTE1X1JFQUQoQkxDX1BXTV9DUFVf Q1RMMik7Cj4gKwkJSTkxNV9XUklURShCTENfUFdNX0NQVV9DVEwyLCB0bXAgJiB+QkxNX1BXTV9F TkFCTEUpOwo+ICsJfQo+ICAKPiAgCXJldHVybiAwOwo+ICB9CgotLSAKSmFuaSBOaWt1bGEsIElu dGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK