From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/5] drm/i915: Clean up ADPA pipe select bits Date: Thu, 17 May 2018 12:31:59 +0300 Message-ID: <87bmdezkz4.fsf@intel.com> References: <20180514172423.9302-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 274256E2F9 for ; Thu, 17 May 2018 09:29:25 +0000 (UTC) In-Reply-To: <20180514172423.9302-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAxNCBNYXkgMjAxOCwgVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+IHdyb3RlOgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4KPiBDbGVhbiB1cCB0aGUgQURQQSBwaXBlIHNlbGVjdCBiaXRzLiBU byBtYWtlIHRoZSB3aG9sZSBzaXR1YXRpb24gYSBiaXQKPiBsZXNzIHVnbHkgd2UnbGwgc3RhcnQg dG8gc2hhcmUgdGhlIHNhbWUgY29kZSBiZXR3ZWVuIC5nZXRfaHdfc3RhdGUoKQo+IGFuZCB0aGUg cG9ydCBzdGF0ZSBhc3NlcnRzLgo+Cj4gdjI6IE9yZGVyIHRoZSBkZWZpbmVzIHNoaWZ0LG1hc2ss dmFsdWUgKEphbmkpCj4KPiBSZXZpZXdlZC1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGlu dGVsLmNvbT4KCll1cCwgdGhlIHNlcmllcyBsb29rcyBnb29kLgoKQlIsCkphbmkuCgo+IFNpZ25l ZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggICAgICB8IDExICsrKysr LS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3J0LmMgICAgIHwgNDAgKysrKysr KysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYyB8IDI0ICsrKysrLS0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgIHwgIDIgKysKPiAgNCBmaWxlcyBjaGFuZ2VkLCAzMyBp bnNlcnRpb25zKCspLCA0NCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X3JlZy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ IGluZGV4IGYxMWJiMjEzZWMwNy4uYWUzYzI2MjE2OTk2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3JlZy5oCj4gQEAgLTQxMzMsMTEgKzQxMzMsMTIgQEAgZW51bSB7Cj4gIAo+ICAjZGVmaW5lICAg QURQQV9EQUNfRU5BQkxFCSgxPDwzMSkKPiAgI2RlZmluZSAgIEFEUEFfREFDX0RJU0FCTEUJMAo+ IC0jZGVmaW5lICAgQURQQV9QSVBFX1NFTEVDVF9NQVNLCSgxPDwzMCkKPiAtI2RlZmluZSAgIEFE UEFfUElQRV9BX1NFTEVDVAkwCj4gLSNkZWZpbmUgICBBRFBBX1BJUEVfQl9TRUxFQ1QJKDE8PDMw KQo+IC0jZGVmaW5lICAgQURQQV9QSVBFX1NFTEVDVChwaXBlKSAoKHBpcGUpIDw8IDMwKQo+IC0v KiBDUFQgdXNlcyBiaXRzIDI5OjMwIGZvciBwY2ggdHJhbnNjb2RlciBzZWxlY3QgKi8KPiArI2Rl ZmluZSAgIEFEUEFfUElQRV9TRUxfU0hJRlQJCTMwCj4gKyNkZWZpbmUgICBBRFBBX1BJUEVfU0VM X01BU0sJCSgxPDwzMCkKPiArI2RlZmluZSAgIEFEUEFfUElQRV9TRUwocGlwZSkJCSgocGlwZSkg PDwgMzApCj4gKyNkZWZpbmUgICBBRFBBX1BJUEVfU0VMX1NISUZUX0NQVAkyOQo+ICsjZGVmaW5l ICAgQURQQV9QSVBFX1NFTF9NQVNLX0NQVAkoMzw8MjkpCj4gKyNkZWZpbmUgICBBRFBBX1BJUEVf U0VMX0NQVChwaXBlKQkoKHBpcGUpIDw8IDI5KQo+ICAjZGVmaW5lICAgQURQQV9DUlRfSE9UUExV R19NQVNLICAweDAzZmYwMDAwIC8qIGJpdCAyNS0xNiAqLwo+ICAjZGVmaW5lICAgQURQQV9DUlRf SE9UUExVR19NT05JVE9SX05PTkUgICgwPDwyNCkKPiAgI2RlZmluZSAgIEFEUEFfQ1JUX0hPVFBM VUdfTU9OSVRPUl9NQVNLICAoMzw8MjQpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2NydC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3J0LmMKPiBpbmRl eCBkZTBlMjIzMjJjNzYuLjIxMWQ2MDFjZDFiMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9jcnQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Ny dC5jCj4gQEAgLTYzLDMzICs2MywzNSBAQCBzdGF0aWMgc3RydWN0IGludGVsX2NydCAqaW50ZWxf YXR0YWNoZWRfY3J0KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IpCj4gIAlyZXR1cm4g aW50ZWxfZW5jb2Rlcl90b19jcnQoaW50ZWxfYXR0YWNoZWRfZW5jb2Rlcihjb25uZWN0b3IpKTsK PiAgfQo+ICAKPiArYm9vbCBpbnRlbF9jcnRfcG9ydF9lbmFibGVkKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiwKPiArCQkJICAgIGk5MTVfcmVnX3QgYWRwYV9yZWcsIGVudW0gcGlw ZSAqcGlwZSkKPiArewo+ICsJdTMyIHZhbDsKPiArCj4gKwl2YWwgPSBJOTE1X1JFQUQoYWRwYV9y ZWcpOwo+ICsKPiArCS8qIGFzc2VydHMgd2FudCB0byBrbm93IHRoZSBwaXBlIGV2ZW4gaWYgdGhl IHBvcnQgaXMgZGlzYWJsZWQgKi8KPiArCWlmIChIQVNfUENIX0NQVChkZXZfcHJpdikpCj4gKwkJ KnBpcGUgPSAodmFsICYgQURQQV9QSVBFX1NFTF9NQVNLX0NQVCkgPj4gQURQQV9QSVBFX1NFTF9T SElGVF9DUFQ7Cj4gKwllbHNlCj4gKwkJKnBpcGUgPSAodmFsICYgQURQQV9QSVBFX1NFTF9NQVNL KSA+PiBBRFBBX1BJUEVfU0VMX1NISUZUOwo+ICsKPiArCXJldHVybiB2YWwgJiBBRFBBX0RBQ19F TkFCTEU7Cj4gK30KPiArCj4gIHN0YXRpYyBib29sIGludGVsX2NydF9nZXRfaHdfc3RhdGUoc3Ry dWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAkJCQkgICBlbnVtIHBpcGUgKnBpcGUpCj4g IHsKPiAtCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBlbmNvZGVyLT5iYXNlLmRldjsKPiAtCXN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiArCXN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZW5jb2Rlci0+YmFzZS5kZXYp Owo+ICAJc3RydWN0IGludGVsX2NydCAqY3J0ID0gaW50ZWxfZW5jb2Rlcl90b19jcnQoZW5jb2Rl cik7Cj4gLQl1MzIgdG1wOwo+ICAJYm9vbCByZXQ7Cj4gIAo+ICAJaWYgKCFpbnRlbF9kaXNwbGF5 X3Bvd2VyX2dldF9pZl9lbmFibGVkKGRldl9wcml2LAo+ICAJCQkJCQllbmNvZGVyLT5wb3dlcl9k b21haW4pKQo+ICAJCXJldHVybiBmYWxzZTsKPiAgCj4gLQlyZXQgPSBmYWxzZTsKPiAtCj4gLQl0 bXAgPSBJOTE1X1JFQUQoY3J0LT5hZHBhX3JlZyk7Cj4gLQo+IC0JaWYgKCEodG1wICYgQURQQV9E QUNfRU5BQkxFKSkKPiAtCQlnb3RvIG91dDsKPiArCXJldCA9IGludGVsX2NydF9wb3J0X2VuYWJs ZWQoZGV2X3ByaXYsIGNydC0+YWRwYV9yZWcsIHBpcGUpOwo+ICAKPiAtCWlmIChIQVNfUENIX0NQ VChkZXZfcHJpdikpCj4gLQkJKnBpcGUgPSBQT1JUX1RPX1BJUEVfQ1BUKHRtcCk7Cj4gLQllbHNl Cj4gLQkJKnBpcGUgPSBQT1JUX1RPX1BJUEUodG1wKTsKPiAtCj4gLQlyZXQgPSB0cnVlOwo+IC1v dXQ6Cj4gIAlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJpdiwgZW5jb2Rlci0+cG93ZXJf ZG9tYWluKTsKPiAgCj4gIAlyZXR1cm4gcmV0Owo+IEBAIC0xNjgsMTEgKzE3MCw5IEBAIHN0YXRp YyB2b2lkIGludGVsX2NydF9zZXRfZHBtcyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwK PiAgCWlmIChIQVNfUENIX0xQVChkZXZfcHJpdikpCj4gIAkJOyAvKiBUaG9zZSBiaXRzIGRvbid0 IGV4aXN0IGhlcmUgKi8KPiAgCWVsc2UgaWYgKEhBU19QQ0hfQ1BUKGRldl9wcml2KSkKPiAtCQlh ZHBhIHw9IFBPUlRfVFJBTlNfU0VMX0NQVChjcnRjLT5waXBlKTsKPiAtCWVsc2UgaWYgKGNydGMt PnBpcGUgPT0gMCkKPiAtCQlhZHBhIHw9IEFEUEFfUElQRV9BX1NFTEVDVDsKPiArCQlhZHBhIHw9 IEFEUEFfUElQRV9TRUxfQ1BUKGNydGMtPnBpcGUpOwo+ICAJZWxzZQo+IC0JCWFkcGEgfD0gQURQ QV9QSVBFX0JfU0VMRUNUOwo+ICsJCWFkcGEgfD0gQURQQV9QSVBFX1NFTChjcnRjLT5waXBlKTsK PiAgCj4gIAlpZiAoIUhBU19QQ0hfU1BMSVQoZGV2X3ByaXYpKQo+ICAJCUk5MTVfV1JJVEUoQkNM UlBBVChjcnRjLT5waXBlKSwgMCk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ IGluZGV4IGFkNTg4ZDU2NDE5OC4uNmRhYThkOTdhMGFhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0xMzYwLDIxICsxMzYwLDYgQEAgc3RhdGljIGJvb2wgbHZk c19waXBlX2VuYWJsZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJcmV0 dXJuIHRydWU7Cj4gIH0KPiAgCj4gLXN0YXRpYyBib29sIGFkcGFfcGlwZV9lbmFibGVkKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAtCQkJICAgICAgZW51bSBwaXBlIHBpcGUs IHUzMiB2YWwpCj4gLXsKPiAtCWlmICgodmFsICYgQURQQV9EQUNfRU5BQkxFKSA9PSAwKQo+IC0J CXJldHVybiBmYWxzZTsKPiAtCWlmIChIQVNfUENIX0NQVChkZXZfcHJpdikpIHsKPiAtCQlpZiAo KHZhbCAmIFBPUlRfVFJBTlNfU0VMX01BU0spICE9IFBPUlRfVFJBTlNfU0VMX0NQVChwaXBlKSkK PiAtCQkJcmV0dXJuIGZhbHNlOwo+IC0JfSBlbHNlIHsKPiAtCQlpZiAoKHZhbCAmIEFEUEFfUElQ RV9TRUxFQ1RfTUFTSykgIT0gQURQQV9QSVBFX1NFTEVDVChwaXBlKSkKPiAtCQkJcmV0dXJuIGZh bHNlOwo+IC0JfQo+IC0JcmV0dXJuIHRydWU7Cj4gLX0KPiAtCj4gIHN0YXRpYyB2b2lkIGFzc2Vy dF9wY2hfZHBfZGlzYWJsZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJ CQkJICAgZW51bSBwaXBlIHBpcGUsIGk5MTVfcmVnX3QgcmVnLAo+ICAJCQkJICAgdTMyIHBvcnRf c2VsKQo+IEBAIC0xNDA1LDE2ICsxMzkwLDE3IEBAIHN0YXRpYyB2b2lkIGFzc2VydF9wY2hfaGRt aV9kaXNhYmxlZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIHN0YXRpYyB2 b2lkIGFzc2VydF9wY2hfcG9ydHNfZGlzYWJsZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2LAo+ICAJCQkJICAgICAgZW51bSBwaXBlIHBpcGUpCj4gIHsKPiArCWVudW0gcGlwZSBw b3J0X3BpcGU7Cj4gIAl1MzIgdmFsOwo+ICAKPiAgCWFzc2VydF9wY2hfZHBfZGlzYWJsZWQoZGV2 X3ByaXYsIHBpcGUsIFBDSF9EUF9CLCBUUkFOU19EUF9QT1JUX1NFTF9CKTsKPiAgCWFzc2VydF9w Y2hfZHBfZGlzYWJsZWQoZGV2X3ByaXYsIHBpcGUsIFBDSF9EUF9DLCBUUkFOU19EUF9QT1JUX1NF TF9DKTsKPiAgCWFzc2VydF9wY2hfZHBfZGlzYWJsZWQoZGV2X3ByaXYsIHBpcGUsIFBDSF9EUF9E LCBUUkFOU19EUF9QT1JUX1NFTF9EKTsKPiAgCj4gLQl2YWwgPSBJOTE1X1JFQUQoUENIX0FEUEEp Owo+IC0JSTkxNV9TVEFURV9XQVJOKGFkcGFfcGlwZV9lbmFibGVkKGRldl9wcml2LCBwaXBlLCB2 YWwpLAo+IC0JICAgICAiUENIIFZHQSBlbmFibGVkIG9uIHRyYW5zY29kZXIgJWMsIHNob3VsZCBi ZSBkaXNhYmxlZFxuIiwKPiAtCSAgICAgcGlwZV9uYW1lKHBpcGUpKTsKPiArCUk5MTVfU1RBVEVf V0FSTihpbnRlbF9jcnRfcG9ydF9lbmFibGVkKGRldl9wcml2LCBQQ0hfQURQQSwgJnBvcnRfcGlw ZSkgJiYKPiArCQkJcG9ydF9waXBlID09IHBpcGUsCj4gKwkJCSJQQ0ggVkdBIGVuYWJsZWQgb24g dHJhbnNjb2RlciAlYywgc2hvdWxkIGJlIGRpc2FibGVkXG4iLAo+ICsJCQlwaXBlX25hbWUocGlw ZSkpOwo+ICAKPiAgCXZhbCA9IEk5MTVfUkVBRChQQ0hfTFZEUyk7Cj4gIAlJOTE1X1NUQVRFX1dB Uk4obHZkc19waXBlX2VuYWJsZWQoZGV2X3ByaXYsIHBpcGUsIHZhbCksCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHJ2LmgKPiBpbmRleCBkN2RiY2ExYWFiZmYuLjQyMzc5NTA1MDk3MCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gQEAgLTEzNzcsNiArMTM3Nyw4IEBAIHZvaWQgZ2VuOV9l bmFibGVfZ3VjX2ludGVycnVwdHMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsK PiAgdm9pZCBnZW45X2Rpc2FibGVfZ3VjX2ludGVycnVwdHMoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2KTsKPiAgCj4gIC8qIGludGVsX2NydC5jICovCj4gK2Jvb2wgaW50ZWxfY3J0 X3BvcnRfZW5hYmxlZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gKwkJCSAg ICBpOTE1X3JlZ190IGFkcGFfcmVnLCBlbnVtIHBpcGUgKnBpcGUpOwo+ICB2b2lkIGludGVsX2Ny dF9pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4gIHZvaWQgaW50ZWxf Y3J0X3Jlc2V0KHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2Rlcik7CgotLSAKSmFuaSBOaWt1bGEs IEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=