Re: [PATCH v10] drm/i915/icl: Gen11 forcewake support

kbuild test robot
2018-02-03T20:27:02Z

[-- Attachment #1: Type: text/plain, Size: 7585 bytes --]

Hi Daniele,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20180202]
[cannot apply to v4.15]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Michel-Thierry/drm-i915-icl-Gen11-forcewake-support/20180204-034751
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-x019-201805 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All error/warnings (new ones prefixed by >>):

In file included from drivers/gpu/drm/i915/i915_drv.h:56:0,
from drivers/gpu/drm/i915/intel_uncore.c:24:
>> drivers/gpu/drm/i915/intel_uncore.c:903:12: error: 'GEN11_BSD_RING_BASE' undeclared here (not in a function); did you mean 'GEN6_BSD_RING_BASE'?
RING_TAIL(GEN11_BSD_RING_BASE), /* 0x1C0000 (base) */
^
drivers/gpu/drm/i915/i915_reg.h:123:47: note: in definition of macro '_MMIO'
#define _MMIO(r) ((const i915_reg_t){ .reg = (r) })
^
>> drivers/gpu/drm/i915/intel_uncore.c:903:2: note: in expansion of macro 'RING_TAIL'
RING_TAIL(GEN11_BSD_RING_BASE), /* 0x1C0000 (base) */
^~~~~~~~~
>> drivers/gpu/drm/i915/intel_uncore.c:904:12: error: 'GEN11_BSD2_RING_BASE' undeclared here (not in a function); did you mean 'GEN11_BSD_RING_BASE'?
RING_TAIL(GEN11_BSD2_RING_BASE), /* 0x1C4000 (base) */
^
drivers/gpu/drm/i915/i915_reg.h:123:47: note: in definition of macro '_MMIO'
#define _MMIO(r) ((const i915_reg_t){ .reg = (r) })
^
drivers/gpu/drm/i915/intel_uncore.c:904:2: note: in expansion of macro 'RING_TAIL'
RING_TAIL(GEN11_BSD2_RING_BASE), /* 0x1C4000 (base) */
^~~~~~~~~
>> drivers/gpu/drm/i915/intel_uncore.c:905:12: error: 'GEN11_VEBOX_RING_BASE' undeclared here (not in a function); did you mean 'GEN11_BSD_RING_BASE'?
RING_TAIL(GEN11_VEBOX_RING_BASE), /* 0x1C8000 (base) */
^
drivers/gpu/drm/i915/i915_reg.h:123:47: note: in definition of macro '_MMIO'
#define _MMIO(r) ((const i915_reg_t){ .reg = (r) })
^
drivers/gpu/drm/i915/intel_uncore.c:905:2: note: in expansion of macro 'RING_TAIL'
RING_TAIL(GEN11_VEBOX_RING_BASE), /* 0x1C8000 (base) */
^~~~~~~~~
>> drivers/gpu/drm/i915/intel_uncore.c:906:12: error: 'GEN11_BSD3_RING_BASE' undeclared here (not in a function); did you mean 'GEN11_BSD2_RING_BASE'?
RING_TAIL(GEN11_BSD3_RING_BASE), /* 0x1D0000 (base) */
^
drivers/gpu/drm/i915/i915_reg.h:123:47: note: in definition of macro '_MMIO'
#define _MMIO(r) ((const i915_reg_t){ .reg = (r) })
^
drivers/gpu/drm/i915/intel_uncore.c:906:2: note: in expansion of macro 'RING_TAIL'
RING_TAIL(GEN11_BSD3_RING_BASE), /* 0x1D0000 (base) */
^~~~~~~~~
>> drivers/gpu/drm/i915/intel_uncore.c:907:12: error: 'GEN11_BSD4_RING_BASE' undeclared here (not in a function); did you mean 'GEN11_BSD3_RING_BASE'?
RING_TAIL(GEN11_BSD4_RING_BASE), /* 0x1D4000 (base) */
^
drivers/gpu/drm/i915/i915_reg.h:123:47: note: in definition of macro '_MMIO'
#define _MMIO(r) ((const i915_reg_t){ .reg = (r) })
^
drivers/gpu/drm/i915/intel_uncore.c:907:2: note: in expansion of macro 'RING_TAIL'
RING_TAIL(GEN11_BSD4_RING_BASE), /* 0x1D4000 (base) */
^~~~~~~~~
>> drivers/gpu/drm/i915/intel_uncore.c:908:12: error: 'GEN11_VEBOX2_RING_BASE' undeclared here (not in a function); did you mean 'GEN11_VEBOX_RING_BASE'?
RING_TAIL(GEN11_VEBOX2_RING_BASE), /* 0x1D8000 (base) */
^
drivers/gpu/drm/i915/i915_reg.h:123:47: note: in definition of macro '_MMIO'
#define _MMIO(r) ((const i915_reg_t){ .reg = (r) })
^
drivers/gpu/drm/i915/intel_uncore.c:908:2: note: in expansion of macro 'RING_TAIL'
RING_TAIL(GEN11_VEBOX2_RING_BASE), /* 0x1D8000 (base) */
^~~~~~~~~
drivers/gpu/drm/i915/intel_uncore.c: In function 'intel_uncore_fw_domains_init':
>> drivers/gpu/drm/i915/intel_uncore.c:1382:19: error: 'I915_MAX_VCS' undeclared (first use in this function); did you mean 'I915_MAP_WC'?
for (i = 0; i < I915_MAX_VCS; i++) {
^~~~~~~~~~~~
I915_MAP_WC
drivers/gpu/drm/i915/intel_uncore.c:1382:19: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/gpu/drm/i915/intel_uncore.c:1382:17: warning: comparison between pointer and integer
for (i = 0; i < I915_MAX_VCS; i++) {
^
>> drivers/gpu/drm/i915/intel_uncore.c:1390:19: error: 'I915_MAX_VECS' undeclared (first use in this function); did you mean 'I915_MAX_VCS'?
for (i = 0; i < I915_MAX_VECS; i++) {
^~~~~~~~~~~~~
I915_MAX_VCS
drivers/gpu/drm/i915/intel_uncore.c:1390:17: warning: comparison between pointer and integer
for (i = 0; i < I915_MAX_VECS; i++) {
^
In file included from include/linux/kernel.h:11:0,
from include/asm-generic/bug.h:18,
from arch/x86/include/asm/bug.h:82,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/gfp.h:5,
from include/linux/slab.h:15,
from include/linux/io-mapping.h:22,
from drivers/gpu/drm/i915/i915_drv.h:36,
from drivers/gpu/drm/i915/intel_uncore.c:24:
>> drivers/gpu/drm/i915/intel_uncore.c:1391:30: error: implicit declaration of function '_VECS'; did you mean '_VCS'? [-Werror=implicit-function-declaration]
if (!HAS_ENGINE(dev_priv, _VECS(i)))
^
include/linux/bitops.h:7:28: note: in definition of macro 'BIT'
#define BIT(nr) (1UL << (nr))
^~
>> drivers/gpu/drm/i915/i915_drv.h:2723:35: note: in expansion of macro 'ENGINE_MASK'
(!!((dev_priv)->info.ring_mask & ENGINE_MASK(id)))
^~~~~~~~~~~
>> drivers/gpu/drm/i915/intel_uncore.c:1391:9: note: in expansion of macro 'HAS_ENGINE'
if (!HAS_ENGINE(dev_priv, _VECS(i)))
^~~~~~~~~~
cc1: some warnings being treated as errors

vim +903 drivers/gpu/drm/i915/intel_uncore.c

897
898 static const i915_reg_t gen11_shadowed_regs[] = {
899 RING_TAIL(RENDER_RING_BASE), /* 0x2000 (base) */
900 GEN6_RPNSWREQ, /* 0xA008 */
901 GEN6_RC_VIDEO_FREQ, /* 0xA00C */
902 RING_TAIL(BLT_RING_BASE), /* 0x22000 (base) */
> 903 RING_TAIL(GEN11_BSD_RING_BASE), /* 0x1C0000 (base) */
> 904 RING_TAIL(GEN11_BSD2_RING_BASE), /* 0x1C4000 (base) */
> 905 RING_TAIL(GEN11_VEBOX_RING_BASE), /* 0x1C8000 (base) */
> 906 RING_TAIL(GEN11_BSD3_RING_BASE), /* 0x1D0000 (base) */
> 907 RING_TAIL(GEN11_BSD4_RING_BASE), /* 0x1D4000 (base) */
> 908 RING_TAIL(GEN11_VEBOX2_RING_BASE), /* 0x1D8000 (base) */
909 /* TODO: Other registers are not yet used */
910 };
911

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32271 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]