From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Dave Airlie" <airlied@gmail.com>, "Noralf Trønnes" <noralf@tronnes.org>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/debugfs: Fix framebuffer debugfs file init
Date: Tue, 14 Nov 2017 12:11:55 +0200 [thread overview]
Message-ID: <87bmk58904.fsf@intel.com> (raw)
In-Reply-To: <CAPM=9txbwYYFi--OdduWq66O0Euc_de6qMDGDY92xFwYzmg27A@mail.gmail.com>
On Tue, 14 Nov 2017, Dave Airlie <airlied@gmail.com> wrote:
> On 14 November 2017 at 09:12, Noralf Trønnes <noralf@tronnes.org> wrote:
>> The introduction of: drm/framebuffer: Add framebuffer debugfs file
>> broke vgem. That patch assumed that all drivers had initialized the
>> dev->mode_config.fb_lock mutex which happens in drm_mode_config_init().
>> vgem doesn't need to call drm_mode_config_init().
>>
>> Fix this by only creating the framebuffer debugfs file for modesetting
>> drivers.
>>
>> Fixes: 45d58b40292b ("drm/framebuffer: Add framebuffer debugfs file")
>> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
>> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
>
> Reviewed-by: Dave Airlie <airlied@redhat.com>
>
> Can someone pushed this to drm-misc, I think it's blocking the intel CI ppl.
Pushed, thanks for the patch and review.
On the one hand, we badly need to have CI running on non-Intel drm core
patches too. On the other hand, I'm still not sure if we're producing
good enough results yet to expose to all of drm. The false negatives are
too frequent I fear.
BR,
Jani.
>
> Dave.
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-11-14 10:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 23:12 [PATCH] drm/debugfs: Fix framebuffer debugfs file init Noralf Trønnes
2017-11-13 23:42 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-11-14 7:45 ` [PATCH] " Dave Airlie
2017-11-14 10:11 ` Jani Nikula [this message]
2017-11-14 9:55 ` ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmk58904.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=noralf@tronnes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox