From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH 1/2] drm/i915/fbc: intel_fbc.crtc and
	intel_fbc.enabled are synonymous
Date: Mon, 30 Oct 2017 17:50:15 +0200
Message-ID: <87bmkofxe0.fsf@intel.com>
References: <20171027194240.11494-1-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id B48756E3C7
 for <intel-gfx@lists.freedesktop.org>; Mon, 30 Oct 2017 15:49:11 +0000 (UTC)
In-Reply-To: <20171027194240.11494-1-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCAyNyBPY3QgMjAxNywgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u
dWs+IHdyb3RlOgo+IFNsaWdodGx5IHJlZHVjZSB0aGUgY2hhbmNlIGZvciBjb25mdXNpb24gYnkg
b25seSBoYXZpbmcgb25lIHZhcmlhYmxlCj4gaW5zdGVhZCBvZiB0d28gdG8gdGVsbCB1cyB3aGVu
IGludGVsX2ZiYyBpcyBlbmFibGVkIG9uIGEgY3J0Yy4KCldvdWxkIGJlIGdyZWF0IHRvIGhhdmUg
YSBzaW1wbGUgY29tbWVudCB3aXRoaW4gc3RydWN0IGludGVsX2ZiYyBzdGF0aW5nCnRoaXMuCgpC
UiwKSmFuaS4KCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp
bHNvbi5jby51az4KPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+
IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IC0tLQo+ICBkcml2
ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICB8ICAxIC0KPiAgZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfZmJjLmMgfCAzMyArKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAg
MiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAyMSBkZWxldGlvbnMoLSkKPgo+IGRp
ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaTkxNV9kcnYuaAo+IGluZGV4IDYxYzE1NWNiZjlkNy4uYzBmOGExM2VjOTU3IDEw
MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gQEAgLTEwODMsNyArMTA4Myw2IEBAIHN0cnVj
dCBpbnRlbF9mYmMgewo+ICAKPiAgCWJvb2wgZmFsc2VfY29sb3I7Cj4gIAo+IC0JYm9vbCBlbmFi
bGVkOwo+ICAJYm9vbCBhY3RpdmU7Cj4gIAo+ICAJYm9vbCB1bmRlcnJ1bl9kZXRlY3RlZDsKPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJjLmMgYi9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF9mYmMuYwo+IGluZGV4IDFhMGY1ZTBjOGQxMC4uZjRjM2EzYjlhOGU2
IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiYy5jCj4gKysrIGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJjLmMKPiBAQCAtNDcyLDcgKzQ3Miw3IEBAIHN0
YXRpYyB2b2lkIGludGVsX2ZiY19zY2hlZHVsZV9hY3RpdmF0aW9uKHN0cnVjdCBpbnRlbF9jcnRj
ICpjcnRjKQo+ICAJc3RydWN0IGludGVsX2ZiY193b3JrICp3b3JrID0gJmZiYy0+d29yazsKPiAg
Cj4gIAlXQVJOX09OKCFtdXRleF9pc19sb2NrZWQoJmZiYy0+bG9jaykpOwo+IC0JaWYgKFdBUk5f
T04oIWZiYy0+ZW5hYmxlZCkpCj4gKwlpZiAoV0FSTl9PTihmYmMtPmNydGMgIT0gY3J0YykpCj4g
IAkJcmV0dXJuOwo+ICAKPiAgCWlmIChkcm1fY3J0Y192YmxhbmtfZ2V0KCZjcnRjLT5iYXNlKSkg
ewo+IEBAIC05MjcsNyArOTI3LDcgQEAgdm9pZCBpbnRlbF9mYmNfcHJlX3VwZGF0ZShzdHJ1Y3Qg
aW50ZWxfY3J0YyAqY3J0YywKPiAgCQlnb3RvIGRlYWN0aXZhdGU7Cj4gIAl9Cj4gIAo+IC0JaWYg
KCFmYmMtPmVuYWJsZWQgfHwgZmJjLT5jcnRjICE9IGNydGMpCj4gKwlpZiAoZmJjLT5jcnRjICE9
IGNydGMpCj4gIAkJZ290byB1bmxvY2s7Cj4gIAo+ICAJaW50ZWxfZmJjX3VwZGF0ZV9zdGF0ZV9j
YWNoZShjcnRjLCBjcnRjX3N0YXRlLCBwbGFuZV9zdGF0ZSk7Cj4gQEAgLTk0Niw3ICs5NDYsNyBA
QCBzdGF0aWMgdm9pZCBfX2ludGVsX2ZiY19wb3N0X3VwZGF0ZShzdHJ1Y3QgaW50ZWxfY3J0YyAq
Y3J0YykKPiAgCj4gIAlXQVJOX09OKCFtdXRleF9pc19sb2NrZWQoJmZiYy0+bG9jaykpOwo+ICAK
PiAtCWlmICghZmJjLT5lbmFibGVkIHx8IGZiYy0+Y3J0YyAhPSBjcnRjKQo+ICsJaWYgKGZiYy0+
Y3J0YyAhPSBjcnRjKQo+ICAJCXJldHVybjsKPiAgCj4gIAlpZiAoIWludGVsX2ZiY19jYW5fYWN0
aXZhdGUoY3J0YykpIHsKPiBAQCAtOTg2LDcgKzk4Niw3IEBAIHZvaWQgaW50ZWxfZmJjX3Bvc3Rf
dXBkYXRlKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ICAKPiAgc3RhdGljIHVuc2lnbmVkIGlu
dCBpbnRlbF9mYmNfZ2V0X2Zyb250YnVmZmVyX2JpdChzdHJ1Y3QgaW50ZWxfZmJjICpmYmMpCj4g
IHsKPiAtCWlmIChmYmMtPmVuYWJsZWQpCj4gKwlpZiAoZmJjLT5jcnRjKQo+ICAJCXJldHVybiB0
b19pbnRlbF9wbGFuZShmYmMtPmNydGMtPmJhc2UucHJpbWFyeSktPmZyb250YnVmZmVyX2JpdDsK
PiAgCWVsc2UKPiAgCQlyZXR1cm4gZmJjLT5wb3NzaWJsZV9mcmFtZWJ1ZmZlcl9iaXRzOwo+IEBA
IC0xMDA4LDcgKzEwMDgsNyBAQCB2b2lkIGludGVsX2ZiY19pbnZhbGlkYXRlKHN0cnVjdCBkcm1f
aTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCj4gIAlmYmMtPmJ1c3lfYml0cyB8PSBpbnRlbF9m
YmNfZ2V0X2Zyb250YnVmZmVyX2JpdChmYmMpICYgZnJvbnRidWZmZXJfYml0czsKPiAgCj4gLQlp
ZiAoZmJjLT5lbmFibGVkICYmIGZiYy0+YnVzeV9iaXRzKQo+ICsJaWYgKGZiYy0+Y3J0YyAmJiBm
YmMtPmJ1c3lfYml0cykKPiAgCQlpbnRlbF9mYmNfZGVhY3RpdmF0ZShkZXZfcHJpdik7Cj4gIAo+
ICAJbXV0ZXhfdW5sb2NrKCZmYmMtPmxvY2spOwo+IEBAIC0xMDI5LDcgKzEwMjksNyBAQCB2b2lk
IGludGVsX2ZiY19mbHVzaChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAlp
ZiAob3JpZ2luID09IE9SSUdJTl9HVFQgfHwgb3JpZ2luID09IE9SSUdJTl9GTElQKQo+ICAJCWdv
dG8gb3V0Owo+ICAKPiAtCWlmICghZmJjLT5idXN5X2JpdHMgJiYgZmJjLT5lbmFibGVkICYmCj4g
KwlpZiAoIWZiYy0+YnVzeV9iaXRzICYmIGZiYy0+Y3J0YyAmJgo+ICAJICAgIChmcm9udGJ1ZmZl
cl9iaXRzICYgaW50ZWxfZmJjX2dldF9mcm9udGJ1ZmZlcl9iaXQoZmJjKSkpIHsKPiAgCQlpZiAo
ZmJjLT5hY3RpdmUpCj4gIAkJCWludGVsX2ZiY19yZWNvbXByZXNzKGRldl9wcml2KTsKPiBAQCAt
MTEyOSwyMCArMTEyOSwxNyBAQCB2b2lkIGludGVsX2ZiY19lbmFibGUoc3RydWN0IGludGVsX2Ny
dGMgKmNydGMsCj4gIAo+ICAJbXV0ZXhfbG9jaygmZmJjLT5sb2NrKTsKPiAgCj4gLQlpZiAoZmJj
LT5lbmFibGVkKSB7Cj4gLQkJV0FSTl9PTihmYmMtPmNydGMgPT0gTlVMTCk7Cj4gLQkJaWYgKGZi
Yy0+Y3J0YyA9PSBjcnRjKSB7Cj4gLQkJCVdBUk5fT04oIWNydGNfc3RhdGUtPmVuYWJsZV9mYmMp
Owo+IC0JCQlXQVJOX09OKGZiYy0+YWN0aXZlKTsKPiAtCQl9Cj4gLQkJZ290byBvdXQ7Cj4gKwlp
ZiAoZmJjLT5jcnRjID09IGNydGMpIHsKPiArCQlXQVJOX09OKCFjcnRjX3N0YXRlLT5lbmFibGVf
ZmJjKTsKPiArCQlXQVJOX09OKGZiYy0+YWN0aXZlKTsKPiAgCX0KPiArCWlmIChmYmMtPmNydGMp
Cj4gKwkJZ290byBvdXQ7Cj4gIAo+ICAJaWYgKCFjcnRjX3N0YXRlLT5lbmFibGVfZmJjKQo+ICAJ
CWdvdG8gb3V0Owo+ICAKPiAgCVdBUk5fT04oZmJjLT5hY3RpdmUpOwo+IC0JV0FSTl9PTihmYmMt
PmNydGMgIT0gTlVMTCk7Cj4gIAo+ICAJaW50ZWxfZmJjX3VwZGF0ZV9zdGF0ZV9jYWNoZShjcnRj
LCBjcnRjX3N0YXRlLCBwbGFuZV9zdGF0ZSk7Cj4gIAlpZiAoaW50ZWxfZmJjX2FsbG9jX2NmYihj
cnRjKSkgewo+IEBAIC0xMTUzLDcgKzExNTAsNiBAQCB2b2lkIGludGVsX2ZiY19lbmFibGUoc3Ry
dWN0IGludGVsX2NydGMgKmNydGMsCj4gIAlEUk1fREVCVUdfS01TKCJFbmFibGluZyBGQkMgb24g
cGlwZSAlY1xuIiwgcGlwZV9uYW1lKGNydGMtPnBpcGUpKTsKPiAgCWZiYy0+bm9fZmJjX3JlYXNv
biA9ICJGQkMgZW5hYmxlZCBidXQgbm90IGFjdGl2ZSB5ZXRcbiI7Cj4gIAo+IC0JZmJjLT5lbmFi
bGVkID0gdHJ1ZTsKPiAgCWZiYy0+Y3J0YyA9IGNydGM7Cj4gIG91dDoKPiAgCW11dGV4X3VubG9j
aygmZmJjLT5sb2NrKTsKPiBAQCAtMTE3Miw3ICsxMTY4LDYgQEAgc3RhdGljIHZvaWQgX19pbnRl
bF9mYmNfZGlzYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAlzdHJ1
Y3QgaW50ZWxfY3J0YyAqY3J0YyA9IGZiYy0+Y3J0YzsKPiAgCj4gIAlXQVJOX09OKCFtdXRleF9p
c19sb2NrZWQoJmZiYy0+bG9jaykpOwo+IC0JV0FSTl9PTighZmJjLT5lbmFibGVkKTsKPiAgCVdB
Uk5fT04oZmJjLT5hY3RpdmUpOwo+ICAJV0FSTl9PTihjcnRjLT5hY3RpdmUpOwo+ICAKPiBAQCAt
MTE4MCw3ICsxMTc1LDYgQEAgc3RhdGljIHZvaWQgX19pbnRlbF9mYmNfZGlzYWJsZShzdHJ1Y3Qg
ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAo+ICAJX19pbnRlbF9mYmNfY2xlYW51cF9j
ZmIoZGV2X3ByaXYpOwo+ICAKPiAtCWZiYy0+ZW5hYmxlZCA9IGZhbHNlOwo+ICAJZmJjLT5jcnRj
ID0gTlVMTDsKPiAgfQo+ICAKPiBAQCAtMTIyMCw3ICsxMjE0LDcgQEAgdm9pZCBpbnRlbF9mYmNf
Z2xvYmFsX2Rpc2FibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJCXJl
dHVybjsKPiAgCj4gIAltdXRleF9sb2NrKCZmYmMtPmxvY2spOwo+IC0JaWYgKGZiYy0+ZW5hYmxl
ZCkKPiArCWlmIChmYmMtPmNydGMpCj4gIAkJX19pbnRlbF9mYmNfZGlzYWJsZShkZXZfcHJpdik7
Cj4gIAltdXRleF91bmxvY2soJmZiYy0+bG9jayk7Cj4gIAo+IEBAIC0xMjM2LDcgKzEyMzAsNyBA
QCBzdGF0aWMgdm9pZCBpbnRlbF9mYmNfdW5kZXJydW5fd29ya19mbihzdHJ1Y3Qgd29ya19zdHJ1
Y3QgKndvcmspCj4gIAltdXRleF9sb2NrKCZmYmMtPmxvY2spOwo+ICAKPiAgCS8qIE1heWJlIHdl
IHdlcmUgc2NoZWR1bGVkIHR3aWNlLiAqLwo+IC0JaWYgKGZiYy0+dW5kZXJydW5fZGV0ZWN0ZWQg
fHwgIWZiYy0+ZW5hYmxlZCkKPiArCWlmIChmYmMtPnVuZGVycnVuX2RldGVjdGVkIHx8ICFmYmMt
PmNydGMpCj4gIAkJZ290byBvdXQ7Cj4gIAo+ICAJRFJNX0RFQlVHX0tNUygiRGlzYWJsaW5nIEZC
QyBkdWUgdG8gRklGTyB1bmRlcnJ1bi5cbiIpOwo+IEBAIC0xMzUxLDcgKzEzNDUsNiBAQCB2b2lk
IGludGVsX2ZiY19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCUlO
SVRfV09SSygmZmJjLT53b3JrLndvcmssIGludGVsX2ZiY193b3JrX2ZuKTsKPiAgCUlOSVRfV09S
SygmZmJjLT51bmRlcnJ1bl93b3JrLCBpbnRlbF9mYmNfdW5kZXJydW5fd29ya19mbik7Cj4gIAlt
dXRleF9pbml0KCZmYmMtPmxvY2spOwo+IC0JZmJjLT5lbmFibGVkID0gZmFsc2U7Cj4gIAlmYmMt
PmFjdGl2ZSA9IGZhbHNlOwo+ICAJZmJjLT53b3JrLnNjaGVkdWxlZCA9IGZhbHNlOwoKLS0gCkph
bmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs
aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz
a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK