public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [dim PATCH] dim: use git ls-files file matching instead of grep
@ 2017-10-02  9:23 Jani Nikula
  2017-10-02  9:41 ` Joonas Lahtinen
  0 siblings, 1 reply; 3+ messages in thread
From: Jani Nikula @ 2017-10-02  9:23 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

Avoid extra pipelines for no good reason.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 dim | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dim b/dim
index 678f34d5f7bd..d2f165893161 100755
--- a/dim
+++ b/dim
@@ -602,7 +602,7 @@ function commit_rerere_cache
 			return 1
 		fi
 		git add ./*.patch >& /dev/null || true
-		for file  in $(git ls-files | grep ^rr-cache); do
+		for file  in $(git ls-files -- rr-cache); do
 			if ! git log --since="60 days ago" --name-only -- $file | grep $file &> /dev/null; then
 				git rm $file &> /dev/null || true
 			fi
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [dim PATCH] dim: use git ls-files file matching instead of grep
  2017-10-02  9:23 [dim PATCH] dim: use git ls-files file matching instead of grep Jani Nikula
@ 2017-10-02  9:41 ` Joonas Lahtinen
  2017-10-03  5:51   ` Jani Nikula
  0 siblings, 1 reply; 3+ messages in thread
From: Joonas Lahtinen @ 2017-10-02  9:41 UTC (permalink / raw)
  To: Jani Nikula, intel-gfx

On Mon, 2017-10-02 at 12:23 +0300, Jani Nikula wrote:
> Avoid extra pipelines for no good reason.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dim PATCH] dim: use git ls-files file matching instead of grep
  2017-10-02  9:41 ` Joonas Lahtinen
@ 2017-10-03  5:51   ` Jani Nikula
  0 siblings, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2017-10-03  5:51 UTC (permalink / raw)
  To: Joonas Lahtinen, intel-gfx

On Mon, 02 Oct 2017, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> On Mon, 2017-10-02 at 12:23 +0300, Jani Nikula wrote:
>> Avoid extra pipelines for no good reason.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Pushed, thanks.

Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-10-03  5:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-02  9:23 [dim PATCH] dim: use git ls-files file matching instead of grep Jani Nikula
2017-10-02  9:41 ` Joonas Lahtinen
2017-10-03  5:51   ` Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox