From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Dhinakaran Pandiyan <dhinakaran.pandiyan@gmail.com>,
intel-gfx@lists.freedesktop.org
Cc: Wayne Boyer <wayne.boyer@intel.com>,
Paulo Zanoni <paulo.r.zanoni@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v3 1/4] drm/i915/psr: Clean-up intel_enable_source_psr1()
Date: Fri, 14 Jul 2017 12:34:28 +0300 [thread overview]
Message-ID: <87bmonl5uj.fsf@nikula.org> (raw)
In-Reply-To: <149985393987.28319.1190106748589865284@mail.alporthouse.com>
On Wed, 12 Jul 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Dhinakaran Pandiyan (2017-07-12 09:47:25)
>> On Tuesday, July 11, 2017 3:19:53 PM PDT Jim Bride wrote:
>> > On SKL+ there is a bit in SRD_CTL that software is not supposed to
>> > modify, but we currently clobber that bit when we enable PSR. In
>> > order to preserve the value of that bit, go ahead and read SRD_CTL
>>
>> And which bit is that?
>
> I think we would all be happier with keeping the explicit construction
> (and a smaller patch) if we used
>
> val |= I915_READ(EDP_PSR_CTL) & EDP_PSR_CTL_RSVD_MASK;
Agreed. Avoid read-modify-write as much as possible.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-07-14 9:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 22:19 [PATCH v3 0/4] Kernel PSR Fix-ups Jim Bride
2017-07-11 22:19 ` [PATCH v3 1/4] drm/i915/psr: Clean-up intel_enable_source_psr1() Jim Bride
2017-07-12 8:47 ` Dhinakaran Pandiyan
2017-07-12 10:05 ` Chris Wilson
2017-07-14 9:34 ` Jani Nikula [this message]
2017-08-03 21:48 ` Jim Bride
2017-08-04 7:29 ` Jani Nikula
2017-08-07 15:55 ` Jim Bride
2017-08-07 17:17 ` Jim Bride
2017-07-11 22:19 ` [PATCH v3 2/4] drm/i915/psr: Account for sink CRC raciness on some panels Jim Bride
2017-07-11 23:37 ` Vivi, Rodrigo
2017-07-12 9:42 ` Dhinakaran Pandiyan
2017-07-14 9:46 ` Jani Nikula
2017-07-14 16:04 ` Jim Bride
2017-07-11 22:19 ` [PATCH v3 3/4] drm/i915/edp: Allow alternate fixed mode for eDP if available Jim Bride
2017-07-11 23:27 ` Chris Wilson
2017-07-12 19:59 ` Jim Bride
2017-07-11 22:19 ` [PATCH v3 4/4] drm/i915/edp: Be less aggressive about changing link config on eDP Jim Bride
2017-07-11 23:16 ` Chris Wilson
2017-07-12 21:36 ` Manasi Navare
2017-07-12 21:38 ` Chris Wilson
2017-07-12 21:53 ` Manasi Navare
2017-07-12 22:01 ` Jim Bride
2017-07-12 21:28 ` Manasi Navare
2017-07-11 22:48 ` ✗ Fi.CI.BAT: failure for Kernel PSR Fix-ups Patchwork
2017-07-18 21:34 ` [PATCH v4 1/4] drm/i915/psr: Clean-up intel_enable_source_psr1() Jim Bride
2017-07-18 21:34 ` [PATCH v4 2/4] drm/i915/psr: Account for sink CRC raciness on some panels Jim Bride
2017-08-03 18:07 ` Rodrigo Vivi
2017-08-04 18:38 ` Pandiyan, Dhinakaran
2017-08-07 15:58 ` Jim Bride
2017-07-18 21:34 ` [PATCH v4 3/4] drm/i915/edp: Be less aggressive about changing link config on eDP Jim Bride
2017-07-18 21:34 ` [PATCH v4 4/4] drm/i915/edp: Allow alternate fixed mode for eDP if available Jim Bride
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmonl5uj.fsf@nikula.org \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=dhinakaran.pandiyan@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=wayne.boyer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).