Re: [PATCH dim v2 1/2] dim: Add extract-tags command

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 16 Mar 2017, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Thu, Mar 16, 2017 at 09:40:05AM +0200, Jani Nikula wrote:
>> On Wed, 15 Mar 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > On Wed, Mar 15, 2017 at 05:09:04PM +0200, ville.syrjala@linux.intel.com wrote:
>> >> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> >> 
>> >> Add a command for extracting various tags (eg. Reviwed-by:) from
>> >> emails. You can give the comamnd a rangeish to add the tags from
>> >> the same email to multiple already applied patches.
>> >> 
>> >> The regexp used to pick up tags is purposefully quite broad. People
>> >> tend to typo these things, or add extra whitespace etc. However the
>> >> broad regexp does mean this occasionally picks up stuff that isn't
>> >> a tag. So manually amending the commit is probably a wise idea,
>> >> and so I simply decided to also leave a '--- extracted tags ---'
>> >> separator in the commit message just before the extracted tags,
>> >> which can be cleaned up manually when verifying that the tags look
>> >> correct.
>> >
>> > An example of typical use would be nice.
>> 
>> I believe you can pipe an email to 'dim extract-tags' or one of its
>> variants, and have the tags in the email applied to the commits in the
>> branch in question.
>
> Yes. My typical work flow with mutt is something like 'open patch mail ;
>  | dim apply... ; open reply mail with tag(s) ; | dim extract...'. 
> Or if someone has r-b'd an entire series I apply everything first,
> and then do 'dim extract... <remote>/drm-intel-next-queued..HEAD' to
> slap the tag(s) onto all the commits.

Pushed both patches (though I guess you could have yourself too). Please
update the dim.rst man page too.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx