From: Jani Nikula <jani.nikula@linux.intel.com>
To: Vidya Srinivas <vidya.srinivas@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 01/14] drm/i915: Check for platform specific GPIO config
Date: Mon, 09 Jan 2017 12:18:10 +0200 [thread overview]
Message-ID: <87bmvgfsf1.fsf@intel.com> (raw)
In-Reply-To: <1483953334-26168-1-git-send-email-vidya.srinivas@intel.com>
On Mon, 09 Jan 2017, Vidya Srinivas <vidya.srinivas@intel.com> wrote:
> From: Uma Shankar <uma.shankar@intel.com>
>
> Panel GPIO control should be done based on platform. Add a check
> to restrict VLV and CHT specific GPIO confirguration, so that
> they dont apply to other platforms.
There are no code paths that would have
dev_priv->vbt.dsi.config->pwm_blc == PPS_BLC_PMIC on platforms other
than VLV/CVH.
BR,
Jani.
>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
> index 16732e7..27d8f95 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -1560,7 +1560,8 @@ void intel_dsi_init(struct drm_i915_private *dev_priv)
> * In case of BYT with CRC PMIC, we need to use GPIO for
> * Panel control.
> */
> - if (dev_priv->vbt.dsi.config->pwm_blc == PPS_BLC_PMIC) {
> + if ((IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) &&
> + (dev_priv->vbt.dsi.config->pwm_blc == PPS_BLC_PMIC)) {
> intel_dsi->gpio_panel =
> gpiod_get(dev->dev, "panel", GPIOD_OUT_HIGH);
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-09 10:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 9:15 [PATCH 01/14] drm/i915: Check for platform specific GPIO config Vidya Srinivas
2017-01-09 10:18 ` Jani Nikula [this message]
2017-02-08 10:30 ` Srinivas, Vidya
2017-02-08 10:41 ` Jani Nikula
2017-02-08 10:58 ` Srinivas, Vidya
2017-02-08 11:11 ` Jani Nikula
-- strict thread matches above, loose matches on Subject: below --
2017-02-08 11:31 Shankar, Uma
2017-02-08 12:28 ` Jani Nikula
2017-02-09 8:34 ` Shankar, Uma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmvgfsf1.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vidya.srinivas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).