* [PATCH] tools/backlight_helper: #include "config.h"
@ 2016-12-07 5:14 Mike Frysinger
2016-12-07 9:51 ` Jani Nikula
2016-12-07 15:33 ` [PATCH xf86-video-intel v2] " Mike Frysinger
0 siblings, 2 replies; 4+ messages in thread
From: Mike Frysinger @ 2016-12-07 5:14 UTC (permalink / raw)
To: intel-gfx
From: Mike Gilbert <floppym@gentoo.org>
---
tools/backlight_helper.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/backlight_helper.c b/tools/backlight_helper.c
index a00f0d6bd8a2..aadb8fac92ba 100644
--- a/tools/backlight_helper.c
+++ b/tools/backlight_helper.c
@@ -1,3 +1,7 @@
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+
#include <stdio.h>
#include <string.h>
#include <stdarg.h>
--
2.11.0.rc2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/backlight_helper: #include "config.h"
2016-12-07 5:14 [PATCH] tools/backlight_helper: #include "config.h" Mike Frysinger
@ 2016-12-07 9:51 ` Jani Nikula
2016-12-07 15:33 ` [PATCH xf86-video-intel v2] " Mike Frysinger
1 sibling, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2016-12-07 9:51 UTC (permalink / raw)
To: Mike Frysinger, intel-gfx
On Wed, 07 Dec 2016, Mike Frysinger <vapier@gentoo.org> wrote:
> From: Mike Gilbert <floppym@gentoo.org>
>
Uh, which project is this for...?
The commit message could use a few words, and you'll need to add
Signed-off-by.
BR,
Jani.
> ---
> tools/backlight_helper.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/backlight_helper.c b/tools/backlight_helper.c
> index a00f0d6bd8a2..aadb8fac92ba 100644
> --- a/tools/backlight_helper.c
> +++ b/tools/backlight_helper.c
> @@ -1,3 +1,7 @@
> +#ifdef HAVE_CONFIG_H
> +#include "config.h"
> +#endif
> +
> #include <stdio.h>
> #include <string.h>
> #include <stdarg.h>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH xf86-video-intel v2] tools/backlight_helper: #include "config.h"
2016-12-07 5:14 [PATCH] tools/backlight_helper: #include "config.h" Mike Frysinger
2016-12-07 9:51 ` Jani Nikula
@ 2016-12-07 15:33 ` Mike Frysinger
2017-02-10 21:54 ` Chris Wilson
1 sibling, 1 reply; 4+ messages in thread
From: Mike Frysinger @ 2016-12-07 15:33 UTC (permalink / raw)
To: intel-gfx
From: Mike Gilbert <floppym@gentoo.org>
The file uses defines from config.h but never actually includes it.
Signed-off-by: Mike Gilbert <floppym@gentoo.org>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
tools/backlight_helper.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/backlight_helper.c b/tools/backlight_helper.c
index a00f0d6bd8a2..aadb8fac92ba 100644
--- a/tools/backlight_helper.c
+++ b/tools/backlight_helper.c
@@ -1,3 +1,7 @@
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+
#include <stdio.h>
#include <string.h>
#include <stdarg.h>
--
2.11.0.rc2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH xf86-video-intel v2] tools/backlight_helper: #include "config.h"
2016-12-07 15:33 ` [PATCH xf86-video-intel v2] " Mike Frysinger
@ 2017-02-10 21:54 ` Chris Wilson
0 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2017-02-10 21:54 UTC (permalink / raw)
To: Mike Frysinger; +Cc: intel-gfx
On Wed, Dec 07, 2016 at 10:33:34AM -0500, Mike Frysinger wrote:
> From: Mike Gilbert <floppym@gentoo.org>
>
> The file uses defines from config.h but never actually includes it.
>
> Signed-off-by: Mike Gilbert <floppym@gentoo.org>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
To ssh://git.freedesktop.org/git/xorg/driver/xf86-video-intel
e4fe79cf..93942b7d HEAD -> master
Thanks,
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-10 21:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-07 5:14 [PATCH] tools/backlight_helper: #include "config.h" Mike Frysinger
2016-12-07 9:51 ` Jani Nikula
2016-12-07 15:33 ` [PATCH xf86-video-intel v2] " Mike Frysinger
2017-02-10 21:54 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox