From: Jani Nikula <jani.nikula@linux.intel.com>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Don't use crtc->config when reading out infoframe state
Date: Fri, 27 Nov 2015 10:41:09 +0200 [thread overview]
Message-ID: <87bnaf7s2i.fsf@intel.com> (raw)
In-Reply-To: <1448555227-31403-1-git-send-email-ville.syrjala@linux.intel.com>
Not strictly related to this patch.
On Thu, 26 Nov 2015, ville.syrjala@linux.intel.com wrote:
> The .get_config() hooks should not reference anything in crtc->config,
> everything should be based on the passed in pipe_config instead.
This is the kind of authoritative comment that I would appreciate seeing
in the kernel-doc for the hooks in struct intel_encoder. We have
practically nothing of the sort. We still seem to rely more on oral
tradition than actual documentation. (Not that there's anything wrong
with oral tradition per se, it's just that we don't regularly sit around
campfires reciting encoder hook rules or make folk songs about them.)
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-27 8:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 16:27 [PATCH] drm/i915: Don't use crtc->config when reading out infoframe state ville.syrjala
2015-11-27 8:41 ` Jani Nikula [this message]
2015-11-30 8:26 ` Daniel Vetter
2015-12-01 14:09 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnaf7s2i.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox