From: "Bjørn Mork" <bjorn@mork.no>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: Still time for v4.2? - c0165304e10f ("drm/i915: Only enable cursor if it can be enabled.")
Date: Tue, 25 Aug 2015 12:41:48 +0200 [thread overview]
Message-ID: <87bndvabv7.fsf@nemi.mork.no> (raw)
In-Reply-To: <55DC3F78.5010404@linux.intel.com> (Maarten Lankhorst's message of "Tue, 25 Aug 2015 12:12:08 +0200")
Maarten Lankhorst <maarten.lankhorst@linux.intel.com> writes:
> Hey,
>
> Op 25-08-15 om 09:45 schreef Bjørn Mork:
>> Hello, I see that I consistently get the warning below on v4.2-rc8. I
>> believe you already fixed this a long time ago by commit c0165304e10f
>> ("drm/i915: Only enable cursor if it can be enabled."), which I assume is
>> a stable candidate for v4.2.y.
>>
>> But wouldn't it look better if you managed to squeeze this into v4.2?
>> The warning will probably cause a few unnecessary worries and reports
>> from users...
>>
>> Sample WARNING from v4.2-rc8, minus the irrelevant list of modules:
>> ------------[ cut here ]------------
>> WARNING: CPU: 1 PID: 2675 at drivers/gpu/drm/i915/intel_display.c:9669 intel_crtc_update_cursor+0x335/0x452 [i915]()
>> Missing switch case (0) in i9xx_update_cursor
>> CPU: 1 PID: 2675 Comm: Xorg Tainted: G W 4.2.0-rc8 #339
>> Hardware name: LENOVO 2776LEG/2776LEG, BIOS 6EET55WW (3.15 ) 12/19/2011
>> 0000000000000009 ffff88022ca07b68 ffffffff81423887 0000000000000006
>> ffff88022ca07bb8 ffff88022ca07ba8 ffffffff8104a9d6 0000000000070088
>> ffffffffa036b141 ffff8802317c9000 000000000053e000 ffff880231790000
> What are you doing that triggers this? Works for me on v4.2..
That's a really good question. I saw the warnings a couple of times
after resuming from suspend (S3) and made a too hasty assumption that
resuming would always trigger it.
But now that I'm trying to provoke it, I cannot reproduce it whatever I
do...
FWIW, my suspend scripts run "xscreensaver-command -lock" to make sure
the screen is at least locked if someone else should wake the PC, and
xscreensaver is set up to blank and power off the screen. I don't know
if this affects the results.
Bjørn
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-08-25 10:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 7:45 Still time for v4.2? - c0165304e10f ("drm/i915: Only enable cursor if it can be enabled.") Bjørn Mork
2015-08-25 10:12 ` Maarten Lankhorst
2015-08-25 10:41 ` Bjørn Mork [this message]
2015-09-08 7:31 ` Bjørn Mork
2015-09-08 8:44 ` Maarten Lankhorst
2015-09-08 8:50 ` Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bndvabv7.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox