From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Dave Gordon" <david.s.gordon@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Minu Mathai" <minu.mathai@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Correcting the reg definitions for PORT_DFT
Date: Wed, 10 Jun 2015 15:50:32 +0300 [thread overview]
Message-ID: <87bngn7mnb.fsf@intel.com> (raw)
In-Reply-To: <55782D3C.2050901@intel.com>
On Wed, 10 Jun 2015, Dave Gordon <david.s.gordon@intel.com> wrote:
> But since INTEL_INFO() can take 'dev_priv' as a parameter (as an
> alternative to 'dev'), all the uses of 'dev' here could be replaced by
> 'dev_priv' and then the parameter changed to pass that directly, thus
> potentially eliminating quite a few extra memory references. Applied
> driver-wide, that micro-optimisation might add up to something useful :)
I think we haven't done that driver-wide because it would be more
disruptive than beneficial, but we're slowly moving at that direction
whenever we change stuff. And this is exactly the reason why Chris
hacked INTEL_INFO et al. to accept either dev or dev_priv.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-06-10 12:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 13:00 [PATCH] drm/i915: Correcting the reg definitions for PORT_DFT Minu Mathai
2015-06-05 13:08 ` Ville Syrjälä
2015-06-08 13:23 ` Mathai, Minu
2015-06-08 13:48 ` Jani Nikula
2015-06-09 12:06 ` Mathai, Minu
2015-06-09 12:16 ` Ville Syrjälä
2015-06-09 13:32 ` Mathai, Minu
2015-06-09 15:01 ` Dave Gordon
2015-06-09 15:24 ` Ville Syrjälä
2015-06-10 8:09 ` Jani Nikula
2015-06-10 12:27 ` Dave Gordon
2015-06-10 12:50 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bngn7mnb.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=minu.mathai@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox