From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 09/17] drm/i915: Don't use atomics for pg_dirty_rings Date: Fri, 17 Apr 2015 19:39:20 +0300 Message-ID: <87bnim1zgn.fsf@gaia.fi.intel.com> References: <1429025727-15380-1-git-send-email-daniel.vetter@ffwll.ch> <1429025727-15380-10-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id BCD606E440 for ; Fri, 17 Apr 2015 09:39:30 -0700 (PDT) In-Reply-To: <1429025727-15380-10-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Intel Graphics Development Cc: Daniel Vetter , Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org RGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4gd3JpdGVzOgoKPiBJdCdzIGFs cmVhZHkgcHJvdGVjdGVkIGJ5IHRoZSBia2xeV2Rldi0+c3RydWN0X211dGV4LiBXaGlsZSBhdCBp dAo+IHJlYWxpZ24gc29tZSByZWxhdGVkIGNvZGUuCj4KPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwg VmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KClJldmlld2VkLWJ5OiBNaWthIEt1b3Bw YWxhIDxtaWthLmt1b3BwYWxhQGludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtX2NvbnRleHQuYyAgICB8IDE2ICsrKysrKysrLS0tLS0tLS0KPiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jIHwgIDUgKystLS0KPiAgMiBmaWxl cyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250ZXh0LmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbV9jb250ZXh0LmMKPiBpbmRleCA2YjA5NjJkYjJjZjcuLjVhNDdl YjVlM2M1ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250 ZXh0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250ZXh0LmMKPiBA QCAtNTc4LDExICs1NzgsOSBAQCBzdGF0aWMgaW5saW5lIGJvb2wgc2hvdWxkX3NraXBfc3dpdGNo KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcsCj4gIAlpZiAodG8tPnJlbWFwX3NsaWNlKQo+ ICAJCXJldHVybiBmYWxzZTsKPiAgCj4gLQlpZiAodG8tPnBwZ3R0KSB7Cj4gLQkJaWYgKGZyb20g PT0gdG8gJiYgIXRlc3RfYml0KHJpbmctPmlkLAo+IC0JCQkJJnRvLT5wcGd0dC0+cGRfZGlydHlf cmluZ3MpKQo+IC0JCQlyZXR1cm4gdHJ1ZTsKPiAtCX0KPiArCWlmICh0by0+cHBndHQgJiYgZnJv bSA9PSB0byAmJgo+ICsJICAgICEoaW50ZWxfcmluZ19mbGFnKHJpbmcpICYgdG8tPnBwZ3R0LT5w ZF9kaXJ0eV9yaW5ncykpCj4gKwkJcmV0dXJuIHRydWU7Cj4gIAo+ICAJcmV0dXJuIGZhbHNlOwo+ ICB9Cj4gQEAgLTY2OCw3ICs2NjYsNyBAQCBzdGF0aWMgaW50IGRvX3N3aXRjaChzdHJ1Y3QgaW50 ZWxfZW5naW5lX2NzICpyaW5nLAo+ICAJCQlnb3RvIHVucGluX291dDsKPiAgCj4gIAkJLyogRG9p bmcgYSBQRCBsb2FkIGFsd2F5cyByZWxvYWRzIHRoZSBwYWdlIGRpcnMgKi8KPiAtCQljbGVhcl9i aXQocmluZy0+aWQsICZ0by0+cHBndHQtPnBkX2RpcnR5X3JpbmdzKTsKPiArCQl0by0+cHBndHQt PnBkX2RpcnR5X3JpbmdzICY9IH5pbnRlbF9yaW5nX2ZsYWcocmluZyk7Cj4gIAl9Cj4gIAo+ICAJ aWYgKHJpbmcgIT0gJmRldl9wcml2LT5yaW5nW1JDU10pIHsKPiBAQCAtNjk2LDEyICs2OTQsMTQg QEAgc3RhdGljIGludCBkb19zd2l0Y2goc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZywKPiAg CQkgKiBzcGFjZS4gVGhpcyBtZWFucyB3ZSBtdXN0IGVuZm9yY2UgdGhhdCBhIHBhZ2UgdGFibGUg bG9hZAo+ICAJCSAqIG9jY3VyIHdoZW4gdGhpcyBvY2N1cnMuICovCj4gIAl9IGVsc2UgaWYgKHRv LT5wcGd0dCAmJgo+IC0JCQl0ZXN0X2FuZF9jbGVhcl9iaXQocmluZy0+aWQsICZ0by0+cHBndHQt PnBkX2RpcnR5X3JpbmdzKSkKPiArCQkgICAoaW50ZWxfcmluZ19mbGFnKHJpbmcpICYgdG8tPnBw Z3R0LT5wZF9kaXJ0eV9yaW5ncykpIHsKPiAgCQlod19mbGFncyB8PSBNSV9GT1JDRV9SRVNUT1JF Owo+ICsJCXRvLT5wcGd0dC0+cGRfZGlydHlfcmluZ3MgJj0gfmludGVsX3JpbmdfZmxhZyhyaW5n KTsKPiArCX0KPiAgCj4gIAkvKiBXZSBzaG91bGQgbmV2ZXIgZW1pdCBzd2l0Y2hfbW0gbW9yZSB0 aGFuIG9uY2UgKi8KPiAgCVdBUk5fT04obmVlZHNfcGRfbG9hZF9wcmUocmluZywgdG8pICYmCj4g LQkJCW5lZWRzX3BkX2xvYWRfcG9zdChyaW5nLCB0bywgaHdfZmxhZ3MpKTsKPiArCQluZWVkc19w ZF9sb2FkX3Bvc3QocmluZywgdG8sIGh3X2ZsYWdzKSk7Cj4gIAo+ICAJcmV0ID0gbWlfc2V0X2Nv bnRleHQocmluZywgdG8sIGh3X2ZsYWdzKTsKPiAgCWlmIChyZXQpCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYwo+IGluZGV4IDFkNWJhZGYxYjg4Ny4uMGIwNmM2 ZGUyN2RlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNi dWZmZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIu Ywo+IEBAIC0xMjQ3LDkgKzEyNDcsOCBAQCBpOTE1X2dlbV9yaW5nYnVmZmVyX3N1Ym1pc3Npb24o c3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRybV9maWxlICpmaWxlLAo+ICAJaWYgKHJl dCkKPiAgCQlnb3RvIGVycm9yOwo+ICAKPiAtCWlmIChjdHgtPnBwZ3R0KQo+IC0JCVdBUk4oY3R4 LT5wcGd0dC0+cGRfZGlydHlfcmluZ3MgJiAoMTw8cmluZy0+aWQpLAo+IC0JCQkiJXMgZGlkbid0 IGNsZWFyIHJlbG9hZFxuIiwgcmluZy0+bmFtZSk7Cj4gKwlXQVJOKGN0eC0+cHBndHQgJiYgY3R4 LT5wcGd0dC0+cGRfZGlydHlfcmluZ3MgJiAoMTw8cmluZy0+aWQpLAo+ICsJICAgICAiJXMgZGlk bid0IGNsZWFyIHJlbG9hZFxuIiwgcmluZy0+bmFtZSk7Cj4gIAo+ICAJaW5zdHBfbW9kZSA9IGFy Z3MtPmZsYWdzICYgSTkxNV9FWEVDX0NPTlNUQU5UU19NQVNLOwo+ICAJaW5zdHBfbWFzayA9IEk5 MTVfRVhFQ19DT05TVEFOVFNfTUFTSzsKPiAtLSAKPiAyLjEuMAo+Cj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0 Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK