From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org, stable@vger.kernel.org,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH] drm/i915: Make WAIT_IOCTL negative timeouts be indefinite again
Date: Tue, 10 Mar 2015 12:00:38 +0200 [thread overview]
Message-ID: <87bnk1rx2x.fsf@intel.com> (raw)
In-Reply-To: <20150309095729.GC23680@nuc-i3427.alporthouse.com>
On Mon, 09 Mar 2015, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Fri, Mar 06, 2015 at 05:48:26PM +0100, Daniel Vetter wrote:
>> On Fri, Mar 06, 2015 at 08:54:35AM +0000, Chris Wilson wrote:
>> > On Thu, Mar 05, 2015 at 01:27:43PM +0100, Daniel Vetter wrote:
>> > > On Wed, Mar 04, 2015 at 06:09:26PM +0000, Chris Wilson wrote:
>> > > > This fixes a regression from
>> > > >
>> > > > commit 5ed0bdf21a85d78e04f89f15ccf227562177cbd9
>> > > > Author: Thomas Gleixner <tglx@linutronix.de>
>> > > > Date: Wed Jul 16 21:05:06 2014 +0000
>> > > >
>> > > > drm: i915: Use nsec based interfaces
>> > > >
>> > > > that made a negative timeout return immediately rather than the
>> > > > previously defined behaviour of waiting indefinitely.
>> > > >
>> > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> > > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> > > > Cc: Ben Widawsky <benjamin.widawsky@intel.com>
>> > > > Cc: Kristian Høgsberg <krh@bitplanet.net>
>> > > > Cc: stable@vger.kernel.org
>> > >
>> > > Do you have the igt for this too? I think an wait while the buffer should
>> > > be busy with a negative timeout is all that's needed to exercise this.
>> >
>> > Done.
>> > Testcase: igt/gem_wait
>>
>> Thanks a lot.
>>
>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89494
Pushed to drm-intel-fixes, thanks for the patch and review.
BR,
Jani.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-03-10 9:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 18:09 [PATCH] drm/i915: Make WAIT_IOCTL negative timeouts be indefinite again Chris Wilson
2015-03-05 1:25 ` shuang.he
2015-03-05 12:27 ` Daniel Vetter
2015-03-06 8:54 ` Chris Wilson
2015-03-06 16:48 ` Daniel Vetter
2015-03-09 9:57 ` Chris Wilson
2015-03-10 10:00 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnk1rx2x.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=benjamin.widawsky@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox