Re: [PATCH] drm/i915: Make WAIT_IOCTL negative timeouts be indefinite again

Jani Nikula
2015-03-10T09:59:13Z

On Mon, 09 Mar 2015, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Fri, Mar 06, 2015 at 05:48:26PM +0100, Daniel Vetter wrote:
>> On Fri, Mar 06, 2015 at 08:54:35AM +0000, Chris Wilson wrote:
>> > On Thu, Mar 05, 2015 at 01:27:43PM +0100, Daniel Vetter wrote:
>> > > On Wed, Mar 04, 2015 at 06:09:26PM +0000, Chris Wilson wrote:
>> > > > This fixes a regression from
>> > > >
>> > > > commit 5ed0bdf21a85d78e04f89f15ccf227562177cbd9
>> > > > Author: Thomas Gleixner <tglx@linutronix.de>
>> > > > Date: Wed Jul 16 21:05:06 2014 +0000
>> > > >
>> > > > drm: i915: Use nsec based interfaces
>> > > >
>> > > > that made a negative timeout return immediately rather than the
>> > > > previously defined behaviour of waiting indefinitely.
>> > > >
>> > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> > > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> > > > Cc: Ben Widawsky <benjamin.widawsky@intel.com>
>> > > > Cc: Kristian Høgsberg <krh@bitplanet.net>
>> > > > Cc: stable@vger.kernel.org
>> > >
>> > > Do you have the igt for this too? I think an wait while the buffer should
>> > > be busy with a negative timeout is all that's needed to exercise this.
>> >
>> > Done.
>> > Testcase: igt/gem_wait
>>
>> Thanks a lot.
>>
>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89494

Pushed to drm-intel-fixes, thanks for the patch and review.

BR,
Jani.

> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org