Re: [PATCH] drm/i915: Make WAIT_IOCTL negative timeouts be indefinite again

Chris Wilson
2015-03-06T08:54:35Z

On Thu, Mar 05, 2015 at 01:27:43PM +0100, Daniel Vetter wrote:
> On Wed, Mar 04, 2015 at 06:09:26PM +0000, Chris Wilson wrote:
> > This fixes a regression from
> >
> > commit 5ed0bdf21a85d78e04f89f15ccf227562177cbd9
> > Author: Thomas Gleixner <tglx@linutronix.de>
> > Date: Wed Jul 16 21:05:06 2014 +0000
> >
> > drm: i915: Use nsec based interfaces
> >
> > that made a negative timeout return immediately rather than the
> > previously defined behaviour of waiting indefinitely.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Ben Widawsky <benjamin.widawsky@intel.com>
> > Cc: Kristian Høgsberg <krh@bitplanet.net>
> > Cc: stable@vger.kernel.org
>
> Do you have the igt for this too? I think an wait while the buffer should
> be busy with a negative timeout is all that's needed to exercise this.

Done.
Testcase: igt/gem_wait
-Chris

--
Chris Wilson, Intel Open Source Technology Centre