From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v4] drm/i915/audio: rewrite vlv/chv and gen 5-7 audio codec enable sequence Date: Wed, 05 Nov 2014 12:41:32 +0200 Message-ID: <87bnomgc9v.fsf@intel.com> References: <87egtoioof.fsf@intel.com> <1415089888-2547-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 131CF6E8BA for ; Wed, 5 Nov 2014 02:41:40 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi , Daniel Vetter Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org CkRhbmllbCwgUm9kcmlnbyBhY2NpZGVudGFsbHkgcmVwbGllZCB0byBqdXN0IG1lIHdpdGggaGlz IHItYi4KCkJSLApKYW5pLgoKT24gV2VkLCAwNSBOb3YgMjAxNCwgUm9kcmlnbyBWaXZpIDxyb2Ry aWdvLnZpdmlAZ21haWwuY29tPiB3cm90ZToKPiBSZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxy b2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+Cj4gT24gVHVlLCBOb3YgNCwgMjAxNCBhdCAxMjozMSBB TSwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4gd3JvdGU6Cj4+IFNpbWlsYXIg dG8gdGhlIGhzdy9iZHcgZW5hYmxlIHNlcXVlbmNlIHJld3JpdGUuCj4+Cj4+IHYzOiByZXBsYWNl IHZibGFuayB3YWl0IHdpdGggYSBjb21tZW50Cj4+Cj4+IHY0OiBleHBhbmQgdGhlIGNvbW1lbnQg b24gd2hhdCBzaG91bGQgYmUgZG9uZSB3aXRoIHRoZSB2Ymxhbmsgd2FpdAo+Pgo+PiBTaWduZWQt b2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+PiAtLS0KPj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F1ZGlvLmMgfCA2MyArKysrKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0tLS0tLS0tLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDMxIGluc2VydGlvbnMoKyks IDMyIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfYXVkaW8uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F1ZGlvLmMKPj4gaW5k ZXggNGRjZmM0NmQ1NzI1Li44NzU5ZmM1MDk3ODMgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2F1ZGlvLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfYXVkaW8uYwo+PiBAQCAtMjE1LDYgKzIxNSwxMCBAQCBzdGF0aWMgdm9pZCBpbGtfYXVkaW9f Y29kZWNfZW5hYmxlKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4+ICB7Cj4+ICAg ICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gY29ubmVjdG9yLT5kZXYt PmRldl9wcml2YXRlOwo+PiAgICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0g dG9faW50ZWxfY3J0YyhlbmNvZGVyLT5iYXNlLmNydGMpOwo+PiArICAgICAgIHN0cnVjdCBpbnRl bF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0ID0KPj4gKyAgICAgICAgICAgICAgIGVuY190 b19kaWdfcG9ydCgmZW5jb2Rlci0+YmFzZSk7Cj4+ICsgICAgICAgZW51bSBwb3J0IHBvcnQgPSBp bnRlbF9kaWdfcG9ydC0+cG9ydDsKPj4gKyAgICAgICBlbnVtIHBpcGUgcGlwZSA9IGludGVsX2Ny dGMtPnBpcGU7Cj4+ICAgICAgICAgdWludDhfdCAqZWxkID0gY29ubmVjdG9yLT5lbGQ7Cj4+ICAg ICAgICAgdWludDMyX3QgZWxkdjsKPj4gICAgICAgICB1aW50MzJfdCB0bXA7Cj4+IEBAIC0yMjMs OCArMjI3LDE2IEBAIHN0YXRpYyB2b2lkIGlsa19hdWRpb19jb2RlY19lbmFibGUoc3RydWN0IGRy bV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPj4gICAgICAgICBpbnQgYXVkX2NvbmZpZzsKPj4gICAg ICAgICBpbnQgYXVkX2NudGxfc3Q7Cj4+ICAgICAgICAgaW50IGF1ZF9jbnRybF9zdDI7Cj4+IC0g ICAgICAgZW51bSBwaXBlIHBpcGUgPSBpbnRlbF9jcnRjLT5waXBlOwo+PiAtICAgICAgIGVudW0g cG9ydCBwb3J0Owo+PiArCj4+ICsgICAgICAgRFJNX0RFQlVHX0tNUygiRW5hYmxlIGF1ZGlvIGNv ZGVjIG9uIHBvcnQgJWMsIHBpcGUgJWMsICV1IGJ5dGVzIEVMRFxuIiwKPj4gKyAgICAgICAgICAg ICAgICAgICAgIHBvcnRfbmFtZShwb3J0KSwgcGlwZV9uYW1lKHBpcGUpLCBlbGRbMl0pOwo+PiAr Cj4+ICsgICAgICAgLyoKPj4gKyAgICAgICAgKiBGSVhNRTogV2UncmUgc3VwcG9zZWQgdG8gd2Fp dCBmb3IgdmJsYW5rIGhlcmUsIGJ1dCB3ZSBoYXZlIHZibGFua3MKPj4gKyAgICAgICAgKiBkaXNh YmxlZCBkdXJpbmcgdGhlIG1vZGUgc2V0LiBUaGUgcHJvcGVyIGZpeCB3b3VsZCBiZSB0byBwdXNo IHRoZQo+PiArICAgICAgICAqIHJlc3Qgb2YgdGhlIHNldHVwIGludG8gYSB2Ymxhbmsgd29yayBp dGVtLCBxdWV1ZWQgaGVyZSwgYnV0IHRoZQo+PiArICAgICAgICAqIGluZnJhc3RydWN0dXJlIGlz IG5vdCB0aGVyZSB5ZXQuCj4+ICsgICAgICAgICovCj4+Cj4+ICAgICAgICAgaWYgKEhBU19QQ0hf SUJYKGNvbm5lY3Rvci0+ZGV2KSkgewo+PiAgICAgICAgICAgICAgICAgaGRtaXdfaGRtaWVkaWQg PSBJQlhfSERNSVdfSERNSUVESUQocGlwZSk7Cj4+IEBAIC0yNDMsNTcgKzI1NSw0NCBAQCBzdGF0 aWMgdm9pZCBpbGtfYXVkaW9fY29kZWNfZW5hYmxlKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25u ZWN0b3IsCj4+ICAgICAgICAgICAgICAgICBhdWRfY250cmxfc3QyID0gQ1BUX0FVRF9DTlRSTF9T VDI7Cj4+ICAgICAgICAgfQo+Pgo+PiAtICAgICAgIERSTV9ERUJVR19EUklWRVIoIkVMRCBvbiBw aXBlICVjXG4iLCBwaXBlX25hbWUocGlwZSkpOwo+PiAtCj4+IC0gICAgICAgaWYgKElTX1ZBTExF WVZJRVcoY29ubmVjdG9yLT5kZXYpKSAgewo+PiAtICAgICAgICAgICAgICAgc3RydWN0IGludGVs X2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQ7Cj4+IC0KPj4gLSAgICAgICAgICAgICAgIGlu dGVsX2RpZ19wb3J0ID0gZW5jX3RvX2RpZ19wb3J0KCZlbmNvZGVyLT5iYXNlKTsKPj4gLSAgICAg ICAgICAgICAgIHBvcnQgPSBpbnRlbF9kaWdfcG9ydC0+cG9ydDsKPj4gLSAgICAgICB9IGVsc2Ug ewo+PiAtICAgICAgICAgICAgICAgdG1wID0gSTkxNV9SRUFEKGF1ZF9jbnRsX3N0KTsKPj4gLSAg ICAgICAgICAgICAgIHBvcnQgPSAodG1wID4+IDI5KSAmIERJUF9QT1JUX1NFTF9NQVNLOwo+PiAt ICAgICAgICAgICAgICAgLyogRElQX1BvcnRfU2VsZWN0LCAweDEgPSBQb3J0QiAqLwo+PiAtICAg ICAgIH0KPj4gLQo+PiAtICAgICAgIGlmICghcG9ydCkgewo+PiAtICAgICAgICAgICAgICAgRFJN X0RFQlVHX0RSSVZFUigiQXVkaW8gZGlyZWN0ZWQgdG8gdW5rbm93biBwb3J0XG4iKTsKPj4gLSAg ICAgICAgICAgICAgIC8qIG9wZXJhdGUgYmxpbmRseSBvbiBhbGwgcG9ydHMgKi8KPj4gKyAgICAg ICBpZiAoV0FSTl9PTighcG9ydCkpIHsKPj4gICAgICAgICAgICAgICAgIGVsZHYgPSBJQlhfRUxE X1ZBTElEQjsKPj4gICAgICAgICAgICAgICAgIGVsZHYgfD0gSUJYX0VMRF9WQUxJREIgPDwgNDsK Pj4gICAgICAgICAgICAgICAgIGVsZHYgfD0gSUJYX0VMRF9WQUxJREIgPDwgODsKPj4gICAgICAg ICB9IGVsc2Ugewo+PiAtICAgICAgICAgICAgICAgRFJNX0RFQlVHX0RSSVZFUigiRUxEIG9uIHBv cnQgJWNcbiIsIHBvcnRfbmFtZShwb3J0KSk7Cj4+ICAgICAgICAgICAgICAgICBlbGR2ID0gSUJY X0VMRF9WQUxJREIgPDwgKChwb3J0IC0gMSkgKiA0KTsKPj4gICAgICAgICB9Cj4+Cj4+IC0gICAg ICAgaWYgKGludGVsX3BpcGVfaGFzX3R5cGUoaW50ZWxfY3J0YywgSU5URUxfT1VUUFVUX0RJU1BM QVlQT1JUKSkKPj4gLSAgICAgICAgICAgICAgIEk5MTVfV1JJVEUoYXVkX2NvbmZpZywgQVVEX0NP TkZJR19OX1ZBTFVFX0lOREVYKTsgLyogMHgxID0gRFAgKi8KPj4gLSAgICAgICBlbHNlCj4+IC0g ICAgICAgICAgICAgICBJOTE1X1dSSVRFKGF1ZF9jb25maWcsIGF1ZGlvX2NvbmZpZ19oZG1pX3Bp eGVsX2Nsb2NrKG1vZGUpKTsKPj4gLQo+PiAtICAgICAgIGlmIChpbnRlbF9lbGRfdXB0b2RhdGUo Y29ubmVjdG9yLAo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYXVkX2NudHJsX3N0 MiwgZWxkdiwKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGF1ZF9jbnRsX3N0LCBJ QlhfRUxEX0FERFJFU1NfTUFTSywKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGhk bWl3X2hkbWllZGlkKSkKPj4gLSAgICAgICAgICAgICAgIHJldHVybjsKPj4gLQo+PiArICAgICAg IC8qIEludmFsaWRhdGUgRUxEICovCj4+ICAgICAgICAgdG1wID0gSTkxNV9SRUFEKGF1ZF9jbnRy bF9zdDIpOwo+PiAgICAgICAgIHRtcCAmPSB+ZWxkdjsKPj4gICAgICAgICBJOTE1X1dSSVRFKGF1 ZF9jbnRybF9zdDIsIHRtcCk7Cj4+Cj4+ICsgICAgICAgLyogUmVzZXQgRUxEIHdyaXRlIGFkZHJl c3MgKi8KPj4gICAgICAgICB0bXAgPSBJOTE1X1JFQUQoYXVkX2NudGxfc3QpOwo+PiAgICAgICAg IHRtcCAmPSB+SUJYX0VMRF9BRERSRVNTX01BU0s7Cj4+ICAgICAgICAgSTkxNV9XUklURShhdWRf Y250bF9zdCwgdG1wKTsKPj4KPj4gLSAgICAgICBsZW4gPSBtaW5fdChpbnQsIGVsZFsyXSwgMjEp OyAgIC8qIDg0IGJ5dGVzIG9mIGh3IEVMRCBidWZmZXIgKi8KPj4gLSAgICAgICBEUk1fREVCVUdf RFJJVkVSKCJFTEQgc2l6ZSAlZFxuIiwgbGVuKTsKPj4gKyAgICAgICAvKiBVcCB0byA4NCBieXRl cyBvZiBodyBFTEQgYnVmZmVyICovCj4+ICsgICAgICAgbGVuID0gbWluX3QoaW50LCBlbGRbMl0s IDIxKTsKPj4gICAgICAgICBmb3IgKGkgPSAwOyBpIDwgbGVuOyBpKyspCj4+ICAgICAgICAgICAg ICAgICBJOTE1X1dSSVRFKGhkbWl3X2hkbWllZGlkLCAqKCh1aW50MzJfdCAqKWVsZCArIGkpKTsK Pj4KPj4gKyAgICAgICAvKiBFTEQgdmFsaWQgKi8KPj4gICAgICAgICB0bXAgPSBJOTE1X1JFQUQo YXVkX2NudHJsX3N0Mik7Cj4+ICAgICAgICAgdG1wIHw9IGVsZHY7Cj4+ICAgICAgICAgSTkxNV9X UklURShhdWRfY250cmxfc3QyLCB0bXApOwo+PiArCj4+ICsgICAgICAgLyogRW5hYmxlIHRpbWVz dGFtcHMgKi8KPj4gKyAgICAgICB0bXAgPSBJOTE1X1JFQUQoYXVkX2NvbmZpZyk7Cj4+ICsgICAg ICAgdG1wICY9IH5BVURfQ09ORklHX05fVkFMVUVfSU5ERVg7Cj4+ICsgICAgICAgdG1wICY9IH5B VURfQ09ORklHX05fUFJPR19FTkFCTEU7Cj4+ICsgICAgICAgdG1wICY9IH5BVURfQ09ORklHX1BJ WEVMX0NMT0NLX0hETUlfTUFTSzsKPj4gKyAgICAgICBpZiAoaW50ZWxfcGlwZV9oYXNfdHlwZShp bnRlbF9jcnRjLCBJTlRFTF9PVVRQVVRfRElTUExBWVBPUlQpKQo+PiArICAgICAgICAgICAgICAg dG1wIHw9IEFVRF9DT05GSUdfTl9WQUxVRV9JTkRFWDsKPj4gKyAgICAgICBlbHNlCj4+ICsgICAg ICAgICAgICAgICB0bXAgfD0gYXVkaW9fY29uZmlnX2hkbWlfcGl4ZWxfY2xvY2sobW9kZSk7Cj4+ ICsgICAgICAgSTkxNV9XUklURShhdWRfY29uZmlnLCB0bXApOwo+PiAgfQo+Pgo+PiAgLyoqCj4+ IC0tCj4+IDIuMS4xCj4+Cj4KPgo+Cj4gLS0gCj4gUm9kcmlnbyBWaXZpCj4gQmxvZzogaHR0cDov L2Jsb2cudml2aS5lbmcuYnIKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVj aG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK