Re: [PATCH v2 09/18] drm/i915/audio: remove misleading checks for !eld[0]

Daniel Vetter
2014-11-03T12:04:28Z

On Mon, Oct 27, 2014 at 11:27:18AM -0700, Rodrigo Vivi wrote:
> I'm not 100% convinced drm_select_eld will always cover this check... so
> What do you think about changing it to a BUG_ON or at least a WARN_ON?

Please don't kill the driver with a BUG_ON, always use WARN_ON instead.
Except when the oops will happen anyway and can't be recovered.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch