public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Ignore VBT backlight presence check on Acer C720 (4005U)
@ 2014-08-21 16:08 Scot Doyle
  2014-08-26 12:21 ` Jani Nikula
  0 siblings, 1 reply; 2+ messages in thread
From: Scot Doyle @ 2014-08-21 16:08 UTC (permalink / raw)
  To: intel-gfx; +Cc: Jani Nikula, Daniel Vetter, Tyler Cleveland

commit c675949ec58ca50d5a3ae3c757892f1560f6e896
    drm/i915: do not setup backlight if not available according to VBT

prevents backlight setup on the Acer C720 (Core i3 4005U CPU), which has a
misconfigured VBT. Apply quirk to ignore the VBT backlight presence check
during backlight setup.

Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
Tested-by: Tyler Cleveland <siralucardt@openmailbox.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/intel_display.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 0b327eb..3d4a4eb 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -12553,6 +12553,9 @@ static struct intel_quirk intel_quirks[] = {
 	/* Acer C720 and C720P Chromebooks (Celeron 2955U) have backlights */
 	{ 0x0a06, 0x1025, 0x0a11, quirk_backlight_present },

+	/* Acer C720 Chromebook (Core i3 4005U) */
+	{ 0x0a16, 0x1025, 0x0a11, quirk_backlight_present },
+
 	/* Toshiba CB35 Chromebook (Celeron 2955U) */
 	{ 0x0a06, 0x1179, 0x0a88, quirk_backlight_present },

-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/i915: Ignore VBT backlight presence check on Acer C720 (4005U)
  2014-08-21 16:08 [PATCH] drm/i915: Ignore VBT backlight presence check on Acer C720 (4005U) Scot Doyle
@ 2014-08-26 12:21 ` Jani Nikula
  0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2014-08-26 12:21 UTC (permalink / raw)
  To: Scot Doyle, intel-gfx; +Cc: Daniel Vetter, Tyler Cleveland

On Thu, 21 Aug 2014, Scot Doyle <lkml14@scotdoyle.com> wrote:
> commit c675949ec58ca50d5a3ae3c757892f1560f6e896
>     drm/i915: do not setup backlight if not available according to VBT
>
> prevents backlight setup on the Acer C720 (Core i3 4005U CPU), which has a
> misconfigured VBT. Apply quirk to ignore the VBT backlight presence check
> during backlight setup.
>
> Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
> Tested-by: Tyler Cleveland <siralucardt@openmailbox.org>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>

Pushed to drm-intel-fixes, thanks for the patch.

BR,
Jani.

> ---
>  drivers/gpu/drm/i915/intel_display.c |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 0b327eb..3d4a4eb 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12553,6 +12553,9 @@ static struct intel_quirk intel_quirks[] = {
>  	/* Acer C720 and C720P Chromebooks (Celeron 2955U) have backlights */
>  	{ 0x0a06, 0x1025, 0x0a11, quirk_backlight_present },
>
> +	/* Acer C720 Chromebook (Core i3 4005U) */
> +	{ 0x0a16, 0x1025, 0x0a11, quirk_backlight_present },
> +
>  	/* Toshiba CB35 Chromebook (Celeron 2955U) */
>  	{ 0x0a06, 0x1179, 0x0a88, quirk_backlight_present },
>
> -- 
> 1.7.10.4

-- 
Jani Nikula, Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-08-26 12:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-21 16:08 [PATCH] drm/i915: Ignore VBT backlight presence check on Acer C720 (4005U) Scot Doyle
2014-08-26 12:21 ` Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox