From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH v2 1/2] drm/i915: fix possible refcount leak
	when resetting forcewake
Date: Tue, 10 Jun 2014 19:35:53 +0300
Message-ID: <87bnu0u3h2.fsf@intel.com>
References: <1402048779-14902-1-git-send-email-imre.deak@intel.com>
 <1402052677-19607-1-git-send-email-imre.deak@intel.com>
 <20140606110843.GF22214@nuc-i3427.alporthouse.com>
 <20140606174619.GS7416@phenom.ffwll.local>
 <1402079906.4193.11.camel@ideak-mobl>
 <20140606201532.GV7416@phenom.ffwll.local>
 <1402085968.4193.14.camel@ideak-mobl>
 <20140606203537.GY7416@phenom.ffwll.local>
 <1402087446.4193.19.camel@ideak-mobl>
 <CAKMK7uG+uXTigjBQphizq0cCN15V7gcVifxPpgiJXGJ=jxu0qg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTP id 8EB6E6E6E8
 for <intel-gfx@lists.freedesktop.org>; Tue, 10 Jun 2014 09:36:01 -0700 (PDT)
In-Reply-To: <CAKMK7uG+uXTigjBQphizq0cCN15V7gcVifxPpgiJXGJ=jxu0qg@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>, Imre Deak <imre.deak@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, 06 Jun 2014, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Jun 6, 2014 at 10:44 PM, Imre Deak <imre.deak@intel.com> wrote:
>> Let's say that forcewake timer is pending, holding the runtime pm ref.
>> System suspend is called - it's not prevented by either this ref or the
>> above autosuspend delay - in the suspend handler we eventually call
>> force_wake_reset which cancels the timer, leaking the runtime pm ref.
>
> Hm, I indeed mixed things up. I guess the window is small with the
> short timeout we have for the forcewake timer, but still the first
> patch makes sense for -fixes. Jani?

v2 of 1/2 pushed to -fixes, thanks for that patch and review.

BR,
Jani.


> -Daniel
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center