Re: [PATCH] drm/i915: Use the first mode if there is no preferred mode in the EDID

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 14 May 2014, Knut Petersen <Knut_Petersen@t-online.de> wrote:
> On 13.05.2014 22:24, Jesse Barnes wrote:
>> On Tue, 13 May 2014 16:50:12 +0100
>> Chris Wilson <chris@chris-wilson.co.uk> wrote:
>>>> diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c
>>>> index 1d3f0a9cce31..05beec4badd5 100644
>>>> --- a/drivers/gpu/drm/i915/intel_fbdev.c
>>>> +++ b/drivers/gpu/drm/i915/intel_fbdev.c
>>>> @@ -397,6 +397,14 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper,
>>>>   							  height);
>>>>   		}
>>>>   
>>>> +		/* No preferred mode marked by the EDID? Are there any modes? */
>>>> +		if (!modes[i] && !list_empty(&connector->modes)) {
>>>> +			DRM_DEBUG_KMS("using first mode listed on connector %s\n",
>>>> +				      drm_get_connector_name(connector));
>>>> +			modes[i] = list_first_entry(struct drm_display_mode,
>>>> +						    &connector->modes, head);
>>> Please imagine that I wrote this correctly.
>> Imagining you wrote it correctly:
>> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> After proper imagination Tested-by: Knut Petersen <Knut_Petersen@t-online.de>.

Pushed the imagined version to -fixes, thanks for the patch, review,
testing, and imagination.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center