From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Use the first mode if there is no
	preferred mode in the EDID
Date: Thu, 15 May 2014 11:57:59 +0300
Message-ID: <87bnuzpgfc.fsf@intel.com>
References: <1399993657-4544-1-git-send-email-chris@chris-wilson.co.uk>
 <20140513155012.GR7239@nuc-i3427.alporthouse.com>
 <20140513132404.5745456f@jbarnes-desktop> <5373009B.50800@t-online.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id 5B23E6E13D
 for <intel-gfx@lists.freedesktop.org>; Thu, 15 May 2014 01:58:03 -0700 (PDT)
In-Reply-To: <5373009B.50800@t-online.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Knut Petersen <Knut_Petersen@t-online.de>, Jesse Barnes <jbarnes@virtuousgeek.org>, Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, 14 May 2014, Knut Petersen <Knut_Petersen@t-online.de> wrote:
> On 13.05.2014 22:24, Jesse Barnes wrote:
>> On Tue, 13 May 2014 16:50:12 +0100
>> Chris Wilson <chris@chris-wilson.co.uk> wrote:
>>>> diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c
>>>> index 1d3f0a9cce31..05beec4badd5 100644
>>>> --- a/drivers/gpu/drm/i915/intel_fbdev.c
>>>> +++ b/drivers/gpu/drm/i915/intel_fbdev.c
>>>> @@ -397,6 +397,14 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper,
>>>>   							  height);
>>>>   		}
>>>>   
>>>> +		/* No preferred mode marked by the EDID? Are there any modes? */
>>>> +		if (!modes[i] && !list_empty(&connector->modes)) {
>>>> +			DRM_DEBUG_KMS("using first mode listed on connector %s\n",
>>>> +				      drm_get_connector_name(connector));
>>>> +			modes[i] = list_first_entry(struct drm_display_mode,
>>>> +						    &connector->modes, head);
>>> Please imagine that I wrote this correctly.
>> Imagining you wrote it correctly:
>> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> After proper imagination Tested-by: Knut Petersen <Knut_Petersen@t-online.de>.

Pushed the imagined version to -fixes, thanks for the patch, review,
testing, and imagination.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center