From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, miku@iki.fi, ben@bwidawsk.net,
kristen@linux.intel.com
Subject: Re: [PATCH v2 1/2] drm/i915: add render state initialization
Date: Tue, 06 May 2014 17:34:30 +0300 [thread overview]
Message-ID: <87bnvbj7rd.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20140506134153.GA476@nuc-i3427.alporthouse.com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> On Tue, May 06, 2014 at 04:26:05PM +0300, Mika Kuoppala wrote:
>> HW guys say that it is not a cool idea to let device
>> go into rc6 without proper 3d pipeline state.
>
> * shrug
>
> What's improper 3d state and what prevents userspace from triggering
> badness later?
I would guess improver is 'whats is there after powerup'. But yes,
we dont even know (yet?) what is the proper minimal state :P
What comes to userspace triggering badness later is that the ring
will hang and hangcheck will cleanup the mess.
> The only problem I see in the patch is that you don't move the so->obj
> to the GPU before execution - the code is only coherent thanks to LLC
> atm.
Fixed in v3.
Thanks,
-Mika
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2014-05-06 14:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 13:26 [PATCH v2 0/2] render state initialization (bdw rc6) Mika Kuoppala
2014-05-06 13:26 ` [PATCH v2 1/2] drm/i915: add render state initialization Mika Kuoppala
2014-05-06 13:41 ` Chris Wilson
2014-05-06 14:30 ` [PATCH v3 " Mika Kuoppala
2014-05-14 10:24 ` Mateo Lozano, Oscar
2014-05-14 11:13 ` Damien Lespiau
2014-05-14 11:24 ` Mateo Lozano, Oscar
2014-05-06 14:34 ` Mika Kuoppala [this message]
2014-05-06 13:26 ` [PATCH v2 2/2] drm/i915: add null render states for gen6, gen7 and gen8 Mika Kuoppala
2014-05-06 13:39 ` [PATCH] tools/null_state_gen: generate null render state Mika Kuoppala
2014-05-06 13:47 ` Chris Wilson
2014-05-06 14:44 ` Mika Kuoppala
2014-05-09 15:15 ` Damien Lespiau
2014-05-08 14:37 ` Damien Lespiau
2014-05-08 14:43 ` Damien Lespiau
2014-05-08 15:10 ` Mika Kuoppala
2014-05-09 14:46 ` Damien Lespiau
2014-05-14 10:06 ` Damien Lespiau
2014-05-14 10:08 ` [PATCH v2 0/2] render state initialization (bdw rc6) Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnvbj7rd.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kristen@linux.intel.com \
--cc=miku@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox