From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: kick firmware fbs even when i915 fbdev is disabled Date: Tue, 17 Dec 2013 08:20:10 +0200 Message-ID: <87bo0g3so5.fsf@intel.com> References: <1387209196-27133-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id EF93D1065FE for ; Mon, 16 Dec 2013 22:23:43 -0800 (PST) In-Reply-To: <1387209196-27133-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Mon, 16 Dec 2013, Daniel Vetter wrote: > Otherwise we don't kick out firmware framebuffers like vesafb and > efifb when CONFIG_DRM_I915_FBDEV=n but CONFIG_FB=y. > > There's still the pesky issue with vgacon which we should somehow > replace with the dummy console at least. We have a similar issue at > module un/reload, since vgacon state is terminally botched after > i915.ko has loaded in modeset mode. But this gets us a step further at > least. > > Reported-by: Chris Wilson > Cc: Chris Wilson > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_dma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c > index c9101bde96be..920b1c95fc18 100644 > --- a/drivers/gpu/drm/i915/i915_dma.c > +++ b/drivers/gpu/drm/i915/i915_dma.c > @@ -1413,7 +1413,7 @@ void i915_master_destroy(struct drm_device *dev, struct drm_master *master) > master->driver_priv = NULL; > } > > -#ifdef CONFIG_DRM_I915_FBDEV > +#if defined(CONFIG_FB) #if IS_ENABLED(CONFIG_FB) if you want this to work for CONFIG_FB=m too. BR, Jani. > static void i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv) > { > struct apertures_struct *ap; > -- > 1.8.4.3 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center