From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19DBAD5E149 for ; Fri, 8 Nov 2024 09:10:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C241A10E948; Fri, 8 Nov 2024 09:10:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="QztMvHcL"; dkim-atps=neutral Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) by gabe.freedesktop.org (Postfix) with ESMTPS id F2AED10E947; Fri, 8 Nov 2024 09:10:11 +0000 (UTC) Received: from relay8-d.mail.gandi.net (unknown [IPv6:2001:4b98:dc4:8::228]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 634BEC3959; Fri, 8 Nov 2024 09:01:20 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id EB0E01BF206; Fri, 8 Nov 2024 09:01:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1731056478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xm3UhMCd7zn0wf/NB/NpG8HDn8ZRdu/b34t338J+8xk=; b=QztMvHcL/LJyrVDUjANfvRSEswWgGPCBkv8uGEXEF5EpfVhacT90xYLK/fwUPj2/au1Tc3 1kh4DFm1qrJD/IV8wBboJjVIHQleo2/noYXHVSj16eJsENavfZmk1SsWmfowSgsSLPfavk phoOMfYt1+uV5mwHNLWE7Uhf/KujTA3RdCjpBF9mXa7ugfbiBd0ygDjVIOMZTYf5yTZ12/ /oYn9/UfoHVdXU+OSnEKkoxw3iYpgtwPRZmg+NDNQZEip+rkelvRp8lva1M2fJRofpKpS8 3U6vTMUP93+AAK89JLssHwaAi7z29pUaKMK4z+2+4qbL5LsfSdJhj+LIGLD6Kg== From: Miquel Raynal To: Rodrigo Vivi Cc: "Usyskin, Alexander" , "Gupta, Anshuman" , "Deak, Imre" , "Richard Weinberger" , Vignesh Raghavendra , "De Marchi, Lucas" , Thomas =?utf-8?Q?Hellstr?= =?utf-8?Q?=C3=B6m?= , "Maarten Lankhorst" , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Tvrtko Ursulin , "Weil, Oren jer" , "linux-mtd@lists.infradead.org" , "dri-devel@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 06/10] mtd: intel-dg: wake card on operations In-Reply-To: (Rodrigo Vivi's message of "Thu, 7 Nov 2024 17:49:36 -0500") References: <20241022104119.3149051-1-alexander.usyskin@intel.com> <20241022104119.3149051-7-alexander.usyskin@intel.com> User-Agent: mu4e 1.12.1; emacs 29.4 Date: Fri, 08 Nov 2024 10:01:15 +0100 Message-ID: <87cyj6aylg.fsf@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" >> > That's the part that I'm not sure if I agree. if I remember from some >> > experiments in the past, >> > when you call to wake up the child, the parent will wakeup first anywa= y. >> >=20 >> The child (mtd device) does not exist at this point of time. >> To create MTD device, the partition table should be provided >> and it read directly from flash that should be powered to do read. > > I don't understand... you have the mtd->dev at this point... this is > the one you should be touching, not the mtd->dev.parent... even at the > probe, but moreover on everywhere else as well. > >>=20 >> > > Considering above, is this move is justified? >> > > Also, MTD drivers tend to enable parent rpm, not its own one. >> >=20 >> > What other drivers are you looking for reference? >>=20 >> drivers/mtd/nand/raw/tegra_nand.c >> drivers/mtd/nand/raw/renesas-nand-controller.c >> drivers/mtd/maps/physmap-core.c > > I see they getting pdev->dev... not the parent... That's three drivers where there is probably room for improvement. These differences are subtle and likely un-catch during review. Feel free to correct the drivers if you think they are wrong and more importantly, do the correct thing in your own. Thanks, Miqu=C3=A8l