* [PATCH v2 1/6] drm/i915/gem: fix bitwise and logical AND mixup
2024-09-18 17:35 [PATCH v2 0/6] drm/i915: wakeref fixes and improvements Jani Nikula
@ 2024-09-18 17:35 ` Jani Nikula
2024-09-26 20:40 ` Rodrigo Vivi
2024-09-18 17:35 ` [PATCH v2 2/6] drm/i915: use INTEL_WAKEREF_DEF instead of magic -1 for intel_wakeref_t Jani Nikula
` (11 subsequent siblings)
12 siblings, 1 reply; 24+ messages in thread
From: Jani Nikula @ 2024-09-18 17:35 UTC (permalink / raw)
To: intel-gfx, intel-xe
Cc: jani.nikula, Matthew Auld, Rodrigo Vivi, Anshuman Gupta,
Andi Shyti, Nathan Chancellor, stable
CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND is an int, defaulting to 250. When
the wakeref is non-zero, it's either -1 or a dynamically allocated
pointer, depending on CONFIG_DRM_I915_DEBUG_RUNTIME_PM. It's likely that
the code works by coincidence with the bitwise AND, but with
CONFIG_DRM_I915_DEBUG_RUNTIME_PM=y, there's the off chance that the
condition evaluates to false, and intel_wakeref_auto() doesn't get
called. Switch to the intended logical AND.
v2: Use != to avoid clang -Wconstant-logical-operand (Nathan)
Fixes: ad74457a6b5a ("drm/i915/dgfx: Release mmap on rpm suspend")
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: <stable@vger.kernel.org> # v6.1+
Reviewed-by: Matthew Auld <matthew.auld@intel.com> # v1
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> # v1
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
index 5c72462d1f57..b22e2019768f 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
@@ -1131,7 +1131,7 @@ static vm_fault_t vm_fault_ttm(struct vm_fault *vmf)
GEM_WARN_ON(!i915_ttm_cpu_maps_iomem(bo->resource));
}
- if (wakeref & CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND)
+ if (wakeref && CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND != 0)
intel_wakeref_auto(&to_i915(obj->base.dev)->runtime_pm.userfault_wakeref,
msecs_to_jiffies_timeout(CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND));
--
2.39.2
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH v2 1/6] drm/i915/gem: fix bitwise and logical AND mixup
2024-09-18 17:35 ` [PATCH v2 1/6] drm/i915/gem: fix bitwise and logical AND mixup Jani Nikula
@ 2024-09-26 20:40 ` Rodrigo Vivi
2024-09-27 8:38 ` Jani Nikula
0 siblings, 1 reply; 24+ messages in thread
From: Rodrigo Vivi @ 2024-09-26 20:40 UTC (permalink / raw)
To: Jani Nikula
Cc: intel-gfx, intel-xe, Matthew Auld, Anshuman Gupta, Andi Shyti,
Nathan Chancellor, stable
On Wed, Sep 18, 2024 at 08:35:43PM +0300, Jani Nikula wrote:
> CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND is an int, defaulting to 250. When
> the wakeref is non-zero, it's either -1 or a dynamically allocated
> pointer, depending on CONFIG_DRM_I915_DEBUG_RUNTIME_PM. It's likely that
> the code works by coincidence with the bitwise AND, but with
> CONFIG_DRM_I915_DEBUG_RUNTIME_PM=y, there's the off chance that the
> condition evaluates to false, and intel_wakeref_auto() doesn't get
> called. Switch to the intended logical AND.
>
> v2: Use != to avoid clang -Wconstant-logical-operand (Nathan)
oh, this is ugly!
Wouldn't it be better then to use IS_ENABLED() macro?
>
> Fixes: ad74457a6b5a ("drm/i915/dgfx: Release mmap on rpm suspend")
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: <stable@vger.kernel.org> # v6.1+
> Reviewed-by: Matthew Auld <matthew.auld@intel.com> # v1
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> # v1
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> index 5c72462d1f57..b22e2019768f 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> @@ -1131,7 +1131,7 @@ static vm_fault_t vm_fault_ttm(struct vm_fault *vmf)
> GEM_WARN_ON(!i915_ttm_cpu_maps_iomem(bo->resource));
> }
>
> - if (wakeref & CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND)
> + if (wakeref && CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND != 0)
> intel_wakeref_auto(&to_i915(obj->base.dev)->runtime_pm.userfault_wakeref,
> msecs_to_jiffies_timeout(CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND));
>
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH v2 1/6] drm/i915/gem: fix bitwise and logical AND mixup
2024-09-26 20:40 ` Rodrigo Vivi
@ 2024-09-27 8:38 ` Jani Nikula
2024-09-30 13:54 ` Jani Nikula
0 siblings, 1 reply; 24+ messages in thread
From: Jani Nikula @ 2024-09-27 8:38 UTC (permalink / raw)
To: Rodrigo Vivi
Cc: intel-gfx, intel-xe, Matthew Auld, Anshuman Gupta, Andi Shyti,
Nathan Chancellor, stable
On Thu, 26 Sep 2024, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Wed, Sep 18, 2024 at 08:35:43PM +0300, Jani Nikula wrote:
>> CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND is an int, defaulting to 250. When
>> the wakeref is non-zero, it's either -1 or a dynamically allocated
>> pointer, depending on CONFIG_DRM_I915_DEBUG_RUNTIME_PM. It's likely that
>> the code works by coincidence with the bitwise AND, but with
>> CONFIG_DRM_I915_DEBUG_RUNTIME_PM=y, there's the off chance that the
>> condition evaluates to false, and intel_wakeref_auto() doesn't get
>> called. Switch to the intended logical AND.
>>
>> v2: Use != to avoid clang -Wconstant-logical-operand (Nathan)
>
> oh, this is ugly!
>
> Wouldn't it be better then to use IS_ENABLED() macro?
It's an int config option, not a bool. (Yes, the name is misleading.)
IS_ENABLED(CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND) would be the same as
CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND == 1.
We're actually checking if the int value != 0, so IMO the patch at hand
is fine.
BR,
Jani.
>
>>
>> Fixes: ad74457a6b5a ("drm/i915/dgfx: Release mmap on rpm suspend")
>> Cc: Matthew Auld <matthew.auld@intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
>> Cc: Andi Shyti <andi.shyti@linux.intel.com>
>> Cc: Nathan Chancellor <nathan@kernel.org>
>> Cc: <stable@vger.kernel.org> # v6.1+
>> Reviewed-by: Matthew Auld <matthew.auld@intel.com> # v1
>> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> # v1
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>> index 5c72462d1f57..b22e2019768f 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>> @@ -1131,7 +1131,7 @@ static vm_fault_t vm_fault_ttm(struct vm_fault *vmf)
>> GEM_WARN_ON(!i915_ttm_cpu_maps_iomem(bo->resource));
>> }
>>
>> - if (wakeref & CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND)
>> + if (wakeref && CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND != 0)
>> intel_wakeref_auto(&to_i915(obj->base.dev)->runtime_pm.userfault_wakeref,
>> msecs_to_jiffies_timeout(CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND));
>>
>> --
>> 2.39.2
>>
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH v2 1/6] drm/i915/gem: fix bitwise and logical AND mixup
2024-09-27 8:38 ` Jani Nikula
@ 2024-09-30 13:54 ` Jani Nikula
2024-09-30 14:23 ` Matthew Auld
0 siblings, 1 reply; 24+ messages in thread
From: Jani Nikula @ 2024-09-30 13:54 UTC (permalink / raw)
To: Rodrigo Vivi
Cc: intel-gfx, intel-xe, Matthew Auld, Anshuman Gupta, Andi Shyti,
Nathan Chancellor, stable
On Fri, 27 Sep 2024, Jani Nikula <jani.nikula@intel.com> wrote:
> On Thu, 26 Sep 2024, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
>> On Wed, Sep 18, 2024 at 08:35:43PM +0300, Jani Nikula wrote:
>>> CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND is an int, defaulting to 250. When
>>> the wakeref is non-zero, it's either -1 or a dynamically allocated
>>> pointer, depending on CONFIG_DRM_I915_DEBUG_RUNTIME_PM. It's likely that
>>> the code works by coincidence with the bitwise AND, but with
>>> CONFIG_DRM_I915_DEBUG_RUNTIME_PM=y, there's the off chance that the
>>> condition evaluates to false, and intel_wakeref_auto() doesn't get
>>> called. Switch to the intended logical AND.
>>>
>>> v2: Use != to avoid clang -Wconstant-logical-operand (Nathan)
>>
>> oh, this is ugly!
>>
>> Wouldn't it be better then to use IS_ENABLED() macro?
>
> It's an int config option, not a bool. (Yes, the name is misleading.)
>
> IS_ENABLED(CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND) would be the same as
> CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND == 1.
>
> We're actually checking if the int value != 0, so IMO the patch at hand
> is fine.
Ping, r-b on this one too?
BR,
Jani.
>
> BR,
> Jani.
>
>
>>
>>>
>>> Fixes: ad74457a6b5a ("drm/i915/dgfx: Release mmap on rpm suspend")
>>> Cc: Matthew Auld <matthew.auld@intel.com>
>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
>>> Cc: Andi Shyti <andi.shyti@linux.intel.com>
>>> Cc: Nathan Chancellor <nathan@kernel.org>
>>> Cc: <stable@vger.kernel.org> # v6.1+
>>> Reviewed-by: Matthew Auld <matthew.auld@intel.com> # v1
>>> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> # v1
>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>>> index 5c72462d1f57..b22e2019768f 100644
>>> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>>> @@ -1131,7 +1131,7 @@ static vm_fault_t vm_fault_ttm(struct vm_fault *vmf)
>>> GEM_WARN_ON(!i915_ttm_cpu_maps_iomem(bo->resource));
>>> }
>>>
>>> - if (wakeref & CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND)
>>> + if (wakeref && CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND != 0)
>>> intel_wakeref_auto(&to_i915(obj->base.dev)->runtime_pm.userfault_wakeref,
>>> msecs_to_jiffies_timeout(CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND));
>>>
>>> --
>>> 2.39.2
>>>
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH v2 1/6] drm/i915/gem: fix bitwise and logical AND mixup
2024-09-30 13:54 ` Jani Nikula
@ 2024-09-30 14:23 ` Matthew Auld
2024-09-30 14:58 ` Jani Nikula
0 siblings, 1 reply; 24+ messages in thread
From: Matthew Auld @ 2024-09-30 14:23 UTC (permalink / raw)
To: Jani Nikula, Rodrigo Vivi
Cc: intel-gfx, intel-xe, Anshuman Gupta, Andi Shyti,
Nathan Chancellor, stable
On 30/09/2024 14:54, Jani Nikula wrote:
> On Fri, 27 Sep 2024, Jani Nikula <jani.nikula@intel.com> wrote:
>> On Thu, 26 Sep 2024, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
>>> On Wed, Sep 18, 2024 at 08:35:43PM +0300, Jani Nikula wrote:
>>>> CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND is an int, defaulting to 250. When
>>>> the wakeref is non-zero, it's either -1 or a dynamically allocated
>>>> pointer, depending on CONFIG_DRM_I915_DEBUG_RUNTIME_PM. It's likely that
>>>> the code works by coincidence with the bitwise AND, but with
>>>> CONFIG_DRM_I915_DEBUG_RUNTIME_PM=y, there's the off chance that the
>>>> condition evaluates to false, and intel_wakeref_auto() doesn't get
>>>> called. Switch to the intended logical AND.
>>>>
>>>> v2: Use != to avoid clang -Wconstant-logical-operand (Nathan)
>>>
>>> oh, this is ugly!
>>>
>>> Wouldn't it be better then to use IS_ENABLED() macro?
>>
>> It's an int config option, not a bool. (Yes, the name is misleading.)
>>
>> IS_ENABLED(CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND) would be the same as
>> CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND == 1.
>>
>> We're actually checking if the int value != 0, so IMO the patch at hand
>> is fine.
>
> Ping, r-b on this one too?
r-b still holds for v2, fwiw.
>
> BR,
> Jani.
>
>>
>> BR,
>> Jani.
>>
>>
>>>
>>>>
>>>> Fixes: ad74457a6b5a ("drm/i915/dgfx: Release mmap on rpm suspend")
>>>> Cc: Matthew Auld <matthew.auld@intel.com>
>>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>>> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
>>>> Cc: Andi Shyti <andi.shyti@linux.intel.com>
>>>> Cc: Nathan Chancellor <nathan@kernel.org>
>>>> Cc: <stable@vger.kernel.org> # v6.1+
>>>> Reviewed-by: Matthew Auld <matthew.auld@intel.com> # v1
>>>> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> # v1
>>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>>> ---
>>>> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>>>> index 5c72462d1f57..b22e2019768f 100644
>>>> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>>>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>>>> @@ -1131,7 +1131,7 @@ static vm_fault_t vm_fault_ttm(struct vm_fault *vmf)
>>>> GEM_WARN_ON(!i915_ttm_cpu_maps_iomem(bo->resource));
>>>> }
>>>>
>>>> - if (wakeref & CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND)
>>>> + if (wakeref && CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND != 0)
>>>> intel_wakeref_auto(&to_i915(obj->base.dev)->runtime_pm.userfault_wakeref,
>>>> msecs_to_jiffies_timeout(CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND));
>>>>
>>>> --
>>>> 2.39.2
>>>>
>
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH v2 1/6] drm/i915/gem: fix bitwise and logical AND mixup
2024-09-30 14:23 ` Matthew Auld
@ 2024-09-30 14:58 ` Jani Nikula
0 siblings, 0 replies; 24+ messages in thread
From: Jani Nikula @ 2024-09-30 14:58 UTC (permalink / raw)
To: Matthew Auld, Rodrigo Vivi
Cc: intel-gfx, intel-xe, Anshuman Gupta, Andi Shyti,
Nathan Chancellor, stable
On Mon, 30 Sep 2024, Matthew Auld <matthew.auld@intel.com> wrote:
> On 30/09/2024 14:54, Jani Nikula wrote:
>> On Fri, 27 Sep 2024, Jani Nikula <jani.nikula@intel.com> wrote:
>>> On Thu, 26 Sep 2024, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
>>>> On Wed, Sep 18, 2024 at 08:35:43PM +0300, Jani Nikula wrote:
>>>>> CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND is an int, defaulting to 250. When
>>>>> the wakeref is non-zero, it's either -1 or a dynamically allocated
>>>>> pointer, depending on CONFIG_DRM_I915_DEBUG_RUNTIME_PM. It's likely that
>>>>> the code works by coincidence with the bitwise AND, but with
>>>>> CONFIG_DRM_I915_DEBUG_RUNTIME_PM=y, there's the off chance that the
>>>>> condition evaluates to false, and intel_wakeref_auto() doesn't get
>>>>> called. Switch to the intended logical AND.
>>>>>
>>>>> v2: Use != to avoid clang -Wconstant-logical-operand (Nathan)
>>>>
>>>> oh, this is ugly!
>>>>
>>>> Wouldn't it be better then to use IS_ENABLED() macro?
>>>
>>> It's an int config option, not a bool. (Yes, the name is misleading.)
>>>
>>> IS_ENABLED(CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND) would be the same as
>>> CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND == 1.
>>>
>>> We're actually checking if the int value != 0, so IMO the patch at hand
>>> is fine.
>>
>> Ping, r-b on this one too?
>
> r-b still holds for v2, fwiw.
Thanks for the reviews, pushed the lot to drm-intel-next.
BR,
Jani.
>
>>
>> BR,
>> Jani.
>>
>>>
>>> BR,
>>> Jani.
>>>
>>>
>>>>
>>>>>
>>>>> Fixes: ad74457a6b5a ("drm/i915/dgfx: Release mmap on rpm suspend")
>>>>> Cc: Matthew Auld <matthew.auld@intel.com>
>>>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>>>> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
>>>>> Cc: Andi Shyti <andi.shyti@linux.intel.com>
>>>>> Cc: Nathan Chancellor <nathan@kernel.org>
>>>>> Cc: <stable@vger.kernel.org> # v6.1+
>>>>> Reviewed-by: Matthew Auld <matthew.auld@intel.com> # v1
>>>>> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> # v1
>>>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>>>> ---
>>>>> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>>>>> index 5c72462d1f57..b22e2019768f 100644
>>>>> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>>>>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>>>>> @@ -1131,7 +1131,7 @@ static vm_fault_t vm_fault_ttm(struct vm_fault *vmf)
>>>>> GEM_WARN_ON(!i915_ttm_cpu_maps_iomem(bo->resource));
>>>>> }
>>>>>
>>>>> - if (wakeref & CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND)
>>>>> + if (wakeref && CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND != 0)
>>>>> intel_wakeref_auto(&to_i915(obj->base.dev)->runtime_pm.userfault_wakeref,
>>>>> msecs_to_jiffies_timeout(CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND));
>>>>>
>>>>> --
>>>>> 2.39.2
>>>>>
>>
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 2/6] drm/i915: use INTEL_WAKEREF_DEF instead of magic -1 for intel_wakeref_t
2024-09-18 17:35 [PATCH v2 0/6] drm/i915: wakeref fixes and improvements Jani Nikula
2024-09-18 17:35 ` [PATCH v2 1/6] drm/i915/gem: fix bitwise and logical AND mixup Jani Nikula
@ 2024-09-18 17:35 ` Jani Nikula
2024-09-26 20:45 ` Rodrigo Vivi
2024-09-18 17:35 ` [PATCH v2 3/6] drm/i915/display: return 0 instead of false for disabled power wakeref Jani Nikula
` (10 subsequent siblings)
12 siblings, 1 reply; 24+ messages in thread
From: Jani Nikula @ 2024-09-18 17:35 UTC (permalink / raw)
To: intel-gfx, intel-xe; +Cc: jani.nikula
A number of places rely on the magic -1 to denote
INTEL_WAKEREF_DEF. Switch to the macro. Define it for xe as well.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
drivers/gpu/drm/i915/display/intel_display_power.h | 4 ++--
drivers/gpu/drm/i915/intel_runtime_pm.c | 6 +++---
drivers/gpu/drm/i915/intel_wakeref.h | 2 +-
| 7 ++++---
| 2 ++
6 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index ecabb674644b..40727a22f18b 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -895,7 +895,7 @@ intel_display_power_put_mask_in_set(struct drm_i915_private *i915,
!bitmap_subset(mask->bits, power_domain_set->mask.bits, POWER_DOMAIN_NUM));
for_each_power_domain(domain, mask) {
- intel_wakeref_t __maybe_unused wf = -1;
+ intel_wakeref_t __maybe_unused wf = INTEL_WAKEREF_DEF;
#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
wf = fetch_and_zero(&power_domain_set->wakerefs[domain]);
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
index 425452c5a469..3b7c1a0bb1de 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power.h
@@ -232,7 +232,7 @@ intel_display_power_put_async(struct drm_i915_private *i915,
enum intel_display_power_domain domain,
intel_wakeref_t wakeref)
{
- __intel_display_power_put_async(i915, domain, -1, -1);
+ __intel_display_power_put_async(i915, domain, INTEL_WAKEREF_DEF, -1);
}
static inline void
@@ -241,7 +241,7 @@ intel_display_power_put_async_delay(struct drm_i915_private *i915,
intel_wakeref_t wakeref,
int delay_ms)
{
- __intel_display_power_put_async(i915, domain, -1, delay_ms);
+ __intel_display_power_put_async(i915, domain, INTEL_WAKEREF_DEF, delay_ms);
}
#endif
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index 2d0647aca964..a21f5a1c89bc 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -66,7 +66,7 @@ static intel_wakeref_t
track_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm)
{
if (!rpm->available || rpm->no_wakeref_tracking)
- return -1;
+ return INTEL_WAKEREF_DEF;
return intel_ref_tracker_alloc(&rpm->debug);
}
@@ -114,7 +114,7 @@ static void init_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm)
static intel_wakeref_t
track_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm)
{
- return -1;
+ return INTEL_WAKEREF_DEF;
}
static void untrack_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm,
@@ -336,7 +336,7 @@ intel_runtime_pm_put_raw(struct intel_runtime_pm *rpm, intel_wakeref_t wref)
*/
void intel_runtime_pm_put_unchecked(struct intel_runtime_pm *rpm)
{
- __intel_runtime_pm_put(rpm, -1, true);
+ __intel_runtime_pm_put(rpm, INTEL_WAKEREF_DEF, true);
}
#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
diff --git a/drivers/gpu/drm/i915/intel_wakeref.h b/drivers/gpu/drm/i915/intel_wakeref.h
index 68aa3be48251..3944587a5e78 100644
--- a/drivers/gpu/drm/i915/intel_wakeref.h
+++ b/drivers/gpu/drm/i915/intel_wakeref.h
@@ -314,7 +314,7 @@ static inline void intel_wakeref_untrack(struct intel_wakeref *wf,
static inline intel_wakeref_t intel_wakeref_track(struct intel_wakeref *wf)
{
- return -1;
+ return INTEL_WAKEREF_DEF;
}
static inline void intel_wakeref_untrack(struct intel_wakeref *wf,
--git a/drivers/gpu/drm/xe/compat-i915-headers/intel_runtime_pm.h b/drivers/gpu/drm/xe/compat-i915-headers/intel_runtime_pm.h
index 8c7b315aa8ac..380d25428bdb 100644
--- a/drivers/gpu/drm/xe/compat-i915-headers/intel_runtime_pm.h
+++ b/drivers/gpu/drm/xe/compat-i915-headers/intel_runtime_pm.h
@@ -24,14 +24,14 @@ static inline intel_wakeref_t intel_runtime_pm_get(struct xe_runtime_pm *pm)
{
struct xe_device *xe = container_of(pm, struct xe_device, runtime_pm);
- return xe_pm_runtime_resume_and_get(xe);
+ return xe_pm_runtime_resume_and_get(xe) ? INTEL_WAKEREF_DEF : 0;
}
static inline intel_wakeref_t intel_runtime_pm_get_if_in_use(struct xe_runtime_pm *pm)
{
struct xe_device *xe = container_of(pm, struct xe_device, runtime_pm);
- return xe_pm_runtime_get_if_in_use(xe);
+ return xe_pm_runtime_get_if_in_use(xe) ? INTEL_WAKEREF_DEF : 0;
}
static inline intel_wakeref_t intel_runtime_pm_get_noresume(struct xe_runtime_pm *pm)
@@ -39,7 +39,8 @@ static inline intel_wakeref_t intel_runtime_pm_get_noresume(struct xe_runtime_pm
struct xe_device *xe = container_of(pm, struct xe_device, runtime_pm);
xe_pm_runtime_get_noresume(xe);
- return true;
+
+ return INTEL_WAKEREF_DEF;
}
static inline void intel_runtime_pm_put_unchecked(struct xe_runtime_pm *pm)
--git a/drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h b/drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h
index ecb1c0707706..5c139ba144a6 100644
--- a/drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h
+++ b/drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h
@@ -6,3 +6,5 @@
#include <linux/types.h>
typedef unsigned long intel_wakeref_t;
+
+#define INTEL_WAKEREF_DEF ((intel_wakeref_t)(-1))
--
2.39.2
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH v2 2/6] drm/i915: use INTEL_WAKEREF_DEF instead of magic -1 for intel_wakeref_t
2024-09-18 17:35 ` [PATCH v2 2/6] drm/i915: use INTEL_WAKEREF_DEF instead of magic -1 for intel_wakeref_t Jani Nikula
@ 2024-09-26 20:45 ` Rodrigo Vivi
0 siblings, 0 replies; 24+ messages in thread
From: Rodrigo Vivi @ 2024-09-26 20:45 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, intel-xe
On Wed, Sep 18, 2024 at 08:35:44PM +0300, Jani Nikula wrote:
> A number of places rely on the magic -1 to denote
> INTEL_WAKEREF_DEF. Switch to the macro. Define it for xe as well.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
> drivers/gpu/drm/i915/display/intel_display_power.h | 4 ++--
> drivers/gpu/drm/i915/intel_runtime_pm.c | 6 +++---
> drivers/gpu/drm/i915/intel_wakeref.h | 2 +-
> drivers/gpu/drm/xe/compat-i915-headers/intel_runtime_pm.h | 7 ++++---
> drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h | 2 ++
> 6 files changed, 13 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> index ecabb674644b..40727a22f18b 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -895,7 +895,7 @@ intel_display_power_put_mask_in_set(struct drm_i915_private *i915,
> !bitmap_subset(mask->bits, power_domain_set->mask.bits, POWER_DOMAIN_NUM));
>
> for_each_power_domain(domain, mask) {
> - intel_wakeref_t __maybe_unused wf = -1;
> + intel_wakeref_t __maybe_unused wf = INTEL_WAKEREF_DEF;
>
> #if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
> wf = fetch_and_zero(&power_domain_set->wakerefs[domain]);
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
> index 425452c5a469..3b7c1a0bb1de 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.h
> @@ -232,7 +232,7 @@ intel_display_power_put_async(struct drm_i915_private *i915,
> enum intel_display_power_domain domain,
> intel_wakeref_t wakeref)
> {
> - __intel_display_power_put_async(i915, domain, -1, -1);
> + __intel_display_power_put_async(i915, domain, INTEL_WAKEREF_DEF, -1);
> }
>
> static inline void
> @@ -241,7 +241,7 @@ intel_display_power_put_async_delay(struct drm_i915_private *i915,
> intel_wakeref_t wakeref,
> int delay_ms)
> {
> - __intel_display_power_put_async(i915, domain, -1, delay_ms);
> + __intel_display_power_put_async(i915, domain, INTEL_WAKEREF_DEF, delay_ms);
> }
> #endif
>
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index 2d0647aca964..a21f5a1c89bc 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -66,7 +66,7 @@ static intel_wakeref_t
> track_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm)
> {
> if (!rpm->available || rpm->no_wakeref_tracking)
> - return -1;
> + return INTEL_WAKEREF_DEF;
>
> return intel_ref_tracker_alloc(&rpm->debug);
> }
> @@ -114,7 +114,7 @@ static void init_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm)
> static intel_wakeref_t
> track_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm)
> {
> - return -1;
> + return INTEL_WAKEREF_DEF;
> }
>
> static void untrack_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm,
> @@ -336,7 +336,7 @@ intel_runtime_pm_put_raw(struct intel_runtime_pm *rpm, intel_wakeref_t wref)
> */
> void intel_runtime_pm_put_unchecked(struct intel_runtime_pm *rpm)
> {
> - __intel_runtime_pm_put(rpm, -1, true);
> + __intel_runtime_pm_put(rpm, INTEL_WAKEREF_DEF, true);
> }
>
> #if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
> diff --git a/drivers/gpu/drm/i915/intel_wakeref.h b/drivers/gpu/drm/i915/intel_wakeref.h
> index 68aa3be48251..3944587a5e78 100644
> --- a/drivers/gpu/drm/i915/intel_wakeref.h
> +++ b/drivers/gpu/drm/i915/intel_wakeref.h
> @@ -314,7 +314,7 @@ static inline void intel_wakeref_untrack(struct intel_wakeref *wf,
>
> static inline intel_wakeref_t intel_wakeref_track(struct intel_wakeref *wf)
> {
> - return -1;
> + return INTEL_WAKEREF_DEF;
> }
>
> static inline void intel_wakeref_untrack(struct intel_wakeref *wf,
> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/intel_runtime_pm.h b/drivers/gpu/drm/xe/compat-i915-headers/intel_runtime_pm.h
> index 8c7b315aa8ac..380d25428bdb 100644
> --- a/drivers/gpu/drm/xe/compat-i915-headers/intel_runtime_pm.h
> +++ b/drivers/gpu/drm/xe/compat-i915-headers/intel_runtime_pm.h
> @@ -24,14 +24,14 @@ static inline intel_wakeref_t intel_runtime_pm_get(struct xe_runtime_pm *pm)
> {
> struct xe_device *xe = container_of(pm, struct xe_device, runtime_pm);
>
> - return xe_pm_runtime_resume_and_get(xe);
> + return xe_pm_runtime_resume_and_get(xe) ? INTEL_WAKEREF_DEF : 0;
> }
>
> static inline intel_wakeref_t intel_runtime_pm_get_if_in_use(struct xe_runtime_pm *pm)
> {
> struct xe_device *xe = container_of(pm, struct xe_device, runtime_pm);
>
> - return xe_pm_runtime_get_if_in_use(xe);
> + return xe_pm_runtime_get_if_in_use(xe) ? INTEL_WAKEREF_DEF : 0;
> }
>
> static inline intel_wakeref_t intel_runtime_pm_get_noresume(struct xe_runtime_pm *pm)
> @@ -39,7 +39,8 @@ static inline intel_wakeref_t intel_runtime_pm_get_noresume(struct xe_runtime_pm
> struct xe_device *xe = container_of(pm, struct xe_device, runtime_pm);
>
> xe_pm_runtime_get_noresume(xe);
> - return true;
> +
> + return INTEL_WAKEREF_DEF;
oh! for some reason I thought we were redefining the intel_wakeref_t to bool
here in Xe...
> }
>
> static inline void intel_runtime_pm_put_unchecked(struct xe_runtime_pm *pm)
> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h b/drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h
> index ecb1c0707706..5c139ba144a6 100644
> --- a/drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h
> +++ b/drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h
> @@ -6,3 +6,5 @@
> #include <linux/types.h>
>
> typedef unsigned long intel_wakeref_t;
but apparently not, but we were lucky!
this definition brings more clarity indeed.
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> +
> +#define INTEL_WAKEREF_DEF ((intel_wakeref_t)(-1))
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 3/6] drm/i915/display: return 0 instead of false for disabled power wakeref
2024-09-18 17:35 [PATCH v2 0/6] drm/i915: wakeref fixes and improvements Jani Nikula
2024-09-18 17:35 ` [PATCH v2 1/6] drm/i915/gem: fix bitwise and logical AND mixup Jani Nikula
2024-09-18 17:35 ` [PATCH v2 2/6] drm/i915: use INTEL_WAKEREF_DEF instead of magic -1 for intel_wakeref_t Jani Nikula
@ 2024-09-18 17:35 ` Jani Nikula
2024-09-26 20:46 ` Rodrigo Vivi
2024-09-18 17:35 ` [PATCH v2 4/6] drm/i915/gt: add a macro for mock gt wakeref special value and use it Jani Nikula
` (9 subsequent siblings)
12 siblings, 1 reply; 24+ messages in thread
From: Jani Nikula @ 2024-09-18 17:35 UTC (permalink / raw)
To: intel-gfx, intel-xe; +Cc: jani.nikula, kernel test robot
We can use 0 for intel_wakeref_t, but not false. Fix it.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202409190032.ZCHBxK9e-lkp@intel.com/
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index 40727a22f18b..7b16ba1a8226 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -545,7 +545,7 @@ intel_display_power_get_if_enabled(struct drm_i915_private *dev_priv,
wakeref = intel_runtime_pm_get_if_in_use(&dev_priv->runtime_pm);
if (!wakeref)
- return false;
+ return 0;
mutex_lock(&power_domains->lock);
--
2.39.2
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH v2 3/6] drm/i915/display: return 0 instead of false for disabled power wakeref
2024-09-18 17:35 ` [PATCH v2 3/6] drm/i915/display: return 0 instead of false for disabled power wakeref Jani Nikula
@ 2024-09-26 20:46 ` Rodrigo Vivi
0 siblings, 0 replies; 24+ messages in thread
From: Rodrigo Vivi @ 2024-09-26 20:46 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, intel-xe, kernel test robot
On Wed, Sep 18, 2024 at 08:35:45PM +0300, Jani Nikula wrote:
> We can use 0 for intel_wakeref_t, but not false. Fix it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202409190032.ZCHBxK9e-lkp@intel.com/
my bad, sorry!
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> index 40727a22f18b..7b16ba1a8226 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -545,7 +545,7 @@ intel_display_power_get_if_enabled(struct drm_i915_private *dev_priv,
>
> wakeref = intel_runtime_pm_get_if_in_use(&dev_priv->runtime_pm);
> if (!wakeref)
> - return false;
> + return 0;
>
> mutex_lock(&power_domains->lock);
>
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 4/6] drm/i915/gt: add a macro for mock gt wakeref special value and use it
2024-09-18 17:35 [PATCH v2 0/6] drm/i915: wakeref fixes and improvements Jani Nikula
` (2 preceding siblings ...)
2024-09-18 17:35 ` [PATCH v2 3/6] drm/i915/display: return 0 instead of false for disabled power wakeref Jani Nikula
@ 2024-09-18 17:35 ` Jani Nikula
2024-09-26 20:49 ` Rodrigo Vivi
2024-09-18 17:35 ` [PATCH v2 5/6] drm/i915/audio: be explicit about intel_wakeref_t conversions Jani Nikula
` (8 subsequent siblings)
12 siblings, 1 reply; 24+ messages in thread
From: Jani Nikula @ 2024-09-18 17:35 UTC (permalink / raw)
To: intel-gfx, intel-xe; +Cc: jani.nikula
Add a dedicated macro for the special mock gt wakeref value, with a cast
to intel_wakeref_t, instead of assuming you can assign or compare the
wakeref to -ENODEV directly.
Arguably the whole thing is a hack that should not exist, but at least
make it slightly less hacky.
Side note: If this value were to ever end up in
intel_ref_tracker_free(), it would wreak havoc.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/gt/intel_gt_pm.h | 6 +++++-
drivers/gpu/drm/i915/gt/intel_tlb.c | 2 +-
drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +-
3 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.h b/drivers/gpu/drm/i915/gt/intel_gt_pm.h
index 911fd0160221..fef8d5d288f8 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm.h
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.h
@@ -105,9 +105,13 @@ int intel_gt_runtime_resume(struct intel_gt *gt);
ktime_t intel_gt_get_awake_time(const struct intel_gt *gt);
+#define INTEL_WAKEREF_MOCK_GT ((intel_wakeref_t)-ENODEV)
+
static inline bool is_mock_gt(const struct intel_gt *gt)
{
- return I915_SELFTEST_ONLY(gt->awake == -ENODEV);
+ BUILD_BUG_ON(INTEL_WAKEREF_DEF == INTEL_WAKEREF_MOCK_GT);
+
+ return I915_SELFTEST_ONLY(gt->awake == INTEL_WAKEREF_MOCK_GT);
}
#endif /* INTEL_GT_PM_H */
diff --git a/drivers/gpu/drm/i915/gt/intel_tlb.c b/drivers/gpu/drm/i915/gt/intel_tlb.c
index 756e9ebbc725..2487768bc230 100644
--- a/drivers/gpu/drm/i915/gt/intel_tlb.c
+++ b/drivers/gpu/drm/i915/gt/intel_tlb.c
@@ -122,7 +122,7 @@ void intel_gt_invalidate_tlb_full(struct intel_gt *gt, u32 seqno)
{
intel_wakeref_t wakeref;
- if (I915_SELFTEST_ONLY(gt->awake == -ENODEV))
+ if (is_mock_gt(gt))
return;
if (intel_gt_is_wedged(gt))
diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
index 70f3d7bf47d0..ae57eb03dfca 100644
--- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
+++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
@@ -203,7 +203,7 @@ struct drm_i915_private *mock_gem_device(void)
intel_root_gt_init_early(i915);
mock_uncore_init(&i915->uncore, i915);
atomic_inc(&to_gt(i915)->wakeref.count); /* disable; no hw support */
- to_gt(i915)->awake = -ENODEV;
+ to_gt(i915)->awake = INTEL_WAKEREF_MOCK_GT;
mock_gt_probe(i915);
ret = intel_region_ttm_device_init(i915);
--
2.39.2
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH v2 4/6] drm/i915/gt: add a macro for mock gt wakeref special value and use it
2024-09-18 17:35 ` [PATCH v2 4/6] drm/i915/gt: add a macro for mock gt wakeref special value and use it Jani Nikula
@ 2024-09-26 20:49 ` Rodrigo Vivi
0 siblings, 0 replies; 24+ messages in thread
From: Rodrigo Vivi @ 2024-09-26 20:49 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, intel-xe
On Wed, Sep 18, 2024 at 08:35:46PM +0300, Jani Nikula wrote:
> Add a dedicated macro for the special mock gt wakeref value, with a cast
> to intel_wakeref_t, instead of assuming you can assign or compare the
> wakeref to -ENODEV directly.
>
> Arguably the whole thing is a hack that should not exist, but at least
> make it slightly less hacky.
I couldn't agree more
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Side note: If this value were to ever end up in
> intel_ref_tracker_free(), it would wreak havoc.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_gt_pm.h | 6 +++++-
> drivers/gpu/drm/i915/gt/intel_tlb.c | 2 +-
> drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +-
> 3 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.h b/drivers/gpu/drm/i915/gt/intel_gt_pm.h
> index 911fd0160221..fef8d5d288f8 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.h
> @@ -105,9 +105,13 @@ int intel_gt_runtime_resume(struct intel_gt *gt);
>
> ktime_t intel_gt_get_awake_time(const struct intel_gt *gt);
>
> +#define INTEL_WAKEREF_MOCK_GT ((intel_wakeref_t)-ENODEV)
> +
> static inline bool is_mock_gt(const struct intel_gt *gt)
> {
> - return I915_SELFTEST_ONLY(gt->awake == -ENODEV);
> + BUILD_BUG_ON(INTEL_WAKEREF_DEF == INTEL_WAKEREF_MOCK_GT);
> +
> + return I915_SELFTEST_ONLY(gt->awake == INTEL_WAKEREF_MOCK_GT);
> }
>
> #endif /* INTEL_GT_PM_H */
> diff --git a/drivers/gpu/drm/i915/gt/intel_tlb.c b/drivers/gpu/drm/i915/gt/intel_tlb.c
> index 756e9ebbc725..2487768bc230 100644
> --- a/drivers/gpu/drm/i915/gt/intel_tlb.c
> +++ b/drivers/gpu/drm/i915/gt/intel_tlb.c
> @@ -122,7 +122,7 @@ void intel_gt_invalidate_tlb_full(struct intel_gt *gt, u32 seqno)
> {
> intel_wakeref_t wakeref;
>
> - if (I915_SELFTEST_ONLY(gt->awake == -ENODEV))
> + if (is_mock_gt(gt))
> return;
>
> if (intel_gt_is_wedged(gt))
> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> index 70f3d7bf47d0..ae57eb03dfca 100644
> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> @@ -203,7 +203,7 @@ struct drm_i915_private *mock_gem_device(void)
> intel_root_gt_init_early(i915);
> mock_uncore_init(&i915->uncore, i915);
> atomic_inc(&to_gt(i915)->wakeref.count); /* disable; no hw support */
> - to_gt(i915)->awake = -ENODEV;
> + to_gt(i915)->awake = INTEL_WAKEREF_MOCK_GT;
> mock_gt_probe(i915);
>
> ret = intel_region_ttm_device_init(i915);
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 5/6] drm/i915/audio: be explicit about intel_wakeref_t conversions
2024-09-18 17:35 [PATCH v2 0/6] drm/i915: wakeref fixes and improvements Jani Nikula
` (3 preceding siblings ...)
2024-09-18 17:35 ` [PATCH v2 4/6] drm/i915/gt: add a macro for mock gt wakeref special value and use it Jani Nikula
@ 2024-09-18 17:35 ` Jani Nikula
2024-09-26 20:49 ` Rodrigo Vivi
2024-09-18 17:35 ` [PATCH v2 6/6] drm/i915: switch intel_wakeref_t underlying type to struct ref_tracker * Jani Nikula
` (7 subsequent siblings)
12 siblings, 1 reply; 24+ messages in thread
From: Jani Nikula @ 2024-09-18 17:35 UTC (permalink / raw)
To: intel-gfx, intel-xe; +Cc: jani.nikula
Use explicit casts to convert between intel_wakeref_t and unsigned long,
to not rely on intel_wakeref_t underlying type remaining unsigned long,
allowing us to change it as needed. (And yes, this is indeed preparation
for changing the typedef for intel_wakeref_t.)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_audio.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c
index f5e7eefab2f1..32aa9ec1a204 100644
--- a/drivers/gpu/drm/i915/display/intel_audio.c
+++ b/drivers/gpu/drm/i915/display/intel_audio.c
@@ -982,12 +982,12 @@ static unsigned long i915_audio_component_get_power(struct device *kdev)
{
struct intel_display *display = to_intel_display(kdev);
struct drm_i915_private *i915 = to_i915(display->drm);
- intel_wakeref_t ret;
+ intel_wakeref_t wakeref;
/* Catch potential impedance mismatches before they occur! */
BUILD_BUG_ON(sizeof(intel_wakeref_t) > sizeof(unsigned long));
- ret = intel_display_power_get(i915, POWER_DOMAIN_AUDIO_PLAYBACK);
+ wakeref = intel_display_power_get(i915, POWER_DOMAIN_AUDIO_PLAYBACK);
if (i915->display.audio.power_refcount++ == 0) {
if (DISPLAY_VER(i915) >= 9) {
@@ -1007,7 +1007,7 @@ static unsigned long i915_audio_component_get_power(struct device *kdev)
0, AUD_PIN_BUF_ENABLE);
}
- return ret;
+ return (unsigned long)wakeref;
}
static void i915_audio_component_put_power(struct device *kdev,
@@ -1015,13 +1015,14 @@ static void i915_audio_component_put_power(struct device *kdev,
{
struct intel_display *display = to_intel_display(kdev);
struct drm_i915_private *i915 = to_i915(display->drm);
+ intel_wakeref_t wakeref = (intel_wakeref_t)cookie;
/* Stop forcing CDCLK to 2*BCLK if no need for audio to be powered. */
if (--i915->display.audio.power_refcount == 0)
if (IS_GEMINILAKE(i915))
glk_force_audio_cdclk(i915, false);
- intel_display_power_put(i915, POWER_DOMAIN_AUDIO_PLAYBACK, cookie);
+ intel_display_power_put(i915, POWER_DOMAIN_AUDIO_PLAYBACK, wakeref);
}
static void i915_audio_component_codec_wake_override(struct device *kdev,
--
2.39.2
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH v2 5/6] drm/i915/audio: be explicit about intel_wakeref_t conversions
2024-09-18 17:35 ` [PATCH v2 5/6] drm/i915/audio: be explicit about intel_wakeref_t conversions Jani Nikula
@ 2024-09-26 20:49 ` Rodrigo Vivi
0 siblings, 0 replies; 24+ messages in thread
From: Rodrigo Vivi @ 2024-09-26 20:49 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, intel-xe
On Wed, Sep 18, 2024 at 08:35:47PM +0300, Jani Nikula wrote:
> Use explicit casts to convert between intel_wakeref_t and unsigned long,
> to not rely on intel_wakeref_t underlying type remaining unsigned long,
> allowing us to change it as needed. (And yes, this is indeed preparation
> for changing the typedef for intel_wakeref_t.)
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_audio.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c
> index f5e7eefab2f1..32aa9ec1a204 100644
> --- a/drivers/gpu/drm/i915/display/intel_audio.c
> +++ b/drivers/gpu/drm/i915/display/intel_audio.c
> @@ -982,12 +982,12 @@ static unsigned long i915_audio_component_get_power(struct device *kdev)
> {
> struct intel_display *display = to_intel_display(kdev);
> struct drm_i915_private *i915 = to_i915(display->drm);
> - intel_wakeref_t ret;
> + intel_wakeref_t wakeref;
>
> /* Catch potential impedance mismatches before they occur! */
> BUILD_BUG_ON(sizeof(intel_wakeref_t) > sizeof(unsigned long));
>
> - ret = intel_display_power_get(i915, POWER_DOMAIN_AUDIO_PLAYBACK);
> + wakeref = intel_display_power_get(i915, POWER_DOMAIN_AUDIO_PLAYBACK);
>
> if (i915->display.audio.power_refcount++ == 0) {
> if (DISPLAY_VER(i915) >= 9) {
> @@ -1007,7 +1007,7 @@ static unsigned long i915_audio_component_get_power(struct device *kdev)
> 0, AUD_PIN_BUF_ENABLE);
> }
>
> - return ret;
> + return (unsigned long)wakeref;
> }
>
> static void i915_audio_component_put_power(struct device *kdev,
> @@ -1015,13 +1015,14 @@ static void i915_audio_component_put_power(struct device *kdev,
> {
> struct intel_display *display = to_intel_display(kdev);
> struct drm_i915_private *i915 = to_i915(display->drm);
> + intel_wakeref_t wakeref = (intel_wakeref_t)cookie;
>
> /* Stop forcing CDCLK to 2*BCLK if no need for audio to be powered. */
> if (--i915->display.audio.power_refcount == 0)
> if (IS_GEMINILAKE(i915))
> glk_force_audio_cdclk(i915, false);
>
> - intel_display_power_put(i915, POWER_DOMAIN_AUDIO_PLAYBACK, cookie);
> + intel_display_power_put(i915, POWER_DOMAIN_AUDIO_PLAYBACK, wakeref);
> }
>
> static void i915_audio_component_codec_wake_override(struct device *kdev,
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 6/6] drm/i915: switch intel_wakeref_t underlying type to struct ref_tracker *
2024-09-18 17:35 [PATCH v2 0/6] drm/i915: wakeref fixes and improvements Jani Nikula
` (4 preceding siblings ...)
2024-09-18 17:35 ` [PATCH v2 5/6] drm/i915/audio: be explicit about intel_wakeref_t conversions Jani Nikula
@ 2024-09-18 17:35 ` Jani Nikula
2024-09-26 20:52 ` Rodrigo Vivi
2024-09-18 18:24 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: wakeref fixes and improvements (rev2) Patchwork
` (6 subsequent siblings)
12 siblings, 1 reply; 24+ messages in thread
From: Jani Nikula @ 2024-09-18 17:35 UTC (permalink / raw)
To: intel-gfx, intel-xe; +Cc: jani.nikula
For intel_wakeref_t, opaque is reasonable, but disguising the underlying
struct ref_tracker * as an unsigned long is not so great. Update the
typedef to remove one level of disguise.
Although the kernel coding style strongly discourages pointer typedefs,
it's a better alternative, and an incremental improvement on the status
quo. It provides much better type safety than an unsigned long could,
and prevents passing magic -1 instead of INTEL_WAKEREF_DEF. Moreover, it
provides a gradual path for replacing intel_wakeref_t with struct
ref_tracker * if desired.
As an extra safety measure, check for error pointers in
intel_ref_tracker_free() before passing them on to ref_tracker_free(),
to catch any mistakes with mock gt special wakeref value.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/gt/intel_gt_pm.h | 2 +-
drivers/gpu/drm/i915/intel_wakeref.h | 16 +++++++++-------
| 4 ++--
3 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.h b/drivers/gpu/drm/i915/gt/intel_gt_pm.h
index fef8d5d288f8..dcbfc09194b7 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm.h
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.h
@@ -105,7 +105,7 @@ int intel_gt_runtime_resume(struct intel_gt *gt);
ktime_t intel_gt_get_awake_time(const struct intel_gt *gt);
-#define INTEL_WAKEREF_MOCK_GT ((intel_wakeref_t)-ENODEV)
+#define INTEL_WAKEREF_MOCK_GT ERR_PTR(-ENODEV)
static inline bool is_mock_gt(const struct intel_gt *gt)
{
diff --git a/drivers/gpu/drm/i915/intel_wakeref.h b/drivers/gpu/drm/i915/intel_wakeref.h
index 3944587a5e78..48836ef52d40 100644
--- a/drivers/gpu/drm/i915/intel_wakeref.h
+++ b/drivers/gpu/drm/i915/intel_wakeref.h
@@ -21,7 +21,7 @@
#include <linux/timer.h>
#include <linux/workqueue.h>
-typedef unsigned long intel_wakeref_t;
+typedef struct ref_tracker *intel_wakeref_t;
#define INTEL_REFTRACK_DEAD_COUNT 16
#define INTEL_REFTRACK_PRINT_LIMIT 16
@@ -273,7 +273,7 @@ __intel_wakeref_defer_park(struct intel_wakeref *wf)
*/
int intel_wakeref_wait_for_idle(struct intel_wakeref *wf);
-#define INTEL_WAKEREF_DEF ((intel_wakeref_t)(-1))
+#define INTEL_WAKEREF_DEF ERR_PTR(-ENOENT)
static inline intel_wakeref_t intel_ref_tracker_alloc(struct ref_tracker_dir *dir)
{
@@ -281,17 +281,19 @@ static inline intel_wakeref_t intel_ref_tracker_alloc(struct ref_tracker_dir *di
ref_tracker_alloc(dir, &user, GFP_NOWAIT);
- return (intel_wakeref_t)user ?: INTEL_WAKEREF_DEF;
+ return user ?: INTEL_WAKEREF_DEF;
}
static inline void intel_ref_tracker_free(struct ref_tracker_dir *dir,
- intel_wakeref_t handle)
+ intel_wakeref_t wakeref)
{
- struct ref_tracker *user;
+ if (wakeref == INTEL_WAKEREF_DEF)
+ wakeref = NULL;
- user = (handle == INTEL_WAKEREF_DEF) ? NULL : (void *)handle;
+ if (WARN_ON(IS_ERR(wakeref)))
+ return;
- ref_tracker_free(dir, &user);
+ ref_tracker_free(dir, &wakeref);
}
void intel_ref_tracker_show(struct ref_tracker_dir *dir,
--git a/drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h b/drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h
index 5c139ba144a6..2a32faea9db5 100644
--- a/drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h
+++ b/drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h
@@ -5,6 +5,6 @@
#include <linux/types.h>
-typedef unsigned long intel_wakeref_t;
+typedef struct ref_tracker *intel_wakeref_t;
-#define INTEL_WAKEREF_DEF ((intel_wakeref_t)(-1))
+#define INTEL_WAKEREF_DEF ERR_PTR(-ENOENT)
--
2.39.2
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH v2 6/6] drm/i915: switch intel_wakeref_t underlying type to struct ref_tracker *
2024-09-18 17:35 ` [PATCH v2 6/6] drm/i915: switch intel_wakeref_t underlying type to struct ref_tracker * Jani Nikula
@ 2024-09-26 20:52 ` Rodrigo Vivi
0 siblings, 0 replies; 24+ messages in thread
From: Rodrigo Vivi @ 2024-09-26 20:52 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, intel-xe
On Wed, Sep 18, 2024 at 08:35:48PM +0300, Jani Nikula wrote:
> For intel_wakeref_t, opaque is reasonable, but disguising the underlying
> struct ref_tracker * as an unsigned long is not so great. Update the
> typedef to remove one level of disguise.
>
> Although the kernel coding style strongly discourages pointer typedefs,
> it's a better alternative, and an incremental improvement on the status
> quo. It provides much better type safety than an unsigned long could,
> and prevents passing magic -1 instead of INTEL_WAKEREF_DEF. Moreover, it
> provides a gradual path for replacing intel_wakeref_t with struct
> ref_tracker * if desired.
>
> As an extra safety measure, check for error pointers in
> intel_ref_tracker_free() before passing them on to ref_tracker_free(),
> to catch any mistakes with mock gt special wakeref value.
After this would be easy to get a coccinelle or sed
to use ref_tracker directly and kill the typedef?
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_gt_pm.h | 2 +-
> drivers/gpu/drm/i915/intel_wakeref.h | 16 +++++++++-------
> .../drm/xe/compat-i915-headers/intel_wakeref.h | 4 ++--
> 3 files changed, 12 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.h b/drivers/gpu/drm/i915/gt/intel_gt_pm.h
> index fef8d5d288f8..dcbfc09194b7 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.h
> @@ -105,7 +105,7 @@ int intel_gt_runtime_resume(struct intel_gt *gt);
>
> ktime_t intel_gt_get_awake_time(const struct intel_gt *gt);
>
> -#define INTEL_WAKEREF_MOCK_GT ((intel_wakeref_t)-ENODEV)
> +#define INTEL_WAKEREF_MOCK_GT ERR_PTR(-ENODEV)
>
> static inline bool is_mock_gt(const struct intel_gt *gt)
> {
> diff --git a/drivers/gpu/drm/i915/intel_wakeref.h b/drivers/gpu/drm/i915/intel_wakeref.h
> index 3944587a5e78..48836ef52d40 100644
> --- a/drivers/gpu/drm/i915/intel_wakeref.h
> +++ b/drivers/gpu/drm/i915/intel_wakeref.h
> @@ -21,7 +21,7 @@
> #include <linux/timer.h>
> #include <linux/workqueue.h>
>
> -typedef unsigned long intel_wakeref_t;
> +typedef struct ref_tracker *intel_wakeref_t;
>
> #define INTEL_REFTRACK_DEAD_COUNT 16
> #define INTEL_REFTRACK_PRINT_LIMIT 16
> @@ -273,7 +273,7 @@ __intel_wakeref_defer_park(struct intel_wakeref *wf)
> */
> int intel_wakeref_wait_for_idle(struct intel_wakeref *wf);
>
> -#define INTEL_WAKEREF_DEF ((intel_wakeref_t)(-1))
> +#define INTEL_WAKEREF_DEF ERR_PTR(-ENOENT)
>
> static inline intel_wakeref_t intel_ref_tracker_alloc(struct ref_tracker_dir *dir)
> {
> @@ -281,17 +281,19 @@ static inline intel_wakeref_t intel_ref_tracker_alloc(struct ref_tracker_dir *di
>
> ref_tracker_alloc(dir, &user, GFP_NOWAIT);
>
> - return (intel_wakeref_t)user ?: INTEL_WAKEREF_DEF;
> + return user ?: INTEL_WAKEREF_DEF;
> }
>
> static inline void intel_ref_tracker_free(struct ref_tracker_dir *dir,
> - intel_wakeref_t handle)
> + intel_wakeref_t wakeref)
> {
> - struct ref_tracker *user;
> + if (wakeref == INTEL_WAKEREF_DEF)
> + wakeref = NULL;
>
> - user = (handle == INTEL_WAKEREF_DEF) ? NULL : (void *)handle;
> + if (WARN_ON(IS_ERR(wakeref)))
> + return;
>
> - ref_tracker_free(dir, &user);
> + ref_tracker_free(dir, &wakeref);
> }
>
> void intel_ref_tracker_show(struct ref_tracker_dir *dir,
> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h b/drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h
> index 5c139ba144a6..2a32faea9db5 100644
> --- a/drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h
> +++ b/drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h
> @@ -5,6 +5,6 @@
>
> #include <linux/types.h>
>
> -typedef unsigned long intel_wakeref_t;
> +typedef struct ref_tracker *intel_wakeref_t;
>
> -#define INTEL_WAKEREF_DEF ((intel_wakeref_t)(-1))
> +#define INTEL_WAKEREF_DEF ERR_PTR(-ENOENT)
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: wakeref fixes and improvements (rev2)
2024-09-18 17:35 [PATCH v2 0/6] drm/i915: wakeref fixes and improvements Jani Nikula
` (5 preceding siblings ...)
2024-09-18 17:35 ` [PATCH v2 6/6] drm/i915: switch intel_wakeref_t underlying type to struct ref_tracker * Jani Nikula
@ 2024-09-18 18:24 ` Patchwork
2024-09-18 18:24 ` ✗ Fi.CI.SPARSE: " Patchwork
` (5 subsequent siblings)
12 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2024-09-18 18:24 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: wakeref fixes and improvements (rev2)
URL : https://patchwork.freedesktop.org/series/138812/
State : warning
== Summary ==
Error: dim checkpatch failed
bf9ad8284095 drm/i915/gem: fix bitwise and logical AND mixup
5b5b6a58fc4c drm/i915: use INTEL_WAKEREF_DEF instead of magic -1 for intel_wakeref_t
f27fabc88786 drm/i915/display: return 0 instead of false for disabled power wakeref
fd0bd1664672 drm/i915/gt: add a macro for mock gt wakeref special value and use it
6806e3bec70e drm/i915/audio: be explicit about intel_wakeref_t conversions
4f21adeb80b9 drm/i915: switch intel_wakeref_t underlying type to struct ref_tracker *
-:46: WARNING:NEW_TYPEDEFS: do not add new typedefs
#46: FILE: drivers/gpu/drm/i915/intel_wakeref.h:24:
+typedef struct ref_tracker *intel_wakeref_t;
-:93: WARNING:NEW_TYPEDEFS: do not add new typedefs
#93: FILE: drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h:8:
+typedef struct ref_tracker *intel_wakeref_t;
total: 0 errors, 2 warnings, 0 checks, 56 lines checked
^ permalink raw reply [flat|nested] 24+ messages in thread* ✗ Fi.CI.SPARSE: warning for drm/i915: wakeref fixes and improvements (rev2)
2024-09-18 17:35 [PATCH v2 0/6] drm/i915: wakeref fixes and improvements Jani Nikula
` (6 preceding siblings ...)
2024-09-18 18:24 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: wakeref fixes and improvements (rev2) Patchwork
@ 2024-09-18 18:24 ` Patchwork
2024-09-18 18:36 ` ✗ Fi.CI.BAT: failure " Patchwork
` (4 subsequent siblings)
12 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2024-09-18 18:24 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: wakeref fixes and improvements (rev2)
URL : https://patchwork.freedesktop.org/series/138812/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 24+ messages in thread* ✗ Fi.CI.BAT: failure for drm/i915: wakeref fixes and improvements (rev2)
2024-09-18 17:35 [PATCH v2 0/6] drm/i915: wakeref fixes and improvements Jani Nikula
` (7 preceding siblings ...)
2024-09-18 18:24 ` ✗ Fi.CI.SPARSE: " Patchwork
@ 2024-09-18 18:36 ` Patchwork
2024-09-18 21:37 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: wakeref fixes and improvements (rev3) Patchwork
` (3 subsequent siblings)
12 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2024-09-18 18:36 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 11017 bytes --]
== Series Details ==
Series: drm/i915: wakeref fixes and improvements (rev2)
URL : https://patchwork.freedesktop.org/series/138812/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15437 -> Patchwork_138812v2
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_138812v2 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_138812v2, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/index.html
Participating hosts (38 -> 38)
------------------------------
Additional (1): bat-mtlp-6
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_138812v2:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@requests:
- bat-arls-2: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15437/bat-arls-2/igt@i915_selftest@live@requests.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-arls-2/igt@i915_selftest@live@requests.html
Known issues
------------
Here are the changes found in Patchwork_138812v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-mtlp-6: NOTRUN -> [SKIP][3] ([i915#9318])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@debugfs_test@basic-hwmon.html
* igt@fbdev@info:
- bat-mtlp-6: NOTRUN -> [SKIP][4] ([i915#1849] / [i915#2582])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@fbdev@info.html
* igt@fbdev@write:
- bat-mtlp-6: NOTRUN -> [SKIP][5] ([i915#2582]) +3 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@fbdev@write.html
* igt@gem_lmem_swapping@verify-random:
- bat-mtlp-6: NOTRUN -> [SKIP][6] ([i915#4613]) +3 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@gem_lmem_swapping@verify-random.html
* igt@gem_mmap@basic:
- bat-mtlp-6: NOTRUN -> [SKIP][7] ([i915#4083])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@gem_mmap@basic.html
* igt@gem_tiled_blits@basic:
- bat-mtlp-6: NOTRUN -> [SKIP][8] ([i915#4077]) +2 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@gem_tiled_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-mtlp-6: NOTRUN -> [SKIP][9] ([i915#4079]) +1 other test skip
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@gem_tiled_pread_basic.html
* igt@i915_pm_rps@basic-api:
- bat-mtlp-6: NOTRUN -> [SKIP][10] ([i915#11681] / [i915#6621])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@workarounds:
- bat-mtlp-6: NOTRUN -> [ABORT][11] ([i915#12061]) +1 other test abort
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
* igt@kms_addfb_basic@addfb25-x-tiled-legacy:
- bat-mtlp-6: NOTRUN -> [SKIP][12] ([i915#4212] / [i915#9792]) +8 other tests skip
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@kms_addfb_basic@addfb25-x-tiled-legacy.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-mtlp-6: NOTRUN -> [SKIP][13] ([i915#5190] / [i915#9792])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- bat-mtlp-6: NOTRUN -> [SKIP][14] ([i915#9792]) +17 other tests skip
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
* igt@kms_flip@basic-flip-vs-dpms:
- bat-mtlp-6: NOTRUN -> [SKIP][15] ([i915#3637] / [i915#9792]) +3 other tests skip
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@kms_flip@basic-flip-vs-dpms.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-mtlp-6: NOTRUN -> [SKIP][16] ([i915#5274] / [i915#9792])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_frontbuffer_tracking@basic:
- bat-mtlp-6: NOTRUN -> [SKIP][17] ([i915#4342] / [i915#5354] / [i915#9792])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pm_backlight@basic-brightness:
- bat-mtlp-6: NOTRUN -> [SKIP][18] ([i915#5354] / [i915#9792])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@kms_pm_backlight@basic-brightness.html
* igt@kms_psr@psr-cursor-plane-move:
- bat-mtlp-6: NOTRUN -> [SKIP][19] ([i915#1072] / [i915#9673] / [i915#9732] / [i915#9792]) +3 other tests skip
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@kms_psr@psr-cursor-plane-move.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-mtlp-6: NOTRUN -> [SKIP][20] ([i915#3555] / [i915#8809] / [i915#9792])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-mtlp-6: NOTRUN -> [SKIP][21] ([i915#3708] / [i915#9792])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-mmap:
- bat-mtlp-6: NOTRUN -> [SKIP][22] ([i915#3708] / [i915#4077]) +1 other test skip
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-read:
- bat-mtlp-6: NOTRUN -> [SKIP][23] ([i915#3708]) +1 other test skip
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-write:
- bat-mtlp-6: NOTRUN -> [SKIP][24] ([i915#10216] / [i915#3708])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-6/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@i915_module_load@load:
- bat-dg2-9: [DMESG-WARN][25] ([i915#12257]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15437/bat-dg2-9/igt@i915_module_load@load.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-dg2-9/igt@i915_module_load@load.html
* igt@i915_selftest@live:
- bat-mtlp-8: [ABORT][27] ([i915#12061]) -> [PASS][28] +1 other test pass
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15437/bat-mtlp-8/igt@i915_selftest@live.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-mtlp-8/igt@i915_selftest@live.html
#### Warnings ####
* igt@i915_module_load@reload:
- bat-arls-5: [DMESG-WARN][29] ([i915#11637]) -> [DMESG-WARN][30] ([i915#11637] / [i915#1982])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15437/bat-arls-5/igt@i915_module_load@reload.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-arls-5/igt@i915_module_load@reload.html
* igt@i915_selftest@live:
- bat-arls-2: [DMESG-FAIL][31] ([i915#10262] / [i915#10341]) -> [INCOMPLETE][32] ([i915#10341] / [i915#12133])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15437/bat-arls-2/igt@i915_selftest@live.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/bat-arls-2/igt@i915_selftest@live.html
[i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
[i915#10262]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10262
[i915#10341]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10341
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#11637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11637
[i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#12133]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12133
[i915#12257]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12257
[i915#1849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1849
[i915#1982]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1982
[i915#2582]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2582
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4212
[i915#4342]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4342
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#6621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6621
[i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809
[i915#9318]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9318
[i915#9673]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9673
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
[i915#9792]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9792
Build changes
-------------
* Linux: CI_DRM_15437 -> Patchwork_138812v2
CI-20190529: 20190529
CI_DRM_15437: 15aeb2cced25e1bfa15f1aa538247d79cf8b0a05 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8024: 15f8ad0bce184e96d171dfe19c06bdef93e7cf72 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_138812v2: 15aeb2cced25e1bfa15f1aa538247d79cf8b0a05 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v2/index.html
[-- Attachment #2: Type: text/html, Size: 13625 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: wakeref fixes and improvements (rev3)
2024-09-18 17:35 [PATCH v2 0/6] drm/i915: wakeref fixes and improvements Jani Nikula
` (8 preceding siblings ...)
2024-09-18 18:36 ` ✗ Fi.CI.BAT: failure " Patchwork
@ 2024-09-18 21:37 ` Patchwork
2024-09-18 21:37 ` ✗ Fi.CI.SPARSE: " Patchwork
` (2 subsequent siblings)
12 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2024-09-18 21:37 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: wakeref fixes and improvements (rev3)
URL : https://patchwork.freedesktop.org/series/138812/
State : warning
== Summary ==
Error: dim checkpatch failed
4293bfe55075 drm/i915/gem: fix bitwise and logical AND mixup
33c96f376a7d drm/i915: use INTEL_WAKEREF_DEF instead of magic -1 for intel_wakeref_t
281c55454bdf drm/i915/display: return 0 instead of false for disabled power wakeref
16ecf87e2b74 drm/i915/gt: add a macro for mock gt wakeref special value and use it
56e6531f0992 drm/i915/audio: be explicit about intel_wakeref_t conversions
0c74f19672bf drm/i915: switch intel_wakeref_t underlying type to struct ref_tracker *
-:46: WARNING:NEW_TYPEDEFS: do not add new typedefs
#46: FILE: drivers/gpu/drm/i915/intel_wakeref.h:24:
+typedef struct ref_tracker *intel_wakeref_t;
-:93: WARNING:NEW_TYPEDEFS: do not add new typedefs
#93: FILE: drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h:8:
+typedef struct ref_tracker *intel_wakeref_t;
total: 0 errors, 2 warnings, 0 checks, 56 lines checked
^ permalink raw reply [flat|nested] 24+ messages in thread* ✗ Fi.CI.SPARSE: warning for drm/i915: wakeref fixes and improvements (rev3)
2024-09-18 17:35 [PATCH v2 0/6] drm/i915: wakeref fixes and improvements Jani Nikula
` (9 preceding siblings ...)
2024-09-18 21:37 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: wakeref fixes and improvements (rev3) Patchwork
@ 2024-09-18 21:37 ` Patchwork
2024-09-18 21:46 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-19 9:25 ` ✗ Fi.CI.IGT: failure " Patchwork
12 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2024-09-18 21:37 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: wakeref fixes and improvements (rev3)
URL : https://patchwork.freedesktop.org/series/138812/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 24+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: wakeref fixes and improvements (rev3)
2024-09-18 17:35 [PATCH v2 0/6] drm/i915: wakeref fixes and improvements Jani Nikula
` (10 preceding siblings ...)
2024-09-18 21:37 ` ✗ Fi.CI.SPARSE: " Patchwork
@ 2024-09-18 21:46 ` Patchwork
2024-09-19 9:25 ` ✗ Fi.CI.IGT: failure " Patchwork
12 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2024-09-18 21:46 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 9569 bytes --]
== Series Details ==
Series: drm/i915: wakeref fixes and improvements (rev3)
URL : https://patchwork.freedesktop.org/series/138812/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15438 -> Patchwork_138812v3
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/index.html
Participating hosts (38 -> 36)
------------------------------
Additional (2): bat-arls-1 fi-kbl-8809g
Missing (4): fi-kbl-7567u bat-dg2-11 fi-cfl-8109u fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_138812v3 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-arls-1: NOTRUN -> [SKIP][1] ([i915#9318])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@debugfs_test@basic-hwmon.html
* igt@fbdev@info:
- bat-arls-1: NOTRUN -> [DMESG-WARN][2] ([i915#12102])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@fbdev@info.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-8809g: NOTRUN -> [SKIP][3] ([i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/fi-kbl-8809g/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-8809g: NOTRUN -> [SKIP][4] ([i915#4613]) +3 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/fi-kbl-8809g/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@random-engines:
- bat-arls-1: NOTRUN -> [SKIP][5] ([i915#10213]) +3 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@gem_lmem_swapping@random-engines.html
* igt@gem_mmap@basic:
- bat-arls-1: NOTRUN -> [SKIP][6] ([i915#11343] / [i915#4083])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@gem_mmap@basic.html
* igt@gem_render_tiled_blits@basic:
- bat-arls-1: NOTRUN -> [SKIP][7] ([i915#10197] / [i915#10211] / [i915#4079])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_blits@basic:
- bat-arls-1: NOTRUN -> [SKIP][8] ([i915#10196] / [i915#4077]) +2 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@gem_tiled_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-arls-1: NOTRUN -> [SKIP][9] ([i915#10206] / [i915#4079])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@gem_tiled_pread_basic.html
* igt@i915_pm_rps@basic-api:
- bat-arls-1: NOTRUN -> [SKIP][10] ([i915#10209] / [i915#11681])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live:
- bat-arls-1: NOTRUN -> [DMESG-WARN][11] ([i915#10341] / [i915#12133])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@i915_selftest@live.html
* igt@i915_selftest@live@hangcheck:
- bat-arls-1: NOTRUN -> [DMESG-WARN][12] ([i915#11349])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@i915_selftest@live@hangcheck.html
* igt@kms_addfb_basic@addfb25-x-tiled-legacy:
- bat-arls-1: NOTRUN -> [SKIP][13] ([i915#10200]) +8 other tests skip
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@kms_addfb_basic@addfb25-x-tiled-legacy.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-arls-1: NOTRUN -> [SKIP][14] ([i915#10200] / [i915#12203])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-arls-1: NOTRUN -> [SKIP][15] ([i915#10202] / [i915#11346]) +1 other test skip
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_dsc@dsc-basic:
- bat-arls-1: NOTRUN -> [SKIP][16] ([i915#11346] / [i915#9886])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@kms_dsc@dsc-basic.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-kbl-8809g: NOTRUN -> [SKIP][17] +30 other tests skip
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/fi-kbl-8809g/igt@kms_force_connector_basic@force-load-detect.html
- bat-arls-1: NOTRUN -> [SKIP][18] ([i915#10207] / [i915#11346])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pm_backlight@basic-brightness:
- bat-arls-1: NOTRUN -> [SKIP][19] ([i915#11346] / [i915#9812])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@kms_pm_backlight@basic-brightness.html
* igt@kms_psr@psr-primary-mmap-gtt:
- bat-arls-1: NOTRUN -> [SKIP][20] ([i915#11346] / [i915#9732]) +3 other tests skip
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@kms_psr@psr-primary-mmap-gtt.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-arls-1: NOTRUN -> [SKIP][21] ([i915#10208] / [i915#8809])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-read:
- bat-arls-1: NOTRUN -> [SKIP][22] ([i915#10212] / [i915#3708])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-gtt:
- bat-arls-1: NOTRUN -> [SKIP][23] ([i915#10196] / [i915#3708] / [i915#4077]) +1 other test skip
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@prime_vgem@basic-gtt.html
* igt@prime_vgem@basic-read:
- bat-arls-1: NOTRUN -> [SKIP][24] ([i915#10214] / [i915#3708])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-write:
- bat-arls-1: NOTRUN -> [SKIP][25] ([i915#10216] / [i915#3708])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/bat-arls-1/igt@prime_vgem@basic-write.html
[i915#10196]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10196
[i915#10197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10197
[i915#10200]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10200
[i915#10202]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10202
[i915#10206]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10206
[i915#10207]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10207
[i915#10208]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10208
[i915#10209]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10209
[i915#10211]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10211
[i915#10212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10212
[i915#10213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10213
[i915#10214]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10214
[i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
[i915#10341]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10341
[i915#11343]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11343
[i915#11346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11346
[i915#11349]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11349
[i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
[i915#12102]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12102
[i915#12133]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12133
[i915#12203]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12203
[i915#2190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2190
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809
[i915#9318]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9318
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
[i915#9812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9812
[i915#9886]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9886
Build changes
-------------
* Linux: CI_DRM_15438 -> Patchwork_138812v3
CI-20190529: 20190529
CI_DRM_15438: e63d4ffd3e279478c789eaceeb28074d9376142a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8024: 15f8ad0bce184e96d171dfe19c06bdef93e7cf72 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_138812v3: e63d4ffd3e279478c789eaceeb28074d9376142a @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/index.html
[-- Attachment #2: Type: text/html, Size: 11552 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread* ✗ Fi.CI.IGT: failure for drm/i915: wakeref fixes and improvements (rev3)
2024-09-18 17:35 [PATCH v2 0/6] drm/i915: wakeref fixes and improvements Jani Nikula
` (11 preceding siblings ...)
2024-09-18 21:46 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2024-09-19 9:25 ` Patchwork
12 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2024-09-19 9:25 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 57460 bytes --]
== Series Details ==
Series: drm/i915: wakeref fixes and improvements (rev3)
URL : https://patchwork.freedesktop.org/series/138812/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15438_full -> Patchwork_138812v3_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_138812v3_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_138812v3_full, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/index.html
Participating hosts (10 -> 9)
------------------------------
Missing (1): shard-snb-0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_138812v3_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_schedule@deep@rcs0:
- shard-dg2: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-6/igt@gem_exec_schedule@deep@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-3/igt@gem_exec_schedule@deep@rcs0.html
Known issues
------------
Here are the changes found in Patchwork_138812v3_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@api_intel_bb@blit-reloc-purge-cache:
- shard-rkl: NOTRUN -> [SKIP][3] ([i915#8411]) +1 other test skip
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@api_intel_bb@blit-reloc-purge-cache.html
* igt@device_reset@cold-reset-bound:
- shard-dg2: NOTRUN -> [SKIP][4] ([i915#11078])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@device_reset@cold-reset-bound.html
* igt@device_reset@unbind-reset-rebind:
- shard-dg1: NOTRUN -> [ABORT][5] ([i915#11814] / [i915#11815])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-16/igt@device_reset@unbind-reset-rebind.html
* igt@gem_ctx_persistence@heartbeat-hostile:
- shard-dg1: NOTRUN -> [SKIP][6] ([i915#8555]) +2 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-16/igt@gem_ctx_persistence@heartbeat-hostile.html
* igt@gem_ctx_persistence@heartbeat-many:
- shard-dg2: NOTRUN -> [SKIP][7] ([i915#8555])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@gem_ctx_persistence@heartbeat-many.html
* igt@gem_ctx_sseu@mmap-args:
- shard-rkl: NOTRUN -> [SKIP][8] ([i915#280])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-2/igt@gem_ctx_sseu@mmap-args.html
* igt@gem_eio@hibernate:
- shard-dg2: [PASS][9] -> [ABORT][10] ([i915#10030] / [i915#7975] / [i915#8213])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-11/igt@gem_eio@hibernate.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@gem_eio@hibernate.html
* igt@gem_eio@reset-stress:
- shard-dg1: [PASS][11] -> [FAIL][12] ([i915#5784])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg1-13/igt@gem_eio@reset-stress.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-15/igt@gem_eio@reset-stress.html
* igt@gem_exec_balancer@bonded-false-hang:
- shard-dg2: NOTRUN -> [SKIP][13] ([i915#4812])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@gem_exec_balancer@bonded-false-hang.html
* igt@gem_exec_balancer@bonded-semaphore:
- shard-dg1: NOTRUN -> [SKIP][14] ([i915#4812])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@gem_exec_balancer@bonded-semaphore.html
* igt@gem_exec_balancer@parallel-bb-first:
- shard-rkl: NOTRUN -> [SKIP][15] ([i915#4525])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-2/igt@gem_exec_balancer@parallel-bb-first.html
* igt@gem_exec_capture@capture@vecs0-lmem0:
- shard-dg2: NOTRUN -> [FAIL][16] ([i915#11965]) +4 other tests fail
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@gem_exec_capture@capture@vecs0-lmem0.html
* igt@gem_exec_fair@basic-none-rrul:
- shard-dg1: NOTRUN -> [SKIP][17] ([i915#3539] / [i915#4852]) +2 other tests skip
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@gem_exec_fair@basic-none-rrul.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][18] -> [FAIL][19] ([i915#2842]) +1 other test fail
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
- shard-tglu: [PASS][20] -> [FAIL][21] ([i915#2842]) +1 other test fail
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-tglu-8/igt@gem_exec_fair@basic-pace-share@rcs0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-tglu-5/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-rkl: NOTRUN -> [FAIL][22] ([i915#2842]) +2 other tests fail
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_reloc@basic-softpin:
- shard-dg1: NOTRUN -> [SKIP][23] ([i915#3281]) +2 other tests skip
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-16/igt@gem_exec_reloc@basic-softpin.html
* igt@gem_exec_reloc@basic-wc-cpu:
- shard-dg2: NOTRUN -> [SKIP][24] ([i915#3281]) +1 other test skip
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@gem_exec_reloc@basic-wc-cpu.html
* igt@gem_exec_reloc@basic-write-cpu:
- shard-rkl: NOTRUN -> [SKIP][25] ([i915#3281]) +2 other tests skip
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@gem_exec_reloc@basic-write-cpu.html
* igt@gem_exec_schedule@preempt-queue:
- shard-dg2: NOTRUN -> [SKIP][26] ([i915#4537] / [i915#4812])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@gem_exec_schedule@preempt-queue.html
* igt@gem_exec_schedule@semaphore-power:
- shard-rkl: NOTRUN -> [SKIP][27] ([i915#7276])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@gem_exec_schedule@semaphore-power.html
* igt@gem_fenced_exec_thrash@no-spare-fences-busy-interruptible:
- shard-dg2: NOTRUN -> [SKIP][28] ([i915#4860]) +1 other test skip
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@gem_fenced_exec_thrash@no-spare-fences-busy-interruptible.html
* igt@gem_lmem_swapping@parallel-multi:
- shard-glk: NOTRUN -> [SKIP][29] ([i915#4613])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-glk7/igt@gem_lmem_swapping@parallel-multi.html
* igt@gem_lmem_swapping@random:
- shard-rkl: NOTRUN -> [SKIP][30] ([i915#4613]) +2 other tests skip
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@gem_lmem_swapping@random.html
* igt@gem_mmap_gtt@fault-concurrent:
- shard-dg1: NOTRUN -> [SKIP][31] ([i915#4077]) +6 other tests skip
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@gem_mmap_gtt@fault-concurrent.html
* igt@gem_mmap_gtt@medium-copy-odd:
- shard-dg2: NOTRUN -> [SKIP][32] ([i915#4077]) +2 other tests skip
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@gem_mmap_gtt@medium-copy-odd.html
* igt@gem_mmap_wc@close:
- shard-dg1: NOTRUN -> [SKIP][33] ([i915#4083]) +1 other test skip
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-16/igt@gem_mmap_wc@close.html
* igt@gem_mmap_wc@write-prefaulted:
- shard-dg2: NOTRUN -> [SKIP][34] ([i915#4083]) +1 other test skip
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@gem_mmap_wc@write-prefaulted.html
* igt@gem_partial_pwrite_pread@writes-after-reads:
- shard-rkl: NOTRUN -> [SKIP][35] ([i915#3282]) +5 other tests skip
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@gem_partial_pwrite_pread@writes-after-reads.html
* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- shard-dg2: NOTRUN -> [SKIP][36] ([i915#3282])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
* igt@gem_pread@bench:
- shard-dg1: NOTRUN -> [SKIP][37] ([i915#3282])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@gem_pread@bench.html
* igt@gem_pxp@display-protected-crc:
- shard-rkl: NOTRUN -> [SKIP][38] ([i915#4270]) +1 other test skip
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-2/igt@gem_pxp@display-protected-crc.html
* igt@gem_pxp@protected-encrypted-src-copy-not-readible:
- shard-dg2: NOTRUN -> [SKIP][39] ([i915#4270])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@gem_pxp@protected-encrypted-src-copy-not-readible.html
* igt@gem_pxp@regular-baseline-src-copy-readible:
- shard-dg1: NOTRUN -> [SKIP][40] ([i915#4270])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@gem_pxp@regular-baseline-src-copy-readible.html
* igt@gem_render_copy@yf-tiled-to-vebox-yf-tiled:
- shard-dg2: NOTRUN -> [SKIP][41] ([i915#5190] / [i915#8428])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@gem_render_copy@yf-tiled-to-vebox-yf-tiled.html
* igt@gem_set_tiling_vs_blt@tiled-to-tiled:
- shard-dg1: NOTRUN -> [SKIP][42] ([i915#4079])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-16/igt@gem_set_tiling_vs_blt@tiled-to-tiled.html
* igt@gem_softpin@evict-snoop:
- shard-rkl: NOTRUN -> [SKIP][43] +10 other tests skip
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@gem_softpin@evict-snoop.html
* igt@gem_userptr_blits@coherency-sync:
- shard-rkl: NOTRUN -> [SKIP][44] ([i915#3297])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-2/igt@gem_userptr_blits@coherency-sync.html
* igt@gem_userptr_blits@create-destroy-unsync:
- shard-dg2: NOTRUN -> [SKIP][45] ([i915#3297])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@gem_userptr_blits@create-destroy-unsync.html
* igt@gem_userptr_blits@relocations:
- shard-dg2: NOTRUN -> [SKIP][46] ([i915#3281] / [i915#3297])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@gem_userptr_blits@relocations.html
* igt@gen9_exec_parse@allowed-single:
- shard-dg1: NOTRUN -> [SKIP][47] ([i915#2527]) +1 other test skip
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-16/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@bb-secure:
- shard-rkl: NOTRUN -> [SKIP][48] ([i915#2527]) +2 other tests skip
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-2/igt@gen9_exec_parse@bb-secure.html
* igt@gen9_exec_parse@bb-start-far:
- shard-dg2: NOTRUN -> [SKIP][49] ([i915#2856]) +1 other test skip
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@gen9_exec_parse@bb-start-far.html
* igt@i915_module_load@load:
- shard-rkl: NOTRUN -> [SKIP][50] ([i915#6227])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@i915_module_load@load.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-tglu: [PASS][51] -> [ABORT][52] ([i915#10887] / [i915#9820])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-tglu-5/igt@i915_module_load@reload-with-fault-injection.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-tglu-6/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rps@thresholds:
- shard-dg2: NOTRUN -> [SKIP][53] ([i915#11681])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@i915_pm_rps@thresholds.html
* igt@intel_hwmon@hwmon-write:
- shard-rkl: NOTRUN -> [SKIP][54] ([i915#7707])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-2/igt@intel_hwmon@hwmon-write.html
* igt@kms_addfb_basic@tile-pitch-mismatch:
- shard-dg1: NOTRUN -> [SKIP][55] ([i915#4212]) +1 other test skip
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@kms_addfb_basic@tile-pitch-mismatch.html
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-3-y-rc-ccs:
- shard-dg1: NOTRUN -> [SKIP][56] ([i915#8709]) +7 other tests skip
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-13/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-3-y-rc-ccs.html
* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-rkl: [PASS][57] -> [FAIL][58] ([i915#11808])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-rkl-4/igt@kms_atomic_transition@plane-all-modeset-transition.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-5/igt@kms_atomic_transition@plane-all-modeset-transition.html
* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-dg1: NOTRUN -> [SKIP][59] ([i915#1769] / [i915#3555])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-1:
- shard-snb: [PASS][60] -> [FAIL][61] ([i915#5956]) +1 other test fail
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-snb7/igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-1.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-snb2/igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-1.html
* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [FAIL][62] ([i915#11808])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-5/igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-2.html
* igt@kms_big_fb@4-tiled-64bpp-rotate-90:
- shard-rkl: NOTRUN -> [SKIP][63] ([i915#5286]) +2 other tests skip
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@kms_big_fb@4-tiled-64bpp-rotate-90.html
* igt@kms_big_fb@4-tiled-8bpp-rotate-270:
- shard-dg1: NOTRUN -> [SKIP][64] ([i915#4538] / [i915#5286]) +1 other test skip
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@kms_big_fb@4-tiled-8bpp-rotate-270.html
* igt@kms_big_fb@linear-32bpp-rotate-90:
- shard-dg1: NOTRUN -> [SKIP][65] ([i915#3638]) +1 other test skip
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@kms_big_fb@linear-32bpp-rotate-90.html
* igt@kms_big_fb@linear-8bpp-rotate-0:
- shard-tglu: [PASS][66] -> [ABORT][67] ([i915#10354])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-tglu-3/igt@kms_big_fb@linear-8bpp-rotate-0.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-tglu-7/igt@kms_big_fb@linear-8bpp-rotate-0.html
* igt@kms_big_fb@y-tiled-16bpp-rotate-90:
- shard-dg2: NOTRUN -> [SKIP][68] ([i915#4538] / [i915#5190]) +1 other test skip
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@kms_big_fb@y-tiled-16bpp-rotate-90.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-270:
- shard-rkl: NOTRUN -> [SKIP][69] ([i915#3638]) +1 other test skip
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@kms_big_fb@y-tiled-64bpp-rotate-270.html
* igt@kms_big_fb@yf-tiled-8bpp-rotate-90:
- shard-dg1: NOTRUN -> [SKIP][70] ([i915#4538]) +2 other tests skip
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@kms_big_fb@yf-tiled-8bpp-rotate-90.html
* igt@kms_big_joiner@invalid-modeset:
- shard-dg1: NOTRUN -> [SKIP][71] ([i915#10656])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-16/igt@kms_big_joiner@invalid-modeset.html
* igt@kms_ccs@crc-primary-basic-4-tiled-bmg-ccs:
- shard-rkl: NOTRUN -> [SKIP][72] ([i915#12042])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@kms_ccs@crc-primary-basic-4-tiled-bmg-ccs.html
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-bmg-ccs:
- shard-dg2: NOTRUN -> [SKIP][73] ([i915#12042])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-bmg-ccs.html
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-mc-ccs@pipe-a-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][74] ([i915#10307] / [i915#6095]) +130 other tests skip
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-7/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-mc-ccs@pipe-a-hdmi-a-3.html
* igt@kms_ccs@missing-ccs-buffer-y-tiled-ccs@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][75] ([i915#10307] / [i915#10434] / [i915#6095]) +6 other tests skip
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-2/igt@kms_ccs@missing-ccs-buffer-y-tiled-ccs@pipe-d-hdmi-a-1.html
* igt@kms_ccs@random-ccs-data-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][76] ([i915#6095]) +53 other tests skip
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-5/igt@kms_ccs@random-ccs-data-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-2.html
* igt@kms_ccs@random-ccs-data-yf-tiled-ccs@pipe-a-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][77] ([i915#6095]) +125 other tests skip
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-13/igt@kms_ccs@random-ccs-data-yf-tiled-ccs@pipe-a-hdmi-a-3.html
* igt@kms_cdclk@mode-transition:
- shard-rkl: NOTRUN -> [SKIP][78] ([i915#3742])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-2/igt@kms_cdclk@mode-transition.html
* igt@kms_chamelium_color@ctm-0-50:
- shard-dg2: NOTRUN -> [SKIP][79] +5 other tests skip
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@kms_chamelium_color@ctm-0-50.html
* igt@kms_chamelium_edid@hdmi-edid-read:
- shard-rkl: NOTRUN -> [SKIP][80] ([i915#7828]) +2 other tests skip
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-2/igt@kms_chamelium_edid@hdmi-edid-read.html
* igt@kms_chamelium_hpd@dp-hpd-with-enabled-mode:
- shard-dg2: NOTRUN -> [SKIP][81] ([i915#7828]) +1 other test skip
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@kms_chamelium_hpd@dp-hpd-with-enabled-mode.html
* igt@kms_chamelium_hpd@vga-hpd-fast:
- shard-dg1: NOTRUN -> [SKIP][82] ([i915#7828]) +3 other tests skip
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-16/igt@kms_chamelium_hpd@vga-hpd-fast.html
* igt@kms_content_protection@atomic-dpms@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [TIMEOUT][83] ([i915#7173])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-11/igt@kms_content_protection@atomic-dpms@pipe-a-dp-4.html
* igt@kms_content_protection@dp-mst-lic-type-0:
- shard-dg2: NOTRUN -> [SKIP][84] ([i915#3299])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@kms_content_protection@dp-mst-lic-type-0.html
* igt@kms_cursor_crc@cursor-random-512x512:
- shard-rkl: NOTRUN -> [SKIP][85] ([i915#11453]) +2 other tests skip
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-2/igt@kms_cursor_crc@cursor-random-512x512.html
* igt@kms_cursor_crc@cursor-random-max-size:
- shard-dg2: NOTRUN -> [SKIP][86] ([i915#3555]) +1 other test skip
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@kms_cursor_crc@cursor-random-max-size.html
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions:
- shard-rkl: NOTRUN -> [SKIP][87] ([i915#4103])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@torture-bo:
- shard-tglu: [PASS][88] -> [DMESG-WARN][89] ([i915#10166] / [i915#1982])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-tglu-9/igt@kms_cursor_legacy@torture-bo.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-tglu-8/igt@kms_cursor_legacy@torture-bo.html
* igt@kms_cursor_legacy@torture-bo@pipe-a:
- shard-tglu: [PASS][90] -> [DMESG-WARN][91] ([i915#10166])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-tglu-9/igt@kms_cursor_legacy@torture-bo@pipe-a.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-tglu-8/igt@kms_cursor_legacy@torture-bo@pipe-a.html
* igt@kms_dirtyfb@psr-dirtyfb-ioctl:
- shard-dg1: NOTRUN -> [SKIP][92] ([i915#9723])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@kms_dirtyfb@psr-dirtyfb-ioctl.html
* igt@kms_dp_aux_dev:
- shard-dg2: [PASS][93] -> [SKIP][94] ([i915#1257])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-11/igt@kms_dp_aux_dev.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@kms_dp_aux_dev.html
* igt@kms_dsc@dsc-with-bpc-formats:
- shard-rkl: NOTRUN -> [SKIP][95] ([i915#3555] / [i915#3840])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@kms_dsc@dsc-with-bpc-formats.html
* igt@kms_dsc@dsc-with-formats:
- shard-dg1: NOTRUN -> [SKIP][96] ([i915#3555] / [i915#3840])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-16/igt@kms_dsc@dsc-with-formats.html
* igt@kms_dsc@dsc-with-output-formats-with-bpc:
- shard-rkl: NOTRUN -> [SKIP][97] ([i915#3840] / [i915#9053])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-2/igt@kms_dsc@dsc-with-output-formats-with-bpc.html
* igt@kms_feature_discovery@display-3x:
- shard-dg1: NOTRUN -> [SKIP][98] ([i915#1839])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@kms_feature_discovery@display-3x.html
* igt@kms_feature_discovery@psr1:
- shard-dg1: NOTRUN -> [SKIP][99] ([i915#658])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@kms_feature_discovery@psr1.html
* igt@kms_flip@2x-busy-flip:
- shard-dg1: NOTRUN -> [SKIP][100] ([i915#9934]) +1 other test skip
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-16/igt@kms_flip@2x-busy-flip.html
* igt@kms_flip@2x-plain-flip-fb-recreate@ab-vga1-hdmi-a1:
- shard-snb: [PASS][101] -> [FAIL][102] ([i915#2122]) +1 other test fail
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-snb6/igt@kms_flip@2x-plain-flip-fb-recreate@ab-vga1-hdmi-a1.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-snb7/igt@kms_flip@2x-plain-flip-fb-recreate@ab-vga1-hdmi-a1.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling:
- shard-rkl: NOTRUN -> [SKIP][103] ([i915#2672] / [i915#3555]) +1 other test skip
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-2/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling@pipe-a-valid-mode:
- shard-rkl: NOTRUN -> [SKIP][104] ([i915#2672]) +1 other test skip
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-2/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling:
- shard-dg1: NOTRUN -> [SKIP][105] ([i915#2672] / [i915#3555])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-16/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-dg1: NOTRUN -> [SKIP][106] ([i915#2587] / [i915#2672])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-16/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-dg2: NOTRUN -> [SKIP][107] ([i915#8708]) +4 other tests skip
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-pgflip-blt:
- shard-snb: [PASS][108] -> [SKIP][109] +5 other tests skip
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-snb7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-pgflip-blt.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-snb2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-pwrite:
- shard-dg1: NOTRUN -> [SKIP][110] +23 other tests skip
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-16/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-dg1: NOTRUN -> [SKIP][111] ([i915#8708]) +3 other tests skip
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-fullscreen:
- shard-dg2: NOTRUN -> [SKIP][112] ([i915#3458]) +3 other tests skip
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-fullscreen.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt:
- shard-rkl: NOTRUN -> [SKIP][113] ([i915#1825]) +12 other tests skip
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-msflip-blt:
- shard-dg1: NOTRUN -> [SKIP][114] ([i915#3458]) +6 other tests skip
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-16/igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-rte:
- shard-rkl: NOTRUN -> [SKIP][115] ([i915#3023]) +11 other tests skip
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@kms_frontbuffer_tracking@psr-1p-rte.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-move:
- shard-dg2: NOTRUN -> [SKIP][116] ([i915#5354]) +7 other tests skip
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-move.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-dg2: [PASS][117] -> [SKIP][118] ([i915#3555] / [i915#8228])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-11/igt@kms_hdr@bpc-switch-dpms.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-2/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-dg1: NOTRUN -> [SKIP][119] ([i915#3555] / [i915#8228])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_hdr@invalid-hdr:
- shard-dg2: NOTRUN -> [SKIP][120] ([i915#3555] / [i915#8228])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@kms_hdr@invalid-hdr.html
* igt@kms_hdr@static-swap:
- shard-rkl: NOTRUN -> [SKIP][121] ([i915#3555] / [i915#8228]) +1 other test skip
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-2/igt@kms_hdr@static-swap.html
* igt@kms_plane_lowres@tiling-yf:
- shard-dg1: NOTRUN -> [SKIP][122] ([i915#3555]) +1 other test skip
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@kms_plane_lowres@tiling-yf.html
* igt@kms_plane_multiple@tiling-yf:
- shard-dg2: NOTRUN -> [SKIP][123] ([i915#3555] / [i915#8806])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@kms_plane_multiple@tiling-yf.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4:
- shard-dg1: NOTRUN -> [FAIL][124] ([i915#8292])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-15/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4.html
* igt@kms_plane_scaling@plane-upscale-factor-0-25-with-rotation@pipe-d:
- shard-dg1: NOTRUN -> [SKIP][125] ([i915#12247]) +9 other tests skip
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@kms_plane_scaling@plane-upscale-factor-0-25-with-rotation@pipe-d.html
* igt@kms_pm_dc@dc6-psr:
- shard-dg1: NOTRUN -> [SKIP][126] ([i915#9685])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-16/igt@kms_pm_dc@dc6-psr.html
* igt@kms_pm_lpsp@kms-lpsp:
- shard-dg2: [PASS][127] -> [SKIP][128] ([i915#9340])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-2/igt@kms_pm_lpsp@kms-lpsp.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-7/igt@kms_pm_lpsp@kms-lpsp.html
* igt@kms_pm_rpm@dpms-lpsp:
- shard-dg2: [PASS][129] -> [SKIP][130] ([i915#9519]) +1 other test skip
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-8/igt@kms_pm_rpm@dpms-lpsp.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-1/igt@kms_pm_rpm@dpms-lpsp.html
- shard-rkl: [PASS][131] -> [SKIP][132] ([i915#9519]) +1 other test skip
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-rkl-2/igt@kms_pm_rpm@dpms-lpsp.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@kms_pm_rpm@dpms-lpsp.html
* igt@kms_pm_rpm@modeset-non-lpsp:
- shard-rkl: NOTRUN -> [SKIP][133] ([i915#9519])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-2/igt@kms_pm_rpm@modeset-non-lpsp.html
* igt@kms_psr2_sf@fbc-cursor-plane-update-sf:
- shard-dg1: NOTRUN -> [SKIP][134] ([i915#11520])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-16/igt@kms_psr2_sf@fbc-cursor-plane-update-sf.html
* igt@kms_psr2_sf@fbc-plane-move-sf-dmg-area:
- shard-dg2: NOTRUN -> [SKIP][135] ([i915#11520])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@kms_psr2_sf@fbc-plane-move-sf-dmg-area.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-rkl: NOTRUN -> [SKIP][136] ([i915#11520]) +1 other test skip
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-dg1: NOTRUN -> [SKIP][137] ([i915#9683])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@kms_psr2_su@frontbuffer-xrgb8888.html
* igt@kms_psr2_su@page_flip-nv12:
- shard-rkl: NOTRUN -> [SKIP][138] ([i915#9683])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@kms_psr2_su@page_flip-nv12.html
* igt@kms_psr@fbc-pr-sprite-plane-onoff:
- shard-rkl: NOTRUN -> [SKIP][139] ([i915#1072] / [i915#9732]) +9 other tests skip
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-2/igt@kms_psr@fbc-pr-sprite-plane-onoff.html
* igt@kms_psr@fbc-psr-cursor-plane-move:
- shard-dg1: NOTRUN -> [SKIP][140] ([i915#1072] / [i915#9732]) +8 other tests skip
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-16/igt@kms_psr@fbc-psr-cursor-plane-move.html
* igt@kms_psr@fbc-psr-primary-blt:
- shard-dg2: NOTRUN -> [SKIP][141] ([i915#1072] / [i915#9732]) +4 other tests skip
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@kms_psr@fbc-psr-primary-blt.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0:
- shard-dg2: NOTRUN -> [SKIP][142] ([i915#5190])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180:
- shard-rkl: NOTRUN -> [SKIP][143] ([i915#5289])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270:
- shard-dg1: NOTRUN -> [SKIP][144] ([i915#5289])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270.html
* igt@kms_selftest@drm_framebuffer:
- shard-glk: NOTRUN -> [ABORT][145] ([i915#12231])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-glk9/igt@kms_selftest@drm_framebuffer.html
* igt@kms_setmode@basic:
- shard-dg1: NOTRUN -> [FAIL][146] ([i915#5465]) +2 other tests fail
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@kms_setmode@basic.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-d-edp-1:
- shard-mtlp: [PASS][147] -> [FAIL][148] ([i915#9196]) +1 other test fail
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-mtlp-2/igt@kms_universal_plane@cursor-fb-leak@pipe-d-edp-1.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-mtlp-5/igt@kms_universal_plane@cursor-fb-leak@pipe-d-edp-1.html
* igt@kms_vrr@flip-basic:
- shard-rkl: NOTRUN -> [SKIP][149] ([i915#3555]) +1 other test skip
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@kms_vrr@flip-basic.html
* igt@kms_vrr@lobf:
- shard-dg1: NOTRUN -> [SKIP][150] ([i915#11920])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@kms_vrr@lobf.html
* igt@kms_vrr@negative-basic:
- shard-glk: NOTRUN -> [SKIP][151] +78 other tests skip
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-glk7/igt@kms_vrr@negative-basic.html
- shard-dg2: [PASS][152] -> [SKIP][153] ([i915#3555] / [i915#9906])
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-11/igt@kms_vrr@negative-basic.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@kms_vrr@negative-basic.html
* igt@kms_vrr@seamless-rr-switch-drrs:
- shard-rkl: NOTRUN -> [SKIP][154] ([i915#9906])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-2/igt@kms_vrr@seamless-rr-switch-drrs.html
* igt@kms_writeback@writeback-check-output:
- shard-dg2: NOTRUN -> [SKIP][155] ([i915#2437])
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@kms_writeback@writeback-check-output.html
* igt@perf@mi-rpc:
- shard-dg2: NOTRUN -> [SKIP][156] ([i915#2434])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@perf@mi-rpc.html
* igt@perf@unprivileged-single-ctx-counters:
- shard-rkl: NOTRUN -> [SKIP][157] ([i915#2433])
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-2/igt@perf@unprivileged-single-ctx-counters.html
* igt@perf_pmu@busy-double-start@vecs1:
- shard-dg2: [PASS][158] -> [FAIL][159] ([i915#4349]) +4 other tests fail
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-6/igt@perf_pmu@busy-double-start@vecs1.html
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-3/igt@perf_pmu@busy-double-start@vecs1.html
* igt@perf_pmu@cpu-hotplug:
- shard-dg1: NOTRUN -> [SKIP][160] ([i915#8850])
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-17/igt@perf_pmu@cpu-hotplug.html
* igt@sriov_basic@enable-vfs-bind-unbind-each:
- shard-rkl: NOTRUN -> [SKIP][161] ([i915#9917])
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-3/igt@sriov_basic@enable-vfs-bind-unbind-each.html
* igt@sysfs_heartbeat_interval@precise:
- shard-snb: NOTRUN -> [SKIP][162] +83 other tests skip
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-snb4/igt@sysfs_heartbeat_interval@precise.html
#### Possible fixes ####
* igt@gem_lmem_swapping@smem-oom@lmem0:
- shard-dg1: [TIMEOUT][163] ([i915#5493]) -> [PASS][164] +1 other test pass
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg1-15/igt@gem_lmem_swapping@smem-oom@lmem0.html
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-15/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@i915_power@sanity:
- shard-mtlp: [SKIP][165] ([i915#7984]) -> [PASS][166]
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-mtlp-1/igt@i915_power@sanity.html
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-mtlp-1/igt@i915_power@sanity.html
* igt@kms_big_joiner@basic-force-joiner:
- shard-dg2: [SKIP][167] ([i915#10656]) -> [PASS][168]
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-10/igt@kms_big_joiner@basic-force-joiner.html
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-11/igt@kms_big_joiner@basic-force-joiner.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][169] ([i915#2346]) -> [PASS][170] +1 other test pass
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_flip@2x-wf_vblank-ts-check:
- shard-snb: [FAIL][171] ([i915#2122]) -> [PASS][172] +5 other tests pass
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-snb7/igt@kms_flip@2x-wf_vblank-ts-check.html
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-snb2/igt@kms_flip@2x-wf_vblank-ts-check.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
- shard-dg2: [FAIL][173] ([i915#6880]) -> [PASS][174]
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-10/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-8/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
* igt@kms_pm_dc@dc9-dpms:
- shard-tglu: [SKIP][175] ([i915#4281]) -> [PASS][176]
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-tglu-8/igt@kms_pm_dc@dc9-dpms.html
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-tglu-10/igt@kms_pm_dc@dc9-dpms.html
* igt@kms_pm_rpm@modeset-lpsp:
- shard-dg2: [SKIP][177] ([i915#9519]) -> [PASS][178] +1 other test pass
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-7/igt@kms_pm_rpm@modeset-lpsp.html
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-2/igt@kms_pm_rpm@modeset-lpsp.html
- shard-rkl: [SKIP][179] ([i915#9519]) -> [PASS][180] +1 other test pass
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-rkl-3/igt@kms_pm_rpm@modeset-lpsp.html
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-4/igt@kms_pm_rpm@modeset-lpsp.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1:
- shard-tglu: [FAIL][181] ([i915#9196]) -> [PASS][182] +1 other test pass
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-tglu-6/igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1.html
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-tglu-3/igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1.html
* igt@perf_pmu@busy-accuracy-98@vecs0:
- shard-rkl: [FAIL][183] ([i915#4349]) -> [PASS][184] +1 other test pass
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-rkl-5/igt@perf_pmu@busy-accuracy-98@vecs0.html
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-5/igt@perf_pmu@busy-accuracy-98@vecs0.html
#### Warnings ####
* igt@i915_module_load@reload-with-fault-injection:
- shard-mtlp: [ABORT][185] ([i915#10131] / [i915#10887] / [i915#9820]) -> [ABORT][186] ([i915#11231])
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-mtlp-1/igt@i915_module_load@reload-with-fault-injection.html
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-mtlp-1/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_selftest@mock:
- shard-dg2: [DMESG-WARN][187] ([i915#9311]) -> [DMESG-WARN][188] ([i915#1982] / [i915#9311])
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-8/igt@i915_selftest@mock.html
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-1/igt@i915_selftest@mock.html
* igt@kms_content_protection@atomic-dpms:
- shard-dg2: [SKIP][189] ([i915#7118] / [i915#9424]) -> [TIMEOUT][190] ([i915#7173])
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-10/igt@kms_content_protection@atomic-dpms.html
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-11/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@mei-interface:
- shard-dg1: [SKIP][191] ([i915#9433]) -> [SKIP][192] ([i915#9424])
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg1-13/igt@kms_content_protection@mei-interface.html
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg1-15/igt@kms_content_protection@mei-interface.html
* igt@kms_cursor_crc@cursor-sliding-512x512:
- shard-dg2: [SKIP][193] ([i915#11453] / [i915#3359]) -> [SKIP][194] ([i915#11453])
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-11/igt@kms_cursor_crc@cursor-sliding-512x512.html
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-2/igt@kms_cursor_crc@cursor-sliding-512x512.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-dg2: [SKIP][195] ([i915#3458]) -> [SKIP][196] ([i915#10433] / [i915#3458]) +1 other test skip
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite.html
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-rkl: [SKIP][197] ([i915#4070] / [i915#4816]) -> [SKIP][198] ([i915#4816])
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-rkl-2/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-4/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
* igt@kms_pm_dc@dc9-dpms:
- shard-rkl: [SKIP][199] ([i915#4281]) -> [SKIP][200] ([i915#3361])
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-rkl-5/igt@kms_pm_dc@dc9-dpms.html
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-rkl-6/igt@kms_pm_dc@dc9-dpms.html
* igt@kms_psr@fbc-pr-suspend:
- shard-dg2: [SKIP][201] ([i915#1072] / [i915#9732]) -> [SKIP][202] ([i915#1072] / [i915#9673] / [i915#9732]) +4 other tests skip
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-10/igt@kms_psr@fbc-pr-suspend.html
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-11/igt@kms_psr@fbc-pr-suspend.html
* igt@kms_psr@psr2-basic:
- shard-dg2: [SKIP][203] ([i915#1072] / [i915#9673] / [i915#9732]) -> [SKIP][204] ([i915#1072] / [i915#9732]) +11 other tests skip
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-11/igt@kms_psr@psr2-basic.html
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-5/igt@kms_psr@psr2-basic.html
* igt@kms_rotation_crc@primary-rotation-270:
- shard-dg2: [SKIP][205] ([i915#11131] / [i915#4235]) -> [SKIP][206] ([i915#11131])
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-11/igt@kms_rotation_crc@primary-rotation-270.html
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-2/igt@kms_rotation_crc@primary-rotation-270.html
* igt@perf@non-zero-reason@0-rcs0:
- shard-dg2: [FAIL][207] ([i915#9100]) -> [FAIL][208] ([i915#7484]) +1 other test fail
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15438/shard-dg2-5/igt@perf@non-zero-reason@0-rcs0.html
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/shard-dg2-4/igt@perf@non-zero-reason@0-rcs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#10030]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10030
[i915#10131]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10131
[i915#10166]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10166
[i915#10307]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10307
[i915#10354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10354
[i915#10433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10433
[i915#10434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10434
[i915#10656]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10656
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#10887]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10887
[i915#11078]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11078
[i915#11131]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11131
[i915#11231]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11231
[i915#11453]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11453
[i915#11520]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11520
[i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
[i915#11808]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11808
[i915#11814]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11814
[i915#11815]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11815
[i915#11920]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11920
[i915#11965]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11965
[i915#12042]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12042
[i915#12231]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12231
[i915#12247]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12247
[i915#1257]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1257
[i915#1769]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1839
[i915#1982]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2346
[i915#2433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2433
[i915#2434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2527
[i915#2587]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2672
[i915#280]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3638]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3638
[i915#3742]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3742
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#4070]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4212
[i915#4235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4235
[i915#4270]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4281
[i915#4349]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4349
[i915#4525]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4525
[i915#4537]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4537
[i915#4538]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4816
[i915#4852]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4860
[i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
[i915#5286]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5289
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#5465]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5465
[i915#5493]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5493
[i915#5784]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5784
[i915#5956]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5956
[i915#6095]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6227
[i915#658]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/658
[i915#6880]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6880
[i915#7118]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7118
[i915#7173]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7173
[i915#7276]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7276
[i915#7484]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7484
[i915#7707]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7707
[i915#7828]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7828
[i915#7975]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7975
[i915#7984]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7984
[i915#8213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8228
[i915#8292]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8292
[i915#8411]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8411
[i915#8428]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8428
[i915#8555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8555
[i915#8708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8708
[i915#8709]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8709
[i915#8806]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8806
[i915#8850]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8850
[i915#9053]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9053
[i915#9100]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9100
[i915#9196]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9196
[i915#9311]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9311
[i915#9340]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9340
[i915#9424]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9424
[i915#9433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9433
[i915#9519]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9519
[i915#9673]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9673
[i915#9683]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9683
[i915#9685]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9685
[i915#9723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9723
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
[i915#9820]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9820
[i915#9906]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9906
[i915#9917]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9917
[i915#9934]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9934
Build changes
-------------
* Linux: CI_DRM_15438 -> Patchwork_138812v3
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_15438: e63d4ffd3e279478c789eaceeb28074d9376142a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8024: 15f8ad0bce184e96d171dfe19c06bdef93e7cf72 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_138812v3: e63d4ffd3e279478c789eaceeb28074d9376142a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138812v3/index.html
[-- Attachment #2: Type: text/html, Size: 69058 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread