From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0863AC04FFE for ; Wed, 8 May 2024 08:33:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6F57C10F9F6; Wed, 8 May 2024 08:33:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="VaMI90pQ"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 99B4510F8EF for ; Wed, 8 May 2024 08:33:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715157230; x=1746693230; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=YCsg1u+niEczogssz+PTwGFiNoFiKGD6NSqDv/+3zqM=; b=VaMI90pQSxuEG+b5+YgTva9gwYdFbvF5jhmYNO+qjp1NHPErFQISLYRl hRH8hlXEunrO3SL6LKIkCSqBm3VvvrFBmVaoo5vvkO2szaTm5aMfqBio1 2lIu5DdyoR4aW0rfb7yFn0G+Bz6kETLYxt2o/wxIYuqv06u/lj/cGcQyl ppUff46BM7Ph3jnie2v4plI81v87O5rznOFD+jZiqE109W1HYRV2LPJBS x5iM8Mc+oVRmhIiNsj190ETopol4kR3d8wQCbX5AgDXaK//pRPIvuLiOm NXzzYLLF2Cxbr6iMJtCk/KV7QTcQAg6yMJAGSlYZ3Dte5oBEPmvx9YjQ9 g==; X-CSE-ConnectionGUID: N4G6nAsyRLSxKdp3X1t8fQ== X-CSE-MsgGUID: 7mW07wQgS5u9bF9LRBW+JQ== X-IronPort-AV: E=McAfee;i="6600,9927,11066"; a="22155811" X-IronPort-AV: E=Sophos;i="6.08,144,1712646000"; d="scan'208";a="22155811" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2024 01:33:49 -0700 X-CSE-ConnectionGUID: 4zQr7uIDSSGGu2cIeWHoQA== X-CSE-MsgGUID: tUlY151TTQunbj2t184GZA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,144,1712646000"; d="scan'208";a="52023373" Received: from dhhellew-desk2.ger.corp.intel.com.ger.corp.intel.com (HELO localhost) ([10.245.246.76]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2024 01:33:46 -0700 From: Jani Nikula To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org, lucas.demarchi@intel.com, Bjorn Helgaas , linux-pci@vger.kernel.org Subject: Re: [PATCH 1/5] drm/i915: don't include CML PCI IDs in CFL In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Wed, 08 May 2024 11:33:43 +0300 Message-ID: <87cypwln2w.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 07 May 2024, Rodrigo Vivi wrote: > On Tue, May 07, 2024 at 03:56:48PM +0300, Jani Nikula wrote: >> @@ -535,11 +541,7 @@ >> INTEL_WHL_U_GT1_IDS(info), \ >> INTEL_WHL_U_GT2_IDS(info), \ >> INTEL_WHL_U_GT3_IDS(info), \ >> - INTEL_AML_CFL_GT2_IDS(info), \ >> - INTEL_CML_GT1_IDS(info), \ >> - INTEL_CML_GT2_IDS(info), \ >> - INTEL_CML_U_GT1_IDS(info), \ >> - INTEL_CML_U_GT2_IDS(info) >> + INTEL_AML_CFL_GT2_IDS(info) > > Why only CML and not AML and WHL as well? Mainly because we don't have a separate enumeration in enum intel_platform for AML or WHL, while for CML we do. We don't even have subplatforms for AML or WHL. So we don't need to distinguish them. That said, we could also have a rule that anything with a name needs to have a PCI ID macro. Could lean either way. BR, Jani. > >> >> /* CNL */ >> #define INTEL_CNL_PORT_F_IDS(info) \ >> -- >> 2.39.2 >> -- Jani Nikula, Intel