From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 931DBC433FE for ; Thu, 12 May 2022 04:25:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 297A210E326; Thu, 12 May 2022 04:25:19 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C0F510E326 for ; Thu, 12 May 2022 04:25:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652329518; x=1683865518; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=GvIARmFwLcD6EhfCN4EXhuo2kovQ4Z925EKC77Zb5X4=; b=AuDEXXYRbI2VP1zkxX6p9V7zmATjFKLlOjXJL/G8LBZfUkAwgfBfbbKp 2gy6Zdh7tuNwy5FR5el2roK9wQugsA/A5UEer1rzkIkMm3eXAOmpw6dwe 9KUmKs/W+uUS/DaoEfVBGsXYmXaQVCsFHIe2kR5OYtMVV9LnOdkXJ4C0D 68uwO19cuvdQpYqRAyA8ZYEOE9vBN0htbP9mWPo2BAdK99YmqbkS6t6Km fS3OEWkW8AwnpS9LDEczr5p13iUGS7eWagGpjzFItEkEW51oIYB7dHJoS 4NH6/UqEFdeXM8DVHjwcnwmr2qk6Ei98OIolRpkRnUNRzxT0q5lYhht+X Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10344"; a="257433678" X-IronPort-AV: E=Sophos;i="5.91,218,1647327600"; d="scan'208";a="257433678" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 21:25:17 -0700 X-IronPort-AV: E=Sophos;i="5.91,218,1647327600"; d="scan'208";a="624233639" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.252.130.105]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 21:25:17 -0700 Date: Wed, 11 May 2022 21:25:16 -0700 Message-ID: <87czgj74yb.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Tvrtko Ursulin In-Reply-To: References: <338e59f201303c25f88e779a0dd2b3cbae799e92.1651261886.git.ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 2/8] drm/i915/gt: Add media freq factor to per-gt sysfs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 10 May 2022 00:24:02 -0700, Tvrtko Ursulin wrote: > > > @@ -598,4 +720,12 @@ void intel_gt_sysfs_pm_init(struct intel_gt *gt, struct kobject *kobj) > > drm_warn(>->i915->drm, > > "failed to create gt%u throttle sysfs files (%pe)", > > gt->info.id, ERR_PTR(ret)); > > + > > + if (HAS_MEDIA_RATIO_MODE(gt->i915) && intel_uc_uses_guc_slpc(>->uc)) { > > + ret = sysfs_create_files(kobj, media_perf_power_attrs); > > + if (ret) > > + drm_warn(>->i915->drm, > > + "failed to create add gt%u media_perf_power_attrs sysfs (%pe)\n", > > Nit - "create add" - pick one? Fixed in Patch v2 (Series v5).