From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96B71C433F5 for ; Fri, 22 Oct 2021 17:07:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BB1760E0C for ; Fri, 22 Oct 2021 17:07:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5BB1760E0C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C440D6EDBC; Fri, 22 Oct 2021 17:07:11 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A7EE6EDBC for ; Fri, 22 Oct 2021 17:07:11 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10145"; a="209446187" X-IronPort-AV: E=Sophos;i="5.87,173,1631602800"; d="scan'208";a="209446187" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2021 10:07:10 -0700 X-IronPort-AV: E=Sophos;i="5.87,173,1631602800"; d="scan'208";a="495756807" Received: from pbabu-mobl.gar.corp.intel.com (HELO localhost) ([10.251.213.192]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2021 10:07:06 -0700 From: Jani Nikula To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org, airlied@gmail.com, daniel@ffwll.ch, lucas.demarchi@intel.com, Dave Airlie In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <97098cf69dfeb0c6c4ab85d3378e4d41fdd952c2.1634918767.git.jani.nikula@intel.com> Date: Fri, 22 Oct 2021 20:07:03 +0300 Message-ID: <87cznxkmyw.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915/audio: define the audio struct separately from drm_i915_private X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 22 Oct 2021, Ville Syrj=C3=A4l=C3=A4 wrote: > On Fri, Oct 22, 2021 at 07:27:57PM +0300, Jani Nikula wrote: >> Add a standalone definition of struct intel_audio_private, and note that >> all of it is private to intel_audio.c. >>=20 >> Cc: Dave Airlie >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/i915_drv.h | 45 ++++++++++++++++++--------------- >> 1 file changed, 24 insertions(+), 21 deletions(-) >>=20 >> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915= _drv.h >> index 9c77610acf23..ed86633a587b 100644 >> --- a/drivers/gpu/drm/i915/i915_drv.h >> +++ b/drivers/gpu/drm/i915/i915_drv.h >> @@ -828,6 +828,29 @@ struct i915_selftest_stash { >> struct ida mock_region_instances; >> }; >>=20=20 >> +/* intel_audio.c private */ >> +struct intel_audio_private { > > Not sure the "_private" is actually useful. I'd just call it > intel_audio. The fact that struct drm_i915_private > already says "private" doesn't mean anything to anyone anyway. I first named it just intel_audio. Then I added intel_hdcp too, and realized it means something else, in intel_display_types.h. Then there's intel_gmbus. Probably others. I'd kind of like to have some consistency. I'm not hung up on "_private", but I don't like to call this intel_audio and then have intel_hdcp_foo and intel_gmbus_bar. Ideas welcome. And, yeah, we could just rename drm_i915_private drm_i915_public. :p BR, Jani. --=20 Jani Nikula, Intel Open Source Graphics Center