From: "Keith Packard" <keithp@keithp.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Michel Dänzer" <michel@daenzer.net>,
"Dhinakaran Pandiyan" <dhinakaran.pandiyan@intel.com>,
dri-devel@lists.freedesktop.org, rodrigo.vivi@intel.com
Subject: Re: [PATCH 2/5] drm/vblank: Fix data type width for drm_crtc_arm_vblank_event()
Date: Tue, 30 Jan 2018 22:49:07 -0800 [thread overview]
Message-ID: <87d11qldzw.fsf@keithp.com> (raw)
In-Reply-To: <20180112215707.3084-2-dhinakaran.pandiyan@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 752 bytes --]
Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> writes:
> Now that drm_vblank_count() returns all bits of the vblank count, update
> drm_crtc_arm_vblank_event() so that it queues the correct sequence.
> Otherwise, this leads to prolonged waits for a vblank sequence when the
> current count is >=2^32.
The summary for this patch is incorrect; the function being fixed is
drm_crtc_accurate_vblank_event.
And, I'm afraid you've uncovered a rabbit hole here -- there are a
couple of users of this function outside of the core, including i915 in
a couple of places and nouveau. We should at least review the whole call
graph starting here and make sure it does what we think it should.
Thanks for finding these bugs!
--
-keith
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-01-31 6:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 21:57 [PATCH 1/5] drm/vblank: Fix return type for drm_vblank_count() Dhinakaran Pandiyan
2018-01-12 21:57 ` [PATCH 2/5] drm/vblank: Fix data type width for drm_crtc_arm_vblank_event() Dhinakaran Pandiyan
2018-01-19 7:39 ` Rodrigo Vivi
2018-01-31 6:49 ` Keith Packard [this message]
2018-01-12 21:57 ` [PATCH 3/5] drm/vblank: Do not update vblank count if interrupts are already disabled Dhinakaran Pandiyan
2018-01-19 7:47 ` Rodrigo Vivi
2018-01-12 21:57 ` [PATCH 4/5] drm/vblank: Restoring vblank counts after device PM events Dhinakaran Pandiyan
2018-01-19 8:01 ` Rodrigo Vivi
2018-01-19 22:02 ` Pandiyan, Dhinakaran
2018-01-19 22:44 ` [Intel-gfx] " Rodrigo Vivi
2018-01-12 21:57 ` [PATCH 5/5] drm/i915: Estimate and update missed vblanks Dhinakaran Pandiyan
2018-01-15 9:45 ` Daniel Vetter
2018-01-19 7:26 ` Rodrigo Vivi
2018-01-19 21:42 ` [Intel-gfx] " Pandiyan, Dhinakaran
2018-01-19 22:45 ` Rodrigo Vivi
2018-01-12 22:26 ` ✓ Fi.CI.BAT: success for series starting with [1/5] drm/vblank: Fix return type for drm_vblank_count() Patchwork
2018-01-12 23:16 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-01-15 9:38 ` [PATCH 1/5] " Daniel Vetter
2018-01-16 21:26 ` [Intel-gfx] " Pandiyan, Dhinakaran
2018-01-19 4:53 ` Pandiyan, Dhinakaran
2018-01-19 8:03 ` Rodrigo Vivi
2018-01-19 7:36 ` Rodrigo Vivi
2018-01-19 21:30 ` Pandiyan, Dhinakaran
2018-01-31 6:42 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d11qldzw.fsf@keithp.com \
--to=keithp@keithp.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michel@daenzer.net \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).