* [PATCH v2] drm/i915: Check for fused or unused pipes
@ 2017-12-18 8:04 Mika Kahola
2017-12-18 8:30 ` ✓ Fi.CI.BAT: success for drm/i915: Check for fused or unused pipes (rev3) Patchwork
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Mika Kahola @ 2017-12-18 8:04 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, jaswinder
We may have fused or unused pipes in our system. Let's check that the pipe
in question is within limits of accessible pipes. In case, that we are not
able to access the pipe, we return early with a warning.
v2: Rephrasing of the commit message (Jani)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103206
Reported-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Jaswinder Singh Rajput <jaswinder@perfectintelligent.com>
Suggested-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
drivers/gpu/drm/i915/intel_audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index f1502a0..522d54f 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -779,7 +779,7 @@ static struct intel_encoder *get_saved_enc(struct drm_i915_private *dev_priv,
{
struct intel_encoder *encoder;
- if (WARN_ON(pipe >= INTEL_INFO(dev_priv)->num_pipes))
+ if (WARN_ON(pipe >= ARRAY_SIZE(dev_priv->av_enc_map)))
return NULL;
/* MST */
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Check for fused or unused pipes (rev3)
2017-12-18 8:04 [PATCH v2] drm/i915: Check for fused or unused pipes Mika Kahola
@ 2017-12-18 8:30 ` Patchwork
2017-12-18 9:40 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-01-19 14:22 ` [PATCH v2] drm/i915: Check for fused or unused pipes Jani Nikula
2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2017-12-18 8:30 UTC (permalink / raw)
To: Mika Kahola; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check for fused or unused pipes (rev3)
URL : https://patchwork.freedesktop.org/series/35389/
State : success
== Summary ==
Series 35389v3 drm/i915: Check for fused or unused pipes
https://patchwork.freedesktop.org/api/1.0/series/35389/revisions/3/mbox/
Test debugfs_test:
Subgroup read_all_entries:
dmesg-warn -> PASS (fi-elk-e7500) fdo#103989 +1
Test kms_psr_sink_crc:
Subgroup psr_basic:
dmesg-warn -> PASS (fi-skl-6700hq) fdo#101144
fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:433s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:439s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:386s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:498s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:277s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:495s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:493s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:478s
fi-elk-e7500 total:224 pass:163 dwarn:15 dfail:0 fail:0 skip:45
fi-gdg-551 total:7 pass:5 dwarn:1 dfail:0 fail:0 skip:0
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:538s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:407s
fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:414s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:466s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:428s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:480s
fi-kbl-7560u total:288 pass:268 dwarn:1 dfail:0 fail:0 skip:19 time:520s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:467s
fi-kbl-r total:288 pass:260 dwarn:1 dfail:0 fail:0 skip:27 time:530s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:588s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:443s
fi-skl-6600u total:288 pass:260 dwarn:1 dfail:0 fail:0 skip:27 time:527s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:564s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:507s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:504s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:446s
fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:548s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:416s
Blacklisted hosts:
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:582s
fi-cnl-y total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:638s
fi-glk-dsi total:166 pass:56 dwarn:0 dfail:2 fail:0 skip:107
b415f7d96ee2a0a2870e367c7e43f4d9f0af1ba5 drm-tip: 2017y-12m-17d-19h-00m-50s UTC integration manifest
c6f0c07d5ba9 drm/i915: Check for fused or unused pipes
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7521/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* ✗ Fi.CI.IGT: failure for drm/i915: Check for fused or unused pipes (rev3)
2017-12-18 8:04 [PATCH v2] drm/i915: Check for fused or unused pipes Mika Kahola
2017-12-18 8:30 ` ✓ Fi.CI.BAT: success for drm/i915: Check for fused or unused pipes (rev3) Patchwork
@ 2017-12-18 9:40 ` Patchwork
2018-01-19 14:22 ` [PATCH v2] drm/i915: Check for fused or unused pipes Jani Nikula
2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2017-12-18 9:40 UTC (permalink / raw)
To: Mika Kahola; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check for fused or unused pipes (rev3)
URL : https://patchwork.freedesktop.org/series/35389/
State : failure
== Summary ==
Test kms_chv_cursor_fail:
Subgroup pipe-c-64x64-bottom-edge:
pass -> INCOMPLETE (shard-hsw)
Test drv_suspend:
Subgroup fence-restore-untiled:
pass -> INCOMPLETE (shard-hsw) fdo#103540 +1
Test drv_module_reload:
Subgroup basic-reload:
dmesg-warn -> PASS (shard-snb) fdo#102848
dmesg-warn -> PASS (shard-hsw) fdo#102707
Test kms_setmode:
Subgroup clone-exclusive-crtc:
warn -> PASS (shard-snb) fdo#104312
Test kms_flip:
Subgroup wf_vblank-vs-dpms:
pass -> DMESG-WARN (shard-hsw) fdo#102614
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-blt:
pass -> FAIL (shard-snb) fdo#101623
Test gem_tiled_swapping:
Subgroup non-threaded:
pass -> INCOMPLETE (shard-snb) fdo#104218 +1
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#102848 https://bugs.freedesktop.org/show_bug.cgi?id=102848
fdo#102707 https://bugs.freedesktop.org/show_bug.cgi?id=102707
fdo#104312 https://bugs.freedesktop.org/show_bug.cgi?id=104312
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#104218 https://bugs.freedesktop.org/show_bug.cgi?id=104218
shard-hsw total:2518 pass:1423 dwarn:2 dfail:0 fail:10 skip:1079 time:8174s
shard-snb total:2620 pass:1248 dwarn:1 dfail:0 fail:12 skip:1357 time:7494s
Blacklisted hosts:
shard-apl total:2712 pass:1687 dwarn:1 dfail:1 fail:22 skip:1001 time:13896s
shard-kbl total:2712 pass:1805 dwarn:1 dfail:1 fail:25 skip:880 time:11086s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7521/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] drm/i915: Check for fused or unused pipes
2017-12-18 8:04 [PATCH v2] drm/i915: Check for fused or unused pipes Mika Kahola
2017-12-18 8:30 ` ✓ Fi.CI.BAT: success for drm/i915: Check for fused or unused pipes (rev3) Patchwork
2017-12-18 9:40 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-01-19 14:22 ` Jani Nikula
2018-01-29 20:40 ` Chris Wilson
2 siblings, 1 reply; 8+ messages in thread
From: Jani Nikula @ 2018-01-19 14:22 UTC (permalink / raw)
To: Mika Kahola, intel-gfx; +Cc: jaswinder
On Mon, 18 Dec 2017, Mika Kahola <mika.kahola@intel.com> wrote:
> We may have fused or unused pipes in our system. Let's check that the pipe
> in question is within limits of accessible pipes. In case, that we are not
> able to access the pipe, we return early with a warning.
>
> v2: Rephrasing of the commit message (Jani)
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103206
> Reported-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Jaswinder Singh Rajput <jaswinder@perfectintelligent.com>
> Suggested-by: Jani Nikula <jani.nikula@intel.com>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
Pushed, thanks for the patch, sorry for the delay.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/intel_audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index f1502a0..522d54f 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -779,7 +779,7 @@ static struct intel_encoder *get_saved_enc(struct drm_i915_private *dev_priv,
> {
> struct intel_encoder *encoder;
>
> - if (WARN_ON(pipe >= INTEL_INFO(dev_priv)->num_pipes))
> + if (WARN_ON(pipe >= ARRAY_SIZE(dev_priv->av_enc_map)))
> return NULL;
>
> /* MST */
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] drm/i915: Check for fused or unused pipes
2018-01-19 14:22 ` [PATCH v2] drm/i915: Check for fused or unused pipes Jani Nikula
@ 2018-01-29 20:40 ` Chris Wilson
2018-01-30 7:36 ` Jani Nikula
0 siblings, 1 reply; 8+ messages in thread
From: Chris Wilson @ 2018-01-29 20:40 UTC (permalink / raw)
To: Jani Nikula, Mika Kahola, intel-gfx; +Cc: jaswinder, fritsch
Quoting Jani Nikula (2018-01-19 14:22:49)
> On Mon, 18 Dec 2017, Mika Kahola <mika.kahola@intel.com> wrote:
> > We may have fused or unused pipes in our system. Let's check that the pipe
> > in question is within limits of accessible pipes. In case, that we are not
> > able to access the pipe, we return early with a warning.
> >
> > v2: Rephrasing of the commit message (Jani)
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103206
> > Reported-by: Thomas Gleixner <tglx@linutronix.de>
> > Tested-by: Jaswinder Singh Rajput <jaswinder@perfectintelligent.com>
> > Suggested-by: Jani Nikula <jani.nikula@intel.com>
> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
>
> Pushed, thanks for the patch, sorry for the delay.
This WARN is in the wild, should we queue this for drm-intel-fixes.
Reported-by: fritsch@xbmc.org
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drm/i915: Check for fused or unused pipes
2018-01-29 20:40 ` Chris Wilson
@ 2018-01-30 7:36 ` Jani Nikula
0 siblings, 0 replies; 8+ messages in thread
From: Jani Nikula @ 2018-01-30 7:36 UTC (permalink / raw)
To: Chris Wilson, Mika Kahola, intel-gfx, Rodrigo Vivi; +Cc: jaswinder, fritsch
On Mon, 29 Jan 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2018-01-19 14:22:49)
>> On Mon, 18 Dec 2017, Mika Kahola <mika.kahola@intel.com> wrote:
>> > We may have fused or unused pipes in our system. Let's check that the pipe
>> > in question is within limits of accessible pipes. In case, that we are not
>> > able to access the pipe, we return early with a warning.
>> >
>> > v2: Rephrasing of the commit message (Jani)
>> >
>> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103206
>> > Reported-by: Thomas Gleixner <tglx@linutronix.de>
>> > Tested-by: Jaswinder Singh Rajput <jaswinder@perfectintelligent.com>
>> > Suggested-by: Jani Nikula <jani.nikula@intel.com>
>> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
>>
>> Pushed, thanks for the patch, sorry for the delay.
>
> This WARN is in the wild, should we queue this for drm-intel-fixes.
>
> Reported-by: fritsch@xbmc.org
Rodrigo, please cherry-pick this to drm-intel-next-fixes, with Cc:
stable, with any other cherry-picks you might have, and send a pull
request to Dave to merge either during the merge window or at -rc1.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] drm/i915: Check for fused or unused pipes
@ 2017-12-15 13:56 Mika Kahola
2017-12-15 15:32 ` Jani Nikula
0 siblings, 1 reply; 8+ messages in thread
From: Mika Kahola @ 2017-12-15 13:56 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
We may have fused or unused pipes in our system. Let's check that the pipe
in question is within limits of accessible pipes. In case, that we are not
able to access the pipe, we return early with a warning.
v2: Rephrasing of the commit message (Jani)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103206
Reported-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
drivers/gpu/drm/i915/intel_audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index f1502a0..522d54f 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -779,7 +779,7 @@ static struct intel_encoder *get_saved_enc(struct drm_i915_private *dev_priv,
{
struct intel_encoder *encoder;
- if (WARN_ON(pipe >= INTEL_INFO(dev_priv)->num_pipes))
+ if (WARN_ON(pipe >= ARRAY_SIZE(dev_priv->av_enc_map)))
return NULL;
/* MST */
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2] drm/i915: Check for fused or unused pipes
2017-12-15 13:56 Mika Kahola
@ 2017-12-15 15:32 ` Jani Nikula
0 siblings, 0 replies; 8+ messages in thread
From: Jani Nikula @ 2017-12-15 15:32 UTC (permalink / raw)
To: Mika Kahola, intel-gfx
On Fri, 15 Dec 2017, Mika Kahola <mika.kahola@intel.com> wrote:
> We may have fused or unused pipes in our system. Let's check that the pipe
> in question is within limits of accessible pipes. In case, that we are not
> able to access the pipe, we return early with a warning.
>
> v2: Rephrasing of the commit message (Jani)
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103206
> Reported-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Please just change that to:
Suggested-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
BR,
Jani.
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
> drivers/gpu/drm/i915/intel_audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index f1502a0..522d54f 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -779,7 +779,7 @@ static struct intel_encoder *get_saved_enc(struct drm_i915_private *dev_priv,
> {
> struct intel_encoder *encoder;
>
> - if (WARN_ON(pipe >= INTEL_INFO(dev_priv)->num_pipes))
> + if (WARN_ON(pipe >= ARRAY_SIZE(dev_priv->av_enc_map)))
> return NULL;
>
> /* MST */
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-01-30 7:36 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-18 8:04 [PATCH v2] drm/i915: Check for fused or unused pipes Mika Kahola
2017-12-18 8:30 ` ✓ Fi.CI.BAT: success for drm/i915: Check for fused or unused pipes (rev3) Patchwork
2017-12-18 9:40 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-01-19 14:22 ` [PATCH v2] drm/i915: Check for fused or unused pipes Jani Nikula
2018-01-29 20:40 ` Chris Wilson
2018-01-30 7:36 ` Jani Nikula
-- strict thread matches above, loose matches on Subject: below --
2017-12-15 13:56 Mika Kahola
2017-12-15 15:32 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).