From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Remove WA_(SET|CLR)_BIT
Date: Wed, 04 Oct 2017 15:57:14 +0300 [thread overview]
Message-ID: <87d1632hqt.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20171004124153.14142-2-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> These macros are of dubious merit when coupled with the per-context w/a
> set. Instead of tweaking the value in the context, they tweak the value
> based on the mmio at the time of recording; they are almost by
> definition not per-context! Having removed the last users, remove the
> macros to avoid temptation in the future.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Oscar Mateo <oscar.mateo@intel.com>
> ---
> drivers/gpu/drm/i915/intel_engine_cs.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
> index 06044f1f48c8..60d500e27af0 100644
> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -830,9 +830,6 @@ static int wa_add(struct drm_i915_private *dev_priv,
> #define WA_SET_FIELD_MASKED(addr, mask, value) \
> WA_REG(addr, mask, _MASKED_FIELD(mask, value))
>
> -#define WA_SET_BIT(addr, mask) WA_REG(addr, mask, I915_READ(addr) | (mask))
> -#define WA_CLR_BIT(addr, mask) WA_REG(addr, mask, I915_READ(addr) & ~(mask))
> -
> #define WA_WRITE(addr, val) WA_REG(addr, 0xffffffff, val)
>
WA_WRITE can be removed too if NON_PRIV slips in first.
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> static int wa_ring_whitelist_reg(struct intel_engine_cs *engine,
> --
> 2.14.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-04 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 12:41 [PATCH 1/2] drm/i915: Move MMCD_MISC_CTRL from context w/a to standard Chris Wilson
2017-10-04 12:41 ` [PATCH 2/2] drm/i915: Remove WA_(SET|CLR)_BIT Chris Wilson
2017-10-04 12:57 ` Mika Kuoppala [this message]
2017-10-04 12:55 ` [PATCH 1/2] drm/i915: Move MMCD_MISC_CTRL from context w/a to standard Mika Kuoppala
2017-10-04 15:33 ` Oscar Mateo
2017-10-04 13:06 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2017-10-04 14:16 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1632hqt.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox