* [PATCH] dim: Accept author x signed-off based on email, but warn. @ 2017-09-19 17:48 Rodrigo Vivi 2017-09-20 7:56 ` Jani Nikula 2017-09-20 11:02 ` Joonas Lahtinen 0 siblings, 2 replies; 13+ messages in thread From: Rodrigo Vivi @ 2017-09-19 17:48 UTC (permalink / raw) To: intel-gfx; +Cc: Jani Nikula, Rodrigo Vivi It seems Patchwork or SMTP servers are messing some patches and changing the original git's author name on git per "Last, First". So we end up with a mismatch were signed-off uses one name format and author is using another format. So, let's check for email addresses instead. However let's continue to WARN so commiters can take action on it before pushing patch upstream with incorrect "Last, First" name. Cc: Jani Nikula <jani.nikula@intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- dim | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dim b/dim index dbaeb1ec944d..13cc5f00209d 100755 --- a/dim +++ b/dim @@ -690,11 +690,16 @@ function checkpatch_commit_push # use real names for people with many different email addresses author=$(git show -s $sha1 --format="format:%an") + author_email=$(git show -s $sha1 --format="format:%ae") committer=$(git show -s $sha1 --format="format:%cn") # check for author sign-off if ! git show -s $sha1 | grep -qi "S.*-by:.*$author" ; then - warn_or_fail "$sha1 is lacking author of sign-off" + if git show -s $sha1 | grep -qi "S.*-by:.*$author_email" ; then + echoerr "WARNING: Author name mismatch. Patchwork or SMTP messing it up. Consider fixing it before pushing it." + else + warn_or_fail "$sha1 is lacking author of sign-off" + fi fi # check for committer sign-off -- 2.13.5 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] dim: Accept author x signed-off based on email, but warn. 2017-09-19 17:48 [PATCH] dim: Accept author x signed-off based on email, but warn Rodrigo Vivi @ 2017-09-20 7:56 ` Jani Nikula 2017-09-20 11:02 ` Joonas Lahtinen 1 sibling, 0 replies; 13+ messages in thread From: Jani Nikula @ 2017-09-20 7:56 UTC (permalink / raw) To: intel-gfx; +Cc: Rodrigo Vivi On Tue, 19 Sep 2017, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote: > It seems Patchwork or SMTP servers are messing some patches > and changing the original git's author name on git per "Last, First". > So we end up with a mismatch were signed-off uses one name format > and author is using another format. > > So, let's check for email addresses instead. > > However let's continue to WARN so commiters can take action on it > before pushing patch upstream with incorrect "Last, First" name. > > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > dim | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/dim b/dim > index dbaeb1ec944d..13cc5f00209d 100755 > --- a/dim > +++ b/dim > @@ -690,11 +690,16 @@ function checkpatch_commit_push > > # use real names for people with many different email addresses > author=$(git show -s $sha1 --format="format:%an") > + author_email=$(git show -s $sha1 --format="format:%ae") > committer=$(git show -s $sha1 --format="format:%cn") > > # check for author sign-off > if ! git show -s $sha1 | grep -qi "S.*-by:.*$author" ; then > - warn_or_fail "$sha1 is lacking author of sign-off" > + if git show -s $sha1 | grep -qi "S.*-by:.*$author_email" ; then No spaces required before ;. Even if it's copy-pasted from above... ;) > + echoerr "WARNING: Author name mismatch. Patchwork or SMTP messing it up. Consider fixing it before pushing it." Please don't make any assumptions about what caused it. The user may have configured it so. But the real trouble is, it's too late anyway at this state. If this succeeds, it'll already be pushed after it's done! > + else > + warn_or_fail "$sha1 is lacking author of sign-off" Please fix this while at it, it doesn't make any sense. "$sha1 author sign-off missing" or something. > + fi > fi > > # check for committer sign-off -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dim: Accept author x signed-off based on email, but warn. 2017-09-19 17:48 [PATCH] dim: Accept author x signed-off based on email, but warn Rodrigo Vivi 2017-09-20 7:56 ` Jani Nikula @ 2017-09-20 11:02 ` Joonas Lahtinen 2017-09-20 11:51 ` Jani Nikula 1 sibling, 1 reply; 13+ messages in thread From: Joonas Lahtinen @ 2017-09-20 11:02 UTC (permalink / raw) To: Rodrigo Vivi, intel-gfx, Arkadiusz Hiler; +Cc: Jani Nikula On Tue, 2017-09-19 at 10:48 -0700, Rodrigo Vivi wrote: > It seems Patchwork or SMTP servers are messing some patches > and changing the original git's author name on git per "Last, First". > So we end up with a mismatch were signed-off uses one name format > and author is using another format. + Arek, Wasn't this trouble supposed to be fixed? Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dim: Accept author x signed-off based on email, but warn. 2017-09-20 11:02 ` Joonas Lahtinen @ 2017-09-20 11:51 ` Jani Nikula 2017-09-20 12:46 ` Rodrigo Vivi 2017-09-20 12:49 ` [PATCH] dim: Accept author x signed-off based on email Rodrigo Vivi 0 siblings, 2 replies; 13+ messages in thread From: Jani Nikula @ 2017-09-20 11:51 UTC (permalink / raw) To: Joonas Lahtinen, Rodrigo Vivi, intel-gfx, Arkadiusz Hiler On Wed, 20 Sep 2017, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote: > On Tue, 2017-09-19 at 10:48 -0700, Rodrigo Vivi wrote: >> It seems Patchwork or SMTP servers are messing some patches >> and changing the original git's author name on git per "Last, First". >> So we end up with a mismatch were signed-off uses one name format >> and author is using another format. > > + Arek, > > Wasn't this trouble supposed to be fixed? Maybe in patchwork context, but it can still happen for people applying patches from their MUA. And I doubt it can be reliably "fixed" if the author intentionally or inadvertently has differing author and sob lines. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dim: Accept author x signed-off based on email, but warn. 2017-09-20 11:51 ` Jani Nikula @ 2017-09-20 12:46 ` Rodrigo Vivi 2017-09-20 12:49 ` [PATCH] dim: Accept author x signed-off based on email Rodrigo Vivi 1 sibling, 0 replies; 13+ messages in thread From: Rodrigo Vivi @ 2017-09-20 12:46 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx On Wed, Sep 20, 2017 at 11:51:50AM +0000, Jani Nikula wrote: > On Wed, 20 Sep 2017, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote: > > On Tue, 2017-09-19 at 10:48 -0700, Rodrigo Vivi wrote: > >> It seems Patchwork or SMTP servers are messing some patches > >> and changing the original git's author name on git per "Last, First". > >> So we end up with a mismatch were signed-off uses one name format > >> and author is using another format. > > > > + Arek, > > > > Wasn't this trouble supposed to be fixed? > > Maybe in patchwork context, but it can still happen for people applying > patches from their MUA. And I doubt it can be reliably "fixed" if the > author intentionally or inadvertently has differing author and sob > lines. hmm... if this is possible we do need to only check for email and move one. But anyways what I'm seeing a lot recently is this patchwork issue joonas mentioned. I had to edit few of my patches recently because something on the way changed my "name last" per "last, name".. and this seems exactly the case with one Manasi's and one Lee's patch that was impacting the pull request flow. So if the patchwork is fixed now I believe we can just change the check to email instead of the name and move on... Thanks, Rodrigo. > > BR, > Jani. > > > -- > Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] dim: Accept author x signed-off based on email. 2017-09-20 11:51 ` Jani Nikula 2017-09-20 12:46 ` Rodrigo Vivi @ 2017-09-20 12:49 ` Rodrigo Vivi 2017-09-21 11:12 ` Jani Nikula 1 sibling, 1 reply; 13+ messages in thread From: Rodrigo Vivi @ 2017-09-20 12:49 UTC (permalink / raw) To: intel-gfx; +Cc: Jani Nikula, Rodrigo Vivi It seems Patchwork or SMTP servers are messing some patches and changing the original git's author name on git per "Last, First". So we end up with a mismatch were signed-off uses one name format and author is using another format. So, let's check for email addresses instead. v2: Avoid useles warning and only check for email. Cc: Jani Nikula <jani.nikula@intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- dim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dim b/dim index dbaeb1ec944d..a63000fb67a8 100755 --- a/dim +++ b/dim @@ -689,7 +689,7 @@ function checkpatch_commit_push sha1=$1 # use real names for people with many different email addresses - author=$(git show -s $sha1 --format="format:%an") + author=$(git show -s $sha1 --format="format:%ae") committer=$(git show -s $sha1 --format="format:%cn") # check for author sign-off -- 2.13.5 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] dim: Accept author x signed-off based on email. 2017-09-20 12:49 ` [PATCH] dim: Accept author x signed-off based on email Rodrigo Vivi @ 2017-09-21 11:12 ` Jani Nikula 2017-09-21 13:27 ` Rodrigo Vivi 0 siblings, 1 reply; 13+ messages in thread From: Jani Nikula @ 2017-09-21 11:12 UTC (permalink / raw) To: intel-gfx; +Cc: Rodrigo Vivi On Wed, 20 Sep 2017, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote: > It seems Patchwork or SMTP servers are messing some patches > and changing the original git's author name on git per "Last, First". > So we end up with a mismatch were signed-off uses one name format > and author is using another format. > > So, let's check for email addresses instead. > > v2: Avoid useles warning and only check for email. > > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > dim | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dim b/dim > index dbaeb1ec944d..a63000fb67a8 100755 > --- a/dim > +++ b/dim > @@ -689,7 +689,7 @@ function checkpatch_commit_push > sha1=$1 > > # use real names for people with many different email addresses > - author=$(git show -s $sha1 --format="format:%an") > + author=$(git show -s $sha1 --format="format:%ae") > committer=$(git show -s $sha1 --format="format:%cn") > > # check for author sign-off -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dim: Accept author x signed-off based on email. 2017-09-21 11:12 ` Jani Nikula @ 2017-09-21 13:27 ` Rodrigo Vivi 2017-09-26 11:59 ` Daniel Vetter 0 siblings, 1 reply; 13+ messages in thread From: Rodrigo Vivi @ 2017-09-21 13:27 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx On Thu, Sep 21, 2017 at 11:12:52AM +0000, Jani Nikula wrote: > On Wed, 20 Sep 2017, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote: > > It seems Patchwork or SMTP servers are messing some patches > > and changing the original git's author name on git per "Last, First". > > So we end up with a mismatch were signed-off uses one name format > > and author is using another format. > > > > So, let's check for email addresses instead. > > > > v2: Avoid useles warning and only check for email. > > > > Cc: Jani Nikula <jani.nikula@intel.com> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Reviewed-by: Jani Nikula <jani.nikula@intel.com> pushed, thanks. > > > --- > > dim | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/dim b/dim > > index dbaeb1ec944d..a63000fb67a8 100755 > > --- a/dim > > +++ b/dim > > @@ -689,7 +689,7 @@ function checkpatch_commit_push > > sha1=$1 > > > > # use real names for people with many different email addresses > > - author=$(git show -s $sha1 --format="format:%an") > > + author=$(git show -s $sha1 --format="format:%ae") > > committer=$(git show -s $sha1 --format="format:%cn") > > > > # check for author sign-off > > -- > Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dim: Accept author x signed-off based on email. 2017-09-21 13:27 ` Rodrigo Vivi @ 2017-09-26 11:59 ` Daniel Vetter 2017-09-26 13:24 ` Jani Nikula 0 siblings, 1 reply; 13+ messages in thread From: Daniel Vetter @ 2017-09-26 11:59 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: Jani Nikula, intel-gfx On Thu, Sep 21, 2017 at 06:27:28AM -0700, Rodrigo Vivi wrote: > On Thu, Sep 21, 2017 at 11:12:52AM +0000, Jani Nikula wrote: > > On Wed, 20 Sep 2017, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote: > > > It seems Patchwork or SMTP servers are messing some patches > > > and changing the original git's author name on git per "Last, First". > > > So we end up with a mismatch were signed-off uses one name format > > > and author is using another format. > > > > > > So, let's check for email addresses instead. > > > > > > v2: Avoid useles warning and only check for email. > > > > > > Cc: Jani Nikula <jani.nikula@intel.com> > > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > > Reviewed-by: Jani Nikula <jani.nikula@intel.com> > > pushed, thanks. Yeah except this breaks funny people like me who use different mails for stuff. My idea with fixing this was that we parse the mail name and check for both "Last, First" and "First Last" to work around the outlook crap. I really don't want to send mail from @intel.com to anywhere near public stuff. -Daniel > > > > > > --- > > > dim | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/dim b/dim > > > index dbaeb1ec944d..a63000fb67a8 100755 > > > --- a/dim > > > +++ b/dim > > > @@ -689,7 +689,7 @@ function checkpatch_commit_push > > > sha1=$1 > > > > > > # use real names for people with many different email addresses > > > - author=$(git show -s $sha1 --format="format:%an") > > > + author=$(git show -s $sha1 --format="format:%ae") > > > committer=$(git show -s $sha1 --format="format:%cn") > > > > > > # check for author sign-off > > > > -- > > Jani Nikula, Intel Open Source Technology Center > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dim: Accept author x signed-off based on email. 2017-09-26 11:59 ` Daniel Vetter @ 2017-09-26 13:24 ` Jani Nikula 2017-09-26 16:55 ` Rodrigo Vivi 0 siblings, 1 reply; 13+ messages in thread From: Jani Nikula @ 2017-09-26 13:24 UTC (permalink / raw) To: Daniel Vetter, Rodrigo Vivi; +Cc: intel-gfx On Tue, 26 Sep 2017, Daniel Vetter <daniel@ffwll.ch> wrote: > On Thu, Sep 21, 2017 at 06:27:28AM -0700, Rodrigo Vivi wrote: >> On Thu, Sep 21, 2017 at 11:12:52AM +0000, Jani Nikula wrote: >> > On Wed, 20 Sep 2017, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote: >> > > It seems Patchwork or SMTP servers are messing some patches >> > > and changing the original git's author name on git per "Last, First". >> > > So we end up with a mismatch were signed-off uses one name format >> > > and author is using another format. >> > > >> > > So, let's check for email addresses instead. >> > > >> > > v2: Avoid useles warning and only check for email. >> > > >> > > Cc: Jani Nikula <jani.nikula@intel.com> >> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> >> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> >> > >> > Reviewed-by: Jani Nikula <jani.nikula@intel.com> >> >> pushed, thanks. > > Yeah except this breaks funny people like me who use different mails for > stuff. My idea with fixing this was that we parse the mail name and check > for both "Last, First" and "First Last" to work around the outlook crap. > > I really don't want to send mail from @intel.com to anywhere near public > stuff. Ok, I'm fine with reverting, and finding another way. BR, Jani. > -Daniel > >> >> > >> > > --- >> > > dim | 2 +- >> > > 1 file changed, 1 insertion(+), 1 deletion(-) >> > > >> > > diff --git a/dim b/dim >> > > index dbaeb1ec944d..a63000fb67a8 100755 >> > > --- a/dim >> > > +++ b/dim >> > > @@ -689,7 +689,7 @@ function checkpatch_commit_push >> > > sha1=$1 >> > > >> > > # use real names for people with many different email addresses >> > > - author=$(git show -s $sha1 --format="format:%an") >> > > + author=$(git show -s $sha1 --format="format:%ae") >> > > committer=$(git show -s $sha1 --format="format:%cn") >> > > >> > > # check for author sign-off >> > >> > -- >> > Jani Nikula, Intel Open Source Technology Center >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dim: Accept author x signed-off based on email. 2017-09-26 13:24 ` Jani Nikula @ 2017-09-26 16:55 ` Rodrigo Vivi 2017-09-27 12:14 ` Daniel Vetter 0 siblings, 1 reply; 13+ messages in thread From: Rodrigo Vivi @ 2017-09-26 16:55 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx On Tue, Sep 26, 2017 at 01:24:35PM +0000, Jani Nikula wrote: > On Tue, 26 Sep 2017, Daniel Vetter <daniel@ffwll.ch> wrote: > > On Thu, Sep 21, 2017 at 06:27:28AM -0700, Rodrigo Vivi wrote: > >> On Thu, Sep 21, 2017 at 11:12:52AM +0000, Jani Nikula wrote: > >> > On Wed, 20 Sep 2017, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote: > >> > > It seems Patchwork or SMTP servers are messing some patches > >> > > and changing the original git's author name on git per "Last, First". > >> > > So we end up with a mismatch were signed-off uses one name format > >> > > and author is using another format. > >> > > > >> > > So, let's check for email addresses instead. > >> > > > >> > > v2: Avoid useles warning and only check for email. > >> > > > >> > > Cc: Jani Nikula <jani.nikula@intel.com> > >> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > >> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > >> > > >> > Reviewed-by: Jani Nikula <jani.nikula@intel.com> > >> > >> pushed, thanks. > > > > Yeah except this breaks funny people like me who use different mails for > > stuff. My idea with fixing this was that we parse the mail name and check > > for both "Last, First" and "First Last" to work around the outlook crap. The name parsing with last and first can be really nasty and end up having other corner cases soon. Like, my legal name in us is still: de Oliveira Vivi, Rodrigo not Vivi, Rodrigo de Oliveira I can imagine many other possible combinations with this and other names. > > > > I really don't want to send mail from @intel.com to anywhere near public > > stuff. I'm not sure if it is outlook fault honestly. On my patches where this funny mess happenend I checked my email on the mailing list and original and everything seemed sane there. The only place where Last, First started was post pwclient. > > Ok, I'm fine with reverting, and finding another way. I'm fine with the revert as well, but before reverting let me propose one thing that is name_match || email_match so we cover both cases. What do you think? > > BR, > Jani. > > > -Daniel > > > >> > >> > > >> > > --- > >> > > dim | 2 +- > >> > > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > > >> > > diff --git a/dim b/dim > >> > > index dbaeb1ec944d..a63000fb67a8 100755 > >> > > --- a/dim > >> > > +++ b/dim > >> > > @@ -689,7 +689,7 @@ function checkpatch_commit_push > >> > > sha1=$1 > >> > > > >> > > # use real names for people with many different email addresses > >> > > - author=$(git show -s $sha1 --format="format:%an") > >> > > + author=$(git show -s $sha1 --format="format:%ae") > >> > > committer=$(git show -s $sha1 --format="format:%cn") > >> > > > >> > > # check for author sign-off > >> > > >> > -- > >> > Jani Nikula, Intel Open Source Technology Center > >> _______________________________________________ > >> Intel-gfx mailing list > >> Intel-gfx@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dim: Accept author x signed-off based on email. 2017-09-26 16:55 ` Rodrigo Vivi @ 2017-09-27 12:14 ` Daniel Vetter 2017-09-27 15:39 ` Rodrigo Vivi 0 siblings, 1 reply; 13+ messages in thread From: Daniel Vetter @ 2017-09-27 12:14 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: Jani Nikula, intel-gfx On Tue, Sep 26, 2017 at 09:55:44AM -0700, Rodrigo Vivi wrote: > On Tue, Sep 26, 2017 at 01:24:35PM +0000, Jani Nikula wrote: > > On Tue, 26 Sep 2017, Daniel Vetter <daniel@ffwll.ch> wrote: > > > On Thu, Sep 21, 2017 at 06:27:28AM -0700, Rodrigo Vivi wrote: > > >> On Thu, Sep 21, 2017 at 11:12:52AM +0000, Jani Nikula wrote: > > >> > On Wed, 20 Sep 2017, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote: > > >> > > It seems Patchwork or SMTP servers are messing some patches > > >> > > and changing the original git's author name on git per "Last, First". > > >> > > So we end up with a mismatch were signed-off uses one name format > > >> > > and author is using another format. > > >> > > > > >> > > So, let's check for email addresses instead. > > >> > > > > >> > > v2: Avoid useles warning and only check for email. > > >> > > > > >> > > Cc: Jani Nikula <jani.nikula@intel.com> > > >> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > >> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > >> > > > >> > Reviewed-by: Jani Nikula <jani.nikula@intel.com> > > >> > > >> pushed, thanks. > > > > > > Yeah except this breaks funny people like me who use different mails for > > > stuff. My idea with fixing this was that we parse the mail name and check > > > for both "Last, First" and "First Last" to work around the outlook crap. > > The name parsing with last and first can be really nasty and end up having other > corner cases soon. > > Like, my legal name in us is still: > de Oliveira Vivi, Rodrigo > not > Vivi, Rodrigo de Oliveira > > I can imagine many other possible combinations with this and other names. Luckily you're only Rodrigo Vivi in intel's system, so we're passing. But yes, we probably need to check all possible combos for where we could place the comma. > > > > > > > I really don't want to send mail from @intel.com to anywhere near public > > > stuff. > > I'm not sure if it is outlook fault honestly. On my patches where this funny > mess happenend I checked my email on the mailing list and original and everything > seemed sane there. The only place where Last, First started was post pwclient. > > > > > Ok, I'm fine with reverting, and finding another way. > > I'm fine with the revert as well, but before reverting let me propose one thing > that is name_match || email_match so we cover both cases. > > What do you think? I sent out a patch, pls test for your cases. I'll be happy to amend. -Daniel > > > > > BR, > > Jani. > > > > > -Daniel > > > > > >> > > >> > > > >> > > --- > > >> > > dim | 2 +- > > >> > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >> > > > > >> > > diff --git a/dim b/dim > > >> > > index dbaeb1ec944d..a63000fb67a8 100755 > > >> > > --- a/dim > > >> > > +++ b/dim > > >> > > @@ -689,7 +689,7 @@ function checkpatch_commit_push > > >> > > sha1=$1 > > >> > > > > >> > > # use real names for people with many different email addresses > > >> > > - author=$(git show -s $sha1 --format="format:%an") > > >> > > + author=$(git show -s $sha1 --format="format:%ae") > > >> > > committer=$(git show -s $sha1 --format="format:%cn") > > >> > > > > >> > > # check for author sign-off > > >> > > > >> > -- > > >> > Jani Nikula, Intel Open Source Technology Center > > >> _______________________________________________ > > >> Intel-gfx mailing list > > >> Intel-gfx@lists.freedesktop.org > > >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > -- > > Jani Nikula, Intel Open Source Technology Center -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dim: Accept author x signed-off based on email. 2017-09-27 12:14 ` Daniel Vetter @ 2017-09-27 15:39 ` Rodrigo Vivi 0 siblings, 0 replies; 13+ messages in thread From: Rodrigo Vivi @ 2017-09-27 15:39 UTC (permalink / raw) To: Daniel Vetter; +Cc: Jani Nikula, intel-gfx On Wed, Sep 27, 2017 at 12:14:55PM +0000, Daniel Vetter wrote: > On Tue, Sep 26, 2017 at 09:55:44AM -0700, Rodrigo Vivi wrote: > > On Tue, Sep 26, 2017 at 01:24:35PM +0000, Jani Nikula wrote: > > > On Tue, 26 Sep 2017, Daniel Vetter <daniel@ffwll.ch> wrote: > > > > On Thu, Sep 21, 2017 at 06:27:28AM -0700, Rodrigo Vivi wrote: > > > >> On Thu, Sep 21, 2017 at 11:12:52AM +0000, Jani Nikula wrote: > > > >> > On Wed, 20 Sep 2017, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote: > > > >> > > It seems Patchwork or SMTP servers are messing some patches > > > >> > > and changing the original git's author name on git per "Last, First". > > > >> > > So we end up with a mismatch were signed-off uses one name format > > > >> > > and author is using another format. > > > >> > > > > > >> > > So, let's check for email addresses instead. > > > >> > > > > > >> > > v2: Avoid useles warning and only check for email. > > > >> > > > > > >> > > Cc: Jani Nikula <jani.nikula@intel.com> > > > >> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > > >> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > >> > > > > >> > Reviewed-by: Jani Nikula <jani.nikula@intel.com> > > > >> > > > >> pushed, thanks. > > > > > > > > Yeah except this breaks funny people like me who use different mails for > > > > stuff. My idea with fixing this was that we parse the mail name and check > > > > for both "Last, First" and "First Last" to work around the outlook crap. > > > > The name parsing with last and first can be really nasty and end up having other > > corner cases soon. > > > > Like, my legal name in us is still: > > de Oliveira Vivi, Rodrigo > > not > > Vivi, Rodrigo de Oliveira > > > > I can imagine many other possible combinations with this and other names. > > Luckily you're only Rodrigo Vivi in intel's system, so we're passing. my one was just the first example that came to my mind ;) > > But yes, we probably need to check all possible combos for where we could > place the comma. yep, because my name wasn't the problem on the fixes branches flow. Others names end up merged with last, name. > > > > > > > > > > > I really don't want to send mail from @intel.com to anywhere near public > > > > stuff. > > > > I'm not sure if it is outlook fault honestly. On my patches where this funny > > mess happenend I checked my email on the mailing list and original and everything > > seemed sane there. The only place where Last, First started was post pwclient. > > > > > > > > Ok, I'm fine with reverting, and finding another way. > > > > I'm fine with the revert as well, but before reverting let me propose one thing > > that is name_match || email_match so we cover both cases. > > > > What do you think? > > I sent out a patch, pls test for your cases. I'll be happy to amend. lets move with those patches and if I get impacted on fixes flow later again I raise it back ;) > -Daniel > > > > > > > > > BR, > > > Jani. > > > > > > > -Daniel > > > > > > > >> > > > >> > > > > >> > > --- > > > >> > > dim | 2 +- > > > >> > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >> > > > > > >> > > diff --git a/dim b/dim > > > >> > > index dbaeb1ec944d..a63000fb67a8 100755 > > > >> > > --- a/dim > > > >> > > +++ b/dim > > > >> > > @@ -689,7 +689,7 @@ function checkpatch_commit_push > > > >> > > sha1=$1 > > > >> > > > > > >> > > # use real names for people with many different email addresses > > > >> > > - author=$(git show -s $sha1 --format="format:%an") > > > >> > > + author=$(git show -s $sha1 --format="format:%ae") > > > >> > > committer=$(git show -s $sha1 --format="format:%cn") > > > >> > > > > > >> > > # check for author sign-off > > > >> > > > > >> > -- > > > >> > Jani Nikula, Intel Open Source Technology Center > > > >> _______________________________________________ > > > >> Intel-gfx mailing list > > > >> Intel-gfx@lists.freedesktop.org > > > >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > > > -- > > > Jani Nikula, Intel Open Source Technology Center > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2017-09-27 15:39 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-09-19 17:48 [PATCH] dim: Accept author x signed-off based on email, but warn Rodrigo Vivi 2017-09-20 7:56 ` Jani Nikula 2017-09-20 11:02 ` Joonas Lahtinen 2017-09-20 11:51 ` Jani Nikula 2017-09-20 12:46 ` Rodrigo Vivi 2017-09-20 12:49 ` [PATCH] dim: Accept author x signed-off based on email Rodrigo Vivi 2017-09-21 11:12 ` Jani Nikula 2017-09-21 13:27 ` Rodrigo Vivi 2017-09-26 11:59 ` Daniel Vetter 2017-09-26 13:24 ` Jani Nikula 2017-09-26 16:55 ` Rodrigo Vivi 2017-09-27 12:14 ` Daniel Vetter 2017-09-27 15:39 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).