From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 4/7] drm/i915: Change the placement of some static functions in intel_dp.c Date: Fri, 28 Oct 2016 15:11:34 +0300 Message-ID: <87d1iklll5.fsf@intel.com> References: <1477524358-16563-1-git-send-email-manasi.d.navare@intel.com> <1477524358-16563-4-git-send-email-manasi.d.navare@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 845346E294 for ; Fri, 28 Oct 2016 12:11:37 +0000 (UTC) In-Reply-To: <1477524358-16563-4-git-send-email-manasi.d.navare@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Manasi Navare , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAyNyBPY3QgMjAxNiwgTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVs LmNvbT4gd3JvdGU6Cj4gRnJvbTogIk5hdmFyZSwgTWFuYXNpIEQiIDxtYW5hc2kuZC5uYXZhcmVA aW50ZWwuY29tPgo+Cj4gVGhlc2Ugc3RhdGljIGhlbHBlciBmdW5jdGlvbnMgYXJlIHJlcXVpcmVk IHRvIGJlIHVzZWQgZHVyaW5nCj4gZmFsbGJhY2sgbGluayByYXRlIGltcGxlbW5ldGF0aW9uIHNv IHRoZXkgbmVlZCB0byBiZSBwbGFjZWQgYXQgdGhlIHRvcAo+IG9mIHRoZSBmaWxlLgo+Cj4gdjM6 Cj4gKiBBZGQgY2xlYW51cCB0byBvdGhlciBwYXRjaCAoTWlrYSBLYWhvbGEpCj4gdjI6Cj4gKiBE b250IG1vdmUgYXJvdW5kIGZ1bmN0aW9ucyBkZWNsYXJlZCBpbiBpbnRlbF9kcnYuaCAoUm9kcmln byBWaXZpKQo+Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRlbC5jb20+ Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+IENjOiBWaWxs ZSBTeXJqYWxhIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5 OiBNYW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwuY29tPgo+IFJldmlld2VkLWJ5 OiBNaWthIEthaG9sYSA8bWlrYS5rYWhvbGFAaW50ZWwuY29tPgoKUHVzaGVkIHRoaXMgb25lIHNv IHdlIGRvbid0IGhhdmUgdG8ga2VlcCBjYXJyeWluZyBpdCBhcm91bmQuIFRoYW5rcyBmb3IKdGhl IHBhdGNoIGFuZCByZXZpZXcuCgpCUiwKSmFuaS4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RwLmMgfCAxNTAgKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0t LS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNzUgaW5zZXJ0aW9ucygrKSwgNzUgZGVsZXRpb25zKC0p Cj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRleCA3OTU4OTdjLi5hZWNmZDIyIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gQEAgLTIxMyw2ICsyMTMsODEgQEAgc3RhdGljIHU4 IGludGVsX2RwX21heF9sYW5lX2NvdW50KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIAly ZXR1cm4gbWF4X2RvdGNsazsKPiAgfQo+ICAKPiArc3RhdGljIGludAo+ICtpbnRlbF9kcF9zaW5r X3JhdGVzKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIGNvbnN0IGludCAqKnNpbmtfcmF0ZXMp Cj4gK3sKPiArCWlmIChpbnRlbF9kcC0+bnVtX3NpbmtfcmF0ZXMpIHsKPiArCQkqc2lua19yYXRl cyA9IGludGVsX2RwLT5zaW5rX3JhdGVzOwo+ICsJCXJldHVybiBpbnRlbF9kcC0+bnVtX3Npbmtf cmF0ZXM7Cj4gKwl9Cj4gKwo+ICsJKnNpbmtfcmF0ZXMgPSBkZWZhdWx0X3JhdGVzOwo+ICsKPiAr CXJldHVybiAoaW50ZWxfZHBfbWF4X2xpbmtfYncoaW50ZWxfZHApID4+IDMpICsgMTsKPiArfQo+ ICsKPiArc3RhdGljIGludAo+ICtpbnRlbF9kcF9zb3VyY2VfcmF0ZXMoc3RydWN0IGludGVsX2Rw ICppbnRlbF9kcCwgY29uc3QgaW50ICoqc291cmNlX3JhdGVzKQo+ICt7Cj4gKwlzdHJ1Y3QgaW50 ZWxfZGlnaXRhbF9wb3J0ICpkaWdfcG9ydCA9IGRwX3RvX2RpZ19wb3J0KGludGVsX2RwKTsKPiAr CXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGlnX3BvcnQtPmJh c2UuYmFzZS5kZXYpOwo+ICsJaW50IHNpemU7Cj4gKwo+ICsJaWYgKElTX0JST1hUT04oZGV2X3By aXYpKSB7Cj4gKwkJKnNvdXJjZV9yYXRlcyA9IGJ4dF9yYXRlczsKPiArCQlzaXplID0gQVJSQVlf U0laRShieHRfcmF0ZXMpOwo+ICsJfSBlbHNlIGlmIChJU19TS1lMQUtFKGRldl9wcml2KSB8fCBJ U19LQUJZTEFLRShkZXZfcHJpdikpIHsKPiArCQkqc291cmNlX3JhdGVzID0gc2tsX3JhdGVzOwo+ ICsJCXNpemUgPSBBUlJBWV9TSVpFKHNrbF9yYXRlcyk7Cj4gKwl9IGVsc2Ugewo+ICsJCSpzb3Vy Y2VfcmF0ZXMgPSBkZWZhdWx0X3JhdGVzOwo+ICsJCXNpemUgPSBBUlJBWV9TSVpFKGRlZmF1bHRf cmF0ZXMpOwo+ICsJfQo+ICsKPiArCS8qIFRoaXMgZGVwZW5kcyBvbiB0aGUgZmFjdCB0aGF0IDUu NCBpcyBsYXN0IHZhbHVlIGluIHRoZSBhcnJheSAqLwo+ICsJaWYgKCFpbnRlbF9kcF9zb3VyY2Vf c3VwcG9ydHNfaGJyMihpbnRlbF9kcCkpCj4gKwkJc2l6ZS0tOwo+ICsKPiArCXJldHVybiBzaXpl Owo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IGludGVyc2VjdF9yYXRlcyhjb25zdCBpbnQgKnNvdXJj ZV9yYXRlcywgaW50IHNvdXJjZV9sZW4sCj4gKwkJCSAgIGNvbnN0IGludCAqc2lua19yYXRlcywg aW50IHNpbmtfbGVuLAo+ICsJCQkgICBpbnQgKmNvbW1vbl9yYXRlcykKPiArewo+ICsJaW50IGkg PSAwLCBqID0gMCwgayA9IDA7Cj4gKwo+ICsJd2hpbGUgKGkgPCBzb3VyY2VfbGVuICYmIGogPCBz aW5rX2xlbikgewo+ICsJCWlmIChzb3VyY2VfcmF0ZXNbaV0gPT0gc2lua19yYXRlc1tqXSkgewo+ ICsJCQlpZiAoV0FSTl9PTihrID49IERQX01BWF9TVVBQT1JURURfUkFURVMpKQo+ICsJCQkJcmV0 dXJuIGs7Cj4gKwkJCWNvbW1vbl9yYXRlc1trXSA9IHNvdXJjZV9yYXRlc1tpXTsKPiArCQkJKytr Owo+ICsJCQkrK2k7Cj4gKwkJCSsrajsKPiArCQl9IGVsc2UgaWYgKHNvdXJjZV9yYXRlc1tpXSA8 IHNpbmtfcmF0ZXNbal0pIHsKPiArCQkJKytpOwo+ICsJCX0gZWxzZSB7Cj4gKwkJCSsrajsKPiAr CQl9Cj4gKwl9Cj4gKwlyZXR1cm4gazsKPiArfQo+ICsKPiArc3RhdGljIGludCBpbnRlbF9kcF9j b21tb25fcmF0ZXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiArCQkJCSBpbnQgKmNvbW1v bl9yYXRlcykKPiArewo+ICsJY29uc3QgaW50ICpzb3VyY2VfcmF0ZXMsICpzaW5rX3JhdGVzOwo+ ICsJaW50IHNvdXJjZV9sZW4sIHNpbmtfbGVuOwo+ICsKPiArCXNpbmtfbGVuID0gaW50ZWxfZHBf c2lua19yYXRlcyhpbnRlbF9kcCwgJnNpbmtfcmF0ZXMpOwo+ICsJc291cmNlX2xlbiA9IGludGVs X2RwX3NvdXJjZV9yYXRlcyhpbnRlbF9kcCwgJnNvdXJjZV9yYXRlcyk7Cj4gKwo+ICsJcmV0dXJu IGludGVyc2VjdF9yYXRlcyhzb3VyY2VfcmF0ZXMsIHNvdXJjZV9sZW4sCj4gKwkJCSAgICAgICBz aW5rX3JhdGVzLCBzaW5rX2xlbiwKPiArCQkJICAgICAgIGNvbW1vbl9yYXRlcyk7Cj4gK30KPiAr Cj4gIHN0YXRpYyBlbnVtIGRybV9tb2RlX3N0YXR1cwo+ICBpbnRlbF9kcF9tb2RlX3ZhbGlkKHN0 cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gIAkJICAgIHN0cnVjdCBkcm1fZGlzcGxh eV9tb2RlICptb2RlKQo+IEBAIC0xMjkxLDE5ICsxMzY2LDYgQEAgc3RhdGljIHZvaWQgaW50ZWxf YXV4X3JlZ19pbml0KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIAlpbnRlbF9kcC0+YXV4 LnRyYW5zZmVyID0gaW50ZWxfZHBfYXV4X3RyYW5zZmVyOwo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50 Cj4gLWludGVsX2RwX3NpbmtfcmF0ZXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgY29uc3Qg aW50ICoqc2lua19yYXRlcykKPiAtewo+IC0JaWYgKGludGVsX2RwLT5udW1fc2lua19yYXRlcykg ewo+IC0JCSpzaW5rX3JhdGVzID0gaW50ZWxfZHAtPnNpbmtfcmF0ZXM7Cj4gLQkJcmV0dXJuIGlu dGVsX2RwLT5udW1fc2lua19yYXRlczsKPiAtCX0KPiAtCj4gLQkqc2lua19yYXRlcyA9IGRlZmF1 bHRfcmF0ZXM7Cj4gLQo+IC0JcmV0dXJuIChpbnRlbF9kcF9tYXhfbGlua19idyhpbnRlbF9kcCkg Pj4gMykgKyAxOwo+IC19Cj4gLQo+ICBib29sIGludGVsX2RwX3NvdXJjZV9zdXBwb3J0c19oYnIy KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIHsKPiAgCXN0cnVjdCBpbnRlbF9kaWdpdGFs X3BvcnQgKmRpZ19wb3J0ID0gZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApOwo+IEBAIC0xMzE2LDMx ICsxMzc4LDYgQEAgYm9vbCBpbnRlbF9kcF9zb3VyY2Vfc3VwcG9ydHNfaGJyMihzdHJ1Y3QgaW50 ZWxfZHAgKmludGVsX2RwKQo+ICAJCXJldHVybiBmYWxzZTsKPiAgfQo+ICAKPiAtc3RhdGljIGlu dAo+IC1pbnRlbF9kcF9zb3VyY2VfcmF0ZXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgY29u c3QgaW50ICoqc291cmNlX3JhdGVzKQo+IC17Cj4gLQlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0 ICpkaWdfcG9ydCA9IGRwX3RvX2RpZ19wb3J0KGludGVsX2RwKTsKPiAtCXN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXYpOwo+ IC0JaW50IHNpemU7Cj4gLQo+IC0JaWYgKElTX0JST1hUT04oZGV2X3ByaXYpKSB7Cj4gLQkJKnNv dXJjZV9yYXRlcyA9IGJ4dF9yYXRlczsKPiAtCQlzaXplID0gQVJSQVlfU0laRShieHRfcmF0ZXMp Owo+IC0JfSBlbHNlIGlmIChJU19TS1lMQUtFKGRldl9wcml2KSB8fCBJU19LQUJZTEFLRShkZXZf cHJpdikpIHsKPiAtCQkqc291cmNlX3JhdGVzID0gc2tsX3JhdGVzOwo+IC0JCXNpemUgPSBBUlJB WV9TSVpFKHNrbF9yYXRlcyk7Cj4gLQl9IGVsc2Ugewo+IC0JCSpzb3VyY2VfcmF0ZXMgPSBkZWZh dWx0X3JhdGVzOwo+IC0JCXNpemUgPSBBUlJBWV9TSVpFKGRlZmF1bHRfcmF0ZXMpOwo+IC0JfQo+ IC0KPiAtCS8qIFRoaXMgZGVwZW5kcyBvbiB0aGUgZmFjdCB0aGF0IDUuNCBpcyBsYXN0IHZhbHVl IGluIHRoZSBhcnJheSAqLwo+IC0JaWYgKCFpbnRlbF9kcF9zb3VyY2Vfc3VwcG9ydHNfaGJyMihp bnRlbF9kcCkpCj4gLQkJc2l6ZS0tOwo+IC0KPiAtCXJldHVybiBzaXplOwo+IC19Cj4gLQo+ICBz dGF0aWMgdm9pZAo+ICBpbnRlbF9kcF9zZXRfY2xvY2soc3RydWN0IGludGVsX2VuY29kZXIgKmVu Y29kZXIsCj4gIAkJICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnKQo+IEBA IC0xMzc1LDQzICsxNDEyLDYgQEAgYm9vbCBpbnRlbF9kcF9zb3VyY2Vfc3VwcG9ydHNfaGJyMihz dHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICAJfQo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50IGlu dGVyc2VjdF9yYXRlcyhjb25zdCBpbnQgKnNvdXJjZV9yYXRlcywgaW50IHNvdXJjZV9sZW4sCj4g LQkJCSAgIGNvbnN0IGludCAqc2lua19yYXRlcywgaW50IHNpbmtfbGVuLAo+IC0JCQkgICBpbnQg KmNvbW1vbl9yYXRlcykKPiAtewo+IC0JaW50IGkgPSAwLCBqID0gMCwgayA9IDA7Cj4gLQo+IC0J d2hpbGUgKGkgPCBzb3VyY2VfbGVuICYmIGogPCBzaW5rX2xlbikgewo+IC0JCWlmIChzb3VyY2Vf cmF0ZXNbaV0gPT0gc2lua19yYXRlc1tqXSkgewo+IC0JCQlpZiAoV0FSTl9PTihrID49IERQX01B WF9TVVBQT1JURURfUkFURVMpKQo+IC0JCQkJcmV0dXJuIGs7Cj4gLQkJCWNvbW1vbl9yYXRlc1tr XSA9IHNvdXJjZV9yYXRlc1tpXTsKPiAtCQkJKytrOwo+IC0JCQkrK2k7Cj4gLQkJCSsrajsKPiAt CQl9IGVsc2UgaWYgKHNvdXJjZV9yYXRlc1tpXSA8IHNpbmtfcmF0ZXNbal0pIHsKPiAtCQkJKytp Owo+IC0JCX0gZWxzZSB7Cj4gLQkJCSsrajsKPiAtCQl9Cj4gLQl9Cj4gLQlyZXR1cm4gazsKPiAt fQo+IC0KPiAtc3RhdGljIGludCBpbnRlbF9kcF9jb21tb25fcmF0ZXMoc3RydWN0IGludGVsX2Rw ICppbnRlbF9kcCwKPiAtCQkJCSBpbnQgKmNvbW1vbl9yYXRlcykKPiAtewo+IC0JY29uc3QgaW50 ICpzb3VyY2VfcmF0ZXMsICpzaW5rX3JhdGVzOwo+IC0JaW50IHNvdXJjZV9sZW4sIHNpbmtfbGVu Owo+IC0KPiAtCXNpbmtfbGVuID0gaW50ZWxfZHBfc2lua19yYXRlcyhpbnRlbF9kcCwgJnNpbmtf cmF0ZXMpOwo+IC0Jc291cmNlX2xlbiA9IGludGVsX2RwX3NvdXJjZV9yYXRlcyhpbnRlbF9kcCwg JnNvdXJjZV9yYXRlcyk7Cj4gLQo+IC0JcmV0dXJuIGludGVyc2VjdF9yYXRlcyhzb3VyY2VfcmF0 ZXMsIHNvdXJjZV9sZW4sCj4gLQkJCSAgICAgICBzaW5rX3JhdGVzLCBzaW5rX2xlbiwKPiAtCQkJ ICAgICAgIGNvbW1vbl9yYXRlcyk7Cj4gLX0KPiAtCj4gIHN0YXRpYyB2b2lkIHNucHJpbnRmX2lu dF9hcnJheShjaGFyICpzdHIsIHNpemVfdCBsZW4sCj4gIAkJCSAgICAgICBjb25zdCBpbnQgKmFy cmF5LCBpbnQgbmVsZW0pCj4gIHsKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2Ug VGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==