* [drm-intel:topic/drm-misc 3/3] htmldocs: include/drm/drm_fb_helper.h:222: warning: Cannot understand * @DRM_FB_HELPER_DEFAULT_OPS:
@ 2016-09-30 15:18 kbuild test robot
2016-10-03 9:35 ` Jani Nikula
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2016-09-30 15:18 UTC (permalink / raw)
To: Stefan Christ
Cc: Daniel Vetter, intel-gfx, Gustavo Padovan, kbuild-all, dri-devel
[-- Attachment #1: Type: text/plain, Size: 1544 bytes --]
tree: git://anongit.freedesktop.org/drm-intel topic/drm-misc
head: 6c4d6f9f997c5dafccb54b52167f0c4d0ea37874
commit: 6c4d6f9f997c5dafccb54b52167f0c4d0ea37874 [3/3] drm/fb-helper: add DRM_FB_HELPER_DEFAULT_OPS for fb_ops
reproduce: make htmldocs
All warnings (new ones prefixed by >>):
>> include/drm/drm_fb_helper.h:222: warning: Cannot understand * @DRM_FB_HELPER_DEFAULT_OPS:
on line 222 - I thought it was a doc line
vim +222 include/drm/drm_fb_helper.h
206 * Entry on the global kernel_fb_helper_list, used for kgdb entry/exit.
207 */
208 struct list_head kernel_fb_list;
209
210 /**
211 * @delayed_hotplug:
212 *
213 * A hotplug was received while fbdev wasn't in control of the DRM
214 * device, i.e. another KMS master was active. The output configuration
215 * needs to be reprobe when fbdev is in control again.
216 */
217 bool delayed_hotplug;
218 };
219
220 /**
221 * @DRM_FB_HELPER_DEFAULT_OPS:
> 222 *
223 * Helper define to register default implementations of drm_fb_helper
224 * functions. To be used in struct fb_ops of drm drivers.
225 */
226 #define DRM_FB_HELPER_DEFAULT_OPS \
227 .fb_check_var = drm_fb_helper_check_var, \
228 .fb_set_par = drm_fb_helper_set_par, \
229 .fb_setcmap = drm_fb_helper_setcmap, \
230 .fb_blank = drm_fb_helper_blank, \
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 6406 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [drm-intel:topic/drm-misc 3/3] htmldocs: include/drm/drm_fb_helper.h:222: warning: Cannot understand * @DRM_FB_HELPER_DEFAULT_OPS:
2016-09-30 15:18 [drm-intel:topic/drm-misc 3/3] htmldocs: include/drm/drm_fb_helper.h:222: warning: Cannot understand * @DRM_FB_HELPER_DEFAULT_OPS: kbuild test robot
@ 2016-10-03 9:35 ` Jani Nikula
2016-10-03 13:50 ` [Intel-gfx] " Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Jani Nikula @ 2016-10-03 9:35 UTC (permalink / raw)
To: kbuild test robot, Stefan Christ
Cc: Daniel Vetter, intel-gfx, Gustavo Padovan, kbuild-all, dri-devel
On Fri, 30 Sep 2016, kbuild test robot <fengguang.wu@intel.com> wrote:
> tree: git://anongit.freedesktop.org/drm-intel topic/drm-misc
> head: 6c4d6f9f997c5dafccb54b52167f0c4d0ea37874
> commit: 6c4d6f9f997c5dafccb54b52167f0c4d0ea37874 [3/3] drm/fb-helper: add DRM_FB_HELPER_DEFAULT_OPS for fb_ops
> reproduce: make htmldocs
>
> All warnings (new ones prefixed by >>):
>
>>> include/drm/drm_fb_helper.h:222: warning: Cannot understand * @DRM_FB_HELPER_DEFAULT_OPS:
> on line 222 - I thought it was a doc line
>
> vim +222 include/drm/drm_fb_helper.h
>
> 206 * Entry on the global kernel_fb_helper_list, used for kgdb entry/exit.
> 207 */
> 208 struct list_head kernel_fb_list;
> 209
> 210 /**
> 211 * @delayed_hotplug:
> 212 *
> 213 * A hotplug was received while fbdev wasn't in control of the DRM
> 214 * device, i.e. another KMS master was active. The output configuration
> 215 * needs to be reprobe when fbdev is in control again.
> 216 */
> 217 bool delayed_hotplug;
> 218 };
> 219
> 220 /**
> 221 * @DRM_FB_HELPER_DEFAULT_OPS:
Superfluous @.
BR,
Jani.
> > 222 *
> 223 * Helper define to register default implementations of drm_fb_helper
> 224 * functions. To be used in struct fb_ops of drm drivers.
> 225 */
> 226 #define DRM_FB_HELPER_DEFAULT_OPS \
> 227 .fb_check_var = drm_fb_helper_check_var, \
> 228 .fb_set_par = drm_fb_helper_set_par, \
> 229 .fb_setcmap = drm_fb_helper_setcmap, \
> 230 .fb_blank = drm_fb_helper_blank, \
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [drm-intel:topic/drm-misc 3/3] htmldocs: include/drm/drm_fb_helper.h:222: warning: Cannot understand * @DRM_FB_HELPER_DEFAULT_OPS:
2016-10-03 9:35 ` Jani Nikula
@ 2016-10-03 13:50 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2016-10-03 13:50 UTC (permalink / raw)
To: Jani Nikula
Cc: intel-gfx, dri-devel, kbuild-all, Stefan Christ,
kbuild test robot, Gustavo Padovan
On Mon, Oct 3, 2016 at 11:35 AM, Jani Nikula
<jani.nikula@linux.intel.com> wrote:
>> 220 /**
>> 221 * @DRM_FB_HELPER_DEFAULT_OPS:
>
> Superfluous @.
Stefan, pls fix this and run
$ make htmldocs
to make sure the output looks correct. Cargo-culting kerneldoc without
checking the output doesn't work too well ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-03 13:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-30 15:18 [drm-intel:topic/drm-misc 3/3] htmldocs: include/drm/drm_fb_helper.h:222: warning: Cannot understand * @DRM_FB_HELPER_DEFAULT_OPS: kbuild test robot
2016-10-03 9:35 ` Jani Nikula
2016-10-03 13:50 ` [Intel-gfx] " Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox