From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel-gfx@lists.freedesktop.org, stable@vger.kernel.org,
Daniel Stone <daniels@collabora.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Use userspace compatible type in fourcc_mod_code macro
Date: Thu, 05 Nov 2015 14:51:22 +0200 [thread overview]
Message-ID: <87d1vomwxh.fsf@intel.com> (raw)
In-Reply-To: <20150923113642.GY26517@intel.com>
On Wed, 23 Sep 2015, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Sep 23, 2015 at 10:10:31AM +0100, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> __u64 should be used instead of u64.
>>
>> Feature originally added in:
>>
>> commit e3eb3250d84ef97b766312345774367b6a310db8
>> Author: Rob Clark <robdclark@gmail.com>
>> Date: Thu Feb 5 14:41:52 2015 +0000
>>
>> drm: add support for tiled/compressed/etc modifier in addfb2
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: Rob Clark <robdclark@gmail.com>
>> Cc: Daniel Stone <daniels@collabora.com>
>> Cc: Daniel Vetter <daniel.vetter@intel.com>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: stable@vger.kernel.org
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Pushed to our topic/drm-fixes branch, thanks for the patch and review.
BR,
Jani.
>
>> ---
>> include/uapi/drm/drm_fourcc.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
>> index 8c5e8b91a3cb..0b69a7753558 100644
>> --- a/include/uapi/drm/drm_fourcc.h
>> +++ b/include/uapi/drm/drm_fourcc.h
>> @@ -158,7 +158,7 @@
>> /* add more to the end as needed */
>>
>> #define fourcc_mod_code(vendor, val) \
>> - ((((u64)DRM_FORMAT_MOD_VENDOR_## vendor) << 56) | (val & 0x00ffffffffffffffULL))
>> + ((((__u64)DRM_FORMAT_MOD_VENDOR_## vendor) << 56) | (val & 0x00ffffffffffffffULL))
>>
>> /*
>> * Format Modifier tokens:
>> --
>> 2.5.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-05 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 9:10 [PATCH] drm: Use userspace compatible type in fourcc_mod_code macro Tvrtko Ursulin
2015-09-23 11:36 ` [Intel-gfx] " Ville Syrjälä
2015-11-05 12:51 ` Jani Nikula [this message]
2015-11-05 21:12 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1vomwxh.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=daniel.vetter@intel.com \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox